Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/68661/?format=api
{ "id": 68661, "url": "https://patches.dpdk.org/api/patches/68661/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200416191944.23284-4-jia.guo@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200416191944.23284-4-jia.guo@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200416191944.23284-4-jia.guo@intel.com", "date": "2020-04-16T19:19:44", "name": "[v6,3/3] app/testpmd: add new types to RSS hash commands", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "27b3fee8362ef20878df53788a1c47ad922e6dbc", "submitter": { "id": 507, "url": "https://patches.dpdk.org/api/people/507/?format=api", "name": "Guo, Jia", "email": "jia.guo@intel.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200416191944.23284-4-jia.guo@intel.com/mbox/", "series": [ { "id": 9417, "url": "https://patches.dpdk.org/api/series/9417/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=9417", "date": "2020-04-16T19:19:41", "name": "add RSS configuration for iavf", "version": 6, "mbox": "https://patches.dpdk.org/series/9417/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/68661/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/68661/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7645EA0588;\n\tThu, 16 Apr 2020 12:24:29 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6B2951DBE8;\n\tThu, 16 Apr 2020 12:24:03 +0200 (CEST)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n by dpdk.org (Postfix) with ESMTP id CEC161DBF1\n for <dev@dpdk.org>; Thu, 16 Apr 2020 12:23:59 +0200 (CEST)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 16 Apr 2020 03:23:59 -0700", "from npg-dpdk-cvl-jeffguo-01.sh.intel.com ([10.67.111.128])\n by fmsmga005.fm.intel.com with ESMTP; 16 Apr 2020 03:23:56 -0700" ], "IronPort-SDR": [ "\n Gjn73ACoWk3DtwExzVbA3VXvBlyBdzkDtXX3mcJcVaHlNlve0AWgiLrCRiPdnzCUevdSLjmwLJ\n YKv+hqgIc3Fw==", "\n Cn6QrkSJUNM7MfCCHqr0Ib02bey+sa/iURf9Eth23mPJg1aIbsXwCuiXr2spBJZRfl0YeFNDGx\n 7srMmAyzcpEg==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.72,390,1580803200\"; d=\"scan'208\";a=\"454277386\"", "From": "Jeff Guo <jia.guo@intel.com>", "To": "bernard.iremonger@intel.com, orika@mellanox.com, xiaolong.ye@intel.com,\n qi.z.zhang@intel.com", "Cc": "dev@dpdk.org, jingjing.wu@intel.com, yahui.cao@intel.com,\n simei.su@intel.com, jia.guo@intel.com", "Date": "Thu, 16 Apr 2020 15:19:44 -0400", "Message-Id": "<20200416191944.23284-4-jia.guo@intel.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200416191944.23284-1-jia.guo@intel.com>", "References": "<20200318170401.7938-5-jia.guo@intel.com>\n <20200416191944.23284-1-jia.guo@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [dpdk-dev v6 3/3] app/testpmd: add new types to RSS hash\n\tcommands", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add some new types, such as eth/l2-src-only/l2-dst-only/svlan/cvlan/\nl2tpv3/esp/ah/pfcp types into RSS hash commands, it could be used\nto configure these rss input set by cmdline.\n\nExample testpmd commands was:\ntestpmd>flow create 0 ingress pattern eth / ipv4 / l2tpv3oip / end \\\n\tactions rss types l2tpv3 end key_len 0 queues end / end\n\nSigned-off-by: Jeff Guo <jia.guo@intel.com>\n---\nv6->v5:\nadd some missing part and refine commit log\n---\n app/test-pmd/cmdline.c | 34 +++++++++++++++++++++++++++++-----\n app/test-pmd/config.c | 15 ++++++++++++---\n 2 files changed, 41 insertions(+), 8 deletions(-)", "diff": "diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c\nindex 863b567c1..4164767b8 100644\n--- a/app/test-pmd/cmdline.c\n+++ b/app/test-pmd/cmdline.c\n@@ -2270,9 +2270,13 @@ cmd_config_rss_parsed(void *parsed_result,\n \tint ret;\n \n \tif (!strcmp(res->value, \"all\"))\n-\t\trss_conf.rss_hf = ETH_RSS_IP | ETH_RSS_TCP |\n-\t\t\t\tETH_RSS_UDP | ETH_RSS_SCTP |\n-\t\t\t\t\tETH_RSS_L2_PAYLOAD;\n+\t\trss_conf.rss_hf = ETH_RSS_ETH | ETH_RSS_S_VLAN |\n+\t\t\tETH_RSS_C_VLAN | ETH_RSS_IP | ETH_RSS_TCP |\n+\t\t\tETH_RSS_UDP | ETH_RSS_SCTP | ETH_RSS_L2_PAYLOAD |\n+\t\t\tETH_RSS_L2TPV3 | ETH_RSS_ESP | ETH_RSS_AH |\n+\t\t\tETH_RSS_PFCP;\n+\telse if (!strcmp(res->value, \"eth\"))\n+\t\trss_conf.rss_hf = ETH_RSS_ETH;\n \telse if (!strcmp(res->value, \"ip\"))\n \t\trss_conf.rss_hf = ETH_RSS_IP;\n \telse if (!strcmp(res->value, \"udp\"))\n@@ -2299,6 +2303,22 @@ cmd_config_rss_parsed(void *parsed_result,\n \t\trss_conf.rss_hf = ETH_RSS_L4_SRC_ONLY;\n \telse if (!strcmp(res->value, \"l4-dst-only\"))\n \t\trss_conf.rss_hf = ETH_RSS_L4_DST_ONLY;\n+\telse if (!strcmp(res->value, \"l2-src-only\"))\n+\t\trss_conf.rss_hf = ETH_RSS_L2_SRC_ONLY;\n+\telse if (!strcmp(res->value, \"l2-dst-only\"))\n+\t\trss_conf.rss_hf = ETH_RSS_L2_DST_ONLY;\n+\telse if (!strcmp(res->value, \"s-vlan\"))\n+\t\trss_conf.rss_hf = ETH_RSS_S_VLAN;\n+\telse if (!strcmp(res->value, \"c-vlan\"))\n+\t\trss_conf.rss_hf = ETH_RSS_C_VLAN;\n+\telse if (!strcmp(res->value, \"l2tpv3\"))\n+\t\trss_conf.rss_hf = ETH_RSS_L2TPV3;\n+\telse if (!strcmp(res->value, \"esp\"))\n+\t\trss_conf.rss_hf = ETH_RSS_ESP;\n+\telse if (!strcmp(res->value, \"ah\"))\n+\t\trss_conf.rss_hf = ETH_RSS_AH;\n+\telse if (!strcmp(res->value, \"pfcp\"))\n+\t\trss_conf.rss_hf = ETH_RSS_PFCP;\n \telse if (!strcmp(res->value, \"none\"))\n \t\trss_conf.rss_hf = 0;\n \telse if (!strcmp(res->value, \"default\"))\n@@ -2467,7 +2487,9 @@ cmdline_parse_token_string_t cmd_config_rss_hash_key_rss_type =\n \t\t\t\t \"ipv4-other#ipv6#ipv6-frag#ipv6-tcp#ipv6-udp#\"\n \t\t\t\t \"ipv6-sctp#ipv6-other#l2-payload#ipv6-ex#\"\n \t\t\t\t \"ipv6-tcp-ex#ipv6-udp-ex#\"\n-\t\t\t\t \"l3-src-only#l3-dst-only#l4-src-only#l4-dst-only\");\n+\t\t\t\t \"l3-src-only#l3-dst-only#l4-src-only#l4-dst-only#\"\n+\t\t\t\t \"l2-src-only#l2-dst-only#s-vlan#c-vlan#\"\n+\t\t\t\t \"l2tpv3#esp#ah#pfcp\");\n cmdline_parse_token_string_t cmd_config_rss_hash_key_value =\n \tTOKEN_STRING_INITIALIZER(struct cmd_config_rss_hash_key, key, NULL);\n \n@@ -2478,7 +2500,9 @@ cmdline_parse_inst_t cmd_config_rss_hash_key = {\n \t\t\"ipv4|ipv4-frag|ipv4-tcp|ipv4-udp|ipv4-sctp|ipv4-other|\"\n \t\t\"ipv6|ipv6-frag|ipv6-tcp|ipv6-udp|ipv6-sctp|ipv6-other|\"\n \t\t\"l2-payload|ipv6-ex|ipv6-tcp-ex|ipv6-udp-ex|\"\n-\t\t\"l3-src-only|l3-dst-only|l4-src-only|l4-dst-only \"\n+\t\t\"l3-src-only|l3-dst-only|l4-src-only|l4-dst-only|\"\n+\t\t\"l2-src-only|l2-dst-only|s-vlan|c-vlan|\"\n+\t\t\"l2tpv3|esp|ah|pfcp \"\n \t\t\"<string of hex digits (variable length, NIC dependent)>\",\n \t.tokens = {\n \t\t(void *)&cmd_config_rss_hash_key_port,\ndiff --git a/app/test-pmd/config.c b/app/test-pmd/config.c\nindex 71aeb5413..c8196e47a 100644\n--- a/app/test-pmd/config.c\n+++ b/app/test-pmd/config.c\n@@ -75,10 +75,15 @@ static const struct {\n };\n \n const struct rss_type_info rss_type_table[] = {\n-\t{ \"all\", ETH_RSS_IP | ETH_RSS_TCP |\n-\t\t\tETH_RSS_UDP | ETH_RSS_SCTP |\n-\t\t\tETH_RSS_L2_PAYLOAD },\n+\t{ \"all\", ETH_RSS_ETH | ETH_RSS_IP | ETH_RSS_TCP | ETH_RSS_UDP |\n+\t\tETH_RSS_SCTP | ETH_RSS_L2_PAYLOAD | ETH_RSS_L2TPV3 |\n+\t\tETH_RSS_ESP | ETH_RSS_AH | ETH_RSS_PFCP},\n \t{ \"none\", 0 },\n+\t{ \"eth\", ETH_RSS_ETH },\n+\t{ \"l2-src-only\", ETH_RSS_L2_SRC_ONLY },\n+\t{ \"l2-dst-only\", ETH_RSS_L2_DST_ONLY },\n+\t{ \"s-vlan\", ETH_RSS_S_VLAN },\n+\t{ \"c-vlan\", ETH_RSS_C_VLAN },\n \t{ \"ipv4\", ETH_RSS_IPV4 },\n \t{ \"ipv4-frag\", ETH_RSS_FRAG_IPV4 },\n \t{ \"ipv4-tcp\", ETH_RSS_NONFRAG_IPV4_TCP },\n@@ -108,6 +113,10 @@ const struct rss_type_info rss_type_table[] = {\n \t{ \"l3-dst-only\", ETH_RSS_L3_DST_ONLY },\n \t{ \"l4-src-only\", ETH_RSS_L4_SRC_ONLY },\n \t{ \"l4-dst-only\", ETH_RSS_L4_DST_ONLY },\n+\t{ \"l2tpv3\", ETH_RSS_L2TPV3 },\n+\t{ \"esp\", ETH_RSS_ESP },\n+\t{ \"ah\", ETH_RSS_AH },\n+\t{ \"pfcp\", ETH_RSS_PFCP },\n \t{ NULL, 0 },\n };\n \n", "prefixes": [ "v6", "3/3" ] }