Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 68618,
    "url": "https://patches.dpdk.org/api/patches/68618/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200416055309.19679-3-i.dyukov@samsung.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20200416055309.19679-3-i.dyukov@samsung.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20200416055309.19679-3-i.dyukov@samsung.com",
    "date": "2020-04-16T05:53:02",
    "name": "[v11,2/6] net/virtio: refactor devargs parsing",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "b223a7a74cf86c981646bb2e7725ac9500b54586",
    "submitter": {
        "id": 783,
        "url": "https://patches.dpdk.org/api/people/783/?format=api",
        "name": "Ivan Dyukov",
        "email": "i.dyukov@samsung.com"
    },
    "delegate": {
        "id": 2642,
        "url": "https://patches.dpdk.org/api/users/2642/?format=api",
        "username": "mcoquelin",
        "first_name": "Maxime",
        "last_name": "Coquelin",
        "email": "maxime.coquelin@redhat.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200416055309.19679-3-i.dyukov@samsung.com/mbox/",
    "series": [
        {
            "id": 9411,
            "url": "https://patches.dpdk.org/api/series/9411/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=9411",
            "date": "2020-04-16T05:53:00",
            "name": "net/virtio: add link speed devarg",
            "version": 11,
            "mbox": "https://patches.dpdk.org/series/9411/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/68618/comments/",
    "check": "fail",
    "checks": "https://patches.dpdk.org/api/patches/68618/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 98C04A0588;\n\tThu, 16 Apr 2020 07:53:45 +0200 (CEST)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 570281DAA3;\n\tThu, 16 Apr 2020 07:53:30 +0200 (CEST)",
            "from mailout1.w1.samsung.com (mailout1.w1.samsung.com\n [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 9CA841DAAF\n for <dev@dpdk.org>; Thu, 16 Apr 2020 07:53:28 +0200 (CEST)",
            "from eucas1p1.samsung.com (unknown [182.198.249.206])\n by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id\n 20200416055327euoutp0177efd6473ad97bcb1432400c1cf45205~GNwO2uDXU2038620386euoutp01h\n for <dev@dpdk.org>; Thu, 16 Apr 2020 05:53:27 +0000 (GMT)",
            "from eusmges1new.samsung.com (unknown [203.254.199.242]) by\n eucas1p1.samsung.com (KnoxPortal) with ESMTP id\n 20200416055327eucas1p12f9657076ef50f370c343acb5b3de8bb~GNwOZXXl51679516795eucas1p10;\n Thu, 16 Apr 2020 05:53:27 +0000 (GMT)",
            "from eucas1p2.samsung.com ( [182.198.249.207]) by\n eusmges1new.samsung.com (EUCPMTA) with SMTP id 8D.91.61286.7D2F79E5; Thu, 16\n Apr 2020 06:53:27 +0100 (BST)",
            "from eusmtrp1.samsung.com (unknown [182.198.249.138]) by\n eucas1p2.samsung.com (KnoxPortal) with ESMTPA id\n 20200416055326eucas1p266592b624ab220d6b259210b5e413e01~GNwOB62CF1938419384eucas1p2P;\n Thu, 16 Apr 2020 05:53:26 +0000 (GMT)",
            "from eusmgms1.samsung.com (unknown [182.198.249.179]) by\n eusmtrp1.samsung.com (KnoxPortal) with ESMTP id\n 20200416055326eusmtrp18bfeabf934e713dbb3526035606ac399~GNwOBRj1Z2642726427eusmtrp1f;\n Thu, 16 Apr 2020 05:53:26 +0000 (GMT)",
            "from eusmtip2.samsung.com ( [203.254.199.222]) by\n eusmgms1.samsung.com (EUCPMTA) with SMTP id 81.FE.08375.6D2F79E5; Thu, 16\n Apr 2020 06:53:26 +0100 (BST)",
            "from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by\n eusmtip2.samsung.com (KnoxPortal) with ESMTPA id\n 20200416055326eusmtip24677ce1fd5c03a3991ddff3a2623df77~GNwNcf4UA2328223282eusmtip29;\n Thu, 16 Apr 2020 05:53:26 +0000 (GMT)"
        ],
        "DKIM-Filter": "OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com\n 20200416055327euoutp0177efd6473ad97bcb1432400c1cf45205~GNwO2uDXU2038620386euoutp01h",
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com;\n s=mail20170921; t=1587016407;\n bh=K7Mh/Yk74ODK2aSKPKJtcnVsJ6EOdbU5DTdVk7Usf7A=;\n h=From:To:Subject:Date:In-Reply-To:References:From;\n b=t2iQ/sZpzczOWFAYdo6HtM7r/wisykRZ1nH0HiN2h6GavKBfFBriQlOkjlmh4c4FI\n QeLTuhYEq0Fa7S4jG8l5ZA0yiiXXr3l/ahQUIwafC5kdH3/mRCvJKvlJmkxYYba061\n XuS0/yp2Jaw8f6SCYFZMbAdWoCxXn4ejoYElI5PA=",
        "X-AuditID": "cbfec7f2-ef1ff7000001ef66-19-5e97f2d78f41",
        "From": "Ivan Dyukov <i.dyukov@samsung.com>",
        "To": "dev@dpdk.org, maxime.coquelin@redhat.com, i.dyukov@samsung.com,\n v.kuramshin@samsung.com, amorenoz@redhat.com, zhihong.wang@intel.com,\n xiaolong.ye@intel.com, mb@smartsharesystems.com",
        "Date": "Thu, 16 Apr 2020 08:53:02 +0300",
        "Message-Id": "<20200416055309.19679-3-i.dyukov@samsung.com>",
        "X-Mailer": "git-send-email 2.17.1",
        "In-Reply-To": "<20200416055309.19679-1-i.dyukov@samsung.com>",
        "X-Brightmail-Tracker": [
            "\n H4sIAAAAAAAAA+NgFvrMIsWRmVeSWpSXmKPExsWy7djP87rXP02PM9j8k9+idccDFot3n7Yz\n Wcy61MRucaxzD4tF36+rjBanb25mt/jzxtRi88VJTA4cHr8WLGX1WLznJZPH+31X2Tz6tqxi\n 9Dj1qJs5gDWKyyYlNSezLLVI3y6BK+PsiSnMBcsFK9Zv38XUwNjI18XIySEhYCLx4OYrti5G\n Lg4hgRWMEsu/r2CHcL4wSpxfe4wJwvnMKLFsSjMzTMvEiVtZIBLLGSXW/uqCqvrKKDHt+BWw\n KjYBDYnTHfOYQGwRgb2MEsfOFIDYwgK2EjPuvGEHsVkEVCXWPV4KVs8rYClxZc9vJogN8hKr\n NxwAi3MKWEkc6D4DtkBC4D2bxNtZq4GaOYAcF4mHl7gg6oUlXh3fwg5hy0icntzDAmFXS3zf\n dJ0doreDUeLeolaoInuJLa/Pgc1hFtCUWL9LHyLsKLFu6QVWiPF8EjfeCoKEmYHMSdumM0OE\n eSU62oQgqpUkDpy8BBWWkPj7mwci7CFxbOZ2aCDuYZRov3yfZQKj3CyEXQsYGVcxiqeWFuem\n pxYb5qWW6xUn5haX5qXrJefnbmIEJoXT/45/2sH49VLSIUYBDkYlHt6O19PihFgTy4orcw8x\n SnAwK4nw7vCfHifEm5JYWZValB9fVJqTWnyIUZqDRUmc13jRy1ghgfTEktTs1NSC1CKYLBMH\n p1QD4269dfk/twf7PZvvET5RsXVi1pIbQd/6k6VulZVrGwb9Wzh30r98/v/OyltLdkRI1/dJ\n ld69prCM/9zLJbzaHC0rNqr4qrhPsbc4pXjgZYYfP8cBvaKyb4lfFOscfxzWnF4e294S+kVG\n 6OfvX5PypXPPR5j9uj7r8bq5tob5dtPd1++xehyYqcRSnJFoqMVcVJwIAO24rd8GAwAA",
            "\n H4sIAAAAAAAAA+NgFrrGLMWRmVeSWpSXmKPExsVy+t/xe7rXPk2PM7g+yciidccDFot3n7Yz\n Wcy61MRucaxzD4tF36+rjBanb25mt/jzxtRi88VJTA4cHr8WLGX1WLznJZPH+31X2Tz6tqxi\n 9Dj1qJs5gDVKz6Yov7QkVSEjv7jEVina0MJIz9DSQs/IxFLP0Ng81srIVEnfziYlNSezLLVI\n 3y5BL+PsiSnMBcsFK9Zv38XUwNjI18XIySEhYCIxceJWli5GLg4hgaWMEps2LmbuYuQASkhI\n vH7CDFEjLPHnWhcbRM1nRokry2eBJdgENCROd8xjAkmICBxnlOid9Z8JJCEsYCsx484bdhCb\n RUBVYt3jpWANvAKWElf2/GaCmCovsXrDAbA4p4CVxIHuM2BxIYEMicaOY0wTGHkXMDKsYhRJ\n LS3OTc8tNtQrTswtLs1L10vOz93ECAzTbcd+bt7BeGlj8CFGAQ5GJR7ejtfT4oRYE8uKK3MP\n MUpwMCuJ8O7wnx4nxJuSWFmVWpQfX1Sak1p8iNEU6KiJzFKiyfnAGMoriTc0NTS3sDQ0NzY3\n NrNQEuftEDgYIySQnliSmp2aWpBaBNPHxMEp1cAo/nKXvE6cmUzbguYNS/bo/MxO6vnoHNr4\n 4GXbBHZZwaZMi1nMDKxZXnvffTR8xlL6TuHMIoZ/Mb9ZTxbddc7f9XuqsHrDymc/JnPP2n1/\n leAq7nML+Q5tLsyam3Hr3F32iTb8sd90uSSnL7patl5hy/3yL+0quZqySabq7T6fwn/fVl0l\n eTBdiaU4I9FQi7moOBEA2KaWTGkCAAA="
        ],
        "X-CMS-MailID": "20200416055326eucas1p266592b624ab220d6b259210b5e413e01",
        "X-Msg-Generator": "CA",
        "Content-Type": "text/plain; charset=\"utf-8\"",
        "X-RootMTR": "20200416055326eucas1p266592b624ab220d6b259210b5e413e01",
        "X-EPHeader": "CA",
        "CMS-TYPE": "201P",
        "X-CMS-RootMailID": "20200416055326eucas1p266592b624ab220d6b259210b5e413e01",
        "References": "<20191212085012.9170-1-i.dyukov@samsung.com>\n <20200416055309.19679-1-i.dyukov@samsung.com>\n <CGME20200416055326eucas1p266592b624ab220d6b259210b5e413e01@eucas1p2.samsung.com>",
        "Subject": "[dpdk-dev] [PATCH v11 2/6] net/virtio: refactor devargs parsing",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "refactor vdpa specific devargs parsing to more generic way\n\nSigned-off-by: Ivan Dyukov <i.dyukov@samsung.com>\n---\n drivers/net/virtio/virtio_ethdev.c | 34 +++++++++++++++++++++---------\n 1 file changed, 24 insertions(+), 10 deletions(-)",
    "diff": "diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c\nindex e98a76ea2..60195ab3c 100644\n--- a/drivers/net/virtio/virtio_ethdev.c\n+++ b/drivers/net/virtio/virtio_ethdev.c\n@@ -1957,16 +1957,18 @@ eth_virtio_dev_uninit(struct rte_eth_dev *eth_dev)\n }\n \n static int vdpa_check_handler(__rte_unused const char *key,\n-\t\tconst char *value, __rte_unused void *opaque)\n+\t\tconst char *value, void *ret_val)\n {\n-\tif (strcmp(value, \"1\"))\n-\t\treturn -1;\n+\tif (strcmp(value, \"1\") == 0)\n+\t\t*(int *)ret_val = 1;\n+\telse\n+\t\t*(int *)ret_val = 0;\n \n \treturn 0;\n }\n \n static int\n-vdpa_mode_selected(struct rte_devargs *devargs)\n+virtio_dev_devargs_parse(struct rte_devargs *devargs, int *vdpa)\n {\n \tstruct rte_kvargs *kvlist;\n \tconst char *key = \"vdpa\";\n@@ -1982,12 +1984,16 @@ vdpa_mode_selected(struct rte_devargs *devargs)\n \tif (!rte_kvargs_count(kvlist, key))\n \t\tgoto exit;\n \n-\t/* vdpa mode selected when there's a key-value pair: vdpa=1 */\n-\tif (rte_kvargs_process(kvlist, key,\n-\t\t\t\tvdpa_check_handler, NULL) < 0) {\n-\t\tgoto exit;\n+\tif (vdpa) {\n+\t\t/* vdpa mode selected when there's a key-value pair:\n+\t\t * vdpa=1\n+\t\t */\n+\t\tret = rte_kvargs_process(kvlist, key,\n+\t\t\t\tvdpa_check_handler, vdpa);\n+\t\tif (ret < 0)\n+\t\t\tgoto exit;\n \t}\n-\tret = 1;\n+\n \n exit:\n \trte_kvargs_free(kvlist);\n@@ -1997,8 +2003,16 @@ vdpa_mode_selected(struct rte_devargs *devargs)\n static int eth_virtio_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,\n \tstruct rte_pci_device *pci_dev)\n {\n+\tint vdpa = 0;\n+\tint ret = 0;\n+\n+\tret = virtio_dev_devargs_parse(pci_dev->device.devargs, &vdpa);\n+\tif (ret < 0) {\n+\t\tPMD_INIT_LOG(ERR, \"devargs parsing is failed\");\n+\t\treturn ret;\n+\t}\n \t/* virtio pmd skips probe if device needs to work in vdpa mode */\n-\tif (vdpa_mode_selected(pci_dev->device.devargs))\n+\tif (vdpa == 1)\n \t\treturn 1;\n \n \treturn rte_eth_dev_pci_generic_probe(pci_dev, sizeof(struct virtio_hw),\n",
    "prefixes": [
        "v11",
        "2/6"
    ]
}