Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/68516/?format=api
{ "id": 68516, "url": "https://patches.dpdk.org/api/patches/68516/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1586938751-32808-31-git-send-email-venkatkumar.duvvuru@broadcom.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1586938751-32808-31-git-send-email-venkatkumar.duvvuru@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1586938751-32808-31-git-send-email-venkatkumar.duvvuru@broadcom.com", "date": "2020-04-15T08:19:07", "name": "[v4,30/34] net/bnxt: add support for rte flow flush driver hook", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "fd5cb790dada5e12adc92860d46e1952853df7ca", "submitter": { "id": 1635, "url": "https://patches.dpdk.org/api/people/1635/?format=api", "name": "Venkat Duvvuru", "email": "venkatkumar.duvvuru@broadcom.com" }, "delegate": { "id": 1766, "url": "https://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1586938751-32808-31-git-send-email-venkatkumar.duvvuru@broadcom.com/mbox/", "series": [ { "id": 9386, "url": "https://patches.dpdk.org/api/series/9386/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=9386", "date": "2020-04-15T08:18:37", "name": "add support for host based flow table management", "version": 4, "mbox": "https://patches.dpdk.org/series/9386/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/68516/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/68516/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 87CE8A0563;\n\tWed, 15 Apr 2020 10:26:30 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D8DCF1D616;\n\tWed, 15 Apr 2020 10:20:46 +0200 (CEST)", "from mail-pj1-f66.google.com (mail-pj1-f66.google.com\n [209.85.216.66]) by dpdk.org (Postfix) with ESMTP id B91161D5FD\n for <dev@dpdk.org>; Wed, 15 Apr 2020 10:20:43 +0200 (CEST)", "by mail-pj1-f66.google.com with SMTP id a32so6460645pje.5\n for <dev@dpdk.org>; Wed, 15 Apr 2020 01:20:43 -0700 (PDT)", "from S60.dhcp.broadcom.net ([192.19.234.250])\n by smtp.gmail.com with ESMTPSA id fy21sm3819019pjb.25.2020.04.15.01.20.40\n (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);\n Wed, 15 Apr 2020 01:20:41 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com;\n s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references;\n bh=dTjmtNBYLz+Emc0kXrwGLp1L/m8tb/HvqPLLOaJbPvc=;\n b=B/TJI3wbBkHuJgWQteygGZFH6kGbjSDAolj86+GAEE6fuxIevSPwlHYl/zWcMmZhkl\n 1A7DA0fLWRRJXIDRJb+s5zt1Kz1BuGpDcEfdIN/xEcyDUcIN04/mLLVjm2Oq/sV2ato9\n QUrCGFMOV+1yHwPWQTsmxTWnvE2C0Rdfm6lsc=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references;\n bh=dTjmtNBYLz+Emc0kXrwGLp1L/m8tb/HvqPLLOaJbPvc=;\n b=Yk4QJZ5n7m7Z+iqxkABDl+hNF+Z95Y6Jyc+ReAxkIK4C2qbLukO39DjqTQ76qD/GpB\n FFKYQjkVi6ep/UQxNUqEU4zQdK0ND8hbmo7A+1LEPpsSv6ROubSh0fq3iLU1Myy2JVtb\n soK/yr5a2zi827ghSEKY8rSZbmiK7dpRcDAqygs7X1KhivhqESkzoZg46xyENRpwX+KK\n uOGiYHGoKZNp+2DqqeDgUEZtP6zPBTvgw0kG60eNEOnZuSccoi806+7ioykNI3Y9aUd1\n AUslEb+cEJj81MVcvF3OLN3AL/mzrRTpzu5M+8yItEBv6GYyOGlHagbHKHu5A1YiOBQv\n RMHQ==", "X-Gm-Message-State": "AGi0PuZ8vutI346CivIlpikLSCLjsz04fl8zYt4Op/p/HMOt4jYBikOr\n 1Dbj7v8fWdKIfP4j/1UiViqqC6RE58YJECOmAQLklvrv1Rw8S6wAVedYEL0aLFPo9KYXg6UABMe\n Kto2R0x/YmQsiH8bi55hdhMt7QviaWzQ6dCjvULiBAtsvacHh1EZxuR4eYGdWRItBHPZf", "X-Google-Smtp-Source": "\n APiQypIKtKfmvMq8FdSiGNOnrSPUkSMXcWCanLz7OdQluaYH5vNSQ6qVX1T7LRl04xmLO5fCZTuZjA==", "X-Received": "by 2002:a17:902:ead4:: with SMTP id\n p20mr3925037pld.129.1586938842493;\n Wed, 15 Apr 2020 01:20:42 -0700 (PDT)", "From": "Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>", "To": "dev@dpdk.org", "Cc": "Kishore Padmanabha <kishore.padmanabha@broadcom.com>,\n Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>", "Date": "Wed, 15 Apr 2020 13:49:07 +0530", "Message-Id": "\n <1586938751-32808-31-git-send-email-venkatkumar.duvvuru@broadcom.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "\n <1586938751-32808-1-git-send-email-venkatkumar.duvvuru@broadcom.com>", "References": "\n <1586852011-37536-1-git-send-email-venkatkumar.duvvuru@broadcom.com>\n <1586938751-32808-1-git-send-email-venkatkumar.duvvuru@broadcom.com>", "Subject": "[dpdk-dev] [PATCH v4 30/34] net/bnxt: add support for rte flow\n\tflush driver hook", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Kishore Padmanabha <kishore.padmanabha@broadcom.com>\n\nThis patch does the following\n1. Gets the ulp session information from eth_dev\n2. Fetches the rte_flow table associated with this session\n3. Iterates through all the flows in the flow table\n4. Calls ulp_mapper_resources_free which releases the key & action\n tables associated with each flow\n\nSigned-off-by: Kishore Padmanabha <kishore.padmanabha@broadcom.com>\nSigned-off-by: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>\nReviewed-by: Lance Richardson <lance.richardson@broadcom.com>\nReviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/tf_ulp/bnxt_ulp.c | 3 ++\n drivers/net/bnxt/tf_ulp/bnxt_ulp_flow.c | 33 +++++++++++++++-\n drivers/net/bnxt/tf_ulp/ulp_flow_db.c | 69 +++++++++++++++++++++++++++++++++\n drivers/net/bnxt/tf_ulp/ulp_flow_db.h | 11 ++++++\n 4 files changed, 115 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/bnxt/tf_ulp/bnxt_ulp.c b/drivers/net/bnxt/tf_ulp/bnxt_ulp.c\nindex 3795c6d..56e08f2 100644\n--- a/drivers/net/bnxt/tf_ulp/bnxt_ulp.c\n+++ b/drivers/net/bnxt/tf_ulp/bnxt_ulp.c\n@@ -517,6 +517,9 @@ bnxt_ulp_deinit(struct bnxt *bp)\n \tif (!session)\n \t\treturn;\n \n+\t/* clean up regular flows */\n+\tulp_flow_db_flush_flows(&bp->ulp_ctx, BNXT_ULP_REGULAR_FLOW_TABLE);\n+\n \t/* cleanup the eem table scope */\n \tulp_eem_tbl_scope_deinit(bp, &bp->ulp_ctx);\n \ndiff --git a/drivers/net/bnxt/tf_ulp/bnxt_ulp_flow.c b/drivers/net/bnxt/tf_ulp/bnxt_ulp_flow.c\nindex 35099a3..4958895 100644\n--- a/drivers/net/bnxt/tf_ulp/bnxt_ulp_flow.c\n+++ b/drivers/net/bnxt/tf_ulp/bnxt_ulp_flow.c\n@@ -262,11 +262,42 @@ bnxt_ulp_flow_destroy(struct rte_eth_dev *dev,\n \treturn ret;\n }\n \n+/* Function to destroy the rte flows. */\n+static int32_t\n+bnxt_ulp_flow_flush(struct rte_eth_dev *eth_dev,\n+\t\t struct rte_flow_error *error)\n+{\n+\tstruct bnxt_ulp_context *ulp_ctx;\n+\tint32_t ret;\n+\tstruct bnxt *bp;\n+\n+\tulp_ctx = bnxt_ulp_eth_dev_ptr2_cntxt_get(eth_dev);\n+\tif (!ulp_ctx) {\n+\t\tBNXT_TF_DBG(ERR, \"ULP context is not initialized\\n\");\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\t\t RTE_FLOW_ERROR_TYPE_HANDLE, NULL,\n+\t\t\t\t \"Failed to flush flow.\");\n+\t\treturn -EINVAL;\n+\t}\n+\tbp = eth_dev->data->dev_private;\n+\n+\t/* Free the resources for the last device */\n+\tif (!ulp_ctx_deinit_allowed(bp))\n+\t\treturn 0;\n+\n+\tret = ulp_flow_db_flush_flows(ulp_ctx, BNXT_ULP_REGULAR_FLOW_TABLE);\n+\tif (ret)\n+\t\trte_flow_error_set(error, ret,\n+\t\t\t\t RTE_FLOW_ERROR_TYPE_HANDLE, NULL,\n+\t\t\t\t \"Failed to flush flow.\");\n+\treturn ret;\n+}\n+\n const struct rte_flow_ops bnxt_ulp_rte_flow_ops = {\n \t.validate = bnxt_ulp_flow_validate,\n \t.create = bnxt_ulp_flow_create,\n \t.destroy = bnxt_ulp_flow_destroy,\n-\t.flush = NULL,\n+\t.flush = bnxt_ulp_flow_flush,\n \t.query = NULL,\n \t.isolate = NULL\n };\ndiff --git a/drivers/net/bnxt/tf_ulp/ulp_flow_db.c b/drivers/net/bnxt/tf_ulp/ulp_flow_db.c\nindex ee703a1..aed5078 100644\n--- a/drivers/net/bnxt/tf_ulp/ulp_flow_db.c\n+++ b/drivers/net/bnxt/tf_ulp/ulp_flow_db.c\n@@ -555,3 +555,72 @@ int32_t\tulp_flow_db_fid_free(struct bnxt_ulp_context\t\t*ulp_ctxt,\n \t/* all good, return success */\n \treturn 0;\n }\n+\n+/** Get the flow database entry iteratively\n+ *\n+ * flow_tbl [in] Ptr to flow table\n+ * fid [in/out] The index to the flow entry\n+ *\n+ * returns 0 on success and negative on failure.\n+ */\n+static int32_t\n+ulp_flow_db_next_entry_get(struct bnxt_ulp_flow_tbl\t*flowtbl,\n+\t\t\t uint32_t\t\t\t*fid)\n+{\n+\tuint32_t\tlfid = *fid;\n+\tuint32_t\tidx;\n+\tuint64_t\tbs;\n+\n+\tdo {\n+\t\tlfid++;\n+\t\tif (lfid >= flowtbl->num_flows)\n+\t\t\treturn -ENOENT;\n+\t\tidx = lfid / ULP_INDEX_BITMAP_SIZE;\n+\t\twhile (!(bs = flowtbl->active_flow_tbl[idx])) {\n+\t\t\tidx++;\n+\t\t\tif ((idx * ULP_INDEX_BITMAP_SIZE) >= flowtbl->num_flows)\n+\t\t\t\treturn -ENOENT;\n+\t\t}\n+\t\tlfid = (idx * ULP_INDEX_BITMAP_SIZE) + __builtin_clzl(bs);\n+\t\tif (*fid >= lfid) {\n+\t\t\tBNXT_TF_DBG(ERR, \"Flow Database is corrupt\\n\");\n+\t\t\treturn -ENOENT;\n+\t\t}\n+\t} while (!ulp_flow_db_active_flow_is_set(flowtbl, lfid));\n+\n+\t/* all good, return success */\n+\t*fid = lfid;\n+\treturn 0;\n+}\n+\n+/*\n+ * Flush all flows in the flow database.\n+ *\n+ * ulp_ctxt [in] Ptr to ulp context\n+ * tbl_idx [in] The index to table\n+ *\n+ * returns 0 on success or negative number on failure\n+ */\n+int32_t\tulp_flow_db_flush_flows(struct bnxt_ulp_context *ulp_ctx,\n+\t\t\t\tuint32_t\t\tidx)\n+{\n+\tuint32_t\t\t\tfid = 0;\n+\tstruct bnxt_ulp_flow_db\t\t*flow_db;\n+\tstruct bnxt_ulp_flow_tbl\t*flow_tbl;\n+\n+\tif (!ulp_ctx) {\n+\t\tBNXT_TF_DBG(ERR, \"Invalid Argument\\n\");\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tflow_db = bnxt_ulp_cntxt_ptr2_flow_db_get(ulp_ctx);\n+\tif (!flow_db) {\n+\t\tBNXT_TF_DBG(ERR, \"Flow database not found\\n\");\n+\t\treturn -EINVAL;\n+\t}\n+\tflow_tbl = &flow_db->flow_tbl[idx];\n+\twhile (!ulp_flow_db_next_entry_get(flow_tbl, &fid))\n+\t\t(void)ulp_mapper_resources_free(ulp_ctx, fid, idx);\n+\n+\treturn 0;\n+}\ndiff --git a/drivers/net/bnxt/tf_ulp/ulp_flow_db.h b/drivers/net/bnxt/tf_ulp/ulp_flow_db.h\nindex eb5effa..5435415 100644\n--- a/drivers/net/bnxt/tf_ulp/ulp_flow_db.h\n+++ b/drivers/net/bnxt/tf_ulp/ulp_flow_db.h\n@@ -142,4 +142,15 @@ int32_t\tulp_flow_db_fid_free(struct bnxt_ulp_context\t\t*ulp_ctxt,\n \t\t\t enum bnxt_ulp_flow_db_tables\ttbl_idx,\n \t\t\t uint32_t\t\t\t\tfid);\n \n+/*\n+ * Flush all flows in the flow database.\n+ *\n+ * ulp_ctxt [in] Ptr to ulp context\n+ * tbl_idx [in] The index to table\n+ *\n+ * returns 0 on success or negative number on failure\n+ */\n+int32_t\tulp_flow_db_flush_flows(struct bnxt_ulp_context *ulp_ctx,\n+\t\t\t\tuint32_t\t\tidx);\n+\n #endif /* _ULP_FLOW_DB_H_ */\n", "prefixes": [ "v4", "30/34" ] }