Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/68513/?format=api
{ "id": 68513, "url": "https://patches.dpdk.org/api/patches/68513/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1586938751-32808-28-git-send-email-venkatkumar.duvvuru@broadcom.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1586938751-32808-28-git-send-email-venkatkumar.duvvuru@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1586938751-32808-28-git-send-email-venkatkumar.duvvuru@broadcom.com", "date": "2020-04-15T08:19:04", "name": "[v4,27/34] net/bnxt: add support for rte flow create driver hook", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "57ae2bd53108394e8a72b8cdb9455aead24f07e1", "submitter": { "id": 1635, "url": "https://patches.dpdk.org/api/people/1635/?format=api", "name": "Venkat Duvvuru", "email": "venkatkumar.duvvuru@broadcom.com" }, "delegate": { "id": 1766, "url": "https://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1586938751-32808-28-git-send-email-venkatkumar.duvvuru@broadcom.com/mbox/", "series": [ { "id": 9386, "url": "https://patches.dpdk.org/api/series/9386/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=9386", "date": "2020-04-15T08:18:37", "name": "add support for host based flow table management", "version": 4, "mbox": "https://patches.dpdk.org/series/9386/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/68513/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/68513/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0F6F7A0563;\n\tWed, 15 Apr 2020 10:26:01 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0E1251D5EB;\n\tWed, 15 Apr 2020 10:20:43 +0200 (CEST)", "from mail-pg1-f195.google.com (mail-pg1-f195.google.com\n [209.85.215.195]) by dpdk.org (Postfix) with ESMTP id 546751D54C\n for <dev@dpdk.org>; Wed, 15 Apr 2020 10:20:36 +0200 (CEST)", "by mail-pg1-f195.google.com with SMTP id x26so1154740pgc.10\n for <dev@dpdk.org>; Wed, 15 Apr 2020 01:20:36 -0700 (PDT)", "from S60.dhcp.broadcom.net ([192.19.234.250])\n by smtp.gmail.com with ESMTPSA id fy21sm3819019pjb.25.2020.04.15.01.20.32\n (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);\n Wed, 15 Apr 2020 01:20:34 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com;\n s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references;\n bh=hmmihKI/fy3B8Q89yjaOQY4ITGY9iRlonej5aa7Yz8M=;\n b=iKQtzUztVCum9fsN3CzFt/O/6Eb76yX5ogHuoPWOPpY1t4Hv/QFkPXiVgA0VAdTGQ0\n 89EMjmzW1pSAyrmzZTiUMQ0IQQEJNAa+K48DZPQYXQ+eJCMG/m5/h1J/Vsur8/9FDS6O\n X5etBEkyzdUZV4q+1x2UFy1eavASldWxhXJy8=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references;\n bh=hmmihKI/fy3B8Q89yjaOQY4ITGY9iRlonej5aa7Yz8M=;\n b=HWPSKsuVvt8mpxGclBIy9F3OHjIg1DxV4P43PRKGgE8ZO6YFbRQzejDLQJtkmcCEBg\n LxJUlZEjG7uaTIBAppVruqaFtfREjmwWDfYGfps0/D+Ca/gjd3zh4o8xUKDnE2mapKtt\n A6e87xRm9h4RFr/lcs4Ni+SokNedRT+fJt8NW3gv3pIbDYcuROjFA26QjV4RMvAU6pWp\n zW2LxP3Xnkyt9JW7HL7SPlqxLYLzIewK8EjZLj86g3tduE+4yoAvzr9WF0eimPz/78jz\n WvNXeTxrdRwIuazJ5iRcoY8PtGd/K0P4ukN9w/ScmjTYQxjmp3aJbOJ6cvvZMea8hC/d\n WBGw==", "X-Gm-Message-State": "AGi0PuYOkJO/AZSy8JBtKHb6K74QAdpfyjSMb+a7I9vrZ0exKNTYqwqS\n zU+OnOLVy5yYqumalU8f3tAD/8gSO+1AYWJe0IRC3g4D5pMe6ApxVqxDzvUPiH+JtpmfU4oUCV+\n V0ncBT7hAAsAYd73CWQ7InTZC4TSkSNSNPT/WIQ7GPCTitykXQakDzKKj6OM2EB3BaQoN", "X-Google-Smtp-Source": "\n APiQypJ23lMBGit2im4HBT6W0UUcluam9y9htYoSvFJauFE8MPKBW31EUxxKwPGaRyC27MVYoZKkyg==", "X-Received": "by 2002:a65:530b:: with SMTP id m11mr5453003pgq.338.1586938835021;\n Wed, 15 Apr 2020 01:20:35 -0700 (PDT)", "From": "Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>", "To": "dev@dpdk.org", "Cc": "Kishore Padmanabha <kishore.padmanabha@broadcom.com>,\n Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>", "Date": "Wed, 15 Apr 2020 13:49:04 +0530", "Message-Id": "\n <1586938751-32808-28-git-send-email-venkatkumar.duvvuru@broadcom.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "\n <1586938751-32808-1-git-send-email-venkatkumar.duvvuru@broadcom.com>", "References": "\n <1586852011-37536-1-git-send-email-venkatkumar.duvvuru@broadcom.com>\n <1586938751-32808-1-git-send-email-venkatkumar.duvvuru@broadcom.com>", "Subject": "[dpdk-dev] [PATCH v4 27/34] net/bnxt: add support for rte flow\n\tcreate driver hook", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Kishore Padmanabha <kishore.padmanabha@broadcom.com>\n\nThis patch does the following\n1. Validates rte_flow_create arguments\n2. Parses rte_flow_item types\n3. Parses rte_flow_action types\n4. Calls ulp_matcher_pattern_match to see if the flow is supported\n5. If there is a match, calls ulp_mapper_flow_create to program\n key & action tables\n\nSigned-off-by: Kishore Padmanabha <kishore.padmanabha@broadcom.com>\nSigned-off-by: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>\nReviewed-by: Lance Richardson <lance.richardson@broadcom.com>\nReviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/Makefile | 1 +\n drivers/net/bnxt/tf_ulp/bnxt_ulp_flow.c | 177 ++++++++++++++++++++++++++++++++\n 2 files changed, 178 insertions(+)\n create mode 100644 drivers/net/bnxt/tf_ulp/bnxt_ulp_flow.c", "diff": "diff --git a/drivers/net/bnxt/Makefile b/drivers/net/bnxt/Makefile\nindex 5e2d751..5ed33cc 100644\n--- a/drivers/net/bnxt/Makefile\n+++ b/drivers/net/bnxt/Makefile\n@@ -65,6 +65,7 @@ SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_ulp/ulp_utils.c\n SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_ulp/ulp_mapper.c\n SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_ulp/ulp_matcher.c\n SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_ulp/ulp_rte_parser.c\n+SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_ulp/bnxt_ulp_flow.c\n \n #\n # Export include files\ndiff --git a/drivers/net/bnxt/tf_ulp/bnxt_ulp_flow.c b/drivers/net/bnxt/tf_ulp/bnxt_ulp_flow.c\nnew file mode 100644\nindex 0000000..6402dd3\n--- /dev/null\n+++ b/drivers/net/bnxt/tf_ulp/bnxt_ulp_flow.c\n@@ -0,0 +1,177 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright(c) 2014-2020 Broadcom\n+ * All rights reserved.\n+ */\n+\n+#include \"bnxt.h\"\n+#include \"bnxt_tf_common.h\"\n+#include \"ulp_rte_parser.h\"\n+#include \"ulp_matcher.h\"\n+#include \"ulp_flow_db.h\"\n+#include \"ulp_mapper.h\"\n+#include <rte_malloc.h>\n+\n+static int32_t\n+bnxt_ulp_flow_validate_args(const struct rte_flow_attr *attr,\n+\t\t\t const struct rte_flow_item pattern[],\n+\t\t\t const struct rte_flow_action actions[],\n+\t\t\t struct rte_flow_error *error)\n+{\n+\t/* Perform the validation of the arguments for null */\n+\tif (!error)\n+\t\treturn BNXT_TF_RC_ERROR;\n+\n+\tif (!pattern) {\n+\t\trte_flow_error_set(error,\n+\t\t\t\t EINVAL,\n+\t\t\t\t RTE_FLOW_ERROR_TYPE_ITEM_NUM,\n+\t\t\t\t NULL,\n+\t\t\t\t \"NULL pattern.\");\n+\t\treturn BNXT_TF_RC_ERROR;\n+\t}\n+\n+\tif (!actions) {\n+\t\trte_flow_error_set(error,\n+\t\t\t\t EINVAL,\n+\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION_NUM,\n+\t\t\t\t NULL,\n+\t\t\t\t \"NULL action.\");\n+\t\treturn BNXT_TF_RC_ERROR;\n+\t}\n+\n+\tif (!attr) {\n+\t\trte_flow_error_set(error,\n+\t\t\t\t EINVAL,\n+\t\t\t\t RTE_FLOW_ERROR_TYPE_ATTR,\n+\t\t\t\t NULL,\n+\t\t\t\t \"NULL attribute.\");\n+\t\treturn BNXT_TF_RC_ERROR;\n+\t}\n+\n+\tif (attr->egress && attr->ingress) {\n+\t\trte_flow_error_set(error,\n+\t\t\t\t EINVAL,\n+\t\t\t\t RTE_FLOW_ERROR_TYPE_ATTR,\n+\t\t\t\t attr,\n+\t\t\t\t \"EGRESS AND INGRESS UNSUPPORTED\");\n+\t\treturn BNXT_TF_RC_ERROR;\n+\t}\n+\treturn BNXT_TF_RC_SUCCESS;\n+}\n+\n+/* Function to create the rte flow. */\n+static struct rte_flow *\n+bnxt_ulp_flow_create(struct rte_eth_dev\t\t\t*dev,\n+\t\t const struct rte_flow_attr\t\t*attr,\n+\t\t const struct rte_flow_item\t\tpattern[],\n+\t\t const struct rte_flow_action\tactions[],\n+\t\t struct rte_flow_error\t\t*error)\n+{\n+\tstruct ulp_rte_hdr_bitmap hdr_bitmap;\n+\tstruct ulp_rte_hdr_field hdr_field[BNXT_ULP_PROTO_HDR_MAX];\n+\tstruct ulp_rte_act_bitmap act_bitmap;\n+\tstruct ulp_rte_act_prop act_prop;\n+\tenum ulp_direction_type dir = ULP_DIR_INGRESS;\n+\tuint32_t class_id, act_tmpl;\n+\tuint32_t app_priority;\n+\tint ret;\n+\tstruct bnxt_ulp_context *ulp_ctx = NULL;\n+\tuint32_t vnic;\n+\tuint8_t svif;\n+\tstruct rte_flow *flow_id;\n+\tuint32_t fid;\n+\n+\tif (bnxt_ulp_flow_validate_args(attr,\n+\t\t\t\t\tpattern, actions,\n+\t\t\t\t\terror) == BNXT_TF_RC_ERROR) {\n+\t\tBNXT_TF_DBG(ERR, \"Invalid arguments being passed\\n\");\n+\t\treturn NULL;\n+\t}\n+\n+\tulp_ctx = bnxt_ulp_eth_dev_ptr2_cntxt_get(dev);\n+\tif (!ulp_ctx) {\n+\t\tBNXT_TF_DBG(ERR, \"ULP context is not initialized\\n\");\n+\t\treturn NULL;\n+\t}\n+\n+\t/* clear the header bitmap and field structure */\n+\tmemset(&hdr_bitmap, 0, sizeof(struct ulp_rte_hdr_bitmap));\n+\tmemset(hdr_field, 0, sizeof(hdr_field));\n+\tmemset(&act_bitmap, 0, sizeof(act_bitmap));\n+\tmemset(&act_prop, 0, sizeof(act_prop));\n+\n+\tsvif = bnxt_get_svif(dev->data->port_id, false);\n+\tBNXT_TF_DBG(ERR, \"SVIF for port[%d][port]=0x%08x\\n\",\n+\t\t dev->data->port_id, svif);\n+\n+\thdr_field[BNXT_ULP_HDR_FIELD_SVIF_INDEX].size = sizeof(svif);\n+\thdr_field[BNXT_ULP_HDR_FIELD_SVIF_INDEX].spec[0] = svif;\n+\thdr_field[BNXT_ULP_HDR_FIELD_SVIF_INDEX].mask[0] = -1;\n+\tULP_BITMAP_SET(hdr_bitmap.bits, BNXT_ULP_HDR_BIT_SVIF);\n+\n+\t/*\n+\t * VNIC is being pushed as 32bit and the pop will take care of\n+\t * proper size\n+\t */\n+\tvnic = (uint32_t)bnxt_get_vnic_id(dev->data->port_id);\n+\tvnic = htonl(vnic);\n+\trte_memcpy(&act_prop.act_details[BNXT_ULP_ACT_PROP_IDX_VNIC],\n+\t\t &vnic, BNXT_ULP_ACT_PROP_SZ_VNIC);\n+\n+\t/* Parse the rte flow pattern */\n+\tret = bnxt_ulp_rte_parser_hdr_parse(pattern,\n+\t\t\t\t\t &hdr_bitmap,\n+\t\t\t\t\t hdr_field);\n+\tif (ret != BNXT_TF_RC_SUCCESS)\n+\t\tgoto parse_error;\n+\n+\t/* Parse the rte flow action */\n+\tret = bnxt_ulp_rte_parser_act_parse(actions,\n+\t\t\t\t\t &act_bitmap,\n+\t\t\t\t\t &act_prop);\n+\tif (ret != BNXT_TF_RC_SUCCESS)\n+\t\tgoto parse_error;\n+\n+\tif (attr->egress)\n+\t\tdir = ULP_DIR_EGRESS;\n+\n+\tret = ulp_matcher_pattern_match(dir, &hdr_bitmap, hdr_field,\n+\t\t\t\t\t&act_bitmap, &class_id);\n+\n+\tif (ret != BNXT_TF_RC_SUCCESS)\n+\t\tgoto parse_error;\n+\n+\tret = ulp_matcher_action_match(dir, &act_bitmap, &act_tmpl);\n+\tif (ret != BNXT_TF_RC_SUCCESS)\n+\t\tgoto parse_error;\n+\n+\tapp_priority = attr->priority;\n+\t/* call the ulp mapper to create the flow in the hardware */\n+\tret = ulp_mapper_flow_create(ulp_ctx,\n+\t\t\t\t app_priority,\n+\t\t\t\t &hdr_bitmap,\n+\t\t\t\t hdr_field,\n+\t\t\t\t &act_bitmap,\n+\t\t\t\t &act_prop,\n+\t\t\t\t class_id,\n+\t\t\t\t act_tmpl,\n+\t\t\t\t &fid);\n+\tif (!ret) {\n+\t\tflow_id = (struct rte_flow *)((uintptr_t)fid);\n+\t\treturn flow_id;\n+\t}\n+\n+parse_error:\n+\trte_flow_error_set(error, ret, RTE_FLOW_ERROR_TYPE_HANDLE, NULL,\n+\t\t\t \"Failed to create flow.\");\n+\treturn NULL;\n+}\n+\n+const struct rte_flow_ops bnxt_ulp_rte_flow_ops = {\n+\t.validate = NULL,\n+\t.create = bnxt_ulp_flow_create,\n+\t.destroy = NULL,\n+\t.flush = NULL,\n+\t.query = NULL,\n+\t.isolate = NULL\n+};\n", "prefixes": [ "v4", "27/34" ] }