Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/68501/?format=api
{ "id": 68501, "url": "https://patches.dpdk.org/api/patches/68501/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1586938751-32808-16-git-send-email-venkatkumar.duvvuru@broadcom.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1586938751-32808-16-git-send-email-venkatkumar.duvvuru@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1586938751-32808-16-git-send-email-venkatkumar.duvvuru@broadcom.com", "date": "2020-04-15T08:18:52", "name": "[v4,15/34] net/bnxt: add devargs parameter for host memory based TRUFLOW feature", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "01efb62e80d36fe0a67985d04a9039b91c72525f", "submitter": { "id": 1635, "url": "https://patches.dpdk.org/api/people/1635/?format=api", "name": "Venkat Duvvuru", "email": "venkatkumar.duvvuru@broadcom.com" }, "delegate": { "id": 1766, "url": "https://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1586938751-32808-16-git-send-email-venkatkumar.duvvuru@broadcom.com/mbox/", "series": [ { "id": 9386, "url": "https://patches.dpdk.org/api/series/9386/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=9386", "date": "2020-04-15T08:18:37", "name": "add support for host based flow table management", "version": 4, "mbox": "https://patches.dpdk.org/series/9386/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/68501/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/68501/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6F1F6A0563;\n\tWed, 15 Apr 2020 10:23:17 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 7F6121D5B0;\n\tWed, 15 Apr 2020 10:20:05 +0200 (CEST)", "from mail-pg1-f193.google.com (mail-pg1-f193.google.com\n [209.85.215.193]) by dpdk.org (Postfix) with ESMTP id 19AC01D5A5\n for <dev@dpdk.org>; Wed, 15 Apr 2020 10:20:03 +0200 (CEST)", "by mail-pg1-f193.google.com with SMTP id r4so1170131pgg.4\n for <dev@dpdk.org>; Wed, 15 Apr 2020 01:20:03 -0700 (PDT)", "from S60.dhcp.broadcom.net ([192.19.234.250])\n by smtp.gmail.com with ESMTPSA id fy21sm3819019pjb.25.2020.04.15.01.19.59\n (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);\n Wed, 15 Apr 2020 01:20:01 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com;\n s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=lhUKNr4BQDS/JwGej21/sv8hNab8o984cmrf4FSZAmY=;\n b=emT2mO2LC0+yT2tKqULuCHqR8KZLnRF9u19xV2rLwswPfCLFbev6bbTj9iyEEhWhBt\n 6jumES2wXjoO/1Kz+dVdLuQdZQFfBAg32rA8Ghf1+fhPo/XGHhh9Z/1kxmprESEqxBK8\n HQBwTeMAYDFDkApGkK2tavd6DClpACtdghivE=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=lhUKNr4BQDS/JwGej21/sv8hNab8o984cmrf4FSZAmY=;\n b=Toi+U6UN7ossJdT8xmd3+f8GGyuzhlAvq7IyMekltjpEGncg5H9U4skFaGqIVsxh2x\n xoNkfHTUCLBzbk2b1uI2lu+zMXwuJqE+zwBvCFkRQpLFa16kKifhzixqPUtYCU7ojPaj\n nN/JhP5aGSuyYjXFo+Kj5T7s0TTqji7iPubSU/PRhyr5X9DRUrENZOkb3NWgZmroQrPS\n KapL4002oRkRMW/mKzBWP44OGcENanToWx6H7PBSKmhesNxdTUtlRRsx0CcbS5Y/xrp/\n f1JIhjBXsYc1QmHpAAmR/Poz7MagBUhGGkMCZ63t6yOb6mEUP9M9y0oyOVYPKMHsmwFn\n PFDQ==", "X-Gm-Message-State": "AGi0PuZWnh/p2Zq5UbufjiGiwkGhB+c5G5EVtJOlx8KnLTd18qcwg43U\n X49zWJX+nHmpvraxUZEBvs/3FguisPKTeIrmRKk68Of+HvKvbBUithM/t2pa5UzteuFnECSj/Nb\n lCzwYNq78y3a694aQvY7MdhXmnV6SzpYPDtdKByHxHGdwDkwW585Xxl93/eaetfTW3DAy", "X-Google-Smtp-Source": "\n APiQypKieQd5O+ebZOn0FJRjVqj2dIND05URyd6YwjaYDAd9QRbyIIK3pTIS3en9A+OXZufPkHvHVQ==", "X-Received": "by 2002:a63:e10f:: with SMTP id z15mr26042126pgh.88.1586938801762;\n Wed, 15 Apr 2020 01:20:01 -0700 (PDT)", "From": "Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>", "To": "dev@dpdk.org", "Cc": "Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>", "Date": "Wed, 15 Apr 2020 13:48:52 +0530", "Message-Id": "\n <1586938751-32808-16-git-send-email-venkatkumar.duvvuru@broadcom.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "\n <1586938751-32808-1-git-send-email-venkatkumar.duvvuru@broadcom.com>", "References": "\n <1586852011-37536-1-git-send-email-venkatkumar.duvvuru@broadcom.com>\n <1586938751-32808-1-git-send-email-venkatkumar.duvvuru@broadcom.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v4 15/34] net/bnxt: add devargs parameter for\n\thost memory based TRUFLOW feature", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This feature can be enabled by passing\n\"-w 0000:0d:00.0,host-based-truflow=1” to the DPDK application.\n\nSigned-off-by: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>\nReviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>\n---\n drivers/net/bnxt/bnxt.h | 4 ++-\n drivers/net/bnxt/bnxt_ethdev.c | 73 ++++++++++++++++++++++++++++++++++++++++++\n 2 files changed, 76 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h\nindex c4507f7..cd84ebd 100644\n--- a/drivers/net/bnxt/bnxt.h\n+++ b/drivers/net/bnxt/bnxt.h\n@@ -685,7 +685,9 @@ struct bnxt {\n #define\tBNXT_SVIF_INVALID\t0xFFFF\n \tuint16_t\t\tfunc_svif;\n \tuint16_t\t\tport_svif;\n-\tstruct tf tfp;\n+\n+\tstruct tf\t\ttfp;\n+\tuint8_t\t\t\ttruflow;\n };\n \n int bnxt_mtu_set_op(struct rte_eth_dev *eth_dev, uint16_t new_mtu);\ndiff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex 57ed90f..c4bbf1d 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -12,6 +12,7 @@\n #include <rte_malloc.h>\n #include <rte_cycles.h>\n #include <rte_alarm.h>\n+#include <rte_kvargs.h>\n \n #include \"bnxt.h\"\n #include \"bnxt_filter.h\"\n@@ -126,6 +127,18 @@ static const struct rte_pci_id bnxt_pci_id_map[] = {\n \t\t\t\t DEV_RX_OFFLOAD_SCATTER | \\\n \t\t\t\t DEV_RX_OFFLOAD_RSS_HASH)\n \n+#define BNXT_DEVARG_TRUFLOW\t\"host-based-truflow\"\n+static const char *const bnxt_dev_args[] = {\n+\tBNXT_DEVARG_TRUFLOW,\n+\tNULL\n+};\n+\n+/*\n+ * truflow == false to disable the feature\n+ * truflow == true to enable the feature\n+ */\n+#define\tBNXT_DEVARG_TRUFLOW_INVALID(truflow)\t((truflow) > 1)\n+\n static int bnxt_vlan_offload_set_op(struct rte_eth_dev *dev, int mask);\n static void bnxt_print_link_info(struct rte_eth_dev *eth_dev);\n static int bnxt_dev_uninit(struct rte_eth_dev *eth_dev);\n@@ -4854,6 +4867,63 @@ static int bnxt_init_resources(struct bnxt *bp, bool reconfig_dev)\n }\n \n static int\n+bnxt_parse_devarg_truflow(__rte_unused const char *key,\n+\t\t\t const char *value, void *opaque_arg)\n+{\n+\tstruct bnxt *bp = opaque_arg;\n+\tunsigned long truflow;\n+\tchar *end = NULL;\n+\n+\tif (!value || !opaque_arg) {\n+\t\tPMD_DRV_LOG(ERR,\n+\t\t\t \"Invalid parameter passed to truflow devargs.\\n\");\n+\t\treturn -EINVAL;\n+\t}\n+\n+\ttruflow = strtoul(value, &end, 10);\n+\tif (end == NULL || *end != '\\0' ||\n+\t (truflow == ULONG_MAX && errno == ERANGE)) {\n+\t\tPMD_DRV_LOG(ERR,\n+\t\t\t \"Invalid parameter passed to truflow devargs.\\n\");\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tif (BNXT_DEVARG_TRUFLOW_INVALID(truflow)) {\n+\t\tPMD_DRV_LOG(ERR,\n+\t\t\t \"Invalid value passed to truflow devargs.\\n\");\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tbp->truflow = truflow;\n+\tif (bp->truflow)\n+\t\tPMD_DRV_LOG(INFO, \"Host-based truflow feature enabled.\\n\");\n+\n+\treturn 0;\n+}\n+\n+static void\n+bnxt_parse_dev_args(struct bnxt *bp, struct rte_devargs *devargs)\n+{\n+\tstruct rte_kvargs *kvlist;\n+\n+\tif (devargs == NULL)\n+\t\treturn;\n+\n+\tkvlist = rte_kvargs_parse(devargs->args, bnxt_dev_args);\n+\tif (kvlist == NULL)\n+\t\treturn;\n+\n+\t/*\n+\t * Handler for \"truflow\" devarg.\n+\t * Invoked as for ex: \"-w 0000:00:0d.0,host-based-truflow=1”\n+\t */\n+\trte_kvargs_process(kvlist, BNXT_DEVARG_TRUFLOW,\n+\t\t\t bnxt_parse_devarg_truflow, bp);\n+\n+\trte_kvargs_free(kvlist);\n+}\n+\n+static int\n bnxt_dev_init(struct rte_eth_dev *eth_dev)\n {\n \tstruct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(eth_dev);\n@@ -4879,6 +4949,9 @@ bnxt_dev_init(struct rte_eth_dev *eth_dev)\n \n \tbp = eth_dev->data->dev_private;\n \n+\t/* Parse dev arguments passed on when starting the DPDK application. */\n+\tbnxt_parse_dev_args(bp, pci_dev->device.devargs);\n+\n \tbp->flags &= ~BNXT_FLAG_RX_VECTOR_PKT_MODE;\n \n \tif (bnxt_vf_pciid(pci_dev->id.device_id))\n", "prefixes": [ "v4", "15/34" ] }