Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/68454/?format=api
{ "id": 68454, "url": "https://patches.dpdk.org/api/patches/68454/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200414220733.7868-1-sodey@rbbn.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200414220733.7868-1-sodey@rbbn.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200414220733.7868-1-sodey@rbbn.com", "date": "2020-04-14T22:07:33", "name": "net/i40e: issue with ADD VLAN from Guest", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": true, "hash": "8b737acd0bd8bd8b0b82f2e3a46a8ff1b86ea966", "submitter": { "id": 952, "url": "https://patches.dpdk.org/api/people/952/?format=api", "name": "Dey, Souvik", "email": "sodey@rbbn.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200414220733.7868-1-sodey@rbbn.com/mbox/", "series": [ { "id": 9376, "url": "https://patches.dpdk.org/api/series/9376/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=9376", "date": "2020-04-14T22:07:33", "name": "net/i40e: issue with ADD VLAN from Guest", "version": 1, "mbox": "https://patches.dpdk.org/series/9376/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/68454/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/68454/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9991BA0588;\n\tWed, 15 Apr 2020 00:07:51 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id CF0751C437;\n\tWed, 15 Apr 2020 00:07:50 +0200 (CEST)", "from us-smtp-delivery-181.mimecast.com\n (us-smtp-delivery-181.mimecast.com [63.128.21.181])\n by dpdk.org (Postfix) with ESMTP id BFC771C2F8\n for <dev@dpdk.org>; Wed, 15 Apr 2020 00:07:49 +0200 (CEST)", "from NAM12-BN8-obe.outbound.protection.outlook.com\n (mail-bn8nam12lp2170.outbound.protection.outlook.com [104.47.55.170])\n (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-386-BC9J7-OIM1ewwWEyGfTsrg-1; Tue, 14 Apr 2020 18:07:47 -0400", "from DM6PR03MB4777.namprd03.prod.outlook.com (20.179.106.218) by\n DM6PR03MB5034.namprd03.prod.outlook.com (10.141.162.206) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.2900.26; Tue, 14 Apr 2020 22:07:45 +0000", "from DM6PR03MB4777.namprd03.prod.outlook.com\n ([fe80::7cc8:d76f:2733:b128]) by DM6PR03MB4777.namprd03.prod.outlook.com\n ([fe80::7cc8:d76f:2733:b128%3]) with mapi id 15.20.2900.028; Tue, 14 Apr 2020\n 22:07:45 +0000", "from SODEY-LMA.sonusnet.com (72.70.55.110) by\n MN2PR14CA0006.namprd14.prod.outlook.com (2603:10b6:208:23e::11) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.2900.15 via Frontend\n Transport; Tue, 14 Apr 2020 22:07:44 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=rbbn.com;\n s=mimecast20180816; t=1586902069;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding;\n bh=FeZc2ADKuEnzzr4fcjsYzfJo5QJv/zB1pxa+XlhOC0U=;\n b=GrDqNCoWzO57MlRCWutV6IsU149W22XRoiBDhkeUAkKDfIPxnggurIOd34A2sMU+uKJht5\n cemeF2NBae8x/1kHocBkKnWvltpKIJjRYe6YSoZEzTRLioEeP77nLjLPrhToX+ZvJh5hOX\n 6gn2DoMxOb2ycvITr0vfKEqzh7CfzI4=", "X-MC-Unique": "BC9J7-OIM1ewwWEyGfTsrg-1", "From": "Souvik Dey <sodey@rbbn.com>", "To": "beilei.xing@intel.com,\n\tqi.z.zhang@intel.com", "Cc": "dev@dpdk.org,\n\tSouvik Dey <sodey@rbbn.com>", "Date": "Tue, 14 Apr 2020 18:07:33 -0400", "Message-Id": "<20200414220733.7868-1-sodey@rbbn.com>", "X-Mailer": [ "git-send-email 2.9.3.windows.1", "git-send-email 2.9.3.windows.1" ], "X-ClientProxiedBy": "MN2PR14CA0006.namprd14.prod.outlook.com\n (2603:10b6:208:23e::11) To DM6PR03MB4777.namprd03.prod.outlook.com\n (2603:10b6:5:18b::26)", "MIME-Version": "1.0", "X-MS-Exchange-MessageSentRepresentingType": "1", "X-Originating-IP": "[72.70.55.110]", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "41fbc243-8ca0-4606-7682-08d7e0c0427b", "X-MS-TrafficTypeDiagnostic": "DM6PR03MB5034:", "X-MS-Exchange-Transport-Forked": "True", "X-Microsoft-Antispam-PRVS": "\n <DM6PR03MB50341C42E263E19AA0CB2DDFCDDA0@DM6PR03MB5034.namprd03.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:8882;", "X-Forefront-PRVS": "0373D94D15", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:DM6PR03MB4777.namprd03.prod.outlook.com; PTR:; CAT:NONE;\n SFTY:;\n SFS:(10009020)(4636009)(366004)(136003)(376002)(346002)(39850400004)(396003)(2616005)(26005)(956004)(52116002)(4326008)(316002)(6506007)(186003)(66556008)(16526019)(66476007)(66946007)(5660300002)(2906002)(8936002)(81156014)(8676002)(107886003)(1076003)(478600001)(6512007)(36756003)(86362001)(6486002)(6666004);\n DIR:OUT; SFP:1101;", "X-MS-Exchange-SenderADCheck": "1", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n xyrVin8PFoPRygnBrBKQ0PhFBSUuRVWgu4SEFy1LQeSmqgECzHhMzylVPSvI1A02i32n+XtoxdesyCmJOQvqHHjEjoPxhl/aUirfZMBg/1Ri0K8LPfbhbL+hFjRmzvYUwSMvQQxxW4yhdp5pOPaaUnGrZAV2RLhnADYg4ujDzPcj22PDQMzqretnDqyomW3I9mQ6UEFMFUMuPliC3JcLgOki+utKedd4vjt9dfYQNlwQ5w0sfePLJZGdGYvvrbm9HD8lN1Cd2JvweuHQ1jTEVlzgF1VMNI71D0v/rHcowW1vIwaDlNo5IdqW6NYEmSuOHUTup8cIg1MKYBGN0TaWSnvDLai8HwlujfiC7z1luhflW5CZqrpjkEUDv+TuxLWL0j5XsIMI3210jb+UAOlPQvNF4FpozCH7c+V9yKPSC/PKbTqk7hKZukDwnDwE33Lr", "X-MS-Exchange-AntiSpam-MessageData": "\n DbRuE17ir4eASx5OVzZEX0+EgWt4EbNSRS+3D9Tf+DaJ3Agf3Y7lAcdlrBJEXEpuKBavIAZolqX3w4g7KpGjEr+pfx5boT6riZfLxxmko+eDYVdbiA175B2nFl9Lgje28cDrFq37vzPHUcqzGvMM4Q==", "X-OriginatorOrg": "rbbn.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 41fbc243-8ca0-4606-7682-08d7e0c0427b", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "14 Apr 2020 22:07:45.1953 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "29a671dc-ed7e-4a54-b1e5-8da1eb495dc3", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n JbblKPYMmO1+RDGH7nVEsYI+Yg0vm+bd5uquKq08wbBEsmN8k03TwX1xE9Oq7Eo0", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DM6PR03MB5034", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "rbbn.com", "Content-Type": "text/plain; charset=WINDOWS-1252", "Content-Transfer-Encoding": "quoted-printable", "Subject": "[dpdk-dev] [PATCH] net/i40e: issue with ADD VLAN from Guest", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "In case of i40evf pmd, when ADD_VLAN is sent down the linux i40e driver,\nalong with add the vlan the kernel driver also enables the vlan stripping\nby default.\nThis might have issues if the app configured DEV_RX_OFFLOAD_VLAN_STRIP\nas off at the port configuration. The app after adding the VLAN will\nexpect the VLAN to be coming in the received packets but, due to\nVLAN_STRIP enabled at the PF, it will get stripped.\nThis behavior of the Linux driver causes confussion with the DPDK app\nusing i40e_pmd. So it is better to check the state of the\nDEV_RX_OFFLOAD_VLAN_STRIP flag in the dev_conf and disable the vlan strip\nafter sending add_vlan if app configured the VLAN_STRIP as disabled.\n\n\nSigned-off-by: Souvik Dey <sodey@rbbn.com>\n---\n drivers/net/i40e/i40e_ethdev_vf.c | 16 +++++++++++++++-\n 1 file changed, 15 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c\nindex 244397e..b8b6c57 100644\n--- a/drivers/net/i40e/i40e_ethdev_vf.c\n+++ b/drivers/net/i40e/i40e_ethdev_vf.c\n@@ -1044,6 +1044,7 @@ i40evf_add_vlan(struct rte_eth_dev *dev, uint16_t vlanid)\n {\n \tstruct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);\n \tstruct virtchnl_vlan_filter_list *vlan_list;\n+\tstruct rte_eth_conf *dev_conf = &dev->data->dev_conf;\n \tuint8_t cmd_buffer[sizeof(struct virtchnl_vlan_filter_list) +\n \t\t\t\t\t\t\tsizeof(uint16_t)];\n \tint err;\n@@ -1060,8 +1061,21 @@ i40evf_add_vlan(struct rte_eth_dev *dev, uint16_t vlanid)\n \targs.out_buffer = vf->aq_resp;\n \targs.out_size = I40E_AQ_BUF_SZ;\n \terr = i40evf_execute_vf_cmd(dev, &args);\n-\tif (err)\n+\tif (err) {\n \t\tPMD_DRV_LOG(ERR, \"fail to execute command OP_ADD_VLAN\");\n+\t\treturn ret;\n+\t}\n+\t/*\n+\t * In linux kernel driver on receiving ADD_VLAN it enables\n+\t * VLAN_STRIP by default. So disable it if app confifured\n+\t * it that way.\n+\t */\n+\tif (!(dev_conf->rxmode.offloads & DEV_RX_OFFLOAD_VLAN_STRIP)) {\n+\t\terr = i40evf_disable_vlan_strip(dev);\n+\t\tif (err)\n+\t\t\tPMD_DRV_LOG(ERR, \"fail to execute command disable_vlan_strip \"\n+\t\t\t\t\"as a part of OP_ADD_VLAN\");\n+\t}\n \n \treturn err;\n }\n", "prefixes": [] }