Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/6845/?format=api
{ "id": 6845, "url": "https://patches.dpdk.org/api/patches/6845/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1441072746-29174-6-git-send-email-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1441072746-29174-6-git-send-email-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/1441072746-29174-6-git-send-email-stephen@networkplumber.org", "date": "2015-09-01T01:59:06", "name": "[dpdk-dev,5/5] examples_ip_pipeline: fix possible string overrun", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "fa22de906ee66ef86b1f928bb4c121af805c0fd5", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1441072746-29174-6-git-send-email-stephen@networkplumber.org/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/6845/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/6845/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id D140F8DAE;\n\tTue, 1 Sep 2015 03:59:04 +0200 (CEST)", "from mail-pa0-f50.google.com (mail-pa0-f50.google.com\n\t[209.85.220.50]) by dpdk.org (Postfix) with ESMTP id 243E08D95\n\tfor <dev@dpdk.org>; Tue, 1 Sep 2015 03:59:02 +0200 (CEST)", "by paczk9 with SMTP id zk9so9929677pac.0\n\tfor <dev@dpdk.org>; Mon, 31 Aug 2015 18:59:01 -0700 (PDT)", "from urahara.home.lan (static-50-53-82-155.bvtn.or.frontiernet.net.\n\t[50.53.82.155]) by smtp.gmail.com with ESMTPSA id\n\tld8sm15988418pbc.61.2015.08.31.18.59.00\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tMon, 31 Aug 2015 18:59:00 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=n7grVrPX7+s5jqYfKeRC/QnfUHVHiHH+1T2gbrM10ZI=;\n\tb=dxwXEW61K8/XM0VVKxqsFuStu8eWxI76PPm7gPnVpsFTR1OW8fGikCib7Rt+MakUOI\n\tYKXB5RN4qQgVYGwdqbpRWmcRoI0GSDwTwyLhwqYdkXivxjp0/uNjIhVOSMAbeuUZwHsP\n\tT1wjBrli6yTn+Z/gq3f6zR/7MuFYzKNaabPETBQ7WZH0XHfrKvC+Cp9tGnXECiQ7qrXC\n\t8/Tg97vJimxQ/0CgojeBMfOuOB/ARyBfBdjQPMuH8c1EUBaW39jI2viQPA0PmmbsW1fW\n\tIZKvsXDNptxOAiuBnjEvL4Q0Gs1M+vpJLdCeQOlBcFV265dwTfvi4cmYMGilFokBR2E5\n\teOhA==", "X-Gm-Message-State": "ALoCoQkV7VKEn8ebS1ZCviFRJBaa0QDjafoG+e6GReiroK477EuDuTCBPtQQszT6bndPemFsmT2L", "X-Received": "by 10.68.181.34 with SMTP id dt2mr41852419pbc.7.1441072741528;\n\tMon, 31 Aug 2015 18:59:01 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "cristian.dumitrescu@intel.com", "Date": "Mon, 31 Aug 2015 18:59:06 -0700", "Message-Id": "<1441072746-29174-6-git-send-email-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.1.4", "In-Reply-To": "<1441072746-29174-1-git-send-email-stephen@networkplumber.org>", "References": "<1441072746-29174-1-git-send-email-stephen@networkplumber.org>", "Cc": "dev@dpdk.org", "Subject": "[dpdk-dev] [PATCH 5/5] examples_ip_pipeline: fix possible string\n\toverrun", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "If a long name was passed the code would clobber memory with\nstrcpy.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n examples/ip_pipeline/app.h | 2 +-\n examples/ip_pipeline/init.c | 5 +++--\n 2 files changed, 4 insertions(+), 3 deletions(-)", "diff": "diff --git a/examples/ip_pipeline/app.h b/examples/ip_pipeline/app.h\nindex 521e3a0..1f6bf0c 100644\n--- a/examples/ip_pipeline/app.h\n+++ b/examples/ip_pipeline/app.h\n@@ -190,7 +190,7 @@ struct app_pktq_out_params {\n #define APP_MAX_PIPELINE_ARGS PIPELINE_MAX_ARGS\n \n struct app_pipeline_params {\n-\tchar *name;\n+\tconst char *name;\n \tuint8_t parsed;\n \n \tchar type[APP_PIPELINE_TYPE_SIZE];\ndiff --git a/examples/ip_pipeline/init.c b/examples/ip_pipeline/init.c\nindex 75e3767..007af83 100644\n--- a/examples/ip_pipeline/init.c\n+++ b/examples/ip_pipeline/init.c\n@@ -1022,12 +1022,13 @@ app_init_msgq(struct app_params *app)\n }\n \n static void app_pipeline_params_get(struct app_params *app,\n-\tstruct app_pipeline_params *p_in,\n+\tconst struct app_pipeline_params *p_in,\n \tstruct pipeline_params *p_out)\n {\n \tuint32_t i;\n \n-\tstrcpy(p_out->name, p_in->name);\n+\tstrncpy(p_out->name, p_in->name, PIPELINE_NAME_SIZE - 1);\n+\tp_out->name[PIPELINE_NAME_SIZE - 1] = '\\0';\n \n \tp_out->socket_id = (int) p_in->socket_id;\n \n", "prefixes": [ "dpdk-dev", "5/5" ] }