Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/68020/?format=api
{ "id": 68020, "url": "https://patches.dpdk.org/api/patches/68020/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200408164956.47864-9-ciara.power@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200408164956.47864-9-ciara.power@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200408164956.47864-9-ciara.power@intel.com", "date": "2020-04-08T16:49:48", "name": "[v2,08/16] ethdev: add callback support for telemetry", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "c94488bf41df965399dea177ac4b6852f23dd5b9", "submitter": { "id": 978, "url": "https://patches.dpdk.org/api/people/978/?format=api", "name": "Power, Ciara", "email": "ciara.power@intel.com" }, "delegate": { "id": 24651, "url": "https://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200408164956.47864-9-ciara.power@intel.com/mbox/", "series": [ { "id": 9255, "url": "https://patches.dpdk.org/api/series/9255/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=9255", "date": "2020-04-08T16:49:41", "name": "update and simplify telemetry library.", "version": 2, "mbox": "https://patches.dpdk.org/series/9255/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/68020/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/68020/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C0653A0597;\n\tWed, 8 Apr 2020 19:10:00 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E8A521C1CE;\n\tWed, 8 Apr 2020 19:08:23 +0200 (CEST)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n by dpdk.org (Postfix) with ESMTP id 0BF7E1C0CD\n for <dev@dpdk.org>; Wed, 8 Apr 2020 19:08:21 +0200 (CEST)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 08 Apr 2020 10:08:21 -0700", "from silpixa00399953.ir.intel.com (HELO\n silpixa00399953.ger.corp.intel.com) ([10.237.222.53])\n by fmsmga006.fm.intel.com with ESMTP; 08 Apr 2020 10:08:19 -0700" ], "IronPort-SDR": [ "\n zZfFOtoVTWwSY/K33PqWLMjPSHPo+SHnO7GKnooYxREptTAR8SG+/QNXg1g7+y1FUN/lW+4ijb\n g5qTOIS9rXxQ==", "\n zjDt3vI5EtRYz5I1ECwoaTMa5/G2zYvBUHXGT1Us9dKSQvARcvRIxavuhQeeNDxj620CxiVqSn\n Dg59qTPR/mHw==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.72,359,1580803200\"; d=\"scan'208\";a=\"452880227\"", "From": "Ciara Power <ciara.power@intel.com>", "To": "dev@dpdk.org,\n\tkevin.laatz@intel.com", "Cc": "reshma.pattan@intel.com, jerinjacobk@gmail.com, david.marchand@redhat.com,\n keith.wiles@intel.com, mb@smartsharesystems.com, thomas@monjalon.net,\n Bruce Richardson <bruce.richardson@intel.com>,\n Ciara Power <ciara.power@intel.com>", "Date": "Wed, 8 Apr 2020 17:49:48 +0100", "Message-Id": "<20200408164956.47864-9-ciara.power@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200408164956.47864-1-ciara.power@intel.com>", "References": "<20200319171907.60891-1-ciara.power@intel.com>\n <20200408164956.47864-1-ciara.power@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 08/16] ethdev: add callback support for\n\ttelemetry", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Bruce Richardson <bruce.richardson@intel.com>\n\nThe ethdev library now registers commands with telemetry, and\nimplements the callback functions. These commands allow the list of\nethdev ports and the stats and link status for a port to be queried.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\nSigned-off-by: Ciara Power <ciara.power@intel.com>\n\n---\nv2:\n - Renamed stats to xstats for device specific stats.\n - Added link status command for ethdev ports.\n---\n lib/librte_ethdev/Makefile | 4 ++\n lib/librte_ethdev/meson.build | 4 ++\n lib/librte_ethdev/rte_ethdev.c | 106 +++++++++++++++++++++++++++++++++\n 3 files changed, 114 insertions(+)", "diff": "diff --git a/lib/librte_ethdev/Makefile b/lib/librte_ethdev/Makefile\nindex b627e4e23b..4ba9cb8f47 100644\n--- a/lib/librte_ethdev/Makefile\n+++ b/lib/librte_ethdev/Makefile\n@@ -24,6 +24,10 @@ SRCS-y += rte_tm.c\n SRCS-y += rte_mtr.c\n SRCS-y += ethdev_profile.c\n \n+ifeq ($(CONFIG_RTE_LIBRTE_TELEMETRY),y)\n+LDLIBS += -lrte_telemetry\n+endif\n+\n #\n # Export include files\n #\ndiff --git a/lib/librte_ethdev/meson.build b/lib/librte_ethdev/meson.build\nindex 3537f22f59..072805cf18 100644\n--- a/lib/librte_ethdev/meson.build\n+++ b/lib/librte_ethdev/meson.build\n@@ -26,3 +26,7 @@ headers = files('rte_ethdev.h',\n \t'rte_tm_driver.h')\n \n deps += ['net', 'kvargs', 'meter']\n+\n+if dpdk_conf.has('RTE_LIBRTE_TELEMETRY')\n+\tdeps += ['telemetry']\n+endif\ndiff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c\nindex 0854ef8832..f033d60152 100644\n--- a/lib/librte_ethdev/rte_ethdev.c\n+++ b/lib/librte_ethdev/rte_ethdev.c\n@@ -38,6 +38,9 @@\n #include <rte_kvargs.h>\n #include <rte_class.h>\n #include <rte_ether.h>\n+#ifdef RTE_LIBRTE_TELEMETRY\n+#include <rte_telemetry.h>\n+#endif\n \n #include \"rte_ethdev.h\"\n #include \"rte_ethdev_driver.h\"\n@@ -5189,9 +5192,112 @@ rte_eth_devargs_parse(const char *dargs, struct rte_eth_devargs *eth_da)\n \treturn result;\n }\n \n+#ifdef RTE_LIBRTE_TELEMETRY\n+static int\n+handle_port_list(const char *cmd __rte_unused,\n+\t\tconst char *params __rte_unused,\n+\t\tchar *buffer, int buf_len)\n+{\n+\tint port_id, used = 0;\n+\n+\tused = rte_tel_json_empty_array(buffer, buf_len, used);\n+\tRTE_ETH_FOREACH_DEV(port_id)\n+\t\tused = rte_tel_json_add_array_int(buffer, buf_len, used,\n+\t\t\t\tport_id);\n+\treturn used;\n+}\n+\n+static int\n+handle_port_xstats(const char *cmd __rte_unused,\n+\t\tconst char *params,\n+\t\tchar *buffer, int buf_len)\n+{\n+\tstruct rte_eth_xstat *eth_xstats;\n+\tstruct rte_eth_xstat_name *xstat_names;\n+\tint port_id, num_xstats;\n+\tint i, ret;\n+\tint used = 0;\n+\n+\tif (params == NULL || strlen(params) == 0 || !isdigit(*params))\n+\t\treturn -1;\n+\n+\tport_id = atoi(params);\n+\tif (!rte_eth_dev_is_valid_port(port_id))\n+\t\treturn -1;\n+\n+\tnum_xstats = rte_eth_xstats_get(port_id, NULL, 0);\n+\tif (num_xstats < 0)\n+\t\treturn -1;\n+\n+\t/* use one malloc for both names and stats */\n+\teth_xstats = malloc((sizeof(struct rte_eth_xstat) +\n+\t\t\tsizeof(struct rte_eth_xstat_name)) * num_xstats);\n+\tif (eth_xstats == NULL)\n+\t\treturn -1;\n+\txstat_names = (void *)ð_xstats[num_xstats];\n+\n+\tret = rte_eth_xstats_get_names(port_id, xstat_names, num_xstats);\n+\tif (ret < 0 || ret > num_xstats) {\n+\t\tfree(eth_xstats);\n+\t\treturn -1;\n+\t}\n+\n+\tret = rte_eth_xstats_get(port_id, eth_xstats, num_xstats);\n+\tif (ret < 0 || ret > num_xstats) {\n+\t\tfree(eth_xstats);\n+\t\treturn -1;\n+\t}\n+\n+\tused = rte_tel_json_empty_obj(buffer, buf_len, used);\n+\tfor (i = 0; i < num_xstats; i++)\n+\t\tused = rte_tel_json_add_obj_u64(buffer, buf_len, used,\n+\t\t\t\txstat_names[i].name, eth_xstats[i].value);\n+\n+\treturn used;\n+}\n+\n+static int\n+handle_port_link_status(const char *cmd __rte_unused,\n+\t\tconst char *params,\n+\t\tchar *buffer, int buf_len)\n+{\n+\tint ret, port_id;\n+\tstruct rte_eth_link link;\n+\n+\tif (params == NULL || strlen(params) == 0 || !isdigit(*params))\n+\t\treturn -1;\n+\n+\tport_id = atoi(params);\n+\tif (!rte_eth_dev_is_valid_port(port_id))\n+\t\treturn -1;\n+\n+\tret = rte_eth_link_get(port_id, &link);\n+\tif (ret < 0)\n+\t\treturn -1;\n+\n+\tif (link.link_status)\n+\t\tret = snprintf(buffer, buf_len,\n+\t\t\t\t\"{\\\"status\\\":\\\"%s\\\", \\\"speed\\\":%u, \\\"duplex\\\":\"\n+\t\t\t\t\"\\\"%s\\\"}\", link.link_status ? \"UP\" : \"DOWN:\",\n+\t\t\t\tlink.link_speed,\n+\t\t\t\t(link.link_duplex == ETH_LINK_FULL_DUPLEX) ?\n+\t\t\t\t(\"full-duplex\") : (\"half-duplex\"));\n+\telse\n+\t\tret = snprintf(buffer, buf_len, \"{\\\"status\\\":\\\"DOWN\\\"}\");\n+\n+\treturn ret >= buf_len ? -1 : ret;\n+}\n+#endif\n+\n RTE_INIT(ethdev_init_log)\n {\n \trte_eth_dev_logtype = rte_log_register(\"lib.ethdev\");\n \tif (rte_eth_dev_logtype >= 0)\n \t\trte_log_set_level(rte_eth_dev_logtype, RTE_LOG_INFO);\n+#ifdef RTE_LIBRTE_TELEMETRY\n+\trte_telemetry_register_cmd(\"/ethdev/list\", handle_port_list);\n+\trte_telemetry_register_cmd(\"/ethdev/xstats\", handle_port_xstats);\n+\trte_telemetry_register_cmd(\"/ethdev/link_status\",\n+\t\t\thandle_port_link_status);\n+#endif\n }\n", "prefixes": [ "v2", "08/16" ] }