Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/67987/?format=api
{ "id": 67987, "url": "https://patches.dpdk.org/api/patches/67987/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200408082921.31000-22-mk@semihalf.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200408082921.31000-22-mk@semihalf.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200408082921.31000-22-mk@semihalf.com", "date": "2020-04-08T08:29:12", "name": "[v3,21/30] net/ena: add Tx drops statistic", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "d369611ad4cb32ef5dbec4271303f47e62119798", "submitter": { "id": 786, "url": "https://patches.dpdk.org/api/people/786/?format=api", "name": "Michal Krawczyk", "email": "mk@semihalf.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200408082921.31000-22-mk@semihalf.com/mbox/", "series": [ { "id": 9246, "url": "https://patches.dpdk.org/api/series/9246/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=9246", "date": "2020-04-08T08:28:51", "name": "Update ENA driver to v2.1.0", "version": 3, "mbox": "https://patches.dpdk.org/series/9246/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/67987/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/67987/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7AE7DA0597;\n\tWed, 8 Apr 2020 10:33:05 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 63E9D1C1C2;\n\tWed, 8 Apr 2020 10:29:58 +0200 (CEST)", "from mail-lf1-f65.google.com (mail-lf1-f65.google.com\n [209.85.167.65]) by dpdk.org (Postfix) with ESMTP id 8D1BB1C1A1\n for <dev@dpdk.org>; Wed, 8 Apr 2020 10:29:52 +0200 (CEST)", "by mail-lf1-f65.google.com with SMTP id j17so4478576lfe.7\n for <dev@dpdk.org>; Wed, 08 Apr 2020 01:29:52 -0700 (PDT)", "from mkPC.semihalf.local (193-106-246-138.noc.fibertech.net.pl.\n [193.106.246.138])\n by smtp.gmail.com with ESMTPSA id e8sm765685lja.3.2020.04.08.01.29.50\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 08 Apr 2020 01:29:51 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=semihalf-com.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=J9gqqnaTMXcqQgWdFhVDfYPoqc6jIAmVfH9BEDKs3HM=;\n b=T3cPnTG++7LODM3BlGueugDp5yEXPs0P71Bv7NRwSkPHhqUFMuqhOcatDhOYogulDz\n yA87tOrSVgxu+Z0MPeUEF2DwywZuLGIoK9L0B//BMKNZqluAj/qa53hEqAU5YInyRutb\n ve+kbM51wmJIB/Bzo7KqZzx8c2xbGXSlF+EPdqcGqTyqVdz9uasZdF5VKOPyyMVAuPny\n ZKaUSP+zD7ufIZ/0mY/3r0lrumKwvau4WHC2ebZriHuwAVMbSih6MtmlLDUFbp0JE44Q\n 43jZmIg+d366hjY48ByNRoYPNCPUZSW8WVsYCYPlXPaZwHYd2n5GZ5Gvr2+bBJkSyuNc\n B1Zg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=J9gqqnaTMXcqQgWdFhVDfYPoqc6jIAmVfH9BEDKs3HM=;\n b=BFWokLslKEJMfIXObGdx1MHSBzn0zQQan5VP1mLj+6PBBC2fNIIQ1i4o6mDW58WHmY\n ccYYLk+6Uid4zGwR7Yxoyyae9y7iiNbvOYpCgcyaDlKPoUE7HNOY3hEJC5JkydC7Hy7T\n T+fhVJ8YjipCchLYUgNa1mCfJoDO6bRKQCInHS68kjb210tShBQ26DQlGsxTN4tI1CrT\n +Y/ZuiX0WnRgkNWkmzcPYIAM3267OUiGXQXVW3fQV3zZmZsAYInmcsA4fL76ITDUeYjs\n u1Jd9wCYf5M21RpPOhAJ1lNNHDsPvvsgbiqOle4rpJQu6EnvHK7wMHl67VfW0OnK3HOj\n pnxw==", "X-Gm-Message-State": "AGi0PuYLvg8Q18YRc/lsXR9aWXTtuK9isXRNEB5qhKlCmcxEurhSF2sc\n k7dMKWyjZ1w4g/utTgvjPoO9v/1Uegk=", "X-Google-Smtp-Source": "\n APiQypL2EB6m3niK+Q5qQipEsCVHnpzIp3HOzPQIf0j6+s4tY59tLzBryfC45GXjhim0e22ZrUOIWw==", "X-Received": "by 2002:ac2:43b1:: with SMTP id t17mr3903546lfl.9.1586334591828;\n Wed, 08 Apr 2020 01:29:51 -0700 (PDT)", "From": "Michal Krawczyk <mk@semihalf.com>", "To": "dev@dpdk.org", "Cc": "mw@semihalf.com, mba@semihalf.com, gtzalik@amazon.com, evgenys@amazon.com,\n igorch@amazon.com, ferruh.yigit@intel.com, arybchenko@solarflare.com,\n Michal Krawczyk <mk@semihalf.com>", "Date": "Wed, 8 Apr 2020 10:29:12 +0200", "Message-Id": "<20200408082921.31000-22-mk@semihalf.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200408082921.31000-1-mk@semihalf.com>", "References": "<20200408082921.31000-1-mk@semihalf.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 21/30] net/ena: add Tx drops statistic", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "ENA device can report in the AENQ handler amount of Tx packets that were\ndropped and not sent.\n\nThis statistic is showing global value for the device and because\nrte_eth_stats is missing field that could indicate this value (it\nisn't the Tx error), it is being presented as a extended statistic.\n\nAs the current design of extended statistics prevents tx_drops from\nbeing an atomic variable and both tx_drops and rx_drops are only updated\nfrom the AENQ handler, both were set as non-atomic for the alignment.\n\nSigned-off-by: Michal Krawczyk <mk@semihalf.com>\nReviewed-by: Igor Chauskin <igorch@amazon.com>\nReviewed-by: Guy Tzalik <gtzalik@amazon.com>\n---\nv3:\n * Update release notes\n\n doc/guides/rel_notes/release_20_05.rst | 1 +\n drivers/net/ena/ena_ethdev.c | 11 ++++++++---\n drivers/net/ena/ena_ethdev.h | 8 +++++++-\n 3 files changed, 16 insertions(+), 4 deletions(-)", "diff": "diff --git a/doc/guides/rel_notes/release_20_05.rst b/doc/guides/rel_notes/release_20_05.rst\nindex 7c73fe8fd5..bcd8d86299 100644\n--- a/doc/guides/rel_notes/release_20_05.rst\n+++ b/doc/guides/rel_notes/release_20_05.rst\n@@ -83,6 +83,7 @@ New Features\n Updated ena PMD with new features and improvements, including:\n \n * Added support for large LLQ (Low-latency queue) headers.\n+ * Added Tx drops as new extended driver statistic.\n \n \n Removed Items\ndiff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c\nindex 07feb62c3f..0d4523c1da 100644\n--- a/drivers/net/ena/ena_ethdev.c\n+++ b/drivers/net/ena/ena_ethdev.c\n@@ -96,6 +96,7 @@ static const struct ena_stats ena_stats_global_strings[] = {\n \tENA_STAT_GLOBAL_ENTRY(wd_expired),\n \tENA_STAT_GLOBAL_ENTRY(dev_start),\n \tENA_STAT_GLOBAL_ENTRY(dev_stop),\n+\tENA_STAT_GLOBAL_ENTRY(tx_drops),\n };\n \n static const struct ena_stats ena_stats_tx_strings[] = {\n@@ -938,7 +939,7 @@ static void ena_stats_restart(struct rte_eth_dev *dev)\n \trte_atomic64_init(&adapter->drv_stats->ierrors);\n \trte_atomic64_init(&adapter->drv_stats->oerrors);\n \trte_atomic64_init(&adapter->drv_stats->rx_nombuf);\n-\trte_atomic64_init(&adapter->drv_stats->rx_drops);\n+\tadapter->drv_stats->rx_drops = 0;\n }\n \n static int ena_stats_get(struct rte_eth_dev *dev,\n@@ -972,7 +973,7 @@ static int ena_stats_get(struct rte_eth_dev *dev,\n \t\t\t\t\tena_stats.tx_bytes_low);\n \n \t/* Driver related stats */\n-\tstats->imissed = rte_atomic64_read(&adapter->drv_stats->rx_drops);\n+\tstats->imissed = adapter->drv_stats->rx_drops;\n \tstats->ierrors = rte_atomic64_read(&adapter->drv_stats->ierrors);\n \tstats->oerrors = rte_atomic64_read(&adapter->drv_stats->oerrors);\n \tstats->rx_nombuf = rte_atomic64_read(&adapter->drv_stats->rx_nombuf);\n@@ -2785,12 +2786,16 @@ static void ena_keep_alive(void *adapter_data,\n \tstruct ena_adapter *adapter = adapter_data;\n \tstruct ena_admin_aenq_keep_alive_desc *desc;\n \tuint64_t rx_drops;\n+\tuint64_t tx_drops;\n \n \tadapter->timestamp_wd = rte_get_timer_cycles();\n \n \tdesc = (struct ena_admin_aenq_keep_alive_desc *)aenq_e;\n \trx_drops = ((uint64_t)desc->rx_drops_high << 32) | desc->rx_drops_low;\n-\trte_atomic64_set(&adapter->drv_stats->rx_drops, rx_drops);\n+\ttx_drops = ((uint64_t)desc->tx_drops_high << 32) | desc->tx_drops_low;\n+\n+\tadapter->drv_stats->rx_drops = rx_drops;\n+\tadapter->dev_stats.tx_drops = tx_drops;\n }\n \n /**\ndiff --git a/drivers/net/ena/ena_ethdev.h b/drivers/net/ena/ena_ethdev.h\nindex ed3674b202..5afce25f13 100644\n--- a/drivers/net/ena/ena_ethdev.h\n+++ b/drivers/net/ena/ena_ethdev.h\n@@ -134,13 +134,19 @@ struct ena_driver_stats {\n \trte_atomic64_t ierrors;\n \trte_atomic64_t oerrors;\n \trte_atomic64_t rx_nombuf;\n-\trte_atomic64_t rx_drops;\n+\tu64 rx_drops;\n };\n \n struct ena_stats_dev {\n \tu64 wd_expired;\n \tu64 dev_start;\n \tu64 dev_stop;\n+\t/*\n+\t * Tx drops cannot be reported as the driver statistic, because DPDK\n+\t * rte_eth_stats structure isn't providing appropriate field for that.\n+\t * As a workaround it is being published as an extended statistic.\n+\t */\n+\tu64 tx_drops;\n };\n \n struct ena_offloads {\n", "prefixes": [ "v3", "21/30" ] }