Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/67986/?format=api
https://patches.dpdk.org/api/patches/67986/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200408082921.31000-21-mk@semihalf.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200408082921.31000-21-mk@semihalf.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200408082921.31000-21-mk@semihalf.com", "date": "2020-04-08T08:29:11", "name": "[v3,20/30] net/ena: remove memory barriers before doorbells", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "f997f0bcd223a2fda90a80e2cfc146b68aad6d7f", "submitter": { "id": 786, "url": "https://patches.dpdk.org/api/people/786/?format=api", "name": "Michal Krawczyk", "email": "mk@semihalf.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200408082921.31000-21-mk@semihalf.com/mbox/", "series": [ { "id": 9246, "url": "https://patches.dpdk.org/api/series/9246/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=9246", "date": "2020-04-08T08:28:51", "name": "Update ENA driver to v2.1.0", "version": 3, "mbox": "https://patches.dpdk.org/series/9246/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/67986/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/67986/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 87459A0597;\n\tWed, 8 Apr 2020 10:32:55 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 3717E1C1BD;\n\tWed, 8 Apr 2020 10:29:57 +0200 (CEST)", "from mail-lf1-f68.google.com (mail-lf1-f68.google.com\n [209.85.167.68]) by dpdk.org (Postfix) with ESMTP id 2C0461C199\n for <dev@dpdk.org>; Wed, 8 Apr 2020 10:29:51 +0200 (CEST)", "by mail-lf1-f68.google.com with SMTP id 131so4447956lfh.11\n for <dev@dpdk.org>; Wed, 08 Apr 2020 01:29:51 -0700 (PDT)", "from mkPC.semihalf.local (193-106-246-138.noc.fibertech.net.pl.\n [193.106.246.138])\n by smtp.gmail.com with ESMTPSA id e8sm765685lja.3.2020.04.08.01.29.49\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 08 Apr 2020 01:29:49 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=semihalf-com.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=bbFYKAWbQ2J0jwaIugOXsbVTKGezX54zNcZ2S7ig/tA=;\n b=VZBpSUvSqZc0JLuvHoM0z5+zHEB3VQlrtLa1MYVJBBsiHRkKHIhKCxLs/+XdsH8/lB\n bAJGnUR7eaWegv4/UDLB08m2KCjNOYTVhTxadahTQ1vacXGuOsGZ9dEuI5C4Icbb6+J9\n TGaFlALrgWXdEsgsnM7RVsgs5Wil18pT+l2a1lyYkWAncwoBs0QIoNLvlpdaGZX8uJV8\n WQBONhwePKTp063N6udx5JLYkK2SGD/ikgVyPxnKjsnUCW2OXaf1wareIuXXuPmDj5Km\n zJne9KfTIoKdmkJwx6kBO9z0ldfKUD7z9GOTwZs4G2n8/x78Lese8PyoemdP8Jpmz/bw\n d1NQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=bbFYKAWbQ2J0jwaIugOXsbVTKGezX54zNcZ2S7ig/tA=;\n b=TNxroSMN3cztNwT6p7PqrAS76e0X+o/3sXSxs6szHLzF+Ym4PwMkvUni3FVH+NdHIn\n FFxjy7ta8zthxcRXxztBEemMZFwva5zb2l6BoOE/fEjgSN3wcqKHXZNWB3NLrvbvGrrS\n XGIz+lSsn8h8wwgt+nkOu0PIuvjwzLSvcKeoASmh0+Ppb9wDd7p1nfTcmTCV+8j/nisg\n fj5UKoueXYvaxC++qUbdQu2z4rWmnvlxSvIFoSkVwNhEU8szPseN4sxaLAwcSNufcra+\n 8heBv0BCxoTLfHyalcAMIIkFp0uN4GJieCUDZAzKpdQ64rzl21K42P7SkSARLg6GmCes\n Wxeg==", "X-Gm-Message-State": "AGi0PuZh+vxPSJwxtICjTcbYxgcFb7rqkijDtoBaQVhSo8bpAUZeipAD\n vPHxZSeXmoffLjm/BOyrZdxHUsBHihY=", "X-Google-Smtp-Source": "\n APiQypJd1OlR5q3sW6pgvdRS0SSRrKiVIdn7/mNo2li/QdPd0c4bFT61nVemS1jp1Wf10i99hLnN7g==", "X-Received": "by 2002:a05:6512:3049:: with SMTP id\n b9mr3947664lfb.176.1586334590501;\n Wed, 08 Apr 2020 01:29:50 -0700 (PDT)", "From": "Michal Krawczyk <mk@semihalf.com>", "To": "dev@dpdk.org", "Cc": "mw@semihalf.com, mba@semihalf.com, gtzalik@amazon.com, evgenys@amazon.com,\n igorch@amazon.com, ferruh.yigit@intel.com, arybchenko@solarflare.com,\n Michal Krawczyk <mk@semihalf.com>", "Date": "Wed, 8 Apr 2020 10:29:11 +0200", "Message-Id": "<20200408082921.31000-21-mk@semihalf.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200408082921.31000-1-mk@semihalf.com>", "References": "<20200408082921.31000-1-mk@semihalf.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 20/30] net/ena: remove memory barriers before\n\tdoorbells", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The doorbell code is already issuing the doorbell by using rte_write.\nBecause of that, there is no need to do that before calling the\nfunction.\n\nSigned-off-by: Michal Krawczyk <mk@semihalf.com>\nReviewed-by: Igor Chauskin <igorch@amazon.com>\nReviewed-by: Guy Tzalik <gtzalik@amazon.com>\n---\n drivers/net/ena/ena_ethdev.c | 9 +--------\n 1 file changed, 1 insertion(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c\nindex fdcbe53c1c..07feb62c3f 100644\n--- a/drivers/net/ena/ena_ethdev.c\n+++ b/drivers/net/ena/ena_ethdev.c\n@@ -1462,12 +1462,7 @@ static int ena_populate_rx_queue(struct ena_ring *rxq, unsigned int count)\n \n \t/* When we submitted free recources to device... */\n \tif (likely(i > 0)) {\n-\t\t/* ...let HW know that it can fill buffers with data\n-\t\t *\n-\t\t * Add memory barrier to make sure the desc were written before\n-\t\t * issue a doorbell\n-\t\t */\n-\t\trte_wmb();\n+\t\t/* ...let HW know that it can fill buffers with data. */\n \t\tena_com_write_sq_doorbell(rxq->ena_com_io_sq);\n \n \t\trxq->next_to_use = next_to_use;\n@@ -2405,7 +2400,6 @@ static uint16_t eth_ena_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,\n \t\t\tPMD_DRV_LOG(DEBUG, \"llq tx max burst size of queue %d\"\n \t\t\t\t\" achieved, writing doorbell to send burst\\n\",\n \t\t\t\ttx_ring->id);\n-\t\t\trte_wmb();\n \t\t\tena_com_write_sq_doorbell(tx_ring->ena_com_io_sq);\n \t\t}\n \n@@ -2428,7 +2422,6 @@ static uint16_t eth_ena_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,\n \t/* If there are ready packets to be xmitted... */\n \tif (sent_idx > 0) {\n \t\t/* ...let HW do its best :-) */\n-\t\trte_wmb();\n \t\tena_com_write_sq_doorbell(tx_ring->ena_com_io_sq);\n \t\ttx_ring->tx_stats.doorbells++;\n \t\ttx_ring->next_to_use = next_to_use;\n", "prefixes": [ "v3", "20/30" ] }{ "id": 67986, "url": "