Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/67971/?format=api
{ "id": 67971, "url": "https://patches.dpdk.org/api/patches/67971/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200408082921.31000-6-mk@semihalf.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200408082921.31000-6-mk@semihalf.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200408082921.31000-6-mk@semihalf.com", "date": "2020-04-08T08:28:56", "name": "[v3,05/30] net/ena/base: fix testing for supported hash func", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "d139bc3257ba74a4ed896dadb48f3c78035c074e", "submitter": { "id": 786, "url": "https://patches.dpdk.org/api/people/786/?format=api", "name": "Michal Krawczyk", "email": "mk@semihalf.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200408082921.31000-6-mk@semihalf.com/mbox/", "series": [ { "id": 9246, "url": "https://patches.dpdk.org/api/series/9246/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=9246", "date": "2020-04-08T08:28:51", "name": "Update ENA driver to v2.1.0", "version": 3, "mbox": "https://patches.dpdk.org/series/9246/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/67971/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/67971/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 68989A0597;\n\tWed, 8 Apr 2020 10:30:20 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 89DA71C0C2;\n\tWed, 8 Apr 2020 10:29:35 +0200 (CEST)", "from mail-lj1-f194.google.com (mail-lj1-f194.google.com\n [209.85.208.194]) by dpdk.org (Postfix) with ESMTP id 504BD1C06C\n for <dev@dpdk.org>; Wed, 8 Apr 2020 10:29:31 +0200 (CEST)", "by mail-lj1-f194.google.com with SMTP id r7so6629016ljg.13\n for <dev@dpdk.org>; Wed, 08 Apr 2020 01:29:31 -0700 (PDT)", "from mkPC.semihalf.local (193-106-246-138.noc.fibertech.net.pl.\n [193.106.246.138])\n by smtp.gmail.com with ESMTPSA id e8sm765685lja.3.2020.04.08.01.29.29\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 08 Apr 2020 01:29:29 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=semihalf-com.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=EsVCJSfEV1PCZ7mbAUW9XauUx/hx3YPHr0APShNs7Jw=;\n b=qYZEkjHYM2YQzlrevS79Fjh2kpmAcgD/en6whcRccpMVIiTPYrn1PSXUgwynBtbbF8\n eiKTpfa9l0mlBR9juTUBupWQjqNNqCxMXOqykLPBtfoAnFDo1p3oO1P3lMur2HApd6VZ\n ErGGID+ahqqWEwRmK2WRB7BoULFcVONyMJ+KpOhNefbLypJUa84Gxc7nDZwz7mrZWgX6\n pWaIDJKcHsunmQdAbknYRai6Ln+9+5DVx4TWdfysiK9JWzeS5i25ZSHYIA/xG+Di7jdU\n vNvHYhUfBTX+FrRAwg23NjQgW9sBART0rLgsgpqqmL8ZHMj7ezIMTTRI+tASkS5jLA3S\n OvmQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=EsVCJSfEV1PCZ7mbAUW9XauUx/hx3YPHr0APShNs7Jw=;\n b=aEmwBl9IF3w0QHrfkmPntetz3XENmGL9ZEuWCNrz0AbkndEmyexyIArFDytl/l0fUg\n Jaav38fAnweISTP/kRfgLoGSnBXbdVPVd0GfzGle1+wcF/j1ARnivxPg0N/Ef2Vk2vo2\n KaTp4LmEwnTbHQjZzqLHhEatve2e44nW+26oBoCblHblW6zOHlWB7D2CDEWCMCJilo+M\n HLVHV/QRN0A+0afUTxJh6AzcZ/1TFdB0xBGybPpoQxdvlCiXGPaTpzN2xLqgQPlyAjTn\n ctkkP9wbKAMsfqM04s1K+OVX99yZwYMbDqLZ3VDJYqbKnH4v4+PHsdMlAmcrkyln8Trc\n RFWQ==", "X-Gm-Message-State": "AGi0PubT4Eui7gvN/gJcqAuW+h0Tnqm+7C//ZJ6c3mscYOW2tiC1T/H0\n BVWYckkGiU1/MlXWaLiiwru9G1Mx94c=", "X-Google-Smtp-Source": "\n APiQypL645As2L+1kNObE6i3opjtHb/WiHa8rjnKcVUCMlOIJ6ayiSn4IS/10IvJIvwatBUD/pyEbA==", "X-Received": "by 2002:a2e:a40b:: with SMTP id p11mr4216963ljn.173.1586334570697;\n Wed, 08 Apr 2020 01:29:30 -0700 (PDT)", "From": "Michal Krawczyk <mk@semihalf.com>", "To": "dev@dpdk.org", "Cc": "mw@semihalf.com, mba@semihalf.com, gtzalik@amazon.com, evgenys@amazon.com,\n igorch@amazon.com, ferruh.yigit@intel.com, arybchenko@solarflare.com,\n Michal Krawczyk <mk@semihalf.com>", "Date": "Wed, 8 Apr 2020 10:28:56 +0200", "Message-Id": "<20200408082921.31000-6-mk@semihalf.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200408082921.31000-1-mk@semihalf.com>", "References": "<20200408082921.31000-1-mk@semihalf.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 05/30] net/ena/base: fix testing for supported\n\thash func", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "There was a bug in ena_com_fill_hash_function(), which was causing bit to\nbe shifted left one bit too much.\n\nTo fix that, the ENA_FFS macro is being ussed (returning the location of\nthe first bit set), hash_function value is being subtracted by 1 if any\nhash function is supported by the device and BIT macro is used for\nshifting for better verbosity.\n\nSigned-off-by: Michal Krawczyk <mk@semihalf.com>\n---\nv3:\n * This patch was added - previously part of the v2-04\n\n drivers/net/ena/base/ena_com.c | 19 +++++++++++++------\n drivers/net/ena/base/ena_plat_dpdk.h | 2 ++\n 2 files changed, 15 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/ena/base/ena_com.c b/drivers/net/ena/base/ena_com.c\nindex 38a474b1bd..04f5d21d6f 100644\n--- a/drivers/net/ena/base/ena_com.c\n+++ b/drivers/net/ena/base/ena_com.c\n@@ -2394,12 +2394,14 @@ int ena_com_fill_hash_function(struct ena_com_dev *ena_dev,\n \t\t\t enum ena_admin_hash_functions func,\n \t\t\t const u8 *key, u16 key_len, u32 init_val)\n {\n-\tstruct ena_rss *rss = &ena_dev->rss;\n+\tstruct ena_admin_feature_rss_flow_hash_control *hash_key;\n \tstruct ena_admin_get_feat_resp get_resp;\n-\tstruct ena_admin_feature_rss_flow_hash_control *hash_key =\n-\t\trss->hash_key;\n+\tenum ena_admin_hash_functions old_func;\n+\tstruct ena_rss *rss = &ena_dev->rss;\n \tint rc;\n \n+\thash_key = rss->hash_key;\n+\n \t/* Make sure size is a mult of DWs */\n \tif (unlikely(key_len & 0x3))\n \t\treturn ENA_COM_INVAL;\n@@ -2411,7 +2413,7 @@ int ena_com_fill_hash_function(struct ena_com_dev *ena_dev,\n \tif (unlikely(rc))\n \t\treturn rc;\n \n-\tif (!((1 << func) & get_resp.u.flow_hash_func.supported_func)) {\n+\tif (!(BIT(func) & get_resp.u.flow_hash_func.supported_func)) {\n \t\tena_trc_err(\"Flow hash function %d isn't supported\\n\", func);\n \t\treturn ENA_COM_UNSUPPORTED;\n \t}\n@@ -2437,12 +2439,13 @@ int ena_com_fill_hash_function(struct ena_com_dev *ena_dev,\n \t\treturn ENA_COM_INVAL;\n \t}\n \n+\told_func = rss->hash_func;\n \trss->hash_func = func;\n \trc = ena_com_set_hash_function(ena_dev);\n \n \t/* Restore the old function */\n \tif (unlikely(rc))\n-\t\tena_com_get_hash_function(ena_dev, NULL, NULL);\n+\t\trss->hash_func = old_func;\n \n \treturn rc;\n }\n@@ -2464,7 +2467,11 @@ int ena_com_get_hash_function(struct ena_com_dev *ena_dev,\n \tif (unlikely(rc))\n \t\treturn rc;\n \n-\trss->hash_func = get_resp.u.flow_hash_func.selected_func;\n+\t/* ENA_FFS returns 1 in case the lsb is set */\n+\trss->hash_func = ENA_FFS(get_resp.u.flow_hash_func.selected_func);\n+\tif (rss->hash_func)\n+\t\trss->hash_func--;\n+\n \tif (func)\n \t\t*func = rss->hash_func;\n \ndiff --git a/drivers/net/ena/base/ena_plat_dpdk.h b/drivers/net/ena/base/ena_plat_dpdk.h\nindex e9b33bc36c..e9b3c02270 100644\n--- a/drivers/net/ena/base/ena_plat_dpdk.h\n+++ b/drivers/net/ena/base/ena_plat_dpdk.h\n@@ -301,6 +301,8 @@ extern rte_atomic32_t ena_alloc_cnt;\n \n #define DIV_ROUND_UP(n, d) (((n) + (d) - 1) / (d))\n \n+#define ENA_FFS(x) ffs(x)\n+\n void ena_rss_key_fill(void *key, size_t size);\n \n #define ENA_RSS_FILL_KEY(key, size) ena_rss_key_fill(key, size)\n", "prefixes": [ "v3", "05/30" ] }