Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/67968/?format=api
{ "id": 67968, "url": "https://patches.dpdk.org/api/patches/67968/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200408082921.31000-3-mk@semihalf.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200408082921.31000-3-mk@semihalf.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200408082921.31000-3-mk@semihalf.com", "date": "2020-04-08T08:28:53", "name": "[v3,02/30] net/ena/base: make allocation macros thread-safe", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "5c2b1c93d203a87969eaa26ddf6544c6ca20d122", "submitter": { "id": 786, "url": "https://patches.dpdk.org/api/people/786/?format=api", "name": "Michal Krawczyk", "email": "mk@semihalf.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200408082921.31000-3-mk@semihalf.com/mbox/", "series": [ { "id": 9246, "url": "https://patches.dpdk.org/api/series/9246/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=9246", "date": "2020-04-08T08:28:51", "name": "Update ENA driver to v2.1.0", "version": 3, "mbox": "https://patches.dpdk.org/series/9246/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/67968/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/67968/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 82D9CA0597;\n\tWed, 8 Apr 2020 10:29:47 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C9B0C1C069;\n\tWed, 8 Apr 2020 10:29:30 +0200 (CEST)", "from mail-lj1-f178.google.com (mail-lj1-f178.google.com\n [209.85.208.178]) by dpdk.org (Postfix) with ESMTP id 7827F1BFDC\n for <dev@dpdk.org>; Wed, 8 Apr 2020 10:29:27 +0200 (CEST)", "by mail-lj1-f178.google.com with SMTP id r7so6628823ljg.13\n for <dev@dpdk.org>; Wed, 08 Apr 2020 01:29:27 -0700 (PDT)", "from mkPC.semihalf.local (193-106-246-138.noc.fibertech.net.pl.\n [193.106.246.138])\n by smtp.gmail.com with ESMTPSA id e8sm765685lja.3.2020.04.08.01.29.25\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 08 Apr 2020 01:29:26 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=semihalf-com.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=wjkQcxrwEVijfs6i/IOTcKsbyTOYyF8v0zZLLJqLqiI=;\n b=RmTocunwr33CaQJ3VIhheRRRUbmuzHBX6dVDGZ+IhsBoZ3YH4H192flUXfH6LjeJJ8\n wbMBYVijsXyu1NjLsv+HeFCk1ghnUta6V9yIlDURPpOFTtgpYxbhH+DFvIi3DH/suwu6\n 0oTKgNFgR4PzBzWJ/IowBL10chaDdfDlpXqxzEux+FBh3TDTKnMk+yaddy/UBs6akSEc\n 74+jBghbm8OsCnCU16t3l4qSNm96vUKs76LUR/py/Rlzrrw8R0XiE5Zp3ILV4qBnvEsK\n 8yGvPzMOoNx3X7FwEcnHCQ2rMbFzsl830XDRaAI7avCFZMyaIqXGMHMF0CzUx4f67xXe\n HxjQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=wjkQcxrwEVijfs6i/IOTcKsbyTOYyF8v0zZLLJqLqiI=;\n b=D8WNPxDI1Bl0wTjQcioyd03mUGkbLphE0LKp7Wwbvi+ddokt8athZVU31QEd4oc/+q\n qs9N8Tkb/l02rbGUs9RTZrPkNCGrbxFkZ2CTq+dwnhwuVO6dKRisXLZDQxtJFICbyvwU\n +2Z8qIqzOiBXurOy/samAMYpTLf1Tkyza/FUTDeWwkEIkhYK30u3aztrbYrwp1LrfOmd\n MfwnqgWKfsBFqy2QCS0bTeF18JxhLIhXYn/RakU/aluUqMqdiY9r3yfRZxlkyo73PFd7\n 5aS4d4loHWXtFuG+cuAcbpR/6enALQqCY8JDhjDq7pLI3YPYzTndAafhnryqq1lGannu\n Y3KA==", "X-Gm-Message-State": "AGi0PuYUYNATAWd6oBGHcyIB11BFIRd8/La9Gts4mfb4uQJIyJpd2onn\n eYYc6fOqoptA797vN5WuW6aBIK1RtiA=", "X-Google-Smtp-Source": "\n APiQypJZ8OOt9AqEYSEzBSUzBB/Qv3tJ5A+FqrMELGZN4vyuc/nkA0c04MN4X9IAVAvqeEfMHJupTQ==", "X-Received": "by 2002:a2e:3c0b:: with SMTP id j11mr4356316lja.9.1586334566832;\n Wed, 08 Apr 2020 01:29:26 -0700 (PDT)", "From": "Michal Krawczyk <mk@semihalf.com>", "To": "dev@dpdk.org", "Cc": "mw@semihalf.com, mba@semihalf.com, gtzalik@amazon.com, evgenys@amazon.com,\n igorch@amazon.com, ferruh.yigit@intel.com, arybchenko@solarflare.com,\n stable@dpdk.org, Michal Krawczyk <mk@semihalf.com>", "Date": "Wed, 8 Apr 2020 10:28:53 +0200", "Message-Id": "<20200408082921.31000-3-mk@semihalf.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200408082921.31000-1-mk@semihalf.com>", "References": "<20200408082921.31000-1-mk@semihalf.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 02/30] net/ena/base: make allocation macros\n\tthread-safe", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Igor Chauskin <igorch@amazon.com>\n\nMemory allocation region id could possibly be non-unique\ndue to non-atomic increment, causing allocation failure.\n\nFixes: 9ba7981ec992 (\"ena: add communication layer for DPDK\")\nCc: stable@dpdk.org\n\nSigned-off-by: Igor Chauskin <igorch@amazon.com>\nReviewed-by: Michal Krawczyk <mk@semihalf.com>\nReviewed-by: Guy Tzalik <gtzalik@amazon.com>\n---\nv3:\n * Update the copyright date in modified files\n\n drivers/net/ena/base/ena_plat_dpdk.h | 10 ++++++----\n drivers/net/ena/ena_ethdev.c | 2 +-\n 2 files changed, 7 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/ena/base/ena_plat_dpdk.h b/drivers/net/ena/base/ena_plat_dpdk.h\nindex b611fb204b..70261bdbc6 100644\n--- a/drivers/net/ena/base/ena_plat_dpdk.h\n+++ b/drivers/net/ena/base/ena_plat_dpdk.h\n@@ -1,5 +1,5 @@\n /* SPDX-License-Identifier: BSD-3-Clause\n- * Copyright (c) 2015-2019 Amazon.com, Inc. or its affiliates.\n+ * Copyright (c) 2015-2020 Amazon.com, Inc. or its affiliates.\n * All rights reserved.\n */\n \n@@ -180,7 +180,7 @@ do { \\\n * Each rte_memzone should have unique name.\n * To satisfy it, count number of allocations and add it to name.\n */\n-extern uint32_t ena_alloc_cnt;\n+extern rte_atomic32_t ena_alloc_cnt;\n \n #define ENA_MEM_ALLOC_COHERENT(dmadev, size, virt, phys, handle)\t\\\n \tdo {\t\t\t\t\t\t\t\t\\\n@@ -188,7 +188,8 @@ extern uint32_t ena_alloc_cnt;\n \t\tchar z_name[RTE_MEMZONE_NAMESIZE];\t\t\t\\\n \t\tENA_TOUCH(dmadev); ENA_TOUCH(handle);\t\t\t\\\n \t\tsnprintf(z_name, sizeof(z_name),\t\t\t\\\n-\t\t\t\t\"ena_alloc_%d\", ena_alloc_cnt++);\t\\\n+\t\t\t \"ena_alloc_%d\",\t\t\t\t\\\n+\t\t\t rte_atomic32_add_return(&ena_alloc_cnt, 1));\t\\\n \t\tmz = rte_memzone_reserve(z_name, size, SOCKET_ID_ANY,\t\\\n \t\t\t\tRTE_MEMZONE_IOVA_CONTIG);\t\t\\\n \t\thandle = mz;\t\t\t\t\t\t\\\n@@ -213,7 +214,8 @@ extern uint32_t ena_alloc_cnt;\n \t\tchar z_name[RTE_MEMZONE_NAMESIZE];\t\t\t\\\n \t\tENA_TOUCH(dmadev); ENA_TOUCH(dev_node);\t\t\t\\\n \t\tsnprintf(z_name, sizeof(z_name),\t\t\t\\\n-\t\t\t\t\"ena_alloc_%d\", ena_alloc_cnt++);\t\\\n+\t\t\t \"ena_alloc_%d\",\t\t\t\t\\\n+\t\t\t rte_atomic32_add_return(&ena_alloc_cnt, 1));\t\\\n \t\tmz = rte_memzone_reserve(z_name, size, node,\t\t\\\n \t\t\t\tRTE_MEMZONE_IOVA_CONTIG);\t\t\\\n \t\tmem_handle = mz;\t\t\t\t\t\\\ndiff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c\nindex 64aabbbb19..e0ed28419c 100644\n--- a/drivers/net/ena/ena_ethdev.c\n+++ b/drivers/net/ena/ena_ethdev.c\n@@ -89,7 +89,7 @@ struct ena_stats {\n * Each rte_memzone should have unique name.\n * To satisfy it, count number of allocation and add it to name.\n */\n-uint32_t ena_alloc_cnt;\n+rte_atomic32_t ena_alloc_cnt;\n \n static const struct ena_stats ena_stats_global_strings[] = {\n \tENA_STAT_GLOBAL_ENTRY(wd_expired),\n", "prefixes": [ "v3", "02/30" ] }