Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/67948/?format=api
{ "id": 67948, "url": "https://patches.dpdk.org/api/patches/67948/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200408031351.4288-13-l.wojciechow@partner.samsung.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200408031351.4288-13-l.wojciechow@partner.samsung.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200408031351.4288-13-l.wojciechow@partner.samsung.com", "date": "2020-04-08T03:13:50", "name": "[v2,12/13] app/test: add rte security capabilities get tests", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "52ec6594ddae9fc82d8eeaa12d668e1e2e8e74d9", "submitter": { "id": 1628, "url": "https://patches.dpdk.org/api/people/1628/?format=api", "name": "Lukasz Wojciechowski", "email": "l.wojciechow@partner.samsung.com" }, "delegate": { "id": 6690, "url": "https://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200408031351.4288-13-l.wojciechow@partner.samsung.com/mbox/", "series": [ { "id": 9242, "url": "https://patches.dpdk.org/api/series/9242/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=9242", "date": "2020-04-08T03:13:38", "name": "Fixes and unit tests for librte_security", "version": 2, "mbox": "https://patches.dpdk.org/series/9242/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/67948/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/67948/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1328CA0597;\n\tWed, 8 Apr 2020 05:16:44 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D03C41C0C7;\n\tWed, 8 Apr 2020 05:15:07 +0200 (CEST)", "from mailout2.w1.samsung.com (mailout2.w1.samsung.com\n [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id D82931BF60\n for <dev@dpdk.org>; Wed, 8 Apr 2020 05:14:54 +0200 (CEST)", "from eucas1p2.samsung.com (unknown [182.198.249.207])\n by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id\n 20200408031454euoutp025070be77993878880a506a0c882b59d9~Dubg8k5SN1520915209euoutp02y\n for <dev@dpdk.org>; Wed, 8 Apr 2020 03:14:54 +0000 (GMT)", "from eusmges1new.samsung.com (unknown [203.254.199.242]) by\n eucas1p1.samsung.com (KnoxPortal) with ESMTP id\n 20200408031454eucas1p1fdc0c643498b2849a453fa70f4ade098~DubgoYZfW2414224142eucas1p1d\n for <dev@dpdk.org>; Wed, 8 Apr 2020 03:14:54 +0000 (GMT)", "from eucas1p2.samsung.com ( [182.198.249.207]) by\n eusmges1new.samsung.com (EUCPMTA) with SMTP id 3F.1B.61286.EA14D8E5; Wed, 8\n Apr 2020 04:14:54 +0100 (BST)", "from eusmtrp1.samsung.com (unknown [182.198.249.138]) by\n eucas1p1.samsung.com (KnoxPortal) with ESMTPA id\n 20200408031454eucas1p112c6eded420bdcfdb09fad83bf485afb~DubgU9FeL0246502465eucas1p1Q\n for <dev@dpdk.org>; Wed, 8 Apr 2020 03:14:54 +0000 (GMT)", "from eusmgms2.samsung.com (unknown [182.198.249.180]) by\n eusmtrp1.samsung.com (KnoxPortal) with ESMTP id\n 20200408031454eusmtrp14ee134718918a8bb28b19f25b9cc1bb4~DubgUcYdy1153511535eusmtrp1x\n for <dev@dpdk.org>; Wed, 8 Apr 2020 03:14:54 +0000 (GMT)", "from eusmtip1.samsung.com ( [203.254.199.221]) by\n eusmgms2.samsung.com (EUCPMTA) with SMTP id 20.79.07950.DA14D8E5; Wed, 8\n Apr 2020 04:14:53 +0100 (BST)", "from localhost.localdomain (unknown [106.210.88.70]) by\n eusmtip1.samsung.com (KnoxPortal) with ESMTPA id\n 20200408031453eusmtip13f923838f200c8f93abd7178774e9211~DubgCJ_pK2966429664eusmtip1e\n for <dev@dpdk.org>; Wed, 8 Apr 2020 03:14:53 +0000 (GMT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com\n 20200408031454euoutp025070be77993878880a506a0c882b59d9~Dubg8k5SN1520915209euoutp02y", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com;\n s=mail20170921; t=1586315694;\n bh=xVHLCwwZpPMlphGkAsIF+b88Vi+kHzKTZBCeQBv7bUI=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=aS74Zm/YQuJopYelMzyuLvliVId4Ynv8KPWt2P0xm2zY9eZisvfhI7xP1x8D7ky6G\n GiF3C49ox4X+HpOrQDjxWYR961psDFNt0dT1apOMoSzCQ6nsLTx0W5YniHpzNBbGXI\n C8auUY179C1bXF18NlcyrXa7iR6EGz5hqb4d4oLs=", "X-AuditID": "cbfec7f2-ef1ff7000001ef66-6f-5e8d41aeb047", "From": "Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>", "To": "", "Cc": "dev@dpdk.org", "Date": "Wed, 8 Apr 2020 05:13:50 +0200", "Message-Id": "<20200408031351.4288-13-l.wojciechow@partner.samsung.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200408031351.4288-1-l.wojciechow@partner.samsung.com>", "X-Brightmail-Tracker": [ "\n H4sIAAAAAAAAA+NgFjrFIsWRmVeSWpSXmKPExsWy7djP87rrHHvjDPp/CVu8+7SdyYHR49eC\n pawBjFFcNimpOZllqUX6dglcGY/6WpgKlmtX3P/7h7WB8ZtKFyMnh4SAicTuNbeYuxi5OIQE\n VjBKPH36ghXCaWeSaDgwkQXCaWOSmPq4kQ2mZfmLp0wQieWMEgsmvGIBSYBVTV7oCmKzCdhK\n HJn5lRXEFhFgkVj5/TtYDbOAgMTje8/A4sIC3hJfv7Wyg9gsAqoSF1asAVvAK+AqsWPSBCaI\n ZfISqzccALqPg4MTKL77LBfIXgmBNWwS2xY/YIWocZGY3fALql5Y4tXxLewQtozE6ck9LBAN\n 2xglrv7+yQjh7GeUuN67AqrKWuLwv99sIBuYBTQl1u/Shwg7Skx9+Y8VJCwhwCdx460gxP18\n EpO2TWeGCPNKdLQJQVTrSTztmcoIs/bP2icsELaHxIntu6CBeJlR4v+BFcwTGOVnISxbwMi4\n ilE8tbQ4Nz212DAvtVyvODG3uDQvXS85P3cTIzCGT/87/mkH49dLSYcYBTgYlXh4HyT2xAmx\n JpYVV+YeYpTgYFYS4ZXq7YwT4k1JrKxKLcqPLyrNSS0+xCjNwaIkzmu86GWskEB6Yklqdmpq\n QWoRTJaJg1OqgbHaL1337xFmn0lmIWv0O+I/SyzQiYtccJnBsq+DoWiFi9mtJUwzc2NtRYSD\n jKx2Kr9Uk7gotz3+W/2mz1ZaRjvEYu+IHD+3OiUw+dCcVyfEcx/bFF/t2119bqPp3E5tyV7/\n 279OPtBK0KyLlxb+xPqyM3Lr/4Ynqo+MqlxVz2m8qtcXOld6R4mlOCPRUIu5qDgRABL7417d\n AgAA", "\n H4sIAAAAAAAAA+NgFlrFLMWRmVeSWpSXmKPExsVy+t/xu7prHXvjDKa12Fq8+7SdyYHR49eC\n pawBjFF6NkX5pSWpChn5xSW2StGGFkZ6hpYWekYmlnqGxuaxVkamSvp2NimpOZllqUX6dgl6\n GY/6WpgKlmtX3P/7h7WB8ZtKFyMnh4SAicTyF0+Zuhi5OIQEljJKbPhwg62LkQMoISPx4ZIA\n RI2wxJ9rXWwQNS1MEkePNbGDJNgEbCWOzPzKCmKLCLBIrPz+nQXEZhYQkHh87xlYXFjAW+Lr\n t1awehYBVYkLK9awgdi8Aq4SOyZNYIJYIC+xesMBZpC9nEDx3We5QMJCAvUSh+9eZpvAyLeA\n kWEVo0hqaXFuem6xkV5xYm5xaV66XnJ+7iZGYDhtO/Zzyw7GrnfBhxgFOBiVeHgfJPbECbEm\n lhVX5h5ilOBgVhLhlertjBPiTUmsrEotyo8vKs1JLT7EaAp000RmKdHkfGCo55XEG5oamltY\n GpobmxubWSiJ83YIHIwREkhPLEnNTk0tSC2C6WPi4JRqYGzo75oa++VheNc74eWWTyfHXglz\n ym1fsXmZ1W7emzl/7iyLSVpym0/2hLrscbGDG1dsNDl/hOHw157L4jUFH1b78++9cpa7tM91\n 3pta7QObbj9K4+wPcylbWrrp05qp5TlLq/z1WuXXT6k4HqxUcbFG5nXo/TtMSx893p+gbpfx\n QL8xpzHmd5QSS3FGoqEWc1FxIgB2uFnaPQIAAA==" ], "X-CMS-MailID": "20200408031454eucas1p112c6eded420bdcfdb09fad83bf485afb", "X-Msg-Generator": "CA", "Content-Type": "text/plain; charset=\"utf-8\"", "X-RootMTR": "20200408031454eucas1p112c6eded420bdcfdb09fad83bf485afb", "X-EPHeader": "CA", "CMS-TYPE": "201P", "X-CMS-RootMailID": "20200408031454eucas1p112c6eded420bdcfdb09fad83bf485afb", "References": "<20200312151654.7218-1-l.wojciechow@partner.samsung.com>\n <20200408031351.4288-1-l.wojciechow@partner.samsung.com>\n <CGME20200408031454eucas1p112c6eded420bdcfdb09fad83bf485afb@eucas1p1.samsung.com>", "Subject": "[dpdk-dev] [PATCH v2 12/13] app/test: add rte security capabilities\n\tget tests", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add unit tests for rte_security_capabilities_get function.\n\nSigned-off-by: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>\n---\n app/test/test_security.c | 138 +++++++++++++++++++++++++++++++++++++++\n 1 file changed, 138 insertions(+)", "diff": "diff --git a/app/test/test_security.c b/app/test/test_security.c\nindex 230b53891..9da81fa1d 100644\n--- a/app/test/test_security.c\n+++ b/app/test/test_security.c\n@@ -440,6 +440,30 @@ mock_get_userdata(void *device,\n \treturn mock_get_userdata_exp.ret;\n }\n \n+/**\n+ * capabilities_get mockup\n+ *\n+ * Verified parameters: device.\n+ */\n+static struct mock_capabilities_get_data {\n+\tvoid *device;\n+\n+\tstruct rte_security_capability *ret;\n+\n+\tint called;\n+\tint failed;\n+} mock_capabilities_get_exp = {NULL, NULL, 0, 0};\n+\n+static const struct rte_security_capability *\n+mock_capabilities_get(void *device)\n+{\n+\tmock_capabilities_get_exp.called++;\n+\n+\tMOCK_TEST_ASSERT_POINTER_PARAMETER(mock_capabilities_get_exp, device);\n+\n+\treturn mock_capabilities_get_exp.ret;\n+}\n+\n /**\n * empty_ops\n *\n@@ -460,6 +484,7 @@ struct rte_security_ops mock_ops = {\n \t.session_destroy = mock_session_destroy,\n \t.set_pkt_metadata = mock_set_pkt_metadata,\n \t.get_userdata = mock_get_userdata,\n+\t.capabilities_get = mock_capabilities_get,\n };\n \n \n@@ -556,6 +581,7 @@ ut_setup(void)\n \tmock_session_destroy_exp.called = 0;\n \tmock_set_pkt_metadata_exp.called = 0;\n \tmock_get_userdata_exp.called = 0;\n+\tmock_capabilities_get_exp.called = 0;\n \n \tmock_session_create_exp.failed = 0;\n \tmock_session_update_exp.failed = 0;\n@@ -564,6 +590,7 @@ ut_setup(void)\n \tmock_session_destroy_exp.failed = 0;\n \tmock_set_pkt_metadata_exp.failed = 0;\n \tmock_get_userdata_exp.failed = 0;\n+\tmock_capabilities_get_exp.failed = 0;\n \n \treturn TEST_SUCCESS;\n }\n@@ -1658,6 +1685,106 @@ test_get_userdata_success(void)\n }\n \n \n+/**\n+ * rte_security_capabilities_get tests\n+ */\n+\n+/**\n+ * Test execution of rte_security_capabilities_get with NULL instance\n+ */\n+static int\n+test_capabilities_get_inv_context(void)\n+{\n+\tconst struct rte_security_capability *ret;\n+\tret = rte_security_capabilities_get(NULL);\n+\tTEST_ASSERT_MOCK_FUNCTION_CALL_RET(rte_security_capabilities_get,\n+\t\t\tret, NULL, \"%p\");\n+\tTEST_ASSERT_MOCK_CALLS(mock_capabilities_get_exp, 0);\n+\n+\treturn TEST_SUCCESS;\n+}\n+\n+/**\n+ * Test execution of rte_security_capabilities_get with invalid\n+ * security operations structure (NULL)\n+ */\n+static int\n+test_capabilities_get_inv_context_ops(void)\n+{\n+\tstruct security_unittest_params *ut_params = &unittest_params;\n+\tut_params->ctx.ops = NULL;\n+\n+\tconst struct rte_security_capability *ret;\n+\tret = rte_security_capabilities_get(&ut_params->ctx);\n+\tTEST_ASSERT_MOCK_FUNCTION_CALL_RET(rte_security_capabilities_get,\n+\t\t\tret, NULL, \"%p\");\n+\tTEST_ASSERT_MOCK_CALLS(mock_capabilities_get_exp, 0);\n+\n+\treturn TEST_SUCCESS;\n+}\n+\n+/**\n+ * Test execution of rte_security_capabilities_get with empty\n+ * security operations\n+ */\n+static int\n+test_capabilities_get_inv_context_ops_fun(void)\n+{\n+\tstruct security_unittest_params *ut_params = &unittest_params;\n+\tut_params->ctx.ops = &empty_ops;\n+\n+\tconst struct rte_security_capability *ret;\n+\tret = rte_security_capabilities_get(&ut_params->ctx);\n+\tTEST_ASSERT_MOCK_FUNCTION_CALL_RET(rte_security_capabilities_get,\n+\t\t\tret, NULL, \"%p\");\n+\tTEST_ASSERT_MOCK_CALLS(mock_capabilities_get_exp, 0);\n+\n+\treturn TEST_SUCCESS;\n+}\n+\n+/**\n+ * Test execution of rte_security_capabilities_get when capabilities_get\n+ * security operation fails\n+ */\n+static int\n+test_capabilities_get_ops_failure(void)\n+{\n+\tstruct security_unittest_params *ut_params = &unittest_params;\n+\n+\tmock_capabilities_get_exp.device = NULL;\n+\tmock_capabilities_get_exp.ret = NULL;\n+\n+\tconst struct rte_security_capability *ret;\n+\tret = rte_security_capabilities_get(&ut_params->ctx);\n+\tTEST_ASSERT_MOCK_FUNCTION_CALL_RET(rte_security_capabilities_get,\n+\t\t\tret, NULL, \"%p\");\n+\tTEST_ASSERT_MOCK_CALLS(mock_capabilities_get_exp, 1);\n+\n+\treturn TEST_SUCCESS;\n+}\n+\n+/**\n+ * Test execution of rte_security_capabilities_get in successful execution path\n+ */\n+static int\n+test_capabilities_get_success(void)\n+{\n+\tstruct security_unittest_params *ut_params = &unittest_params;\n+\tstruct rte_security_capability capabilities;\n+\n+\tmock_capabilities_get_exp.device = NULL;\n+\tmock_capabilities_get_exp.ret = &capabilities;\n+\n+\tconst struct rte_security_capability *ret;\n+\tret = rte_security_capabilities_get(&ut_params->ctx);\n+\tTEST_ASSERT_MOCK_FUNCTION_CALL_RET(rte_security_capabilities_get,\n+\t\t\tret, &capabilities, \"%p\");\n+\tTEST_ASSERT_MOCK_CALLS(mock_capabilities_get_exp, 1);\n+\n+\treturn TEST_SUCCESS;\n+}\n+\n+\n /**\n * Declaration of testcases\n */\n@@ -1759,6 +1886,17 @@ static struct unit_test_suite security_testsuite = {\n \t\tTEST_CASE_ST(ut_setup_with_session, ut_teardown,\n \t\t\t\ttest_get_userdata_success),\n \n+\t\tTEST_CASE_ST(ut_setup_with_session, ut_teardown,\n+\t\t\t\ttest_capabilities_get_inv_context),\n+\t\tTEST_CASE_ST(ut_setup_with_session, ut_teardown,\n+\t\t\t\ttest_capabilities_get_inv_context_ops),\n+\t\tTEST_CASE_ST(ut_setup_with_session, ut_teardown,\n+\t\t\t\ttest_capabilities_get_inv_context_ops_fun),\n+\t\tTEST_CASE_ST(ut_setup_with_session, ut_teardown,\n+\t\t\t\ttest_capabilities_get_ops_failure),\n+\t\tTEST_CASE_ST(ut_setup_with_session, ut_teardown,\n+\t\t\t\ttest_capabilities_get_success),\n+\n \t\tTEST_CASES_END() /**< NULL terminate unit test array */\n \t}\n };\n", "prefixes": [ "v2", "12/13" ] }