Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/67945/?format=api
{ "id": 67945, "url": "https://patches.dpdk.org/api/patches/67945/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200408031351.4288-10-l.wojciechow@partner.samsung.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200408031351.4288-10-l.wojciechow@partner.samsung.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200408031351.4288-10-l.wojciechow@partner.samsung.com", "date": "2020-04-08T03:13:47", "name": "[v2,09/13] app/test: add rte security session destroy tests", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "093a791e2d701927ab1772f242476d89f1fa2252", "submitter": { "id": 1628, "url": "https://patches.dpdk.org/api/people/1628/?format=api", "name": "Lukasz Wojciechowski", "email": "l.wojciechow@partner.samsung.com" }, "delegate": { "id": 6690, "url": "https://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200408031351.4288-10-l.wojciechow@partner.samsung.com/mbox/", "series": [ { "id": 9242, "url": "https://patches.dpdk.org/api/series/9242/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=9242", "date": "2020-04-08T03:13:38", "name": "Fixes and unit tests for librte_security", "version": 2, "mbox": "https://patches.dpdk.org/series/9242/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/67945/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/67945/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2BF08A0597;\n\tWed, 8 Apr 2020 05:16:18 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0AD731C0B3;\n\tWed, 8 Apr 2020 05:15:03 +0200 (CEST)", "from mailout2.w1.samsung.com (mailout2.w1.samsung.com\n [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id D5C0A1BFC6\n for <dev@dpdk.org>; Wed, 8 Apr 2020 05:14:53 +0200 (CEST)", "from eucas1p1.samsung.com (unknown [182.198.249.206])\n by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id\n 20200408031453euoutp021ec3dce8ba2205b011ee24533a5cd1bf~DubgAaqNA1520415204euoutp02y\n for <dev@dpdk.org>; Wed, 8 Apr 2020 03:14:53 +0000 (GMT)", "from eusmges1new.samsung.com (unknown [203.254.199.242]) by\n eucas1p2.samsung.com (KnoxPortal) with ESMTP id\n 20200408031453eucas1p2d94754d90b8310b89f089840b78481fb~Dubfg4Eo-3011330113eucas1p2i\n for <dev@dpdk.org>; Wed, 8 Apr 2020 03:14:53 +0000 (GMT)", "from eucas1p2.samsung.com ( [182.198.249.207]) by\n eusmges1new.samsung.com (EUCPMTA) with SMTP id 1F.1B.61286.DA14D8E5; Wed, 8\n Apr 2020 04:14:53 +0100 (BST)", "from eusmtrp2.samsung.com (unknown [182.198.249.139]) by\n eucas1p1.samsung.com (KnoxPortal) with ESMTPA id\n 20200408031452eucas1p1b4de173fadca62824b472b8a3dd69e32~DubfNvIM51426114261eucas1p1p\n for <dev@dpdk.org>; Wed, 8 Apr 2020 03:14:52 +0000 (GMT)", "from eusmgms1.samsung.com (unknown [182.198.249.179]) by\n eusmtrp2.samsung.com (KnoxPortal) with ESMTP id\n 20200408031452eusmtrp2ea5bd290ad631599cf0c37f58396978f~DubfNPsoS2369123691eusmtrp2B\n for <dev@dpdk.org>; Wed, 8 Apr 2020 03:14:52 +0000 (GMT)", "from eusmtip1.samsung.com ( [203.254.199.221]) by\n eusmgms1.samsung.com (EUCPMTA) with SMTP id 82.DA.08375.CA14D8E5; Wed, 8\n Apr 2020 04:14:52 +0100 (BST)", "from localhost.localdomain (unknown [106.210.88.70]) by\n eusmtip1.samsung.com (KnoxPortal) with ESMTPA id\n 20200408031452eusmtip133453df0c715a7c8dcddd751a7c30025~Dube0O3_q2835528355eusmtip1g\n for <dev@dpdk.org>; Wed, 8 Apr 2020 03:14:52 +0000 (GMT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com\n 20200408031453euoutp021ec3dce8ba2205b011ee24533a5cd1bf~DubgAaqNA1520415204euoutp02y", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com;\n s=mail20170921; t=1586315693;\n bh=igxkj1rh0eTu9I7h5X2CfjMMhnmGhIJ6tYnNcUVR9fk=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=DdH4nLTaSVz9mKcjfHh5gntpxnO50cCONxZgiAkpweFymqLGOaZSgadDM1yoD9Rpz\n IaAUQCdrzmV5ju3NlWr92zAlan8d1jTUxdC3JT2dxZ+RwQ+wCRFsOx3wgGUoAwdT5v\n nnjX6rlVcjJW3lrvwOPkEF5xQWxtUN9Tv3BzkeDs=", "X-AuditID": "cbfec7f2-ef1ff7000001ef66-6d-5e8d41ad166d", "From": "Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>", "To": "", "Cc": "dev@dpdk.org", "Date": "Wed, 8 Apr 2020 05:13:47 +0200", "Message-Id": "<20200408031351.4288-10-l.wojciechow@partner.samsung.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200408031351.4288-1-l.wojciechow@partner.samsung.com>", "X-Brightmail-Tracker": [ "\n H4sIAAAAAAAAA+NgFjrJIsWRmVeSWpSXmKPExsWy7djP87prHXvjDH5fYLd492k7kwOjx68F\n S1kDGKO4bFJSczLLUov07RK4MjpvbWQqaNapmLnqG1MD4w/VLkZODgkBE4nry/YxdzFycQgJ\n rGCUuLvnAwuE084ksWjSUWaQKiGBNiaJA7fjYTr+9jVCdSxnlLh+8yArhANUtPXsejaQKjYB\n W4kjM7+ygtgiAiwSK79/ZwGxmQUEJB7fewYWFxbwkvg0sxHMZhFQlVh/9hcjiM0r4Crx9OA0\n Foht8hKrNxwA2sbBwQkU332WC2SXhMAKNonfW75C1bhITN/TyghhC0u8Or6FHcKWkfi/cz4T\n RMM2Romrv38yQjj7gc7uXQFVZS1x+N9vNpANzAKaEut36UOEHSXOv+5lBwlLCPBJ3HgrCHE/\n n8SkbdOZIcK8Eh1tQhDVehJPe6Yywqz9s/YJ1GkeEkeX/GWBBOJlRomj3+MnMMrPQti1gJFx\n FaN4amlxbnpqsWFearlecWJucWleul5yfu4mRmAEn/53/NMOxq+Xkg4xCnAwKvHwPkjsiRNi\n TSwrrsw9xCjBwawkwivV2xknxJuSWFmVWpQfX1Sak1p8iFGag0VJnNd40ctYIYH0xJLU7NTU\n gtQimCwTB6dUA+PCoxyhKozLZ1lbtDSaf2r0DMpMS1e6c/WxoqGe277cyJgTcTvOcvUEMiYm\n lvnqZRldXBtgIzqXo7Kuw3DLp3kxWR5Ri5nLHp36Jmneb7OKU8KXr/RgQN5kHSfb81sbYud/\n afOr2Z4kcmM93w7DeQ+T95WE3DTw3HcuNfDIj2N9X6v4V746oMRSnJFoqMVcVJwIACXhWMXc\n AgAA", "\n H4sIAAAAAAAAA+NgFlrFLMWRmVeSWpSXmKPExsVy+t/xu7prHHvjDGb0alm8+7SdyYHR49eC\n pawBjFF6NkX5pSWpChn5xSW2StGGFkZ6hpYWekYmlnqGxuaxVkamSvp2NimpOZllqUX6dgl6\n GZ23NjIVNOtUzFz1jamB8YdqFyMnh4SAicTfvkbmLkYuDiGBpYwSHa0P2LsYOYASMhIfLglA\n 1AhL/LnWxQZR08IksfJLOzNIgk3AVuLIzK+sILaIAIvEyu/fWUBsZgEBicf3noHFhQW8JD7N\n bASzWQRUJdaf/cUIYvMKuEo8PTiNBWKBvMTqDQeYQfZyAsV3n+UCCQsJ1EscvnuZbQIj3wJG\n hlWMIqmlxbnpucWGesWJucWleel6yfm5mxiB4bTt2M/NOxgvbQw+xCjAwajEw/sgsSdOiDWx\n rLgy9xCjBAezkgivVG9nnBBvSmJlVWpRfnxRaU5q8SFGU6CbJjJLiSbnA0M9ryTe0NTQ3MLS\n 0NzY3NjMQkmct0PgYIyQQHpiSWp2ampBahFMHxMHp1QDo/0c17VVd8x8FzQ/CH9n9PJb27O5\n cgdnxV8WP7gnIUig7PanJgubOYpt8uZ6nDrJInPM1i2xMjpzXj/EXdUzZs6sJuu/+145vdjj\n Iazf02H9MWGK74I9Sa1/pIJuzn8c8Ez/7hq9yuB3bMdeirKoS9ekcPJyfNj05uvKSwqLXoVN\n ef36/7UYdSWW4oxEQy3mouJEAI8kMrU9AgAA" ], "X-CMS-MailID": "20200408031452eucas1p1b4de173fadca62824b472b8a3dd69e32", "X-Msg-Generator": "CA", "Content-Type": "text/plain; charset=\"utf-8\"", "X-RootMTR": "20200408031452eucas1p1b4de173fadca62824b472b8a3dd69e32", "X-EPHeader": "CA", "CMS-TYPE": "201P", "X-CMS-RootMailID": "20200408031452eucas1p1b4de173fadca62824b472b8a3dd69e32", "References": "<20200312151654.7218-1-l.wojciechow@partner.samsung.com>\n <20200408031351.4288-1-l.wojciechow@partner.samsung.com>\n <CGME20200408031452eucas1p1b4de173fadca62824b472b8a3dd69e32@eucas1p1.samsung.com>", "Subject": "[dpdk-dev] [PATCH v2 09/13] app/test: add rte security session\n\tdestroy tests", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add unit tests for rte_security_session_destroy function.\n\nSigned-off-by: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>\n---\n app/test/test_security.c | 166 +++++++++++++++++++++++++++++++++++++++\n 1 file changed, 166 insertions(+)", "diff": "diff --git a/app/test/test_security.c b/app/test/test_security.c\nindex c495449b0..b1a907bd9 100644\n--- a/app/test/test_security.c\n+++ b/app/test/test_security.c\n@@ -1137,6 +1137,159 @@ test_session_stats_get_success(void)\n }\n \n \n+/**\n+ * rte_security_session_destroy tests\n+ */\n+\n+/**\n+ * Test execution of rte_security_session_destroy with NULL instance\n+ */\n+static int\n+test_session_destroy_inv_context(void)\n+{\n+\tstruct security_unittest_params *ut_params = &unittest_params;\n+\n+\tTEST_ASSERT_MEMPOOL_USAGE(1);\n+\tTEST_ASSERT_SESSION_COUNT(1);\n+\n+\tint ret = rte_security_session_destroy(NULL, ut_params->sess);\n+\tTEST_ASSERT_MOCK_FUNCTION_CALL_RET(rte_security_session_destroy,\n+\t\t\tret, -EINVAL, \"%d\");\n+\tTEST_ASSERT_MOCK_CALLS(mock_session_destroy_exp, 0);\n+\tTEST_ASSERT_MEMPOOL_USAGE(1);\n+\tTEST_ASSERT_SESSION_COUNT(1);\n+\n+\treturn TEST_SUCCESS;\n+}\n+\n+/**\n+ * Test execution of rte_security_session_destroy with invalid\n+ * security operations structure (NULL)\n+ */\n+static int\n+test_session_destroy_inv_context_ops(void)\n+{\n+\tstruct security_unittest_params *ut_params = &unittest_params;\n+\tut_params->ctx.ops = NULL;\n+\n+\tTEST_ASSERT_MEMPOOL_USAGE(1);\n+\tTEST_ASSERT_SESSION_COUNT(1);\n+\n+\tint ret = rte_security_session_destroy(&ut_params->ctx,\n+\t\t\tut_params->sess);\n+\tTEST_ASSERT_MOCK_FUNCTION_CALL_RET(rte_security_session_destroy,\n+\t\t\tret, -EINVAL, \"%d\");\n+\tTEST_ASSERT_MOCK_CALLS(mock_session_destroy_exp, 0);\n+\tTEST_ASSERT_MEMPOOL_USAGE(1);\n+\tTEST_ASSERT_SESSION_COUNT(1);\n+\n+\treturn TEST_SUCCESS;\n+}\n+\n+/**\n+ * Test execution of rte_security_session_destroy with empty\n+ * security operations\n+ */\n+static int\n+test_session_destroy_inv_context_ops_fun(void)\n+{\n+\tstruct security_unittest_params *ut_params = &unittest_params;\n+\tut_params->ctx.ops = &empty_ops;\n+\n+\tTEST_ASSERT_MEMPOOL_USAGE(1);\n+\tTEST_ASSERT_SESSION_COUNT(1);\n+\n+\tint ret = rte_security_session_destroy(&ut_params->ctx,\n+\t\t\tut_params->sess);\n+\tTEST_ASSERT_MOCK_FUNCTION_CALL_RET(rte_security_session_destroy,\n+\t\t\tret, -ENOTSUP, \"%d\");\n+\tTEST_ASSERT_MOCK_CALLS(mock_session_destroy_exp, 0);\n+\tTEST_ASSERT_MEMPOOL_USAGE(1);\n+\tTEST_ASSERT_SESSION_COUNT(1);\n+\n+\treturn TEST_SUCCESS;\n+}\n+\n+/**\n+ * Test execution of rte_security_session_destroy with NULL sess parameter\n+ */\n+static int\n+test_session_destroy_inv_session(void)\n+{\n+\tstruct security_unittest_params *ut_params = &unittest_params;\n+\n+\tTEST_ASSERT_MEMPOOL_USAGE(1);\n+\tTEST_ASSERT_SESSION_COUNT(1);\n+\n+\tint ret = rte_security_session_destroy(&ut_params->ctx, NULL);\n+\tTEST_ASSERT_MOCK_FUNCTION_CALL_RET(rte_security_session_destroy,\n+\t\t\tret, -EINVAL, \"%d\");\n+\tTEST_ASSERT_MOCK_CALLS(mock_session_destroy_exp, 0);\n+\tTEST_ASSERT_MEMPOOL_USAGE(1);\n+\tTEST_ASSERT_SESSION_COUNT(1);\n+\n+\treturn TEST_SUCCESS;\n+}\n+\n+/**\n+ * Test execution of rte_security_session_destroy when session_destroy\n+ * security operation fails\n+ */\n+static int\n+test_session_destroy_ops_failure(void)\n+{\n+\tstruct security_unittest_params *ut_params = &unittest_params;\n+\n+\tmock_session_destroy_exp.device = NULL;\n+\tmock_session_destroy_exp.sess = ut_params->sess;\n+\tmock_session_destroy_exp.ret = -1;\n+\n+\tTEST_ASSERT_MEMPOOL_USAGE(1);\n+\tTEST_ASSERT_SESSION_COUNT(1);\n+\n+\tint ret = rte_security_session_destroy(&ut_params->ctx,\n+\t\t\tut_params->sess);\n+\tTEST_ASSERT_MOCK_FUNCTION_CALL_RET(rte_security_session_destroy,\n+\t\t\tret, -1, \"%d\");\n+\tTEST_ASSERT_MOCK_CALLS(mock_session_destroy_exp, 1);\n+\tTEST_ASSERT_MEMPOOL_USAGE(1);\n+\tTEST_ASSERT_SESSION_COUNT(1);\n+\n+\treturn TEST_SUCCESS;\n+}\n+\n+/**\n+ * Test execution of rte_security_session_destroy in successful execution path\n+ */\n+static int\n+test_session_destroy_success(void)\n+{\n+\tstruct security_unittest_params *ut_params = &unittest_params;\n+\n+\tmock_session_destroy_exp.device = NULL;\n+\tmock_session_destroy_exp.sess = ut_params->sess;\n+\tmock_session_destroy_exp.ret = 0;\n+\tTEST_ASSERT_MEMPOOL_USAGE(1);\n+\tTEST_ASSERT_SESSION_COUNT(1);\n+\n+\tint ret = rte_security_session_destroy(&ut_params->ctx,\n+\t\t\tut_params->sess);\n+\tTEST_ASSERT_MOCK_FUNCTION_CALL_RET(rte_security_session_destroy,\n+\t\t\tret, 0, \"%d\");\n+\tTEST_ASSERT_MOCK_CALLS(mock_session_destroy_exp, 1);\n+\tTEST_ASSERT_MEMPOOL_USAGE(0);\n+\tTEST_ASSERT_SESSION_COUNT(0);\n+\n+\t/*\n+\t * Remove session from test case parameters, so it won't be destroyed\n+\t * during test case teardown.\n+\t */\n+\tut_params->sess = NULL;\n+\n+\treturn TEST_SUCCESS;\n+}\n+\n+\n /**\n * Declaration of testcases\n */\n@@ -1201,6 +1354,19 @@ static struct unit_test_suite security_testsuite = {\n \t\tTEST_CASE_ST(ut_setup_with_session, ut_teardown,\n \t\t\t\ttest_session_stats_get_success),\n \n+\t\tTEST_CASE_ST(ut_setup_with_session, ut_teardown,\n+\t\t\t\ttest_session_destroy_inv_context),\n+\t\tTEST_CASE_ST(ut_setup_with_session, ut_teardown,\n+\t\t\t\ttest_session_destroy_inv_context_ops),\n+\t\tTEST_CASE_ST(ut_setup_with_session, ut_teardown,\n+\t\t\t\ttest_session_destroy_inv_context_ops_fun),\n+\t\tTEST_CASE_ST(ut_setup_with_session, ut_teardown,\n+\t\t\t\ttest_session_destroy_inv_session),\n+\t\tTEST_CASE_ST(ut_setup_with_session, ut_teardown,\n+\t\t\t\ttest_session_destroy_ops_failure),\n+\t\tTEST_CASE_ST(ut_setup_with_session, ut_teardown,\n+\t\t\t\ttest_session_destroy_success),\n+\n \t\tTEST_CASES_END() /**< NULL terminate unit test array */\n \t}\n };\n", "prefixes": [ "v2", "09/13" ] }