Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/67607/?format=api
{ "id": 67607, "url": "https://patches.dpdk.org/api/patches/67607/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200401142127.13715-23-mk@semihalf.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200401142127.13715-23-mk@semihalf.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200401142127.13715-23-mk@semihalf.com", "date": "2020-04-01T14:21:20", "name": "[v2,22/29] net/ena: rework getting number of available descs", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "955ff25f647315a7de2b7d0b3c71f246d2b1ed3e", "submitter": { "id": 786, "url": "https://patches.dpdk.org/api/people/786/?format=api", "name": "Michal Krawczyk", "email": "mk@semihalf.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200401142127.13715-23-mk@semihalf.com/mbox/", "series": [ { "id": 9153, "url": "https://patches.dpdk.org/api/series/9153/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=9153", "date": "2020-04-01T14:20:58", "name": "Update ENA driver to v2.1.0", "version": 2, "mbox": "https://patches.dpdk.org/series/9153/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/67607/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/67607/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 26210A057B;\n\tWed, 1 Apr 2020 16:25:45 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 583901C11D;\n\tWed, 1 Apr 2020 16:22:14 +0200 (CEST)", "from mail-lj1-f196.google.com (mail-lj1-f196.google.com\n [209.85.208.196]) by dpdk.org (Postfix) with ESMTP id 3D0F71C0D7\n for <dev@dpdk.org>; Wed, 1 Apr 2020 16:22:08 +0200 (CEST)", "by mail-lj1-f196.google.com with SMTP id 19so25905397ljj.7\n for <dev@dpdk.org>; Wed, 01 Apr 2020 07:22:08 -0700 (PDT)", "from mkPC.semihalf.local (193-106-246-138.noc.fibertech.net.pl.\n [193.106.246.138])\n by smtp.gmail.com with ESMTPSA id r21sm1435961ljp.29.2020.04.01.07.22.06\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 01 Apr 2020 07:22:06 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=semihalf-com.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=u292S0ZQkNHgGfU9MhG7cI7obuqkMTeVbxcTMWXYMXA=;\n b=R9DetRoCBcgTVazS0KmX1Xhjs9fvIarAQOxdVvjw686qUlBm5MpATtJIWIjImob49m\n d4a4R70vv5Ws8beghGqMdh0mZJCckGuSc7v3mpYzPTv5s4Gn/H2KSyfqmjWL30X3Z3s2\n SZIJRPVX1W1Dq6fDs+HsB2a6JPq5+VxENRj61Ngi2Vs433mMmf0pig4ynVluTz+/pWv7\n SU7ifpfyioxlbazKcbxaEKi5vste5DbYB32zFYtoEjFbyNaBGudhIKlEALJIwIKDvOO2\n 5p1DVhT0s0qcWt3RcQWH5lEjja/mILD/kjq4ANkBh0vW5pFlhhin8HQ86UH7LQ1zsj/r\n qWIg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=u292S0ZQkNHgGfU9MhG7cI7obuqkMTeVbxcTMWXYMXA=;\n b=LnasboIOYcKs8K9y/iXzSZ7+rjouB4x//BgtA2izeYuHrlIeHKs7NWf9Sl8Mx7CbBM\n +UecOje1rwnL7dq2KekOR5kFPWD5CHIGqX0krRdAqGKFZEfSPV44Sa965oJfLVynSDQU\n VI7rMj2+bQsZojPEXMAMxP6RR0Rhiy6dEOMNGJMBd/hv1u+biCRH59oRVG20Tozt/hWj\n ZyRXJZMXNRbsqkcMgSZfv2JPuxk63F9RcGAX/HB+NZR2g++AClmPjZAwUsHST23yeer+\n w9u0A3SuI4r7XQwvBBcMee1bRSBKt6+Jbj1TTvzggxIObNg416h+Mm4rnYhJzO4dp6gw\n ms8w==", "X-Gm-Message-State": "AGi0PuZjR+oFraAPGL3GjJtS0CK3EnjG9TYe4ZDLcpD2B/chsvjGP75q\n NObd5Nb/+IeBc9zvkyrosYL0wt6Vuhg=", "X-Google-Smtp-Source": "\n APiQypIuU7b8K1diYpmE+8Suyqmv2VUAe6YLsYCaAMKeDjluP9BWdp9bgYIz8FdaKT+tgTquX05XbQ==", "X-Received": "by 2002:a2e:a16d:: with SMTP id\n u13mr12958707ljl.140.1585750927380;\n Wed, 01 Apr 2020 07:22:07 -0700 (PDT)", "From": "Michal Krawczyk <mk@semihalf.com>", "To": "dev@dpdk.org", "Cc": "mw@semihalf.com, mba@semihalf.com, gtzalik@amazon.com, evgenys@amazon.com,\n igorch@amazon.com, Michal Krawczyk <mk@semihalf.com>", "Date": "Wed, 1 Apr 2020 16:21:20 +0200", "Message-Id": "<20200401142127.13715-23-mk@semihalf.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200401142127.13715-1-mk@semihalf.com>", "References": "<20200401142127.13715-1-mk@semihalf.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 22/29] net/ena: rework getting number of\n\tavailable descs", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "ena_com API should be preferred for getting number of used/available\ndescriptors unless extra calculation needs to be performed.\n\nSome helper variables were added for storing values that are later\nreused. Moreover, for limiting the value of sent/received packets to\nthe number of available descriptors, the RTE_MIN is used instead of\nif function, which was doing similar thing but was less descriptive.\n\nSigned-off-by: Michal Krawczyk <mk@semihalf.com>\nReviewed-by: Igor Chauskin <igorch@amazon.com>\nReviewed-by: Guy Tzalik <gtzalik@amazon.com>\n---\n drivers/net/ena/ena_ethdev.c | 25 +++++++++++++------------\n 1 file changed, 13 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c\nindex 1a9c28122b..a6375e71c5 100644\n--- a/drivers/net/ena/ena_ethdev.c\n+++ b/drivers/net/ena/ena_ethdev.c\n@@ -1426,7 +1426,8 @@ static int ena_populate_rx_queue(struct ena_ring *rxq, unsigned int count)\n \tif (unlikely(!count))\n \t\treturn 0;\n \n-\tin_use = rxq->next_to_use - rxq->next_to_clean;\n+\tin_use = ring_size - ena_com_free_q_entries(rxq->ena_com_io_sq) - 1;\n+\n \tena_assert_msg(((in_use + count) < ring_size), \"bad ring state\\n\");\n \n \t/* get resources for incoming packets */\n@@ -2145,8 +2146,9 @@ static uint16_t eth_ena_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,\n \tstruct ena_ring *rx_ring = (struct ena_ring *)(rx_queue);\n \tunsigned int ring_size = rx_ring->ring_size;\n \tunsigned int ring_mask = ring_size - 1;\n+\tunsigned int refill_required;\n \tuint16_t next_to_clean = rx_ring->next_to_clean;\n-\tuint16_t desc_in_use = 0;\n+\tuint16_t descs_in_use;\n \tstruct rte_mbuf *mbuf;\n \tuint16_t completed;\n \tstruct ena_com_rx_ctx ena_rx_ctx;\n@@ -2159,9 +2161,9 @@ static uint16_t eth_ena_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,\n \t\treturn 0;\n \t}\n \n-\tdesc_in_use = rx_ring->next_to_use - next_to_clean;\n-\tif (unlikely(nb_pkts > desc_in_use))\n-\t\tnb_pkts = desc_in_use;\n+\tdescs_in_use = ring_size -\n+\t\tena_com_free_q_entries(rx_ring->ena_com_io_sq) - 1;\n+\tnb_pkts = RTE_MIN(descs_in_use, nb_pkts);\n \n \tfor (completed = 0; completed < nb_pkts; completed++) {\n \t\tena_rx_ctx.max_bufs = rx_ring->sgl_size;\n@@ -2213,11 +2215,11 @@ static uint16_t eth_ena_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,\n \trx_ring->rx_stats.cnt += completed;\n \trx_ring->next_to_clean = next_to_clean;\n \n-\tdesc_in_use = desc_in_use - completed + 1;\n+\trefill_required = ena_com_free_q_entries(rx_ring->ena_com_io_sq);\n \t/* Burst refill to save doorbells, memory barriers, const interval */\n-\tif (ring_size - desc_in_use > ENA_RING_DESCS_RATIO(ring_size)) {\n+\tif (refill_required > ENA_RING_DESCS_RATIO(ring_size)) {\n \t\tena_com_update_dev_comp_head(rx_ring->ena_com_io_cq);\n-\t\tena_populate_rx_queue(rx_ring, ring_size - desc_in_use);\n+\t\tena_populate_rx_queue(rx_ring, refill_required);\n \t}\n \n \treturn completed;\n@@ -2360,7 +2362,7 @@ static uint16_t eth_ena_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,\n \tstruct ena_tx_buffer *tx_info;\n \tstruct ena_com_buf *ebuf;\n \tuint16_t rc, req_id, total_tx_descs = 0;\n-\tuint16_t sent_idx = 0, empty_tx_reqs;\n+\tuint16_t sent_idx = 0;\n \tuint16_t push_len = 0;\n \tuint16_t delta = 0;\n \tint nb_hw_desc;\n@@ -2373,9 +2375,8 @@ static uint16_t eth_ena_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,\n \t\treturn 0;\n \t}\n \n-\tempty_tx_reqs = ring_size - (next_to_use - next_to_clean);\n-\tif (nb_pkts > empty_tx_reqs)\n-\t\tnb_pkts = empty_tx_reqs;\n+\tnb_pkts = RTE_MIN(ena_com_free_q_entries(tx_ring->ena_com_io_sq),\n+\t\tnb_pkts);\n \n \tfor (sent_idx = 0; sent_idx < nb_pkts; sent_idx++) {\n \t\tmbuf = tx_pkts[sent_idx];\n", "prefixes": [ "v2", "22/29" ] }