Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/67595/?format=api
{ "id": 67595, "url": "https://patches.dpdk.org/api/patches/67595/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200401142127.13715-11-mk@semihalf.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200401142127.13715-11-mk@semihalf.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200401142127.13715-11-mk@semihalf.com", "date": "2020-04-01T14:21:08", "name": "[v2,10/29] net/ena/base: add error logs when preparing Tx", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "8aaa6b5411d33ef802f117e093fc0a3763af8329", "submitter": { "id": 786, "url": "https://patches.dpdk.org/api/people/786/?format=api", "name": "Michal Krawczyk", "email": "mk@semihalf.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200401142127.13715-11-mk@semihalf.com/mbox/", "series": [ { "id": 9153, "url": "https://patches.dpdk.org/api/series/9153/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=9153", "date": "2020-04-01T14:20:58", "name": "Update ENA driver to v2.1.0", "version": 2, "mbox": "https://patches.dpdk.org/series/9153/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/67595/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/67595/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BA858A057B;\n\tWed, 1 Apr 2020 16:23:30 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 12A2D1BFC4;\n\tWed, 1 Apr 2020 16:21:54 +0200 (CEST)", "from mail-lj1-f196.google.com (mail-lj1-f196.google.com\n [209.85.208.196]) by dpdk.org (Postfix) with ESMTP id 27C851BEBF\n for <dev@dpdk.org>; Wed, 1 Apr 2020 16:21:52 +0200 (CEST)", "by mail-lj1-f196.google.com with SMTP id p10so25711347ljn.1\n for <dev@dpdk.org>; Wed, 01 Apr 2020 07:21:52 -0700 (PDT)", "from mkPC.semihalf.local (193-106-246-138.noc.fibertech.net.pl.\n [193.106.246.138])\n by smtp.gmail.com with ESMTPSA id r21sm1435961ljp.29.2020.04.01.07.21.49\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 01 Apr 2020 07:21:49 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=semihalf-com.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=VMKzfoDtixxDfKwL4LmA5K/5OQb+WO9qXPNwnHDPCk0=;\n b=RTLYUFnjNw91T1BSQjFTGgGCOGK9OOFKe7umgo2cWqZb93h8tiIgR0SdI1VDXghuZT\n 7uzfWqH+FqP1ZbPevDRzCmFHu1ZmDZeDDzx35vZ256hseEIughocgL7NepUQT0wKcKKI\n Tk387xZIaH6uBaiyxa0yh2+V+tJbhe8C5k3DRYQlwKaVqCMPZDkCThFbJvaqOdzOZth8\n pNw6dSPHJxYKycbZcnm0xMgfu38Wfmv/lOFxnYD+KaZuM+kmqyLdpeK7oHnBIiSF5lEE\n 7zEmoaGvAXpVkaSLDiMj9UnHXdta2FCYRzGIgdnMWmHaRnmrbXWFFfrucaojOg5M6cp2\n OBaQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=VMKzfoDtixxDfKwL4LmA5K/5OQb+WO9qXPNwnHDPCk0=;\n b=tiIDIU2Itf1AlMUoKj3IcP2YeTYJb+6082X4S1N53k6pQK57wvhq0q3QBgNoPYjnsT\n Ltf0cIH0NCwYGdOr94vu2TQTntjoXggPEyJYbWexCJ1IPI5esUcGydDhefL5MPijgzad\n rNBJ84LX0eFCa1sbT97QQPGQ0G/VdX/ZkpRtDVb/Ls5auwSRxkLJFM8vgg+nPOS5k2JG\n fO7K+gd9+sewX4yLbFvhNAlOQoXBT2qGqcOBckk/adxigmSNWOk6ag6lEtbUnlEq4sa/\n sEdkjvh6VfjtOz94TpKD3LP2EiKfIrqRGjwkmaKG84fATecCsU7wJur82Xiy1TV2370R\n bG/w==", "X-Gm-Message-State": "AGi0Pub8YNJqkFGSOI5n/zFUZC86oGuOojvt7TP+8XQ0OHHkXLF2ZeU4\n cf+s/PIAfGl9+Liy6/EkkxhgyeZsaqE=", "X-Google-Smtp-Source": "\n APiQypJUQZ94znh/HX/Yg8PganRDFAXZJ0y3ItVP4u9J5ExYJ8XlixYlWKsvNxlxvIFChnxis8johQ==", "X-Received": "by 2002:a05:651c:c7:: with SMTP id\n 7mr10943605ljr.124.1585750911519;\n Wed, 01 Apr 2020 07:21:51 -0700 (PDT)", "From": "Michal Krawczyk <mk@semihalf.com>", "To": "dev@dpdk.org", "Cc": "mw@semihalf.com, mba@semihalf.com, gtzalik@amazon.com, evgenys@amazon.com,\n igorch@amazon.com, Michal Krawczyk <mk@semihalf.com>", "Date": "Wed, 1 Apr 2020 16:21:08 +0200", "Message-Id": "<20200401142127.13715-11-mk@semihalf.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200401142127.13715-1-mk@semihalf.com>", "References": "<20200401142127.13715-1-mk@semihalf.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 10/29] net/ena/base: add error logs when\n\tpreparing Tx", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "To make the debugging easier, the error logs were added in the Tx path.\n\nSigned-off-by: Michal Krawczyk <mk@semihalf.com>\nReviewed-by: Igor Chauskin <igorch@amazon.com>\nReviewed-by: Guy Tzalik <gtzalik@amazon.com>\n---\n drivers/net/ena/base/ena_eth_com.c | 24 +++++++++++++++++++-----\n 1 file changed, 19 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/ena/base/ena_eth_com.c b/drivers/net/ena/base/ena_eth_com.c\nindex aabc294fb7..747450fec5 100644\n--- a/drivers/net/ena/base/ena_eth_com.c\n+++ b/drivers/net/ena/base/ena_eth_com.c\n@@ -148,8 +148,10 @@ static int ena_com_close_bounce_buffer(struct ena_com_io_sq *io_sq)\n \tif (pkt_ctrl->idx) {\n \t\trc = ena_com_write_bounce_buffer_to_dev(io_sq,\n \t\t\t\t\t\t\tpkt_ctrl->curr_bounce_buf);\n-\t\tif (unlikely(rc))\n+\t\tif (unlikely(rc)) {\n+\t\t\tena_trc_err(\"failed to write bounce buffer to device\\n\");\n \t\t\treturn rc;\n+\t\t}\n \n \t\tpkt_ctrl->curr_bounce_buf =\n \t\t\tena_com_get_next_bounce_buffer(&io_sq->bounce_buf_ctrl);\n@@ -179,8 +181,10 @@ static int ena_com_sq_update_llq_tail(struct ena_com_io_sq *io_sq)\n \tif (!pkt_ctrl->descs_left_in_line) {\n \t\trc = ena_com_write_bounce_buffer_to_dev(io_sq,\n \t\t\t\t\t\t\tpkt_ctrl->curr_bounce_buf);\n-\t\tif (unlikely(rc))\n+\t\tif (unlikely(rc)) {\n+\t\t\tena_trc_err(\"failed to write bounce buffer to device\\n\");\n \t\t\treturn rc;\n+\t\t}\n \n \t\tpkt_ctrl->curr_bounce_buf =\n \t\t\tena_com_get_next_bounce_buffer(&io_sq->bounce_buf_ctrl);\n@@ -394,8 +398,10 @@ int ena_com_prepare_tx(struct ena_com_io_sq *io_sq,\n \t}\n \n \tif (unlikely(io_sq->mem_queue_type == ENA_ADMIN_PLACEMENT_POLICY_DEV\n-\t\t && !buffer_to_push))\n+\t\t && !buffer_to_push)) {\n+\t\tena_trc_err(\"push header wasn't provided on LLQ mode\\n\");\n \t\treturn ENA_COM_INVAL;\n+\t}\n \n \trc = ena_com_write_header_to_bounce(io_sq, buffer_to_push, header_len);\n \tif (unlikely(rc))\n@@ -410,6 +416,8 @@ int ena_com_prepare_tx(struct ena_com_io_sq *io_sq,\n \t/* If the caller doesn't want to send packets */\n \tif (unlikely(!num_bufs && !header_len)) {\n \t\trc = ena_com_close_bounce_buffer(io_sq);\n+\t\tif (rc)\n+\t\t\tena_trc_err(\"failed to write buffers to LLQ\\n\");\n \t\t*nb_hw_desc = io_sq->tail - start_tail;\n \t\treturn rc;\n \t}\n@@ -469,8 +477,10 @@ int ena_com_prepare_tx(struct ena_com_io_sq *io_sq,\n \t\t/* The first desc share the same desc as the header */\n \t\tif (likely(i != 0)) {\n \t\t\trc = ena_com_sq_update_tail(io_sq);\n-\t\t\tif (unlikely(rc))\n+\t\t\tif (unlikely(rc)) {\n+\t\t\t\tena_trc_err(\"failed to update sq tail\\n\");\n \t\t\t\treturn rc;\n+\t\t\t}\n \n \t\t\tdesc = get_sq_desc(io_sq);\n \t\t\tif (unlikely(!desc))\n@@ -499,10 +509,14 @@ int ena_com_prepare_tx(struct ena_com_io_sq *io_sq,\n \tdesc->len_ctrl |= ENA_ETH_IO_TX_DESC_LAST_MASK;\n \n \trc = ena_com_sq_update_tail(io_sq);\n-\tif (unlikely(rc))\n+\tif (unlikely(rc)) {\n+\t\tena_trc_err(\"failed to update sq tail of the last descriptor\\n\");\n \t\treturn rc;\n+\t}\n \n \trc = ena_com_close_bounce_buffer(io_sq);\n+\tif (rc)\n+\t\tena_trc_err(\"failed when closing bounce buffer\\n\");\n \n \t*nb_hw_desc = io_sq->tail - start_tail;\n \treturn rc;\n", "prefixes": [ "v2", "10/29" ] }