Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/67591/?format=api
{ "id": 67591, "url": "https://patches.dpdk.org/api/patches/67591/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200401142127.13715-7-mk@semihalf.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200401142127.13715-7-mk@semihalf.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200401142127.13715-7-mk@semihalf.com", "date": "2020-04-01T14:21:04", "name": "[v2,06/29] net/ena/base: remove extra properties strings", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a80bfbc6c7d96e7cf4e256be4d6a1c01cd7eea37", "submitter": { "id": 786, "url": "https://patches.dpdk.org/api/people/786/?format=api", "name": "Michal Krawczyk", "email": "mk@semihalf.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200401142127.13715-7-mk@semihalf.com/mbox/", "series": [ { "id": 9153, "url": "https://patches.dpdk.org/api/series/9153/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=9153", "date": "2020-04-01T14:20:58", "name": "Update ENA driver to v2.1.0", "version": 2, "mbox": "https://patches.dpdk.org/series/9153/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/67591/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/67591/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9A4CDA057B;\n\tWed, 1 Apr 2020 16:22:44 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6B5121BEE6;\n\tWed, 1 Apr 2020 16:21:48 +0200 (CEST)", "from mail-lj1-f193.google.com (mail-lj1-f193.google.com\n [209.85.208.193]) by dpdk.org (Postfix) with ESMTP id E1F3D1BECC\n for <dev@dpdk.org>; Wed, 1 Apr 2020 16:21:45 +0200 (CEST)", "by mail-lj1-f193.google.com with SMTP id 19so25904069ljj.7\n for <dev@dpdk.org>; Wed, 01 Apr 2020 07:21:45 -0700 (PDT)", "from mkPC.semihalf.local (193-106-246-138.noc.fibertech.net.pl.\n [193.106.246.138])\n by smtp.gmail.com with ESMTPSA id r21sm1435961ljp.29.2020.04.01.07.21.44\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 01 Apr 2020 07:21:44 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=semihalf-com.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=OS8Wq+90JkQ6fUmpk+hKywyQCRi+8rx7LJ5V0ISP0lY=;\n b=KtwWJkUmkrcW5fkDdgyAEVPNO/AKU05hEms02mchaATNlGGU86TJm7za46ZzLk1Otl\n H10lTct4v1XEGN6QWLb3em536dQxUFijEstxqAy5ndyEWBnHQo/XGS25gySr/DeocpZi\n tcWArb2e3wr0YmPMc0FbmkRPtx0CxmmZCqfnYR3U7Wr2KLpChFKCm2J9RpDV43M3a1po\n fPHSCsm4YwkWe56wnRN5eZ2ysG4lLF9GVsMHuybz8sZk8DJtpiQ/wXsx5tp2/DOm2Xbr\n YlxQbFNYEC1wKdYa61dIUIwyyaKRjuX4iCPG04ljsucSmqDmncvpnQaWzAQVztxrunZj\n jbbA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=OS8Wq+90JkQ6fUmpk+hKywyQCRi+8rx7LJ5V0ISP0lY=;\n b=EkDFbDL8TAWEoxohA8rYmn6S2IUx+Dyzh7Oynse1klHUCrxjYBQVeQrx7TbG6Uywry\n RU47TzcHf4EL78sADq12N+BOQEvDeitN8rm+WS03YKRgCCtn1LSFrins0zOn2tOmuSA5\n 7RQE8agGJh2FooVkocn+PGZZmMBpSXjfwaDzL3geu/7h/hQfihUYjrH/jtiF+a85wTF7\n tPuhTvJrnbjO0QNJjNAERPg9/ipXBi/xtujlrHfwFv2cAGC4GD/QYhzSjyTBBP9Fev5f\n icipKb0BX9KUl0tDkPJMnBLxy9hHSW42SLgqugo+urwrnxUZ621HF/oI/RU+An4qJtox\n A3Uw==", "X-Gm-Message-State": "AGi0PuauWAGK6agznVQ9RBfa+tcMEKZpDjTXk1zQtfmujBbdL2ITAmnn\n xnlYJaO2ir2IS+r8oQmO8EZkQhfDPYo=", "X-Google-Smtp-Source": "\n APiQypKyIXi3AUAIGqW2/zy1AyZ6zQvx5tsYQqNnMTCJ2KBQCXCCso1HdReTRMcGYrULyzCliT+uaA==", "X-Received": "by 2002:a2e:b175:: with SMTP id\n a21mr13384478ljm.213.1585750905242;\n Wed, 01 Apr 2020 07:21:45 -0700 (PDT)", "From": "Michal Krawczyk <mk@semihalf.com>", "To": "dev@dpdk.org", "Cc": "mw@semihalf.com, mba@semihalf.com, gtzalik@amazon.com, evgenys@amazon.com,\n igorch@amazon.com, Michal Krawczyk <mk@semihalf.com>", "Date": "Wed, 1 Apr 2020 16:21:04 +0200", "Message-Id": "<20200401142127.13715-7-mk@semihalf.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200401142127.13715-1-mk@semihalf.com>", "References": "<20200401142127.13715-1-mk@semihalf.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 06/29] net/ena/base: remove extra properties\n\tstrings", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This buffer was never used by the ENA PMD. It could be used for\ndebugging, but it's presence is redundant now.\n\nSigned-off-by: Michal Krawczyk <mk@semihalf.com>\nReviewed-by: Igor Chauskin <igorch@amazon.com>\nReviewed-by: Guy Tzalik <gtzalik@amazon.com>\n---\n drivers/net/ena/base/ena_com.c | 56 ----------------------------------\n drivers/net/ena/base/ena_com.h | 33 --------------------\n 2 files changed, 89 deletions(-)", "diff": "diff --git a/drivers/net/ena/base/ena_com.c b/drivers/net/ena/base/ena_com.c\nindex cb2114acb7..19815db9ad 100644\n--- a/drivers/net/ena/base/ena_com.c\n+++ b/drivers/net/ena/base/ena_com.c\n@@ -1910,62 +1910,6 @@ int ena_com_get_link_params(struct ena_com_dev *ena_dev,\n \treturn ena_com_get_feature(ena_dev, resp, ENA_ADMIN_LINK_CONFIG, 0);\n }\n \n-int ena_com_extra_properties_strings_init(struct ena_com_dev *ena_dev)\n-{\n-\tstruct ena_admin_get_feat_resp resp;\n-\tstruct ena_extra_properties_strings *extra_properties_strings =\n-\t\t\t&ena_dev->extra_properties_strings;\n-\tu32 rc;\n-\textra_properties_strings->size = ENA_ADMIN_EXTRA_PROPERTIES_COUNT *\n-\t\tENA_ADMIN_EXTRA_PROPERTIES_STRING_LEN;\n-\n-\tENA_MEM_ALLOC_COHERENT(ena_dev->dmadev,\n-\t\t\t extra_properties_strings->size,\n-\t\t\t extra_properties_strings->virt_addr,\n-\t\t\t extra_properties_strings->dma_addr,\n-\t\t\t extra_properties_strings->dma_handle);\n-\tif (unlikely(!extra_properties_strings->virt_addr)) {\n-\t\tena_trc_err(\"Failed to allocate extra properties strings\\n\");\n-\t\treturn 0;\n-\t}\n-\n-\trc = ena_com_get_feature_ex(ena_dev, &resp,\n-\t\t\t\t ENA_ADMIN_EXTRA_PROPERTIES_STRINGS,\n-\t\t\t\t extra_properties_strings->dma_addr,\n-\t\t\t\t extra_properties_strings->size, 0);\n-\tif (rc) {\n-\t\tena_trc_dbg(\"Failed to get extra properties strings\\n\");\n-\t\tgoto err;\n-\t}\n-\n-\treturn resp.u.extra_properties_strings.count;\n-err:\n-\tena_com_delete_extra_properties_strings(ena_dev);\n-\treturn 0;\n-}\n-\n-void ena_com_delete_extra_properties_strings(struct ena_com_dev *ena_dev)\n-{\n-\tstruct ena_extra_properties_strings *extra_properties_strings =\n-\t\t\t\t&ena_dev->extra_properties_strings;\n-\n-\tif (extra_properties_strings->virt_addr) {\n-\t\tENA_MEM_FREE_COHERENT(ena_dev->dmadev,\n-\t\t\t\t extra_properties_strings->size,\n-\t\t\t\t extra_properties_strings->virt_addr,\n-\t\t\t\t extra_properties_strings->dma_addr,\n-\t\t\t\t extra_properties_strings->dma_handle);\n-\t\textra_properties_strings->virt_addr = NULL;\n-\t}\n-}\n-\n-int ena_com_get_extra_properties_flags(struct ena_com_dev *ena_dev,\n-\t\t\t\t struct ena_admin_get_feat_resp *resp)\n-{\n-\treturn ena_com_get_feature(ena_dev, resp,\n-\t\t\t\t ENA_ADMIN_EXTRA_PROPERTIES_FLAGS, 0);\n-}\n-\n int ena_com_get_dev_attr_feat(struct ena_com_dev *ena_dev,\n \t\t\t struct ena_com_dev_get_features_ctx *get_feat_ctx)\n {\ndiff --git a/drivers/net/ena/base/ena_com.h b/drivers/net/ena/base/ena_com.h\nindex 5935d024dd..0e34a13fde 100644\n--- a/drivers/net/ena/base/ena_com.h\n+++ b/drivers/net/ena/base/ena_com.h\n@@ -284,13 +284,6 @@ struct ena_host_attribute {\n \tena_mem_handle_t host_info_dma_handle;\n };\n \n-struct ena_extra_properties_strings {\n-\tu8 *virt_addr;\n-\tdma_addr_t dma_addr;\n-\tena_mem_handle_t dma_handle;\n-\tu32 size;\n-};\n-\n /* Each ena_dev is a PCI function. */\n struct ena_com_dev {\n \tstruct ena_com_admin_queue admin_queue;\n@@ -326,7 +319,6 @@ struct ena_com_dev {\n \tstruct ena_intr_moder_entry *intr_moder_tbl;\n \n \tstruct ena_com_llq_info llq_info;\n-\tstruct ena_extra_properties_strings extra_properties_strings;\n };\n \n struct ena_com_dev_get_features_ctx {\n@@ -564,31 +556,6 @@ int ena_com_validate_version(struct ena_com_dev *ena_dev);\n int ena_com_get_link_params(struct ena_com_dev *ena_dev,\n \t\t\t struct ena_admin_get_feat_resp *resp);\n \n-/* ena_com_extra_properties_strings_init - Initialize the extra properties strings buffer.\n- * @ena_dev: ENA communication layer struct\n- *\n- * Initialize the extra properties strings buffer.\n- */\n-int ena_com_extra_properties_strings_init(struct ena_com_dev *ena_dev);\n-\n-/* ena_com_delete_extra_properties_strings - Free the extra properties strings buffer.\n- * @ena_dev: ENA communication layer struct\n- *\n- * Free the allocated extra properties strings buffer.\n- */\n-void ena_com_delete_extra_properties_strings(struct ena_com_dev *ena_dev);\n-\n-/* ena_com_get_extra_properties_flags - Retrieve extra properties flags.\n- * @ena_dev: ENA communication layer struct\n- * @resp: Extra properties flags.\n- *\n- * Retrieve the extra properties flags.\n- *\n- * @return - 0 on Success negative value otherwise.\n- */\n-int ena_com_get_extra_properties_flags(struct ena_com_dev *ena_dev,\n-\t\t\t\t struct ena_admin_get_feat_resp *resp);\n-\n /* ena_com_get_dma_width - Retrieve physical dma address width the device\n * supports.\n * @ena_dev: ENA communication layer struct\n", "prefixes": [ "v2", "06/29" ] }