Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/67586/?format=api
{ "id": 67586, "url": "https://patches.dpdk.org/api/patches/67586/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200401142127.13715-2-mk@semihalf.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200401142127.13715-2-mk@semihalf.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200401142127.13715-2-mk@semihalf.com", "date": "2020-04-01T14:20:59", "name": "[v2,01/29] net/ena: check if size of buffer is at least 1400B", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "81308abcacd99eccc4ce984d66f848e9814351f6", "submitter": { "id": 786, "url": "https://patches.dpdk.org/api/people/786/?format=api", "name": "Michal Krawczyk", "email": "mk@semihalf.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200401142127.13715-2-mk@semihalf.com/mbox/", "series": [ { "id": 9153, "url": "https://patches.dpdk.org/api/series/9153/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=9153", "date": "2020-04-01T14:20:58", "name": "Update ENA driver to v2.1.0", "version": 2, "mbox": "https://patches.dpdk.org/series/9153/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/67586/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/67586/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C396CA057B;\n\tWed, 1 Apr 2020 16:21:46 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 25BEF1BE9B;\n\tWed, 1 Apr 2020 16:21:41 +0200 (CEST)", "from mail-lj1-f194.google.com (mail-lj1-f194.google.com\n [209.85.208.194]) by dpdk.org (Postfix) with ESMTP id 25CBF3B5\n for <dev@dpdk.org>; Wed, 1 Apr 2020 16:21:39 +0200 (CEST)", "by mail-lj1-f194.google.com with SMTP id n17so25945640lji.8\n for <dev@dpdk.org>; Wed, 01 Apr 2020 07:21:39 -0700 (PDT)", "from mkPC.semihalf.local (193-106-246-138.noc.fibertech.net.pl.\n [193.106.246.138])\n by smtp.gmail.com with ESMTPSA id r21sm1435961ljp.29.2020.04.01.07.21.37\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 01 Apr 2020 07:21:37 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=semihalf-com.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=m6OL7pgoqyLwVGSBretiCVE6yK1LNicxN0enE1mBvwY=;\n b=jZgHJo7n1gUTw+uY21VOmQrK+DPZXr8lhgP6i2EZjRM51/x05jQHxEeI5SkmtcAk3t\n Z5xuSqAWig2j7IUubmbm25VmyEFJVsUw/2lT1QVvG5kDxH0W9ruxF6NepKqjixmCBv6H\n r3rncJ2za6D6cENMKmRcHXCHfG2EeGaeu4XoCzPS3Jh8ol/VRx5y2KStayVmRd8WIAIY\n hpWc1PtU3LELqVSf1oGBRZonYIyzmErV17gi9hPqJ7GmOCcToXcf4xOk5YIVFQ93P3lX\n 0ORxpzFhmIX1nk8RBAx1u5YFg2JmZvDRwVVrATdVekzaYzVAatWIVReGiMenBmzUPsZh\n 6rEA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=m6OL7pgoqyLwVGSBretiCVE6yK1LNicxN0enE1mBvwY=;\n b=O25WHuVcuTkiGbyQ4eEJ3WEKkTWntHMlj5BOnh6TssrS7tGiSwslizadEEDNoHgEZz\n oqtFhqSBcAcCk7ODTOfGbU6K3VMeAp+n8qhcEb0qMVvovo185ZosxWDcPusrskI4gW1b\n PZGO6WNn+WnO95U9tnhGg7ha/E+g4y9PCL1espEpqmT4LrXlDAVxxhj3FKDPYv+R3JVt\n 5gNET1Xd7pVjOMjU+uzrzUE8dRh8txnPD6n5ILL03dlODd9js1tM4IWosfOJaBwGLJOs\n hEMYIkkKb77yoOnO9wrZhTqnN710T4iD16e+ILT8jg9ARsC8WeWL6PrydA1yii9QtFSE\n 86bg==", "X-Gm-Message-State": "AGi0PuY0HrMmOA4j3lyLDTYe65srB2wlcKhWGRqir3XP5g+pp+fzoS4G\n KaZk7h3t1tP5YiQdK0Jt0ct4uF1TTBc=", "X-Google-Smtp-Source": "\n APiQypK6xCHa4FsbLJ6TGeiXYmQBt67MHOHEySp4QLwuFQvwS2f3RJzC2hh7eEsDlePgZ9TNlDawnw==", "X-Received": "by 2002:a2e:a16d:: with SMTP id\n u13mr12957548ljl.140.1585750898503;\n Wed, 01 Apr 2020 07:21:38 -0700 (PDT)", "From": "Michal Krawczyk <mk@semihalf.com>", "To": "dev@dpdk.org", "Cc": "mw@semihalf.com, mba@semihalf.com, gtzalik@amazon.com, evgenys@amazon.com,\n igorch@amazon.com, Michal Krawczyk <mk@semihalf.com>", "Date": "Wed, 1 Apr 2020 16:20:59 +0200", "Message-Id": "<20200401142127.13715-2-mk@semihalf.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200401142127.13715-1-mk@semihalf.com>", "References": "<20200401142127.13715-1-mk@semihalf.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 01/29] net/ena: check if size of buffer is at\n\tleast 1400B", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Some of the ENA devices can't handle buffers which are smaller than a\n1400B. Because of this limitation, size of the buffer is being checked\nand limited during the Rx queue setup.\n\nIf it's below the allowed value, PMD won't finish it's configuration\nsuccessfully..\n\nSigned-off-by: Michal Krawczyk <mk@semihalf.com>\nReviewed-by: Igor Chauskin <igorch@amazon.com>\nReviewed-by: Guy Tzalik <gtzalik@amazon.com>\n---\nv2:\n * Remove debug printout\n * Change the way of acquiring mempool size\n\n drivers/net/ena/ena_ethdev.c | 10 ++++++++++\n drivers/net/ena/ena_ethdev.h | 1 +\n 2 files changed, 11 insertions(+)", "diff": "diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c\nindex 665afee4f0..292526466c 100644\n--- a/drivers/net/ena/ena_ethdev.c\n+++ b/drivers/net/ena/ena_ethdev.c\n@@ -1282,6 +1282,7 @@ static int ena_rx_queue_setup(struct rte_eth_dev *dev,\n {\n \tstruct ena_adapter *adapter = dev->data->dev_private;\n \tstruct ena_ring *rxq = NULL;\n+\tsize_t buffer_size;\n \tint i;\n \n \trxq = &adapter->rx_ring[queue_idx];\n@@ -1309,6 +1310,15 @@ static int ena_rx_queue_setup(struct rte_eth_dev *dev,\n \t\treturn -EINVAL;\n \t}\n \n+\t/* ENA isn't supporting buffers smaller than 1400 bytes */\n+\tbuffer_size = rte_pktmbuf_data_room_size(mp) - RTE_PKTMBUF_HEADROOM;\n+\tif (buffer_size < ENA_RX_BUF_MIN_SIZE) {\n+\t\tPMD_DRV_LOG(ERR,\n+\t\t\t\"Unsupported size of RX buffer: %zu (min size: %d)\\n\",\n+\t\t\tbuffer_size, ENA_RX_BUF_MIN_SIZE);\n+\t\treturn -EINVAL;\n+\t}\n+\n \trxq->port_id = dev->data->port_id;\n \trxq->next_to_clean = 0;\n \trxq->next_to_use = 0;\ndiff --git a/drivers/net/ena/ena_ethdev.h b/drivers/net/ena/ena_ethdev.h\nindex af5eeea280..c1457defeb 100644\n--- a/drivers/net/ena/ena_ethdev.h\n+++ b/drivers/net/ena/ena_ethdev.h\n@@ -20,6 +20,7 @@\n #define ENA_MIN_FRAME_LEN\t64\n #define ENA_NAME_MAX_LEN\t20\n #define ENA_PKT_MAX_BUFS\t17\n+#define ENA_RX_BUF_MIN_SIZE\t1400\n \n #define ENA_MIN_MTU\t\t128\n \n", "prefixes": [ "v2", "01/29" ] }