Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/67388/?format=api
{ "id": 67388, "url": "https://patches.dpdk.org/api/patches/67388/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200330041026.784624-6-dmitry.kozliuk@gmail.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200330041026.784624-6-dmitry.kozliuk@gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200330041026.784624-6-dmitry.kozliuk@gmail.com", "date": "2020-03-30T04:10:22", "name": "[RFC,5/9] eal: introduce internal wrappers for file operations", "commit_ref": null, "pull_url": null, "state": "rfc", "archived": true, "hash": "59f2610cf6ec34b88cdd6a36ed75905a29dba7fd", "submitter": { "id": 1581, "url": "https://patches.dpdk.org/api/people/1581/?format=api", "name": "Dmitry Kozlyuk", "email": "dmitry.kozliuk@gmail.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200330041026.784624-6-dmitry.kozliuk@gmail.com/mbox/", "series": [ { "id": 9088, "url": "https://patches.dpdk.org/api/series/9088/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=9088", "date": "2020-03-30T04:10:17", "name": "Windows basic memory management", "version": 1, "mbox": "https://patches.dpdk.org/series/9088/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/67388/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/67388/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0FC7EA0562;\n\tMon, 30 Mar 2020 06:11:26 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6D7951C0AA;\n\tMon, 30 Mar 2020 06:10:48 +0200 (CEST)", "from mail-lf1-f67.google.com (mail-lf1-f67.google.com\n [209.85.167.67]) by dpdk.org (Postfix) with ESMTP id 715F71C02D\n for <dev@dpdk.org>; Mon, 30 Mar 2020 06:10:43 +0200 (CEST)", "by mail-lf1-f67.google.com with SMTP id t16so12123014lfl.2\n for <dev@dpdk.org>; Sun, 29 Mar 2020 21:10:43 -0700 (PDT)", "from localhost.localdomain (broadband-37-110-65-23.ip.moscow.rt.ru.\n [37.110.65.23])\n by smtp.googlemail.com with ESMTPSA id c22sm6210036lja.86.2020.03.29.21.10.41\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 29 Mar 2020 21:10:42 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=kRuOpY95+Geg1/zp607Zcl+mSxcFIH4YiwhygeqAqo8=;\n b=chB8OYea8/gvLHlJQ1X3shxw7o0EWGjhcMFns0CHGPPCDQtq8PUIvODyP57HGPYpN1\n jSio8ajYQe3ILiCr0NsmcJa+IJ7L/aAYBjigxhaJ2Xb97HFvJTSZR56Ix2EpPejtTz9c\n LoA95NdyWouUrRexPqVNy6gHl+YKi7YQ7+ADvEXYBYjNxJCVIpJZ9tbZ+vC9wQ1juLIO\n 6s2nBymBzs9a3RXIw1zt9+2C1sgQ0+spflmcXb4meYD8Wy0fk90lWOLYLqtSfrRyhHXE\n STSsBejl+dZSAjdOu8iadq+8prh27AAmlSpW6xIJIfHsfdqGjBvHV85G7rnj8oJrrKWe\n Eezw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=kRuOpY95+Geg1/zp607Zcl+mSxcFIH4YiwhygeqAqo8=;\n b=C7ahM5Kmoqe0+/6vOKh/g6PwMKWwbq1C0weHxTvm5Fj6Qc/MBcENoa6O61UU30dPm7\n AYcTjHIs7gVB8V4KxOXNqQfbOX/PXrVMbx7Ix3CEdOAZ00CENitmMvGr5u3PKPdhrJAD\n AUuSN2VOFfp7Pk7/3Gcy28XdYGSRXQaxoB0qznIHmkaqX8Di2BDXivB3IZRp4G5cgDYB\n 8hKMSUcdczl6BFcM8T2Vg6e/IVMbPBIF1aEeYyWnInqoz0zG635MO8fizkcfGQIklaei\n Ju8qwumwMhnD9TFt9xNNGtyQzUMK4fiumFGj1yEKJLQLybKl3br7qaCDHAef5DbMzV3H\n /HXg==", "X-Gm-Message-State": "AGi0PuYImpu+v08RWGrwk3ikoyk77Z2XdVr5YPO14Wgdi6Kw3/Vv7BjK\n FvwcrnTRRHtAK1qMGjj2TPs+tSHYOqahZg==", "X-Google-Smtp-Source": "\n APiQypJi3zakf1BYhs2MjtLpJXVQtJMe+GMpg5niF4p+gYkLYoc8s+x8KTBruotxFx832g4auvZJnQ==", "X-Received": "by 2002:a19:c515:: with SMTP id w21mr6717294lfe.72.1585541442654;\n Sun, 29 Mar 2020 21:10:42 -0700 (PDT)", "From": "Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>", "To": "dev@dpdk.org", "Cc": "\"Dmitry Malloy (MESHCHANINOV)\" <dmitrym@microsoft.com>,\n Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Harini Ramakrishnan <harini.ramakrishnan@microsoft.com>,\n Omar Cardona <ocardona@microsoft.com>,\n Pallavi Kadam <pallavi.kadam@intel.com>,\n Ranjit Menon <ranjit.menon@intel.com>", "Date": "Mon, 30 Mar 2020 07:10:22 +0300", "Message-Id": "<20200330041026.784624-6-dmitry.kozliuk@gmail.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200330041026.784624-1-dmitry.kozliuk@gmail.com>", "References": "<20200330041026.784624-1-dmitry.kozliuk@gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [RFC PATCH 5/9] eal: introduce internal wrappers for\n\tfile operations", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "EAL common code uses file locking and truncation. Introduce\nOS-independent wrapeprs in order to support both POSIX and Windows:\n\n* eal_file_lock: lock or unlock an open file.\n* eal_file_truncate: enforce a given size for an open file.\n\nWrappers follow POSIX semantics, but interface is not POSIX,\nso that it can be made more clean, e.g. by not mixing locking\noperation and behaviour on conflict.\n\nSigned-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>\n\nWIP2\n---\n lib/librte_eal/common/eal_private.h | 45 ++++++++++++++++\n lib/librte_eal/freebsd/eal/eal.c | 40 ++++++++++++++\n lib/librte_eal/linux/eal/eal.c | 40 ++++++++++++++\n lib/librte_eal/windows/eal/eal.c | 83 +++++++++++++++++++++++++++++\n 4 files changed, 208 insertions(+)", "diff": "diff --git a/lib/librte_eal/common/eal_private.h b/lib/librte_eal/common/eal_private.h\nindex ddcfbe2e4..0130571e8 100644\n--- a/lib/librte_eal/common/eal_private.h\n+++ b/lib/librte_eal/common/eal_private.h\n@@ -443,4 +443,49 @@ rte_option_usage(void);\n uint64_t\n eal_get_baseaddr(void);\n \n+/** File locking operation. */\n+enum rte_flock_op {\n+\tRTE_FLOCK_SHARED, /**< Acquire a shared lock. */\n+\tRTE_FLOCK_EXCLUSIVE, /**< Acquire an exclusive lock. */\n+\tRTE_FLOCK_UNLOCK /**< Release a previously taken lock. */\n+};\n+\n+/** Behavior on file locking conflict. */\n+enum rte_flock_mode {\n+\tRTE_FLOCK_WAIT, /**< Wait until the file gets unlocked to lock it. */\n+\tRTE_FLOCK_RETURN /**< Return immediately if the file is locked. */\n+};\n+\n+/**\n+ * Lock or unlock the file.\n+ *\n+ * On failure @code rte_errno @endcode is set to the error code\n+ * specified by POSIX flock(3) description.\n+ *\n+ * @param fd\n+ * Opened file descriptor.\n+ * @param op\n+ * Operation to perform.\n+ * @param mode\n+ * Behavior on conflict.\n+ * @return\n+ * 0 on success, (-1) on failure.\n+ */\n+int eal_file_lock(int fd, enum rte_flock_op op, enum rte_flock_mode mode);\n+\n+/**\n+ * Truncate or extend the file to the specified size.\n+ *\n+ * On failure @code rte_errno @endcode is set to the error code\n+ * specified by POSIX ftruncate(3) description.\n+ *\n+ * @param fd\n+ * Opened file descriptor.\n+ * @param size\n+ * Desired file size.\n+ * @return\n+ * 0 on success, (-1) on failure.\n+ */\n+int eal_file_truncate(int fd, ssize_t size);\n+\n #endif /* _EAL_PRIVATE_H_ */\ndiff --git a/lib/librte_eal/freebsd/eal/eal.c b/lib/librte_eal/freebsd/eal/eal.c\nindex 6ae37e7e6..4bbcc7ab7 100644\n--- a/lib/librte_eal/freebsd/eal/eal.c\n+++ b/lib/librte_eal/freebsd/eal/eal.c\n@@ -697,6 +697,46 @@ static void rte_eal_init_alert(const char *msg)\n \tRTE_LOG(ERR, EAL, \"%s\\n\", msg);\n }\n \n+int\n+eal_file_truncate(int fd, ssize_t size)\n+{\n+\tint ret;\n+\n+\tret = ftruncate(fd, size);\n+\tif (ret)\n+\t\trte_errno = errno;\n+\n+\treturn ret;\n+}\n+\n+int\n+eal_file_lock(int fd, enum rte_flock_op op, enum rte_flock_mode mode)\n+{\n+\tint sys_flags = 0;\n+\tint ret;\n+\n+\tif (mode == RTE_FLOCK_RETURN)\n+\t\tsys_flags |= LOCK_NB;\n+\n+\tswitch (op) {\n+\tcase RTE_FLOCK_EXCLUSIVE:\n+\t\tsys_flags |= LOCK_EX;\n+\t\tbreak;\n+\tcase RTE_FLOCK_SHARED:\n+\t\tsys_flags |= LOCK_SH;\n+\t\tbreak;\n+\tcase RTE_FLOCK_UNLOCK:\n+\t\tsys_flags |= LOCK_UN;\n+\t\tbreak;\n+\t}\n+\n+\tret = flock(fd, sys_flags);\n+\tif (ret)\n+\t\trte_errno = errno;\n+\n+\treturn ret;\n+}\n+\n /* Launch threads, called at application init(). */\n int\n rte_eal_init(int argc, char **argv)\ndiff --git a/lib/librte_eal/linux/eal/eal.c b/lib/librte_eal/linux/eal/eal.c\nindex 9530ee55f..d75c162c1 100644\n--- a/lib/librte_eal/linux/eal/eal.c\n+++ b/lib/librte_eal/linux/eal/eal.c\n@@ -956,6 +956,46 @@ is_iommu_enabled(void)\n \treturn n > 2;\n }\n \n+int\n+eal_file_truncate(int fd, ssize_t size)\n+{\n+\tint ret;\n+\n+\tret = ftruncate(fd, size);\n+\tif (ret)\n+\t\trte_errno = errno;\n+\n+\treturn ret;\n+}\n+\n+int\n+eal_file_lock(int fd, enum rte_flock_op op, enum rte_flock_mode mode)\n+{\n+\tint sys_flags = 0;\n+\tint ret;\n+\n+\tif (mode == RTE_FLOCK_RETURN)\n+\t\tsys_flags |= LOCK_NB;\n+\n+\tswitch (op) {\n+\tcase RTE_FLOCK_EXCLUSIVE:\n+\t\tsys_flags |= LOCK_EX;\n+\t\tbreak;\n+\tcase RTE_FLOCK_SHARED:\n+\t\tsys_flags |= LOCK_SH;\n+\t\tbreak;\n+\tcase RTE_FLOCK_UNLOCK:\n+\t\tsys_flags |= LOCK_UN;\n+\t\tbreak;\n+\t}\n+\n+\tret = flock(fd, sys_flags);\n+\tif (ret)\n+\t\trte_errno = errno;\n+\n+\treturn ret;\n+}\n+\n /* Launch threads, called at application init(). */\n int\n rte_eal_init(int argc, char **argv)\ndiff --git a/lib/librte_eal/windows/eal/eal.c b/lib/librte_eal/windows/eal/eal.c\nindex a84b6147a..4932185ec 100644\n--- a/lib/librte_eal/windows/eal/eal.c\n+++ b/lib/librte_eal/windows/eal/eal.c\n@@ -224,6 +224,89 @@ rte_eal_init_alert(const char *msg)\n \tRTE_LOG(ERR, EAL, \"%s\\n\", msg);\n }\n \n+int\n+eal_file_truncate(int fd, ssize_t size)\n+{\n+\tHANDLE handle;\n+\tDWORD ret;\n+\tLONG low = (LONG)((size_t)size);\n+\tLONG high = (LONG)((size_t)size >> 32);\n+\n+\thandle = (HANDLE)_get_osfhandle(fd);\n+\tif (handle == INVALID_HANDLE_VALUE) {\n+\t\trte_errno = EBADF;\n+\t\treturn -1;\n+\t}\n+\n+\tret = SetFilePointer(handle, low, &high, FILE_BEGIN);\n+\tif (ret == INVALID_SET_FILE_POINTER) {\n+\t\tRTE_LOG_WIN32_ERR(\"SetFilePointer()\");\n+\t\trte_errno = EINVAL;\n+\t\treturn -1;\n+\t}\n+\n+\treturn 0;\n+}\n+\n+static int\n+lock_file(HANDLE handle, enum rte_flock_op op, enum rte_flock_mode mode)\n+{\n+\tDWORD sys_flags = 0;\n+\tOVERLAPPED overlapped;\n+\n+\tif (op == RTE_FLOCK_EXCLUSIVE)\n+\t\tsys_flags |= LOCKFILE_EXCLUSIVE_LOCK;\n+\tif (mode == RTE_FLOCK_RETURN)\n+\t\tsys_flags |= LOCKFILE_FAIL_IMMEDIATELY;\n+\n+\tmemset(&overlapped, 0, sizeof(overlapped));\n+\tif (!LockFileEx(handle, sys_flags, 0, 0, 0, &overlapped)) {\n+\t\tif ((sys_flags & LOCKFILE_FAIL_IMMEDIATELY) &&\n+\t\t\t(GetLastError() == ERROR_IO_PENDING)) {\n+\t\t\trte_errno = EWOULDBLOCK;\n+\t\t} else {\n+\t\t\tRTE_LOG_WIN32_ERR(\"LockFileEx()\");\n+\t\t\trte_errno = EINVAL;\n+\t\t}\n+\t\treturn -1;\n+\t}\n+\n+\treturn 0;\n+}\n+\n+static int\n+unlock_file(HANDLE handle)\n+{\n+\tif (!UnlockFileEx(handle, 0, 0, 0, NULL)) {\n+\t\tRTE_LOG_WIN32_ERR(\"UnlockFileEx()\");\n+\t\trte_errno = EINVAL;\n+\t\treturn -1;\n+\t}\n+\treturn 0;\n+}\n+\n+int\n+eal_file_lock(int fd, enum rte_flock_op op, enum rte_flock_mode mode)\n+{\n+\tHANDLE handle = (HANDLE)_get_osfhandle(fd);\n+\n+\tif (handle == INVALID_HANDLE_VALUE) {\n+\t\trte_errno = EBADF;\n+\t\treturn -1;\n+\t}\n+\n+\tswitch (op) {\n+\tcase RTE_FLOCK_EXCLUSIVE:\n+\tcase RTE_FLOCK_SHARED:\n+\t\treturn lock_file(handle, op, mode);\n+\tcase RTE_FLOCK_UNLOCK:\n+\t\treturn unlock_file(handle);\n+\tdefault:\n+\t\trte_errno = EINVAL;\n+\t\treturn -1;\n+\t}\n+}\n+\n /* Launch threads, called at application init(). */\n int\n rte_eal_init(int argc, char **argv)\n", "prefixes": [ "RFC", "5/9" ] }