Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/67276/?format=api
{ "id": 67276, "url": "https://patches.dpdk.org/api/patches/67276/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200327101823.12646-3-mk@semihalf.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200327101823.12646-3-mk@semihalf.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200327101823.12646-3-mk@semihalf.com", "date": "2020-03-27T10:17:56", "name": "[02/29] net/ena/base: make allocation macros thread-safe", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "1c5da466d7154443318ce32d65b56b43600aa124", "submitter": { "id": 786, "url": "https://patches.dpdk.org/api/people/786/?format=api", "name": "Michal Krawczyk", "email": "mk@semihalf.com" }, "delegate": { "id": 3961, "url": "https://patches.dpdk.org/api/users/3961/?format=api", "username": "arybchenko", "first_name": "Andrew", "last_name": "Rybchenko", "email": "andrew.rybchenko@oktetlabs.ru" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200327101823.12646-3-mk@semihalf.com/mbox/", "series": [ { "id": 9077, "url": "https://patches.dpdk.org/api/series/9077/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=9077", "date": "2020-03-27T10:17:54", "name": "Update ENA driver to v2.1.0", "version": 1, "mbox": "https://patches.dpdk.org/series/9077/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/67276/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/67276/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 593ABA0589;\n\tFri, 27 Mar 2020 11:29:31 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C98761C0B2;\n\tFri, 27 Mar 2020 11:29:16 +0100 (CET)", "from mail-lf1-f67.google.com (mail-lf1-f67.google.com\n [209.85.167.67]) by dpdk.org (Postfix) with ESMTP id 2547A1C07D\n for <dev@dpdk.org>; Fri, 27 Mar 2020 11:29:13 +0100 (CET)", "by mail-lf1-f67.google.com with SMTP id x200so250556lff.0\n for <dev@dpdk.org>; Fri, 27 Mar 2020 03:29:13 -0700 (PDT)", "from localhost.localdomain (193-106-246-138.noc.fibertech.net.pl.\n [193.106.246.138])\n by smtp.gmail.com with ESMTPSA id i11sm2789587lfo.84.2020.03.27.03.29.11\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 27 Mar 2020 03:29:11 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=semihalf-com.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=ICA0f/rv2hWQhgRjJy3CwEjffjIxOgG4Dk8l0SUlyfc=;\n b=u2ZCrT97gvYIVY9zRdOAzn1/6SNST9awP7Iy1skbIBzyTxrJgtOE0x108nYeo9pKzB\n pGmfq6umVlhXfh62yupbtb3KdHjMTGVipGiZsNmbn+buN7iBfYPA8nKcohnh7xuAr6ZK\n b019WoU1vAFR1dL1/MGcgzzPrddg9S9l9HQ7SoJ52bPFNJpazXp1xTkupnacUb3xXmCz\n pNn7leUx4pnH6kfZepdQFGi7bpsp1DTuWgjALq1FBj+CotGng309eYTZojcq6XTqh3kM\n EvDgXc7EtH5s9kM0MoaLGmflaY1M3L0J9TsFyA5X/FPgtjZgsUa24pehS1mxREoykmDU\n YsJA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=ICA0f/rv2hWQhgRjJy3CwEjffjIxOgG4Dk8l0SUlyfc=;\n b=eu1ALen/TLLdFrTShC43ys1oJSo+LQ4bc1m0+WoyK3Zppq+xrFnB8pzxAETMcog+wn\n ywDf4+lExn3mGhT0BZVwnYJuaY+Jjh9t36hqKY82OYK772Bb9x/QADazpgQ1G5bcRh0n\n GN+uiU8A1K9XVCWCP809GMZw90YvLTU6Nqqif+D713Ks6KnEH6QbqP0ow+EW0nvMKsOQ\n XO8j7Xp352YOyC1tdiecq8nBZAi09/lxqXzhhQIxmXFHCKDDdzp0ZyXMARTQb+7Hn9jL\n Yn21JdceTltpAK6D9b+cMYjUx5luQBus818AtnxmzjbgV/0ELjyjDkUzJrE8WwJXRTs/\n mpbw==", "X-Gm-Message-State": "ANhLgQ0vfZRKRKbb2rjqL7/8vuNaEex6IYt1NoEbE9PpHZ4vyhEv5BPx\n p234qwqtD/rCPgfWOcHEY039yDMfQYo=", "X-Google-Smtp-Source": "\n ADFU+vttr+HyjN9zbnaPE49H3gP6TsxZleUBHw8MGUxzZWv3Ft/XNwE0zd8MQN0FEYYhCCdAi0js4g==", "X-Received": "by 2002:a19:1d6:: with SMTP id 205mr8744959lfb.80.1585304952419;\n Fri, 27 Mar 2020 03:29:12 -0700 (PDT)", "From": "Michal Krawczyk <mk@semihalf.com>", "To": "dev@dpdk.org", "Cc": "mw@semihalf.com, mba@semihalf.com, gtzalik@amazon.com, evgenys@amazon.com,\n igorch@amazon.com, stable@dpdk.org, Michal Krawczyk <mk@semihalf.com>", "Date": "Fri, 27 Mar 2020 11:17:56 +0100", "Message-Id": "<20200327101823.12646-3-mk@semihalf.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200327101823.12646-1-mk@semihalf.com>", "References": "<20200327101823.12646-1-mk@semihalf.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 02/29] net/ena/base: make allocation macros\n\tthread-safe", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Igor Chauskin <igorch@amazon.com>\n\nMemory allocation region id could possibly be non-unique\ndue to non-atomic increment, causing allocation failure.\n\nFixes: 9ba7981ec992 (\"ena: add communication layer for DPDK\")\nCc: stable@dpdk.org\n\nSigned-off-by: Igor Chauskin <igorch@amazon.com>\nReviewed-by: Michal Krawczyk <mk@semihalf.com>\nReviewed-by: Guy Tzalik <gtzalik@amazon.com>\n---\n drivers/net/ena/base/ena_plat_dpdk.h | 8 +++++---\n drivers/net/ena/ena_ethdev.c | 2 +-\n 2 files changed, 6 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ena/base/ena_plat_dpdk.h b/drivers/net/ena/base/ena_plat_dpdk.h\nindex b611fb204b..192bbaefcf 100644\n--- a/drivers/net/ena/base/ena_plat_dpdk.h\n+++ b/drivers/net/ena/base/ena_plat_dpdk.h\n@@ -180,7 +180,7 @@ do { \\\n * Each rte_memzone should have unique name.\n * To satisfy it, count number of allocations and add it to name.\n */\n-extern uint32_t ena_alloc_cnt;\n+extern rte_atomic32_t ena_alloc_cnt;\n \n #define ENA_MEM_ALLOC_COHERENT(dmadev, size, virt, phys, handle)\t\\\n \tdo {\t\t\t\t\t\t\t\t\\\n@@ -188,7 +188,8 @@ extern uint32_t ena_alloc_cnt;\n \t\tchar z_name[RTE_MEMZONE_NAMESIZE];\t\t\t\\\n \t\tENA_TOUCH(dmadev); ENA_TOUCH(handle);\t\t\t\\\n \t\tsnprintf(z_name, sizeof(z_name),\t\t\t\\\n-\t\t\t\t\"ena_alloc_%d\", ena_alloc_cnt++);\t\\\n+\t\t\t \"ena_alloc_%d\",\t\t\t\t\\\n+\t\t\t rte_atomic32_add_return(&ena_alloc_cnt, 1));\t\\\n \t\tmz = rte_memzone_reserve(z_name, size, SOCKET_ID_ANY,\t\\\n \t\t\t\tRTE_MEMZONE_IOVA_CONTIG);\t\t\\\n \t\thandle = mz;\t\t\t\t\t\t\\\n@@ -213,7 +214,8 @@ extern uint32_t ena_alloc_cnt;\n \t\tchar z_name[RTE_MEMZONE_NAMESIZE];\t\t\t\\\n \t\tENA_TOUCH(dmadev); ENA_TOUCH(dev_node);\t\t\t\\\n \t\tsnprintf(z_name, sizeof(z_name),\t\t\t\\\n-\t\t\t\t\"ena_alloc_%d\", ena_alloc_cnt++);\t\\\n+\t\t\t \"ena_alloc_%d\",\t\t\t\t\\\n+\t\t\t rte_atomic32_add_return(&ena_alloc_cnt, 1));\t\\\n \t\tmz = rte_memzone_reserve(z_name, size, node,\t\t\\\n \t\t\t\tRTE_MEMZONE_IOVA_CONTIG);\t\t\\\n \t\tmem_handle = mz;\t\t\t\t\t\\\ndiff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c\nindex a8f8784a9f..cab38152a7 100644\n--- a/drivers/net/ena/ena_ethdev.c\n+++ b/drivers/net/ena/ena_ethdev.c\n@@ -89,7 +89,7 @@ struct ena_stats {\n * Each rte_memzone should have unique name.\n * To satisfy it, count number of allocation and add it to name.\n */\n-uint32_t ena_alloc_cnt;\n+rte_atomic32_t ena_alloc_cnt;\n \n static const struct ena_stats ena_stats_global_strings[] = {\n \tENA_STAT_GLOBAL_ENTRY(wd_expired),\n", "prefixes": [ "02/29" ] }