Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/67267/?format=api
{ "id": 67267, "url": "https://patches.dpdk.org/api/patches/67267/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200327165412.87359-3-yong.liu@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200327165412.87359-3-yong.liu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200327165412.87359-3-yong.liu@intel.com", "date": "2020-03-27T16:54:07", "name": "[v2,2/7] net/virtio-user: add vectorized packed ring parameter", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "0306b497794d06610c7ceb519d717b80140b1776", "submitter": { "id": 17, "url": "https://patches.dpdk.org/api/people/17/?format=api", "name": "Marvin Liu", "email": "yong.liu@intel.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200327165412.87359-3-yong.liu@intel.com/mbox/", "series": [ { "id": 9075, "url": "https://patches.dpdk.org/api/series/9075/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=9075", "date": "2020-03-27T16:54:05", "name": "add packed ring vectorized datapath", "version": 2, "mbox": "https://patches.dpdk.org/series/9075/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/67267/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/67267/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 26B26A0589;\n\tFri, 27 Mar 2020 10:18:32 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4DDF61C0C3;\n\tFri, 27 Mar 2020 10:18:18 +0100 (CET)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n by dpdk.org (Postfix) with ESMTP id BFC151C0AD\n for <dev@dpdk.org>; Fri, 27 Mar 2020 10:18:11 +0100 (CET)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 27 Mar 2020 02:18:10 -0700", "from npg-dpdk-virtual-marvin-dev.sh.intel.com ([10.67.119.58])\n by fmsmga004.fm.intel.com with ESMTP; 27 Mar 2020 02:18:09 -0700" ], "IronPort-SDR": [ "\n iEtqmbFxhZTTsaAV0U+H8l7bXHqTa5gcGiWtdy5VEkMeheJ4M56Jk65pdOy17OUaMPDJs4wpKE\n g7oD9zsNwtqg==", "\n qpBajI2fjIVVqCgClJhfdMs3l3WoLyCYJfBxk7qA0kCYyOKl413HJDvADI01e4dEeTC+lUAP6I\n 6waHPi2yDgaA==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.72,311,1580803200\"; d=\"scan'208\";a=\"271507890\"", "From": "Marvin Liu <yong.liu@intel.com>", "To": "maxime.coquelin@redhat.com, xiaolong.ye@intel.com, zhihong.wang@intel.com", "Cc": "dev@dpdk.org,\n\tMarvin Liu <yong.liu@intel.com>", "Date": "Sat, 28 Mar 2020 00:54:07 +0800", "Message-Id": "<20200327165412.87359-3-yong.liu@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200327165412.87359-1-yong.liu@intel.com>", "References": "<20200313174230.74661-1-yong.liu@intel.com>\n <20200327165412.87359-1-yong.liu@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 2/7] net/virtio-user: add vectorized packed\n\tring parameter", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add new parameter \"packed_vec\" which can disable vectorized packed ring\ndatapath explicitly. When \"packed_vec\" option is on, driver will check\npacked ring vectorized datapath prerequisites. If any one of them not\nmatched, vectorized datapath won't be selected.\n\nSigned-off-by: Marvin Liu <yong.liu@intel.com>", "diff": "diff --git a/drivers/net/virtio/virtio_pci.h b/drivers/net/virtio/virtio_pci.h\nindex 7433d2f08..8103b7a18 100644\n--- a/drivers/net/virtio/virtio_pci.h\n+++ b/drivers/net/virtio/virtio_pci.h\n@@ -251,6 +251,8 @@ struct virtio_hw {\n \tuint8_t\t use_msix;\n \tuint8_t modern;\n \tuint8_t use_simple_rx;\n+\tuint8_t packed_vec_rx;\n+\tuint8_t packed_vec_tx;\n \tuint8_t use_inorder_rx;\n \tuint8_t use_inorder_tx;\n \tuint8_t weak_barriers;\ndiff --git a/drivers/net/virtio/virtio_user_ethdev.c b/drivers/net/virtio/virtio_user_ethdev.c\nindex e61af4068..2608b1fae 100644\n--- a/drivers/net/virtio/virtio_user_ethdev.c\n+++ b/drivers/net/virtio/virtio_user_ethdev.c\n@@ -450,6 +450,8 @@ static const char *valid_args[] = {\n \tVIRTIO_USER_ARG_IN_ORDER,\n #define VIRTIO_USER_ARG_PACKED_VQ \"packed_vq\"\n \tVIRTIO_USER_ARG_PACKED_VQ,\n+#define VIRTIO_USER_ARG_PACKED_VEC \"packed_vec\"\n+\tVIRTIO_USER_ARG_PACKED_VEC,\n \tNULL\n };\n \n@@ -552,6 +554,8 @@ virtio_user_pmd_probe(struct rte_vdev_device *dev)\n \tuint64_t mrg_rxbuf = 1;\n \tuint64_t in_order = 1;\n \tuint64_t packed_vq = 0;\n+\tuint64_t packed_vec = 1;\n+\n \tchar *path = NULL;\n \tchar *ifname = NULL;\n \tchar *mac_addr = NULL;\n@@ -668,6 +672,15 @@ virtio_user_pmd_probe(struct rte_vdev_device *dev)\n \t\t}\n \t}\n \n+\tif (rte_kvargs_count(kvlist, VIRTIO_USER_ARG_PACKED_VEC) == 1) {\n+\t\tif (rte_kvargs_process(kvlist, VIRTIO_USER_ARG_PACKED_VEC,\n+\t\t\t\t &get_integer_arg, &packed_vec) < 0) {\n+\t\t\tPMD_INIT_LOG(ERR, \"error to parse %s\",\n+\t\t\t\t VIRTIO_USER_ARG_PACKED_VQ);\n+\t\t\tgoto end;\n+\t\t}\n+\t}\n+\n \tif (queues > 1 && cq == 0) {\n \t\tPMD_INIT_LOG(ERR, \"multi-q requires ctrl-q\");\n \t\tgoto end;\n@@ -705,6 +718,17 @@ virtio_user_pmd_probe(struct rte_vdev_device *dev)\n \t}\n \n \thw = eth_dev->data->dev_private;\n+#if defined(RTE_ARCH_X86) && defined(CC_AVX512_SUPPORT)\n+\tif (packed_vec) {\n+\t\thw->packed_vec_rx = 1;\n+\t\thw->packed_vec_tx = 1;\n+\t}\n+#else\n+\tif (packed_vec)\n+\t\tPMD_INIT_LOG(ERR, \"building environment not match vectorized \"\n+\t\t\t\t \"packed ring datapath requirement\");\n+#endif\n+\n \tif (virtio_user_dev_init(hw->virtio_user_dev, path, queues, cq,\n \t\t\t queue_size, mac_addr, &ifname, server_mode,\n \t\t\t mrg_rxbuf, in_order, packed_vq) < 0) {\n@@ -777,4 +801,5 @@ RTE_PMD_REGISTER_PARAM_STRING(net_virtio_user,\n \t\"server=<0|1> \"\n \t\"mrg_rxbuf=<0|1> \"\n \t\"in_order=<0|1> \"\n-\t\"packed_vq=<0|1>\");\n+\t\"packed_vq=<0|1>\"\n+\t\"packed_vec=<0|1>\");\n", "prefixes": [ "v2", "2/7" ] }