Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/66967/?format=api
{ "id": 66967, "url": "https://patches.dpdk.org/api/patches/66967/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1584672375-376187-13-git-send-email-alvinx.zhang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1584672375-376187-13-git-send-email-alvinx.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1584672375-376187-13-git-send-email-alvinx.zhang@intel.com", "date": "2020-03-20T02:46:13", "name": "[v2,12/14] net/igc: implement TCP SYN filter", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "e9cb6bdb6cdee60e528965d68ec3c941cd110c25", "submitter": { "id": 1398, "url": "https://patches.dpdk.org/api/people/1398/?format=api", "name": "Alvin Zhang", "email": "alvinx.zhang@intel.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1584672375-376187-13-git-send-email-alvinx.zhang@intel.com/mbox/", "series": [ { "id": 8992, "url": "https://patches.dpdk.org/api/series/8992/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=8992", "date": "2020-03-20T02:46:01", "name": "igc PMD", "version": 2, "mbox": "https://patches.dpdk.org/series/8992/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/66967/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/66967/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3304BA0583;\n\tFri, 20 Mar 2020 03:52:51 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 90BC61C0D2;\n\tFri, 20 Mar 2020 03:51:27 +0100 (CET)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n by dpdk.org (Postfix) with ESMTP id 03A571C0B8\n for <dev@dpdk.org>; Fri, 20 Mar 2020 03:51:16 +0100 (CET)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 19 Mar 2020 19:51:16 -0700", "from unknown (HELO dpdk-zhangalvin-dev.sh.intel.com)\n ([10.240.183.54])\n by fmsmga002.fm.intel.com with ESMTP; 19 Mar 2020 19:51:14 -0700" ], "IronPort-SDR": [ "\n X7DjMxbj7DGOd687ZptO23rpVaXNPl+VVFjlnC8iPRqxCdorxCFum6Mmml4aYwZY5KpHJsuvLT\n wEdXLy+FeDXw==", "\n z9Y3C+IY3YFECm/07MgQl7/KbeFIfAHqSgBFdeFYkeiwvev8AJ2J/93HJ81mU6FC2uwTmzJwj5\n GWSe2YNW/roQ==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.72,283,1580803200\"; d=\"scan'208\";a=\"280290274\"", "From": "alvinx.zhang@intel.com", "To": "dev@dpdk.org, xiaolong.ye@intel.com, haiyue.wang@intel.com,\n qi.z.zhang@intel.com, beilei.xing@intel.com", "Date": "Fri, 20 Mar 2020 10:46:13 +0800", "Message-Id": "<1584672375-376187-13-git-send-email-alvinx.zhang@intel.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1584672375-376187-1-git-send-email-alvinx.zhang@intel.com>", "References": "<1583742247-370386-1-git-send-email-alvinx.zhang@intel.com>\n <1584672375-376187-1-git-send-email-alvinx.zhang@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 12/14] net/igc: implement TCP SYN filter", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Alvin Zhang <alvinx.zhang@intel.com>\n\nSupport putting all TCP SYN packets into a specified queue.\n\nSigned-off-by: Alvin Zhang <alvinx.zhang@intel.com>\n---\n drivers/net/igc/igc_ethdev.h | 18 ++++++\n drivers/net/igc/igc_filter.c | 129 +++++++++++++++++++++++++++++++++++++++++++\n drivers/net/igc/igc_filter.h | 3 +\n 3 files changed, 150 insertions(+)", "diff": "diff --git a/drivers/net/igc/igc_ethdev.h b/drivers/net/igc/igc_ethdev.h\nindex 49075c8..91a3198 100644\n--- a/drivers/net/igc/igc_ethdev.h\n+++ b/drivers/net/igc/igc_ethdev.h\n@@ -101,6 +101,11 @@\n #define IGC_MAX_2TUPLE_FILTERS\t\t8\n #define IGC_2TUPLE_MAX_PRI\t\t7\n \n+#define IGC_SYN_FILTER_ENABLE\t\t0x01\t/* syn filter enable field */\n+#define IGC_SYN_FILTER_QUEUE_SHIFT\t1\t/* syn filter queue field */\n+#define IGC_SYN_FILTER_QUEUE\t0x0000000E\t/* syn filter queue field */\n+#define IGC_RFCTL_SYNQFP\t0x00080000\t/* SYNQFP in RFCTL register */\n+\n /* structure for interrupt relative data */\n struct igc_interrupt {\n \tuint32_t flags;\n@@ -175,6 +180,18 @@ struct igc_2tuple_filter {\n \tuint8_t queue;\n };\n \n+/* Structure of TCP SYN filter */\n+struct igc_syn_filter {\n+\tuint8_t queue;\n+\t/*\n+\t * Defines the priority between SYNQF and 2 tuple filter\n+\t * 0b = 2-tuple filter priority\n+\t * 1b = SYN filter priority\n+\t */\n+\tuint8_t priority:1,\n+\t\tenable:1;\t/* 1-enable; 0-disable */\n+};\n+\n /*\n * Structure to store private data for each driver instance (for each port).\n */\n@@ -191,6 +208,7 @@ struct igc_adapter {\n \n \tstruct igc_ethertype_filter ethertype_filters[IGC_MAX_ETQF_FILTERS];\n \tstruct igc_2tuple_filter tuple2_filters[IGC_MAX_2TUPLE_FILTERS];\n+\tstruct igc_syn_filter syn_filter;\n };\n \n #define IGC_DEV_PRIVATE(_dev)\t((_dev)->data->dev_private)\ndiff --git a/drivers/net/igc/igc_filter.c b/drivers/net/igc/igc_filter.c\nindex 340dbee..5203d82 100644\n--- a/drivers/net/igc/igc_filter.c\n+++ b/drivers/net/igc/igc_filter.c\n@@ -546,11 +546,136 @@\n \treturn ret;\n }\n \n+int\n+igc_set_syn_filter(struct rte_eth_dev *dev,\n+\t\tconst struct rte_eth_syn_filter *filter)\n+{\n+\tstruct igc_hw *hw;\n+\tstruct igc_adapter *igc;\n+\tstruct igc_syn_filter *syn_filter;\n+\tuint32_t synqf, rfctl;\n+\n+\tif (filter->queue >= IGC_QUEUE_PAIRS_NUM) {\n+\t\tPMD_DRV_LOG(ERR, \"out of range queue %u(max is %u)\",\n+\t\t\tfilter->queue, IGC_QUEUE_PAIRS_NUM);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tigc = IGC_DEV_PRIVATE(dev);\n+\tsyn_filter = &igc->syn_filter;\n+\n+\tif (syn_filter->enable) {\n+\t\tPMD_DRV_LOG(ERR, \"SYN filter has been enabled before!\");\n+\t\treturn -EEXIST;\n+\t}\n+\n+\thw = IGC_DEV_PRIVATE_HW(dev);\n+\tsynqf = (uint32_t)filter->queue << IGC_SYN_FILTER_QUEUE_SHIFT;\n+\tsynqf |= IGC_SYN_FILTER_ENABLE;\n+\n+\trfctl = IGC_READ_REG(hw, IGC_RFCTL);\n+\tif (filter->hig_pri) {\n+\t\tsyn_filter->priority = 1;\n+\t\trfctl |= IGC_RFCTL_SYNQFP;\n+\t} else {\n+\t\tsyn_filter->priority = 0;\n+\t\trfctl &= ~IGC_RFCTL_SYNQFP;\n+\t}\n+\n+\tsyn_filter->enable = 1;\n+\tsyn_filter->queue = filter->queue;\n+\tIGC_WRITE_REG(hw, IGC_RFCTL, rfctl);\n+\tIGC_WRITE_REG(hw, IGC_SYNQF(0), synqf);\n+\tIGC_WRITE_FLUSH(hw);\n+\treturn 0;\n+}\n+\n+int\n+igc_del_syn_filter(struct rte_eth_dev *dev)\n+{\n+\tstruct igc_hw *hw = IGC_DEV_PRIVATE_HW(dev);\n+\tstruct igc_adapter *igc = IGC_DEV_PRIVATE(dev);\n+\tstruct igc_syn_filter *syn_filter = &igc->syn_filter;\n+\n+\tif (syn_filter->enable == 0)\n+\t\treturn 0;\n+\n+\tsyn_filter->enable = 0;\n+\n+\tIGC_WRITE_REG(hw, IGC_SYNQF(0), 0);\n+\tIGC_WRITE_FLUSH(hw);\n+\treturn 0;\n+}\n+\n+static int\n+igc_syn_filter_get(struct rte_eth_dev *dev, struct rte_eth_syn_filter *filter)\n+{\n+\tstruct igc_adapter *igc = IGC_DEV_PRIVATE(dev);\n+\tstruct igc_syn_filter *syn_filter = &igc->syn_filter;\n+\n+\tif (syn_filter->enable == 0) {\n+\t\tPMD_DRV_LOG(ERR, \"syn filter not been set.\\n\");\n+\t\treturn -ENOENT;\n+\t}\n+\n+\tfilter->hig_pri = syn_filter->priority;\n+\tfilter->queue = syn_filter->queue;\n+\treturn 0;\n+}\n+\n+/* clear the SYN filter */\n+static void\n+igc_clear_syn_filter(struct rte_eth_dev *dev)\n+{\n+\tstruct igc_hw *hw = IGC_DEV_PRIVATE_HW(dev);\n+\tstruct igc_adapter *igc = IGC_DEV_PRIVATE(dev);\n+\n+\tIGC_WRITE_REG(hw, IGC_SYNQF(0), 0);\n+\tIGC_WRITE_FLUSH(hw);\n+\n+\tmemset(&igc->syn_filter, 0, sizeof(igc->syn_filter));\n+}\n+\n+static int\n+igc_syn_filter_handle(struct rte_eth_dev *dev, enum rte_filter_op filter_op,\n+\t\tstruct rte_eth_syn_filter *filter)\n+{\n+\tint ret;\n+\n+\tif (filter_op == RTE_ETH_FILTER_NOP)\n+\t\treturn 0;\n+\n+\tif (filter == NULL) {\n+\t\tPMD_DRV_LOG(ERR, \"filter shouldn't be NULL for operation %u\",\n+\t\t\t filter_op);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tswitch (filter_op) {\n+\tcase RTE_ETH_FILTER_ADD:\n+\t\tret = igc_set_syn_filter(dev, filter);\n+\t\tbreak;\n+\tcase RTE_ETH_FILTER_DELETE:\n+\t\tret = igc_del_syn_filter(dev);\n+\t\tbreak;\n+\tcase RTE_ETH_FILTER_GET:\n+\t\tret = igc_syn_filter_get(dev, filter);\n+\t\tbreak;\n+\tdefault:\n+\t\tPMD_DRV_LOG(ERR, \"unsupported operation %u\", filter_op);\n+\t\tret = -EINVAL;\n+\t\tbreak;\n+\t}\n+\n+\treturn ret;\n+}\n+\n void\n igc_clear_all_filter(struct rte_eth_dev *dev)\n {\n \tigc_clear_all_ethertype_filter(dev);\n \tigc_clear_all_ntuple_filter(dev);\n+\tigc_clear_syn_filter(dev);\n }\n \n int\n@@ -568,6 +693,10 @@\n \t\tret = igc_ntuple_filter_handle(dev, filter_op,\n \t\t\t(struct rte_eth_ntuple_filter *)arg);\n \t\tbreak;\n+\tcase RTE_ETH_FILTER_SYN:\n+\t\tret = igc_syn_filter_handle(dev, filter_op,\n+\t\t\t(struct rte_eth_syn_filter *)arg);\n+\t\tbreak;\n \tdefault:\n \t\tPMD_DRV_LOG(WARNING, \"Filter type (%d) not supported\",\n \t\t\t\t\t\t\tfilter_type);\ndiff --git a/drivers/net/igc/igc_filter.h b/drivers/net/igc/igc_filter.h\nindex 7c5e843..4fad8e0 100644\n--- a/drivers/net/igc/igc_filter.h\n+++ b/drivers/net/igc/igc_filter.h\n@@ -20,6 +20,9 @@ int igc_del_ethertype_filter(struct rte_eth_dev *dev,\n int igc_add_del_ntuple_filter(struct rte_eth_dev *dev,\n \t\t\tconst struct rte_eth_ntuple_filter *ntuple,\n \t\t\tbool add);\n+int igc_set_syn_filter(struct rte_eth_dev *dev,\n+\t\tconst struct rte_eth_syn_filter *filter);\n+int igc_del_syn_filter(struct rte_eth_dev *dev);\n void\n igc_clear_all_filter(struct rte_eth_dev *dev);\n \n", "prefixes": [ "v2", "12/14" ] }