Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/66951/?format=api
{ "id": 66951, "url": "https://patches.dpdk.org/api/patches/66951/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200319171907.60891-13-ciara.power@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200319171907.60891-13-ciara.power@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200319171907.60891-13-ciara.power@intel.com", "date": "2020-03-19T17:19:07", "name": "[12/12] eal: add eal telemetry callbacks", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "2661c9fdf81dc65692a3b1151391e7ddb83293ee", "submitter": { "id": 978, "url": "https://patches.dpdk.org/api/people/978/?format=api", "name": "Power, Ciara", "email": "ciara.power@intel.com" }, "delegate": { "id": 24651, "url": "https://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200319171907.60891-13-ciara.power@intel.com/mbox/", "series": [ { "id": 8987, "url": "https://patches.dpdk.org/api/series/8987/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=8987", "date": "2020-03-19T17:18:55", "name": "update and simplify telemetry library.", "version": 1, "mbox": "https://patches.dpdk.org/series/8987/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/66951/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/66951/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6759AA0583;\n\tThu, 19 Mar 2020 18:37:57 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 5D6401C116;\n\tThu, 19 Mar 2020 18:35:19 +0100 (CET)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n by dpdk.org (Postfix) with ESMTP id 170401C10D\n for <dev@dpdk.org>; Thu, 19 Mar 2020 18:35:17 +0100 (CET)", "from orsmga004.jf.intel.com ([10.7.209.38])\n by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 19 Mar 2020 10:35:17 -0700", "from silpixa00399953.ir.intel.com (HELO\n silpixa00399953.ger.corp.intel.com) ([10.237.222.53])\n by orsmga004.jf.intel.com with ESMTP; 19 Mar 2020 10:35:14 -0700" ], "IronPort-SDR": [ "\n 1AOGyXua16ojn6xx+tOAu8Ju5z2GBpq27KV0mdRBz+zwrI4zvcEcjEHAIXkGz3Dx0kaTS5TsuS\n ny6tm5sZDN7Q==", "\n OazyGZVBF71YT0fF04766aCZeZ37nRB+CjmnnrQ/r2us0vU9lQsO7AHK1ogw+LEvm1DeZmSWFj\n cCQ/BBpEO7Jw==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.70,572,1574150400\"; d=\"scan'208\";a=\"391872779\"", "From": "Ciara Power <ciara.power@intel.com>", "To": "kevin.laatz@intel.com", "Cc": "dev@dpdk.org, reshma.pattan@intel.com,\n Bruce Richardson <bruce.richardson@intel.com>,\n Ciara Power <ciara.power@intel.com>", "Date": "Thu, 19 Mar 2020 17:19:07 +0000", "Message-Id": "<20200319171907.60891-13-ciara.power@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200319171907.60891-1-ciara.power@intel.com>", "References": "<20200319171907.60891-1-ciara.power@intel.com>", "Subject": "[dpdk-dev] [PATCH 12/12] eal: add eal telemetry callbacks", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Bruce Richardson <bruce.richardson@intel.com>\n\nEAL now registers commands to provide some basic info from EAL.\n\nExample:\nConnecting to /var/run/dpdk/rte/dpdk_telemetry.66307\n--> /\n{\"/\": [\"/\", \"/eal/app_params\", \"/eal/params\", \"/eal/version\",\n \"/ethdev/list\", \"/ethdev/stats\", \"/rawdev/list\", \"/rawdev/stats\"]}\n--> /eal/app_params\n{\"/eal/app_params\": [\"-i\"]}\n--> /eal/params\n{\"/eal/params\": [\"./app/dpdk-testpmd\", \"--telemetry\"]}\n--> /eal/version\n{\"/eal/version\": \"DPDK 20.05.0-rc0\"}\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\nSigned-off-by: Ciara Power <ciara.power@intel.com>\n---\n lib/librte_eal/common/eal_common_options.c | 70 ++++++++++++++++++++++\n lib/librte_eal/common/eal_options.h | 3 +\n lib/librte_eal/freebsd/eal/eal.c | 5 ++\n lib/librte_eal/linux/eal/eal.c | 5 ++\n 4 files changed, 83 insertions(+)", "diff": "diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c\nindex 386566b3d..78cd1f825 100644\n--- a/lib/librte_eal/common/eal_common_options.c\n+++ b/lib/librte_eal/common/eal_common_options.c\n@@ -29,6 +29,7 @@\n #include <rte_version.h>\n #include <rte_devargs.h>\n #include <rte_memcpy.h>\n+#include <rte_telemetry.h>\n \n #include \"eal_internal_cfg.h\"\n #include \"eal_options.h\"\n@@ -132,6 +133,75 @@ static int master_lcore_parsed;\n static int mem_parsed;\n static int core_parsed;\n \n+static char **eal_args;\n+static char **eal_app_args;\n+\n+#define EAL_PARAM_REQ \"/eal/params\"\n+#define EAL_APP_PARAM_REQ \"/eal/app_params\"\n+\n+/* callback handler for telemetry library to report out EAL flags */\n+int\n+handle_eal_info_request(const char *cmd, const char *params __rte_unused,\n+\t\tchar *buffer, int buf_len)\n+{\n+\tchar **args;\n+\tint used = 0;\n+\tint i = 0;\n+\n+\tif (strcmp(cmd, EAL_PARAM_REQ) == 0)\n+\t\targs = eal_args;\n+\telse if (strcmp(cmd, EAL_APP_PARAM_REQ) == 0)\n+\t\targs = eal_app_args;\n+\telse /* version */\n+\t\treturn snprintf(buffer, buf_len, \"\\\"%s\\\"\", rte_version());\n+\n+\tif (args == NULL || args[0] == NULL)\n+\t\treturn snprintf(buffer, buf_len, \"[]\"); /* empty list */\n+\n+\tused = strlcpy(buffer, \"[\", buf_len);\n+\twhile (args[i] != NULL)\n+\t\tused += snprintf(buffer + used, buf_len - used, \"\\\"%s\\\",\",\n+\t\t\t\targs[i++]);\n+\tbuffer[used - 1] = ']';\n+\treturn used;\n+}\n+\n+int\n+eal_save_args(int argc, char **argv)\n+{\n+\tint i, j;\n+\n+\t/* clone argv to report out later. We overprovision, but\n+\t * this does not waste huge amounts of memory\n+\t */\n+\teal_args = calloc(argc + 1, sizeof(*eal_args));\n+\tif (eal_args == NULL)\n+\t\treturn -1;\n+\n+\tfor (i = 0; i < argc; i++) {\n+\t\teal_args[i] = strdup(argv[i]);\n+\t\tif (strcmp(argv[i], \"--\") == 0)\n+\t\t\tbreak;\n+\t}\n+\teal_args[i++] = NULL; /* always finish with NULL */\n+\trte_telemetry_register_cmd(EAL_PARAM_REQ, handle_eal_info_request);\n+\n+\t/* allow reporting of any app args we know about too */\n+\tif (i == argc)\n+\t\treturn 0;\n+\n+\teal_app_args = calloc(argc - i + 1, sizeof(*eal_args));\n+\tif (eal_app_args == NULL)\n+\t\treturn -1;\n+\n+\tfor (j = 0; i < argc; j++, i++)\n+\t\teal_app_args[j] = strdup(argv[i]);\n+\teal_app_args[j] = NULL;\n+\trte_telemetry_register_cmd(EAL_APP_PARAM_REQ, handle_eal_info_request);\n+\n+\treturn 0;\n+}\n+\n static int\n eal_option_device_add(enum rte_devtype type, const char *optarg)\n {\ndiff --git a/lib/librte_eal/common/eal_options.h b/lib/librte_eal/common/eal_options.h\nindex 225ad4bb5..5373e9f5e 100644\n--- a/lib/librte_eal/common/eal_options.h\n+++ b/lib/librte_eal/common/eal_options.h\n@@ -88,5 +88,8 @@ int eal_check_common_options(struct internal_config *internal_cfg);\n void eal_common_usage(void);\n enum rte_proc_type_t eal_proc_type_detect(void);\n int eal_plugins_init(void);\n+int eal_save_args(int argc, char **argv);\n+int handle_eal_info_request(const char *cmd, const char *params __rte_unused,\n+\t\tchar *buffer, int buf_len);\n \n #endif /* EAL_OPTIONS_H */\ndiff --git a/lib/librte_eal/freebsd/eal/eal.c b/lib/librte_eal/freebsd/eal/eal.c\nindex 54acafc31..e18bf59f9 100644\n--- a/lib/librte_eal/freebsd/eal/eal.c\n+++ b/lib/librte_eal/freebsd/eal/eal.c\n@@ -725,6 +725,9 @@ rte_eal_init(int argc, char **argv)\n \n \teal_reset_internal_config(&internal_config);\n \n+\t/* clone argv to report out later in telemetry */\n+\teal_save_args(argc, argv);\n+\n \t/* set log level as early as possible */\n \teal_log_level_parse(argc, argv);\n \n@@ -960,6 +963,8 @@ rte_eal_init(int argc, char **argv)\n \t\t\trte_eal_init_alert(error_str);\n \t\t\treturn -1;\n \t\t}\n+\t\trte_telemetry_register_cmd(\"/eal/version\",\n+\t\t\t\thandle_eal_info_request);\n \t}\n \n \teal_mcfg_complete();\ndiff --git a/lib/librte_eal/linux/eal/eal.c b/lib/librte_eal/linux/eal/eal.c\nindex 8eeffe9aa..a68b66a1e 100644\n--- a/lib/librte_eal/linux/eal/eal.c\n+++ b/lib/librte_eal/linux/eal/eal.c\n@@ -992,6 +992,9 @@ rte_eal_init(int argc, char **argv)\n \t/* set log level as early as possible */\n \teal_log_level_parse(argc, argv);\n \n+\t/* clone argv to report out later in telemetry */\n+\teal_save_args(argc, argv);\n+\n \tif (rte_eal_cpu_init() < 0) {\n \t\trte_eal_init_alert(\"Cannot detect lcores.\");\n \t\trte_errno = ENOTSUP;\n@@ -1299,6 +1302,8 @@ rte_eal_init(int argc, char **argv)\n \t\t\trte_eal_init_alert(error_str);\n \t\t\treturn -1;\n \t\t}\n+\t\trte_telemetry_register_cmd(\"/eal/version\",\n+\t\t\t\thandle_eal_info_request);\n \t}\n \n \teal_mcfg_complete();\n", "prefixes": [ "12/12" ] }