Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/66946/?format=api
{ "id": 66946, "url": "https://patches.dpdk.org/api/patches/66946/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200319171907.60891-8-ciara.power@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200319171907.60891-8-ciara.power@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200319171907.60891-8-ciara.power@intel.com", "date": "2020-03-19T17:19:02", "name": "[07/12] rawdev: add callback support for telemetry", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "39190e523e76cb8e893cfe8d470a1159f8067603", "submitter": { "id": 978, "url": "https://patches.dpdk.org/api/people/978/?format=api", "name": "Power, Ciara", "email": "ciara.power@intel.com" }, "delegate": { "id": 24651, "url": "https://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200319171907.60891-8-ciara.power@intel.com/mbox/", "series": [ { "id": 8987, "url": "https://patches.dpdk.org/api/series/8987/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=8987", "date": "2020-03-19T17:18:55", "name": "update and simplify telemetry library.", "version": 1, "mbox": "https://patches.dpdk.org/series/8987/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/66946/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/66946/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 46C6BA0583;\n\tThu, 19 Mar 2020 18:36:39 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E015A1C0BE;\n\tThu, 19 Mar 2020 18:35:07 +0100 (CET)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n by dpdk.org (Postfix) with ESMTP id 5CC051C0B4\n for <dev@dpdk.org>; Thu, 19 Mar 2020 18:35:06 +0100 (CET)", "from orsmga004.jf.intel.com ([10.7.209.38])\n by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 19 Mar 2020 10:35:06 -0700", "from silpixa00399953.ir.intel.com (HELO\n silpixa00399953.ger.corp.intel.com) ([10.237.222.53])\n by orsmga004.jf.intel.com with ESMTP; 19 Mar 2020 10:35:04 -0700" ], "IronPort-SDR": [ "\n Waji2AwA8SPls364u4Q3qtI6UDjv7PKaGb+LWkTpAZTpChdgSnWEcM86b9nn99xKmA37OVKGwV\n YCtjBk1NM8yQ==", "\n myLFVtOOD0fkkpzvh0eGOGFtC2Tr2eSN35r9MNmVz5m6QDBsKAyBC8S4r6gjLVPM1Uv4sdKvw4\n 87iFIEu2uexA==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.70,572,1574150400\"; d=\"scan'208\";a=\"391872690\"", "From": "Ciara Power <ciara.power@intel.com>", "To": "kevin.laatz@intel.com", "Cc": "dev@dpdk.org, reshma.pattan@intel.com,\n Ciara Power <ciara.power@intel.com>,\n Bruce Richardson <bruce.richardson@intel.com>", "Date": "Thu, 19 Mar 2020 17:19:02 +0000", "Message-Id": "<20200319171907.60891-8-ciara.power@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200319171907.60891-1-ciara.power@intel.com>", "References": "<20200319171907.60891-1-ciara.power@intel.com>", "Subject": "[dpdk-dev] [PATCH 07/12] rawdev: add callback support for telemetry", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The rawdev library now registers commands with telemetry, and\nimplements the corresponding callback functions. These allow a list of\nrawdev devices and stats for a rawdev port to be queried.\n\nAn example usage, with ioat rawdev driver instances, is shown below:\n\nConnecting to /var/run/dpdk/rte/dpdk_telemetry.22345\n--> /\n{\"/\": [\"/\", \"/ethdev/list\", \"/ethdev/stats\", \"/rawdev/list\",\n \"/rawdev/stats\"]}\n--> /rawdev/list\n{\"/rawdev/list\": [0, 1, 2, 3, 4, 5]}\n--> /rawdev/stats,0\n{\"/rawdev/stats\": {\"failed_enqueues\": 0, \"successful_enqueues\": 0,\n \"copies_started\": 0, \"copies_completed\": 0}}\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\nSigned-off-by: Ciara Power <ciara.power@intel.com>\n---\n lib/librte_rawdev/Makefile | 5 ++\n lib/librte_rawdev/meson.build | 5 ++\n lib/librte_rawdev/rte_rawdev.c | 88 ++++++++++++++++++++++++++++++++++\n 3 files changed, 98 insertions(+)", "diff": "diff --git a/lib/librte_rawdev/Makefile b/lib/librte_rawdev/Makefile\nindex 7dd1197dc..ccf68f60e 100644\n--- a/lib/librte_rawdev/Makefile\n+++ b/lib/librte_rawdev/Makefile\n@@ -11,6 +11,11 @@ CFLAGS += -O3\n CFLAGS += $(WERROR_FLAGS)\n LDLIBS += -lrte_eal\n \n+ifeq ($(CONFIG_RTE_LIBRTE_TELEMETRY),y)\n+CFLAGS += -DALLOW_EXPERIMENTAL_API\n+LDLIBS += -lrte_telemetry\n+endif\n+\n # library source files\n SRCS-y += rte_rawdev.c\n \ndiff --git a/lib/librte_rawdev/meson.build b/lib/librte_rawdev/meson.build\nindex a20fbdc04..3a0ea2a29 100644\n--- a/lib/librte_rawdev/meson.build\n+++ b/lib/librte_rawdev/meson.build\n@@ -3,3 +3,8 @@\n \n sources = files('rte_rawdev.c')\n headers = files('rte_rawdev.h', 'rte_rawdev_pmd.h')\n+\n+if dpdk_conf.has('RTE_LIBRTE_TELEMETRY')\n+\tallow_experimental_apis = true\n+\tdeps += ['telemetry']\n+endif\ndiff --git a/lib/librte_rawdev/rte_rawdev.c b/lib/librte_rawdev/rte_rawdev.c\nindex b6f1e1c77..034a0e32f 100644\n--- a/lib/librte_rawdev/rte_rawdev.c\n+++ b/lib/librte_rawdev/rte_rawdev.c\n@@ -29,6 +29,9 @@\n #include <rte_common.h>\n #include <rte_malloc.h>\n #include <rte_errno.h>\n+#ifdef RTE_LIBRTE_TELEMETRY\n+#include <rte_telemetry.h>\n+#endif\n \n #include \"rte_rawdev.h\"\n #include \"rte_rawdev_pmd.h\"\n@@ -544,9 +547,94 @@ rte_rawdev_pmd_release(struct rte_rawdev *rawdev)\n \treturn 0;\n }\n \n+#ifdef RTE_LIBRTE_TELEMETRY\n+static int\n+handle_dev_list(const char *cmd __rte_unused,\n+\t\tconst char *params __rte_unused,\n+\t\tchar *buffer, int buf_len)\n+{\n+\tint used = 0;\n+\tint i;\n+\n+\tused = strlcpy(buffer, \"[\", buf_len);\n+\tfor (i = 0; i < rawdev_globals.nb_devs; i++)\n+\t\tif (rte_rawdevices[i].attached == RTE_RAWDEV_ATTACHED)\n+\t\t\tused += snprintf(buffer + used, buf_len - used, \"%d,\",\n+\t\t\t\trte_rawdevices[i].dev_id);\n+\n+\tbuffer[used - 1] = ']';\n+\treturn used;\n+}\n+\n+static int\n+handle_dev_stats(const char *cmd __rte_unused,\n+\t\tconst char *params,\n+\t\tchar *buffer, int buf_len)\n+{\n+\tuint64_t *rawdev_xstats;\n+\tstruct rte_rawdev_xstats_name *xstat_names;\n+\tint dev_id, num_xstats, i, ret;\n+\tint used = 0;\n+\tunsigned int *ids;\n+\n+\tif (params == NULL || strlen(params) == 0 || !isdigit(*params))\n+\t\treturn -1;\n+\n+\tdev_id = atoi(params);\n+\tif (!rte_rawdev_pmd_is_valid_dev(dev_id))\n+\t\treturn -1;\n+\n+\tused = strlcpy(buffer, \"{\", buf_len);\n+\n+\tnum_xstats = xstats_get_count(dev_id);\n+\tif (num_xstats < 0)\n+\t\treturn -1;\n+\n+\t/* use one malloc for names, stats and ids */\n+\trawdev_xstats = malloc((sizeof(uint64_t) +\n+\t\t\tsizeof(struct rte_rawdev_xstats_name) +\n+\t\t\tsizeof(unsigned int)) * num_xstats);\n+\tif (rawdev_xstats == NULL)\n+\t\treturn -1;\n+\txstat_names = (void *)&rawdev_xstats[num_xstats];\n+\tids = (void *)&xstat_names[num_xstats];\n+\n+\tret = rte_rawdev_xstats_names_get(dev_id, xstat_names, num_xstats);\n+\tif (ret < 0 || ret > num_xstats) {\n+\t\tfree(rawdev_xstats);\n+\t\treturn -1;\n+\t}\n+\n+\tfor (i = 0; i < num_xstats; i++)\n+\t\tids[i] = i;\n+\n+\tret = rte_rawdev_xstats_get(dev_id, ids, rawdev_xstats, num_xstats);\n+\tif (ret < 0 || ret > num_xstats) {\n+\t\tfree(rawdev_xstats);\n+\t\treturn -1;\n+\t}\n+\n+\tfor (i = 0; i < num_xstats; i++) {\n+\t\tret = snprintf(buffer + used, buf_len - used, \"\\\"%s\\\":%\"PRIu64\",\",\n+\t\t\t\txstat_names[i].name, rawdev_xstats[i]);\n+\t\tif (ret + used >= buf_len)\n+\t\t\tbreak;\n+\t\tused += ret;\n+\t}\n+\n+\tbuffer[used - 1] = '}';\n+\tfree(rawdev_xstats);\n+\treturn used;\n+}\n+#endif\n+\n RTE_INIT(librawdev_init_log)\n {\n \tlibrawdev_logtype = rte_log_register(\"lib.rawdev\");\n \tif (librawdev_logtype >= 0)\n \t\trte_log_set_level(librawdev_logtype, RTE_LOG_INFO);\n+#ifdef RTE_LIBRTE_TELEMETRY\n+\trte_telemetry_register_cmd(\"/rawdev/list\", handle_dev_list);\n+\trte_telemetry_register_cmd(\"/rawdev/stats\", handle_dev_stats);\n+#endif\n }\n", "prefixes": [ "07/12" ] }