Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/66869/?format=api
{ "id": 66869, "url": "https://patches.dpdk.org/api/patches/66869/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200318190241.3150971-20-jerinj@marvell.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200318190241.3150971-20-jerinj@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200318190241.3150971-20-jerinj@marvell.com", "date": "2020-03-18T19:02:28", "name": "[v1,19/32] eal/trace: add memzone tracepoints", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "adf156cd0562efb0475ea4532b1c9a5c71bde440", "submitter": { "id": 1188, "url": "https://patches.dpdk.org/api/people/1188/?format=api", "name": "Jerin Jacob Kollanukkaran", "email": "jerinj@marvell.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200318190241.3150971-20-jerinj@marvell.com/mbox/", "series": [ { "id": 8970, "url": "https://patches.dpdk.org/api/series/8970/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=8970", "date": "2020-03-18T19:02:09", "name": "DPDK Trace support", "version": 1, "mbox": "https://patches.dpdk.org/series/8970/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/66869/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/66869/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9F4F0A0579;\n\tWed, 18 Mar 2020 20:05:39 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 7A09625D9;\n\tWed, 18 Mar 2020 20:03:19 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 4C9EC1C112\n for <dev@dpdk.org>; Wed, 18 Mar 2020 20:03:16 +0100 (CET)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id\n 02IJ0rCI010870; Wed, 18 Mar 2020 12:03:15 -0700", "from sc-exch04.marvell.com ([199.233.58.184])\n by mx0a-0016f401.pphosted.com with ESMTP id 2yu8pqm46n-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Wed, 18 Mar 2020 12:03:15 -0700", "from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH04.marvell.com\n (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 18 Mar\n 2020 12:03:13 -0700", "from maili.marvell.com (10.93.176.43) by SC-EXCH03.marvell.com\n (10.93.176.83) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Wed, 18 Mar 2020 12:03:14 -0700", "from jerin-lab.marvell.com (jerin-lab.marvell.com [10.28.34.14])\n by maili.marvell.com (Postfix) with ESMTP id B44B13F703F;\n Wed, 18 Mar 2020 12:03:11 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0818;\n bh=kZiJIS1yb6l6Abk4sKaIDhaQCLXiNa+UkQlMe5SbGys=;\n b=nVYLPGZUrD8/aCivDJpU7b5OB4AnxWrjDX87EbmuzAd8D42jQdkcAkufeR9e3ksiIWmQ\n x3vDY2wQvkTEiTIsGMo3NAQNSpnWoG8C6YzOQ7efADIK7++kH0jeShB3QTNQcvPkVNI1\n iX6eLR81P4DW/Q/JzbJKPVx8iARIH8i1KUvkPgJXv9fhd5xRnz/D2uMqNhqELMfpUCNM\n kDPeiz+TyJneE4QssZmV7RUzRYvCXizdbWTWdnUAq91R49iiTQiSGDNgKwR6kQRBD9W7\n gQJt8n8Gor/9gT+irXRQ319W6O+9GiCDtYYAUMy9U9uFm574VWJf4PfCSNoML/CHLZpw zQ==", "From": "<jerinj@marvell.com>", "To": "Anatoly Burakov <anatoly.burakov@intel.com>, Jerin Jacob\n <jerinj@marvell.com>, Sunil Kumar Kori <skori@marvell.com>", "CC": "<dev@dpdk.org>, <thomas@monjalon.net>, <bruce.richardson@intel.com>,\n <david.marchand@redhat.com>, <mattias.ronnblom@ericsson.com>", "Date": "Thu, 19 Mar 2020 00:32:28 +0530", "Message-ID": "<20200318190241.3150971-20-jerinj@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200318190241.3150971-1-jerinj@marvell.com>", "References": "<20200318190241.3150971-1-jerinj@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.138, 18.0.645\n definitions=2020-03-18_07:2020-03-18,\n 2020-03-18 signatures=0", "Subject": "[dpdk-dev] [PATCH v1 19/32] eal/trace: add memzone tracepoints", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Jerin Jacob <jerinj@marvell.com>\n\nAdd the following memzone related tracepoints.\n\nrte_trace_lib_eal_memzone_reserve\nrte_trace_lib_eal_memzone_lookup\nrte_trace_lib_eal_memzone_free\n\nSigned-off-by: Jerin Jacob <jerinj@marvell.com>\n---\n lib/librte_eal/common/eal_common_memzone.c | 9 +++++++\n .../common/eal_common_trace_points.c | 10 +++++++\n lib/librte_eal/common/include/rte_trace_eal.h | 26 +++++++++++++++++++\n lib/librte_eal/rte_eal_version.map | 3 +++\n 4 files changed, 48 insertions(+)", "diff": "diff --git a/lib/librte_eal/common/eal_common_memzone.c b/lib/librte_eal/common/eal_common_memzone.c\nindex 86f61369b..0f6556714 100644\n--- a/lib/librte_eal/common/eal_common_memzone.c\n+++ b/lib/librte_eal/common/eal_common_memzone.c\n@@ -19,6 +19,7 @@\n #include <rte_errno.h>\n #include <rte_string_fns.h>\n #include <rte_common.h>\n+#include <rte_trace_eal.h>\n \n #include \"malloc_heap.h\"\n #include \"malloc_elem.h\"\n@@ -201,6 +202,9 @@ rte_memzone_reserve_thread_safe(const char *name, size_t len, int socket_id,\n \tmz = memzone_reserve_aligned_thread_unsafe(\n \t\tname, len, socket_id, flags, align, bound);\n \n+\trte_trace_lib_eal_memzone_reserve(name, len, socket_id, flags, align,\n+\t\t\t\t\t bound, mz);\n+\n \trte_rwlock_write_unlock(&mcfg->mlock);\n \n \treturn mz;\n@@ -246,6 +250,7 @@ rte_memzone_reserve(const char *name, size_t len, int socket_id,\n int\n rte_memzone_free(const struct rte_memzone *mz)\n {\n+\tchar name[RTE_MEMZONE_NAMESIZE];\n \tstruct rte_mem_config *mcfg;\n \tstruct rte_fbarray *arr;\n \tstruct rte_memzone *found_mz;\n@@ -256,6 +261,7 @@ rte_memzone_free(const struct rte_memzone *mz)\n \tif (mz == NULL)\n \t\treturn -EINVAL;\n \n+\trte_strlcpy(name, mz->name, RTE_MEMZONE_NAMESIZE);\n \tmcfg = rte_eal_get_configuration()->mem_config;\n \tarr = &mcfg->memzones;\n \n@@ -280,6 +286,8 @@ rte_memzone_free(const struct rte_memzone *mz)\n \tif (addr != NULL)\n \t\trte_free(addr);\n \n+\trte_trace_lib_eal_memzone_free(name, addr, ret);\n+\n \treturn ret;\n }\n \n@@ -300,6 +308,7 @@ rte_memzone_lookup(const char *name)\n \n \trte_rwlock_read_unlock(&mcfg->mlock);\n \n+\trte_trace_lib_eal_memzone_lookup(name, memzone);\n \treturn memzone;\n }\n \ndiff --git a/lib/librte_eal/common/eal_common_trace_points.c b/lib/librte_eal/common/eal_common_trace_points.c\nindex dcae51bac..aeaeac061 100644\n--- a/lib/librte_eal/common/eal_common_trace_points.c\n+++ b/lib/librte_eal/common/eal_common_trace_points.c\n@@ -31,6 +31,10 @@ RTE_TRACE_POINT_DEFINE(rte_trace_lib_eal_mem_malloc);\n RTE_TRACE_POINT_DEFINE(rte_trace_lib_eal_mem_realloc);\n RTE_TRACE_POINT_DEFINE(rte_trace_lib_eal_mem_free);\n \n+RTE_TRACE_POINT_DEFINE(rte_trace_lib_eal_memzone_reserve);\n+RTE_TRACE_POINT_DEFINE(rte_trace_lib_eal_memzone_lookup);\n+RTE_TRACE_POINT_DEFINE(rte_trace_lib_eal_memzone_free);\n+\n RTE_INIT(eal_trace_init)\n {\n \tRTE_TRACE_POINT_REGISTER(rte_trace_lib_eal_generic_void,\n@@ -80,4 +84,10 @@ RTE_INIT(eal_trace_init)\n \tRTE_TRACE_POINT_REGISTER(rte_trace_lib_eal_mem_free,\n \t\t\t\t lib.eal.mem.free, INFO);\n \n+\tRTE_TRACE_POINT_REGISTER(rte_trace_lib_eal_memzone_reserve,\n+\t\t\t\t lib.eal.memzone.reserve, INFO);\n+\tRTE_TRACE_POINT_REGISTER(rte_trace_lib_eal_memzone_lookup,\n+\t\t\t\t lib.eal.memzone.lookup, INFO);\n+\tRTE_TRACE_POINT_REGISTER(rte_trace_lib_eal_memzone_free,\n+\t\t\t\t lib.eal.memzone.free, INFO);\n }\ndiff --git a/lib/librte_eal/common/include/rte_trace_eal.h b/lib/librte_eal/common/include/rte_trace_eal.h\nindex a8eb422f9..316bc8c97 100644\n--- a/lib/librte_eal/common/include/rte_trace_eal.h\n+++ b/lib/librte_eal/common/include/rte_trace_eal.h\n@@ -166,6 +166,32 @@ RTE_TRACE_POINT(\n \trte_trace_ctf_ptr(ptr);\n )\n \n+/* Memzone */\n+RTE_TRACE_POINT(\n+\trte_trace_lib_eal_memzone_reserve,\n+\tRTE_TRACE_POINT_ARGS(const char *name, size_t len, int socket_id,\n+\t\t\t unsigned int flags, unsigned int align,\n+\t\t\t unsigned int bound, const void *mz),\n+\trte_trace_ctf_string(name); rte_trace_ctf_long(len);\n+\trte_trace_ctf_int(socket_id); rte_trace_ctf_u32(flags);\n+\trte_trace_ctf_u32(align); rte_trace_ctf_u32(bound);\n+\trte_trace_ctf_ptr(mz);\n+)\n+\n+RTE_TRACE_POINT(\n+\trte_trace_lib_eal_memzone_lookup,\n+\tRTE_TRACE_POINT_ARGS(const char *name, const void *memzone),\n+\trte_trace_ctf_string(name); rte_trace_ctf_ptr(memzone);\n+)\n+\n+RTE_TRACE_POINT(\n+\trte_trace_lib_eal_memzone_free,\n+\tRTE_TRACE_POINT_ARGS(const char *name, void *addr, int rc),\n+\trte_trace_ctf_string(name); rte_trace_ctf_ptr(addr);\n+\trte_trace_ctf_int(rc);\n+)\n+\n+\n #ifdef __cplusplus\n }\n #endif\ndiff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map\nindex 787d8e076..8a716be9e 100644\n--- a/lib/librte_eal/rte_eal_version.map\n+++ b/lib/librte_eal/rte_eal_version.map\n@@ -387,4 +387,7 @@ EXPERIMENTAL {\n \t__rte_trace_lib_eal_mem_malloc;\n \t__rte_trace_lib_eal_mem_realloc;\n \t__rte_trace_lib_eal_mem_free;\n+\t__rte_trace_lib_eal_memzone_reserve;\n+\t__rte_trace_lib_eal_memzone_lookup;\n+\t__rte_trace_lib_eal_memzone_free;\n };\n", "prefixes": [ "v1", "19/32" ] }