Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/66644/?format=api
{ "id": 66644, "url": "https://patches.dpdk.org/api/patches/66644/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200313174230.74661-3-yong.liu@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200313174230.74661-3-yong.liu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200313174230.74661-3-yong.liu@intel.com", "date": "2020-03-13T17:42:25", "name": "[v1,2/7] net/virtio-user: add LRO parameter", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "2e7fef6fb756560fff1b1f28190c83aa7263e86f", "submitter": { "id": 17, "url": "https://patches.dpdk.org/api/people/17/?format=api", "name": "Marvin Liu", "email": "yong.liu@intel.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200313174230.74661-3-yong.liu@intel.com/mbox/", "series": [ { "id": 8904, "url": "https://patches.dpdk.org/api/series/8904/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=8904", "date": "2020-03-13T17:42:23", "name": "vectorize virtio packed ring datapath", "version": 1, "mbox": "https://patches.dpdk.org/series/8904/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/66644/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/66644/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5F319A0567;\n\tFri, 13 Mar 2020 11:07:41 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 648561C069;\n\tFri, 13 Mar 2020 11:07:29 +0100 (CET)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n by dpdk.org (Postfix) with ESMTP id ED8B71C02C\n for <dev@dpdk.org>; Fri, 13 Mar 2020 11:07:26 +0100 (CET)", "from orsmga006.jf.intel.com ([10.7.209.51])\n by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n 13 Mar 2020 03:07:26 -0700", "from npg-dpdk-virtual-marvin-dev.sh.intel.com ([10.67.119.58])\n by orsmga006.jf.intel.com with ESMTP; 13 Mar 2020 03:07:24 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.70,548,1574150400\"; d=\"scan'208\";a=\"246653887\"", "From": "Marvin Liu <yong.liu@intel.com>", "To": "maxime.coquelin@redhat.com, xiaolong.ye@intel.com, zhihong.wang@intel.com", "Cc": "dev@dpdk.org,\n\tMarvin Liu <yong.liu@intel.com>", "Date": "Sat, 14 Mar 2020 01:42:25 +0800", "Message-Id": "<20200313174230.74661-3-yong.liu@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200313174230.74661-1-yong.liu@intel.com>", "References": "<20200313174230.74661-1-yong.liu@intel.com>", "Subject": "[dpdk-dev] [PATCH v1 2/7] net/virtio-user: add LRO parameter", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Packed ring vectorized rx function won't support GUEST_TSO4 and\nGUSET_TSO6. Adding \"lro\" parameter into virtio user vdev arguments\ncan disable these features for vectorized path selection.\n\nSigned-off-by: Marvin Liu <yong.liu@intel.com>", "diff": "diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c b/drivers/net/virtio/virtio_user/virtio_user_dev.c\nindex 1c6b26f8d..45d4bf14f 100644\n--- a/drivers/net/virtio/virtio_user/virtio_user_dev.c\n+++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c\n@@ -422,7 +422,8 @@ virtio_user_dev_setup(struct virtio_user_dev *dev)\n int\n virtio_user_dev_init(struct virtio_user_dev *dev, char *path, int queues,\n \t\t int cq, int queue_size, const char *mac, char **ifname,\n-\t\t int server, int mrg_rxbuf, int in_order, int packed_vq)\n+\t\t int server, int mrg_rxbuf, int in_order, int packed_vq,\n+\t\t int lro)\n {\n \tpthread_mutex_init(&dev->mutex, NULL);\n \tstrlcpy(dev->path, path, PATH_MAX);\n@@ -478,6 +479,11 @@ virtio_user_dev_init(struct virtio_user_dev *dev, char *path, int queues,\n \tif (!packed_vq)\n \t\tdev->unsupported_features |= (1ull << VIRTIO_F_RING_PACKED);\n \n+\tif (!lro) {\n+\t\tdev->unsupported_features |= (1ull << VIRTIO_NET_F_GUEST_TSO4);\n+\t\tdev->unsupported_features |= (1ull << VIRTIO_NET_F_GUEST_TSO6);\n+\t}\n+\n \tif (dev->mac_specified)\n \t\tdev->frontend_features |= (1ull << VIRTIO_NET_F_MAC);\n \telse\ndiff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.h b/drivers/net/virtio/virtio_user/virtio_user_dev.h\nindex 3b6b6065a..7133e4d26 100644\n--- a/drivers/net/virtio/virtio_user/virtio_user_dev.h\n+++ b/drivers/net/virtio/virtio_user/virtio_user_dev.h\n@@ -62,7 +62,7 @@ int virtio_user_stop_device(struct virtio_user_dev *dev);\n int virtio_user_dev_init(struct virtio_user_dev *dev, char *path, int queues,\n \t\t\t int cq, int queue_size, const char *mac, char **ifname,\n \t\t\t int server, int mrg_rxbuf, int in_order,\n-\t\t\t int packed_vq);\n+\t\t\t int packed_vq, int lro);\n void virtio_user_dev_uninit(struct virtio_user_dev *dev);\n void virtio_user_handle_cq(struct virtio_user_dev *dev, uint16_t queue_idx);\n void virtio_user_handle_cq_packed(struct virtio_user_dev *dev,\ndiff --git a/drivers/net/virtio/virtio_user_ethdev.c b/drivers/net/virtio/virtio_user_ethdev.c\nindex e61af4068..ea07a8384 100644\n--- a/drivers/net/virtio/virtio_user_ethdev.c\n+++ b/drivers/net/virtio/virtio_user_ethdev.c\n@@ -450,6 +450,8 @@ static const char *valid_args[] = {\n \tVIRTIO_USER_ARG_IN_ORDER,\n #define VIRTIO_USER_ARG_PACKED_VQ \"packed_vq\"\n \tVIRTIO_USER_ARG_PACKED_VQ,\n+#define VIRTIO_USER_ARG_LRO \"lro\"\n+\tVIRTIO_USER_ARG_LRO,\n \tNULL\n };\n \n@@ -552,6 +554,7 @@ virtio_user_pmd_probe(struct rte_vdev_device *dev)\n \tuint64_t mrg_rxbuf = 1;\n \tuint64_t in_order = 1;\n \tuint64_t packed_vq = 0;\n+\tuint64_t lro = 1;\n \tchar *path = NULL;\n \tchar *ifname = NULL;\n \tchar *mac_addr = NULL;\n@@ -668,6 +671,15 @@ virtio_user_pmd_probe(struct rte_vdev_device *dev)\n \t\t}\n \t}\n \n+\tif (rte_kvargs_count(kvlist, VIRTIO_USER_ARG_LRO) == 1) {\n+\t\tif (rte_kvargs_process(kvlist, VIRTIO_USER_ARG_LRO,\n+\t\t\t\t &get_integer_arg, &lro) < 0) {\n+\t\t\tPMD_INIT_LOG(ERR, \"error to parse %s\",\n+\t\t\t\t VIRTIO_USER_ARG_PACKED_VQ);\n+\t\t\tgoto end;\n+\t\t}\n+\t}\n+\n \tif (queues > 1 && cq == 0) {\n \t\tPMD_INIT_LOG(ERR, \"multi-q requires ctrl-q\");\n \t\tgoto end;\n@@ -707,7 +719,7 @@ virtio_user_pmd_probe(struct rte_vdev_device *dev)\n \thw = eth_dev->data->dev_private;\n \tif (virtio_user_dev_init(hw->virtio_user_dev, path, queues, cq,\n \t\t\t queue_size, mac_addr, &ifname, server_mode,\n-\t\t\t mrg_rxbuf, in_order, packed_vq) < 0) {\n+\t\t\t mrg_rxbuf, in_order, packed_vq, lro) < 0) {\n \t\tPMD_INIT_LOG(ERR, \"virtio_user_dev_init fails\");\n \t\tvirtio_user_eth_dev_free(eth_dev);\n \t\tgoto end;\n@@ -777,4 +789,5 @@ RTE_PMD_REGISTER_PARAM_STRING(net_virtio_user,\n \t\"server=<0|1> \"\n \t\"mrg_rxbuf=<0|1> \"\n \t\"in_order=<0|1> \"\n-\t\"packed_vq=<0|1>\");\n+\t\"packed_vq=<0|1>\"\n+\t\"lro=<0|1>\");\n", "prefixes": [ "v1", "2/7" ] }