Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/6656/?format=api
{ "id": 6656, "url": "https://patches.dpdk.org/api/patches/6656/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1438178178-5062-2-git-send-email-nelio.laranjeiro@6wind.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1438178178-5062-2-git-send-email-nelio.laranjeiro@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1438178178-5062-2-git-send-email-nelio.laranjeiro@6wind.com", "date": "2015-07-29T13:56:18", "name": "[dpdk-dev,2/2] mlx4: add missing library dependency when compiling in shared library", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "0d7d8fa986cc981341517912e4d2babd3a1ac168", "submitter": { "id": 243, "url": "https://patches.dpdk.org/api/people/243/?format=api", "name": "Nélio Laranjeiro", "email": "nelio.laranjeiro@6wind.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1438178178-5062-2-git-send-email-nelio.laranjeiro@6wind.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/6656/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/6656/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 4A3B8C4B8;\n\tWed, 29 Jul 2015 15:56:50 +0200 (CEST)", "from mail-wi0-f179.google.com (mail-wi0-f179.google.com\n\t[209.85.212.179]) by dpdk.org (Postfix) with ESMTP id 1AFEDC448\n\tfor <dev@dpdk.org>; Wed, 29 Jul 2015 15:56:49 +0200 (CEST)", "by wibxm9 with SMTP id xm9so202596511wib.0\n\tfor <dev@dpdk.org>; Wed, 29 Jul 2015 06:56:49 -0700 (PDT)", "from ping.vm.6wind.com (6wind.net2.nerim.net. [213.41.151.210])\n\tby smtp.gmail.com with ESMTPSA id\n\thd6sm24504169wib.19.2015.07.29.06.56.47 for <dev@dpdk.org>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 29 Jul 2015 06:56:48 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=372l3giD4bfHL5B8AfeS2hzfoSE9ZlTpk/8+pFhCKGk=;\n\tb=jtZcjmmuJ0QOtXH1kXeOlL63+GbCshBAnAd4YoS8gvd7cHzbZ0fzFtdcwBaN+XTwGy\n\tGkcNjCEN4phF2oDWy2NdfgZ3D5LAZKXNNFURrAeSfS6slnzjirE4gQOQ8SoA+jwACXcj\n\tgf2MM8zggkLjvduKkOxeFygCHShZ2XDEyHgstH6gWUuuwHxYWiVIt8QkYuj3vvEWEdPM\n\tzg8l44/9tssNPOwFosAQqzaWfj/IxJAPjSF1GdV8cigseRyH0Ii22lRNmkOCIhwtny7O\n\t0t3j+cGl10dNoY9SR0/AjEyaju7vmk38j+YKqZ5nFJ1yJS/vSEwT+orNeUVgz/fUD0Ww\n\tbIyQ==", "X-Gm-Message-State": "ALoCoQkIB4ViAM27pCB6ky/nv6AGvU/9k3yv3gNvdjV8Jml3JSl0KkSVDD/p46iNNmFNMT3FTmLA", "X-Received": "by 10.181.12.111 with SMTP id ep15mr17258420wid.15.1438178208816;\n\tWed, 29 Jul 2015 06:56:48 -0700 (PDT)", "From": "Nelio Laranjeiro <nelio.laranjeiro@6wind.com>", "To": "dev@dpdk.org", "Date": "Wed, 29 Jul 2015 15:56:18 +0200", "Message-Id": "<1438178178-5062-2-git-send-email-nelio.laranjeiro@6wind.com>", "X-Mailer": "git-send-email 1.9.1", "In-Reply-To": "<1438178178-5062-1-git-send-email-nelio.laranjeiro@6wind.com>", "References": "<1438178178-5062-1-git-send-email-nelio.laranjeiro@6wind.com>", "Subject": "[dpdk-dev] [PATCH 2/2] mlx4: add missing library dependency when\n\tcompiling in shared library", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "librte_pmd_mlx4.so needs to be linked with libiverbs otherwise, the PMD is not\nable to open Mellanox devices and the following message is printed by testpmd\nat startup \"librte_pmd_mlx4: cannot access device, is mlx4_ib loaded?\".\n\nApplications dependency on libverbs are moved to be only valid in static mode,\nin shared mode, applications do not depend on it anymore,\nlibrte_pmd_mlx4.so keeps this dependency and thus is linked with libverbs.\n\nSigned-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>\nAcked-by: Olivier Matz <olivier.matz@6wind.com>\n---\n drivers/net/mlx4/Makefile | 1 +\n mk/rte.app.mk | 2 +-\n 2 files changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/mlx4/Makefile b/drivers/net/mlx4/Makefile\nindex 14cb53f..d2f5692 100644\n--- a/drivers/net/mlx4/Makefile\n+++ b/drivers/net/mlx4/Makefile\n@@ -50,6 +50,7 @@ CFLAGS += -g\n CFLAGS += -I.\n CFLAGS += -D_XOPEN_SOURCE=600\n CFLAGS += $(WERROR_FLAGS)\n+LDLIBS += -libverbs\n \n # A few warnings cannot be avoided in external headers.\n CFLAGS += -Wno-error=cast-qual\ndiff --git a/mk/rte.app.mk b/mk/rte.app.mk\nindex 97719cb..04af756 100644\n--- a/mk/rte.app.mk\n+++ b/mk/rte.app.mk\n@@ -100,7 +100,6 @@ ifeq ($(CONFIG_RTE_LIBRTE_VHOST_USER),n)\n _LDLIBS-$(CONFIG_RTE_LIBRTE_VHOST) += -lfuse\n endif\n \n-_LDLIBS-$(CONFIG_RTE_LIBRTE_MLX4_PMD) += -libverbs\n _LDLIBS-$(CONFIG_RTE_LIBRTE_BNX2X_PMD) += -lz\n \n _LDLIBS-y += --start-group\n@@ -140,6 +139,7 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_RING) += -lrte_pmd_ring\n _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_PCAP) += -lrte_pmd_pcap\n _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET) += -lrte_pmd_af_packet\n _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_NULL) += -lrte_pmd_null\n+_LDLIBS-$(CONFIG_RTE_LIBRTE_MLX4_PMD) += -libverbs\n \n endif # ! $(CONFIG_RTE_BUILD_SHARED_LIB)\n \n", "prefixes": [ "dpdk-dev", "2/2" ] }