Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 6651,
    "url": "https://patches.dpdk.org/api/patches/6651/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1438144692-10114-1-git-send-email-yong.liu@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1438144692-10114-1-git-send-email-yong.liu@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1438144692-10114-1-git-send-email-yong.liu@intel.com",
    "date": "2015-07-29T04:38:12",
    "name": "[dpdk-dev] app test: fix eal --no-huge option should work with -m option",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "6b619d5358d3e1cc0ff7ce914ea2bd03308c2d4c",
    "submitter": {
        "id": 17,
        "url": "https://patches.dpdk.org/api/people/17/?format=api",
        "name": "Marvin Liu",
        "email": "yong.liu@intel.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1438144692-10114-1-git-send-email-yong.liu@intel.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/6651/comments/",
    "check": "pending",
    "checks": "https://patches.dpdk.org/api/patches/6651/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 02A5CC4E4;\n\tWed, 29 Jul 2015 06:38:23 +0200 (CEST)",
            "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id 7C9CEC4E2\n\tfor <dev@dpdk.org>; Wed, 29 Jul 2015 06:38:20 +0200 (CEST)",
            "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga101.jf.intel.com with ESMTP; 28 Jul 2015 21:38:19 -0700",
            "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby orsmga001.jf.intel.com with ESMTP; 28 Jul 2015 21:38:19 -0700",
            "from shecgisg003.sh.intel.com (shecgisg003.sh.intel.com\n\t[10.239.29.90])\n\tby shvmail01.sh.intel.com with ESMTP id t6T4cGXE020412;\n\tWed, 29 Jul 2015 12:38:16 +0800",
            "from shecgisg003.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg003.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid t6T4cELR010150; Wed, 29 Jul 2015 12:38:16 +0800",
            "(from yliu84x@localhost)\n\tby shecgisg003.sh.intel.com (8.13.6/8.13.6/Submit) id t6T4cEIj010146; \n\tWed, 29 Jul 2015 12:38:14 +0800"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.15,568,1432623600\"; d=\"scan'208\";a=\"737621610\"",
        "From": "Yong Liu <yong.liu@intel.com>",
        "To": "dev@dpdk.org",
        "Date": "Wed, 29 Jul 2015 12:38:12 +0800",
        "Message-Id": "<1438144692-10114-1-git-send-email-yong.liu@intel.com>",
        "X-Mailer": "git-send-email 1.7.4.1",
        "Subject": "[dpdk-dev] [PATCH] app test: fix eal --no-huge option should work\n\twith -m option",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "From: Marvin Liu <yong.liu@intel.com>\n\n'--no-huge' option now can workable with -m option.\nUnit test for eal flag should change pass criterion.\n\nSigned-off-by: Marvin Liu <yong.liu@intel.com>",
    "diff": "diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c\nindex 0352f87..e6f7035 100644\n--- a/app/test/test_eal_flags.c\n+++ b/app/test/test_eal_flags.c\n@@ -748,8 +748,8 @@ test_no_hpet_flag(void)\n }\n \n /*\n- * Test that the app runs with --no-huge and doesn't run when either\n- * -m or --socket-mem are specified with --no-huge.\n+ * Test that the app runs with --no-huge and doesn't run when --socket-mem are\n+ * specified with --no-huge.\n  */\n static int\n test_no_huge_flag(void)\n@@ -778,8 +778,8 @@ test_no_huge_flag(void)\n \t\tprintf(\"Error - process did not run ok with --no-huge flag\\n\");\n \t\treturn -1;\n \t}\n-\tif (launch_proc(argv2) == 0) {\n-\t\tprintf(\"Error - process run ok with --no-huge and -m flags\\n\");\n+\tif (launch_proc(argv2) != 0) {\n+\t\tprintf(\"Error - process did not run ok with --no-huge and -m flags\\n\");\n \t\treturn -1;\n \t}\n #ifdef RTE_EXEC_ENV_BSDAPP\n",
    "prefixes": [
        "dpdk-dev"
    ]
}