Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/66203/?format=api
{ "id": 66203, "url": "https://patches.dpdk.org/api/patches/66203/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200303015557.63621-1-taox.zhu@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200303015557.63621-1-taox.zhu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200303015557.63621-1-taox.zhu@intel.com", "date": "2020-03-03T01:55:57", "name": "[DPDK] net/ice: fix hash flow segmentation fault", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a55a0702e51d35f2a7a21f116158b5790231fba5", "submitter": { "id": 1368, "url": "https://patches.dpdk.org/api/people/1368/?format=api", "name": "Zhu, TaoX", "email": "taox.zhu@intel.com" }, "delegate": { "id": 31221, "url": "https://patches.dpdk.org/api/users/31221/?format=api", "username": "yexl", "first_name": "xiaolong", "last_name": "ye", "email": "xiaolong.ye@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200303015557.63621-1-taox.zhu@intel.com/mbox/", "series": [ { "id": 8752, "url": "https://patches.dpdk.org/api/series/8752/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=8752", "date": "2020-03-03T01:55:57", "name": "[DPDK] net/ice: fix hash flow segmentation fault", "version": 1, "mbox": "https://patches.dpdk.org/series/8752/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/66203/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/66203/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9688AA056F;\n\tTue, 3 Mar 2020 03:04:42 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0D0331BFF2;\n\tTue, 3 Mar 2020 03:04:42 +0100 (CET)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n by dpdk.org (Postfix) with ESMTP id 43C511BFF0;\n Tue, 3 Mar 2020 03:04:40 +0100 (CET)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n 02 Mar 2020 18:04:39 -0800", "from unknown (HELO dpdk-zhutao-d.sh.intel.com) ([10.240.179.68])\n by fmsmga001.fm.intel.com with ESMTP; 02 Mar 2020 18:04:36 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.70,509,1574150400\"; d=\"scan'208\";a=\"351711878\"", "From": "taox.zhu@intel.com", "To": "qiming.yang@intel.com,\n\twenzhuo.lu@intel.com", "Cc": "dev@dpdk.org, simei.su@intel.com, yahui.cao@intel.com,\n xiaolong.ye@intel.com, Zhu Tao <taox.zhu@intel.com>, stable@dpdk.org", "Date": "Tue, 3 Mar 2020 09:55:57 +0800", "Message-Id": "<20200303015557.63621-1-taox.zhu@intel.com>", "X-Mailer": "git-send-email 2.17.1", "Subject": "[dpdk-dev] [DPDK] net/ice: fix hash flow segmentation fault", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Zhu Tao <taox.zhu@intel.com>\n\nMacro rte_errno is not a static value, so it needs to be updated in all\nerror handling code.\n\nPatch 'dc36bd5dfd' mistakenly consider that rte_errno is a constant, which\ncauses the unrecognized flow rule to be marked as recognition success.\nLater, when the code tried to parse the flow rule, a null pointer caused\na segmentation fault.\n\nFixes: dc36bd5dfd (\"net/ice: fix flow FDIR/switch memory leak\")\nCc: stable@dpdk.org\n\nSigned-off-by: Zhu Tao <taox.zhu@intel.com>\n---\n drivers/net/ice/ice_hash.c | 14 ++++++++++----\n 1 file changed, 10 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c\nindex d891538bd..e5fb0f344 100644\n--- a/drivers/net/ice/ice_hash.c\n+++ b/drivers/net/ice/ice_hash.c\n@@ -409,7 +409,7 @@ ice_hash_parse_pattern_action(__rte_unused struct ice_adapter *ad,\n \t\t\tvoid **meta,\n \t\t\tstruct rte_flow_error *error)\n {\n-\tint ret = -rte_errno;\n+\tint ret = 0;\n \tstruct ice_pattern_match_item *pattern_match_item;\n \tstruct rss_meta *rss_meta_ptr;\n \n@@ -424,12 +424,16 @@ ice_hash_parse_pattern_action(__rte_unused struct ice_adapter *ad,\n \t/* Check rss supported pattern and find matched pattern. */\n \tpattern_match_item = ice_search_pattern_match_item(pattern,\n \t\t\t\t\tarray, array_len, error);\n-\tif (!pattern_match_item)\n+\tif (!pattern_match_item) {\n+\t\tret = -rte_errno;\n \t\tgoto error;\n+\t}\n \n \tret = ice_hash_check_inset(pattern, error);\n-\tif (ret)\n+\tif (ret) {\n+\t\tret = -rte_errno;\n \t\tgoto error;\n+\t}\n \n \t/* Save protocol header to rss_meta. */\n \t*meta = rss_meta_ptr;\n@@ -439,8 +443,10 @@ ice_hash_parse_pattern_action(__rte_unused struct ice_adapter *ad,\n \t/* Check rss action. */\n \tret = ice_hash_parse_action(pattern_match_item, actions, meta, error);\n error:\n-\tif (ret)\n+\tif (ret) {\n+\t\tret = -rte_errno;\n \t\trte_free(rss_meta_ptr);\n+\t}\n \trte_free(pattern_match_item);\n \n \treturn ret;\n", "prefixes": [ "DPDK" ] }