Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/66146/?format=api
{ "id": 66146, "url": "https://patches.dpdk.org/api/patches/66146/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200228182843.14568-1-sodey@rbbn.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200228182843.14568-1-sodey@rbbn.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200228182843.14568-1-sodey@rbbn.com", "date": "2020-02-28T18:28:43", "name": "[v2] net/bnx2x: handle guest vlan for SR-IOV case", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": true, "hash": "0eaae1a57607a5979df136617caee56f81b8f697", "submitter": { "id": 952, "url": "https://patches.dpdk.org/api/people/952/?format=api", "name": "Dey, Souvik", "email": "sodey@rbbn.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200228182843.14568-1-sodey@rbbn.com/mbox/", "series": [ { "id": 8730, "url": "https://patches.dpdk.org/api/series/8730/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=8730", "date": "2020-02-28T18:28:43", "name": "[v2] net/bnx2x: handle guest vlan for SR-IOV case", "version": 2, "mbox": "https://patches.dpdk.org/series/8730/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/66146/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/66146/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6B2E4A0564;\n\tFri, 28 Feb 2020 19:29:20 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1C1041BFCE;\n\tFri, 28 Feb 2020 19:29:19 +0100 (CET)", "from us-smtp-delivery-181.mimecast.com\n (us-smtp-delivery-181.mimecast.com [216.205.24.181])\n by dpdk.org (Postfix) with ESMTP id A363E1BFC7\n for <dev@dpdk.org>; Fri, 28 Feb 2020 19:29:17 +0100 (CET)", "from NAM12-MW2-obe.outbound.protection.outlook.com\n (mail-mw2nam12lp2043.outbound.protection.outlook.com [104.47.66.43]) (Using\n TLS) by relay.mimecast.com with ESMTP id\n us-mta-13-xaKmQBPRM0Kwcp8KlZBzkQ-1; Fri, 28 Feb 2020 13:29:14 -0500", "from MN2PR03MB4781.namprd03.prod.outlook.com (2603:10b6:208:ae::23)\n by MN2SPR01MB0055.namprd03.prod.outlook.com (2603:10b6:208:1d1::9)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2772.14; Fri, 28 Feb\n 2020 18:29:08 +0000", "from MN2PR03MB4781.namprd03.prod.outlook.com\n ([fe80::347a:449f:f327:3a89]) by MN2PR03MB4781.namprd03.prod.outlook.com\n ([fe80::347a:449f:f327:3a89%7]) with mapi id 15.20.2750.024; Fri, 28 Feb 2020\n 18:29:08 +0000", "from SODEY-LMA.sonusnet.com (208.45.178.4) by\n MN2PR20CA0028.namprd20.prod.outlook.com (2603:10b6:208:e8::41) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id\n 15.20.2772.15 via Frontend Transport; Fri, 28 Feb 2020 18:29:07 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=rbbn.com;\n s=mimecast20180816; t=1582914557;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=dFNw+c4lb1YPsaxCNn+c0JlSNuVJzEDA+NsqTKC7aBQ=;\n b=ZO7GNC9LXt6v88r01w1icaPcfkPWf8KLqQFAEkwRQTyEXB/NMeFMAxtQkGbYREN1WtwWG3\n d/8Zq8kHhTQR1ErVqA0uYOFVl8cHg6+L5//stQDeHEC332eiH3zgXy1rwLg9WU9J0ygXLk\n y3l6jIYX3LzLE7UO7Yek+PAkYHRR+0A=", "X-MC-Unique": "xaKmQBPRM0Kwcp8KlZBzkQ-1", "From": "\"Dey, Souvik\" <sodey@rbbn.com>", "To": "rmody@marvell.com, shshaikh@marvell.com, jerinj@marvell.com,\n ferruh.yigit@intel.com, thomas@monjalon.net", "Cc": "dev@dpdk.org,\n\tstable@dpdk.org,\n\t\"Dey, Souvik\" <sodey@rbbn.com>", "Date": "Fri, 28 Feb 2020 13:28:43 -0500", "Message-Id": "<20200228182843.14568-1-sodey@rbbn.com>", "X-Mailer": [ "git-send-email 2.9.3.windows.1", "git-send-email 2.9.3.windows.1" ], "In-Reply-To": "<20200226163635.18252-1-sodey@rbbn.com>", "References": "<20200226163635.18252-1-sodey@rbbn.com>", "X-ClientProxiedBy": "MN2PR20CA0028.namprd20.prod.outlook.com\n (2603:10b6:208:e8::41) To MN2PR03MB4781.namprd03.prod.outlook.com\n (2603:10b6:208:ae::23)", "MIME-Version": "1.0", "X-MS-Exchange-MessageSentRepresentingType": "1", "X-Originating-IP": "[208.45.178.4]", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "8e8ed0b4-6654-4c43-bad2-08d7bc7c1914", "X-MS-TrafficTypeDiagnostic": "MN2SPR01MB0055:", "X-MS-Exchange-Transport-Forked": "True", "X-Microsoft-Antispam-PRVS": "\n <MN2SPR01MB00558CA28BCEB612333B4940CDE80@MN2SPR01MB0055.namprd03.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:9508;", "X-Forefront-PRVS": "0327618309", "X-Forefront-Antispam-Report": "SFV:NSPM;\n SFS:(10009020)(4636009)(136003)(39850400004)(396003)(366004)(346002)(376002)(199004)(189003)(5660300002)(66476007)(66556008)(2616005)(956004)(2906002)(26005)(16526019)(66946007)(186003)(6506007)(86362001)(81166006)(6512007)(8936002)(6666004)(81156014)(36756003)(6486002)(107886003)(8676002)(52116002)(478600001)(1076003)(4326008)(316002);\n DIR:OUT; SFP:1101; SCL:1; SRVR:MN2SPR01MB0055;\n H:MN2PR03MB4781.namprd03.prod.outlook.com; FPR:; SPF:None; LANG:en;\n PTR:InfoNoRecords; A:1; MX:1;", "X-MS-Exchange-SenderADCheck": "1", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n uhPAYDdjyp87kpGM+jyAf2wDJENeRRiNP0vRWnFN4nMCjQlHMJECLr+onzyjgk7+53AnCaWdUrc5fbYHsPrbhsVWKZxpR6n1W1HZ+jHLYOHKqisOxnKDF+SbiS3NHJ09RhgjmFnytPJTutEg38zMM6ZF76eXxHF7D/Y3AN6XAJ/eG977UPBy2lADm6Iuw2ZmqRzVgo/bsWa8YcwGQxKf7ma6WvLjA4dkGNkRRG67wjyU1XJX/U8NegiDgB3qfOyKKGmx/MVCn86kAhsu+Uq9JOveLRip82UOhnbvA3WsmbrcQa+8sxMQi5cki6ISgA0Vi8c96qe1Jhdpa/18SOK3qlJBafH2a3DGXiFKL6PfNQzlwiGoM4DqRcSYQyQJBiPYVSY91C2/dVgd1i+S4qBUxl2kwEgeogqKIUsxQUapNb+p2XQhazhWVqo1HI+T1fMh", "X-MS-Exchange-AntiSpam-MessageData": "\n OiSTGycFt/Z7GlaASE2374hAa8uDB3mhQZ3Hj2+KStPEVVUNBh1382efzVF9S7C8kUxZrDlUiufGxsFYc2KxRCzuq5+UcFSleEea/54PFec7b0tocpfH4Coboy7a+QjIviU1phdprRXn5ViL9aIuqQ==", "X-OriginatorOrg": "rbbn.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 8e8ed0b4-6654-4c43-bad2-08d7bc7c1914", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "28 Feb 2020 18:29:08.1498 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "29a671dc-ed7e-4a54-b1e5-8da1eb495dc3", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n Q2zAk0YM5LyE+nAK3ErrZgGnyX5yZ9wlbzoA/RMV0WDSWn0YnfDbvMR/tirZgeDo", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "MN2SPR01MB0055", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "rbbn.com", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "quoted-printable", "X-Content-Filtered-By": "Mailman/MimeDel 2.1.15", "Subject": "[dpdk-dev] [PATCH v2] net/bnx2x: handle guest vlan for SR-IOV case", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "In case of bnx2xvf pmd, tx packets can support vland id in 2 ways :\n1. setting the mbuf ol_flags=PKT_TX_VLAN_PKT and passing the\nvlanid in mbuf->vlan_tci.\n2. the tx packet itself has the vlan id included in the packet.\nThe first case is working as expected but the second case where\nthe vlan id is included in thetx packets itself was found not\nworking as expected. To handle that we need to properly set the\nstart_bd bitfield and the vlan_or_ethertype instead of setting it\nto just the ethertype in case of VF.\n\nSigned-off-by: \"Dey, Souvik\" <sodey@rbbn.com>\n---\nv2:\n* Fixed complitaion issues \n ether_type to rte_ether_type/\n ETHER_TYPE_VLAN to RTE_ETHER_TYPE_VLAN/\n vlan_hdr to rte_vlan_hdr/\n* Changed the subject line from bnx2x to net/bnx2x.\n\n drivers/net/bnx2x/bnx2x.c | 9 +++++----\n 1 file changed, 5 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c\nindex f7cca21..a96e8c2 100644\n--- a/drivers/net/bnx2x/bnx2x.c\n+++ b/drivers/net/bnx2x/bnx2x.c\n@@ -2219,11 +2219,11 @@ int bnx2x_tx_encap(struct bnx2x_tx_queue *txq, struct rte_mbuf *m0)\n \t\t\t/* when transmitting in a vf, start bd must hold the ethertype\n \t\t\t * for fw to enforce it\n \t\t\t */\n-\t\t\tstruct ether_hdr *eh =\n+\t\t\tstruct rte_ether_hdr *eh =\n \t\t\t rte_pktmbuf_mtod(m0, struct ether_hdr *);\n \t\t\t/* Still need to consider inband vlan for enforced */\n-\t\t\tif (eh->ether_type == rte_cpu_to_be_16(ETHER_TYPE_VLAN)) {\n-\t\t\t\tstruct vlan_hdr *vh = (struct vlan_hdr *)(eh + 1);\n+\t\t\tif (eh->ether_type == rte_cpu_to_be_16(RTE_ETHER_TYPE_VLAN)) {\n+\t\t\t\tstruct rte_vlan_hdr *vh = (struct vlan_hdr *)(eh + 1);\n \t\t\t\ttx_start_bd->bd_flags.as_bitfield |=\n \t\t\t\t\t(X_ETH_INBAND_VLAN <<\n \t\t\t\t\t\tETH_TX_BD_FLAGS_VLAN_MODE_SHIFT);\n@@ -2231,7 +2231,8 @@ int bnx2x_tx_encap(struct bnx2x_tx_queue *txq, struct rte_mbuf *m0)\n \t\t\t\t\trte_cpu_to_le_16(ntohs(vh->vlan_tci));\n \t\t\t} else {\n \t\t\t\ttx_start_bd->vlan_or_ethertype =\n-\t\t\t\t\trte_cpu_to_le_16(rte_be_to_cpu_16(eh->ether_type));\n+\t\t\t\t\t(rte_cpu_to_le_16(\n+\t\t\t\t\t\trte_be_to_cpu_16(eh->ether_type)));\n \t\t\t}\n \t\t}\n \t}\n", "prefixes": [ "v2" ] }