Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/65958/?format=api
{ "id": 65958, "url": "https://patches.dpdk.org/api/patches/65958/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200220110431.30074-1-rnagadheeraj@marvell.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200220110431.30074-1-rnagadheeraj@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200220110431.30074-1-rnagadheeraj@marvell.com", "date": "2020-02-20T11:04:31", "name": "crypto/nitrox: fix coverity defects", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "da538b75551081b46077f9ec0ddbf068343e69cd", "submitter": { "id": 1365, "url": "https://patches.dpdk.org/api/people/1365/?format=api", "name": "Nagadheeraj Rottela", "email": "rnagadheeraj@marvell.com" }, "delegate": { "id": 6690, "url": "https://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200220110431.30074-1-rnagadheeraj@marvell.com/mbox/", "series": [ { "id": 8629, "url": "https://patches.dpdk.org/api/series/8629/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=8629", "date": "2020-02-20T11:04:31", "name": "crypto/nitrox: fix coverity defects", "version": 1, "mbox": "https://patches.dpdk.org/series/8629/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/65958/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/65958/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 24D5FA0556;\n\tThu, 20 Feb 2020 12:04:45 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 013A437B0;\n\tThu, 20 Feb 2020 12:04:45 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 1986A3B5\n for <dev@dpdk.org>; Thu, 20 Feb 2020 12:04:42 +0100 (CET)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id\n 01KB05Gt032091; Thu, 20 Feb 2020 03:04:42 -0800", "from sc-exch01.marvell.com ([199.233.58.181])\n by mx0b-0016f401.pphosted.com with ESMTP id 2y8ubv72w1-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Thu, 20 Feb 2020 03:04:42 -0800", "from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH01.marvell.com\n (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 20 Feb\n 2020 03:04:39 -0800", "from hyd1399.marvell.com (10.93.176.43) by SC-EXCH01.marvell.com\n (10.93.176.81) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Thu, 20 Feb 2020 03:04:38 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : mime-version : content-type; s=pfpt0818;\n bh=ENVrcm4nrFdB7+CDZvNsUVwlD7D2FpALTp8/iZK/N88=;\n b=mqSPbx/lTKvxsp8lCAnqH6C3C0Fr3he4Hgc6ZCKY3zTSRPYJYW7iKOmOyday5wniq7w1\n q3TMKf+t6OxAW1rsNJzfdcN95Hab5qWPolNaBN9MDyEBGOKNiAOD0GTTV8pJVUMBfUds\n 0f2FnYECMjpCtZf5c0a3H7YTmeWRotm5UEvYRysGOLp5sB1WUDsIdLWDslsKTSiVlAIt\n zH1/DQAAYFCZVzYWty0aw150+Hsjy69TGAT7oMT6T2YVIp0Mct1+F8wakyT0PjRiC4Ru\n ALgEKni5GL+J2JTTuGy9dJh8MAbL862lrbuxu5elOhCxLI8SrAUVuBA6mYatnUx3v8C3 Xw==", "From": "Nagadheeraj Rottela <rnagadheeraj@marvell.com>", "To": "<akhil.goyal@nxp.com>", "CC": "<dev@dpdk.org>, <jsrikanth@marvell.com>, Nagadheeraj Rottela\n <rnagadheeraj@marvell.com>", "Date": "Thu, 20 Feb 2020 16:34:31 +0530", "Message-ID": "<20200220110431.30074-1-rnagadheeraj@marvell.com>", "X-Mailer": "git-send-email 2.13.6", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.138, 18.0.572\n definitions=2020-02-20_03:2020-02-19,\n 2020-02-20 signatures=0", "Subject": "[dpdk-dev] [PATCH] crypto/nitrox: fix coverity defects", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Address the defects reported by coverity: Unintended sign extension\nand Out-of-bounds access.\n\nCoverity issue: 349899, 349905, 349911, 349921, 349923, 349926\n\nFixes: 32e4930d5a3b (\"crypto/nitrox: add hardware queue management\")\nFixes: 9fdef0cc2385 (\"crypto/nitrox: create symmetric cryptodev\")\n\nSigned-off-by: Nagadheeraj Rottela <rnagadheeraj@marvell.com>\n---\n drivers/crypto/nitrox/nitrox_csr.h | 18 +++++++++---------\n drivers/crypto/nitrox/nitrox_sym.c | 3 ++-\n 2 files changed, 11 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/crypto/nitrox/nitrox_csr.h b/drivers/crypto/nitrox/nitrox_csr.h\nindex 8cd92e38b..b4c969b26 100644\n--- a/drivers/crypto/nitrox/nitrox_csr.h\n+++ b/drivers/crypto/nitrox/nitrox_csr.h\n@@ -12,15 +12,15 @@\n #define NITROX_CSR_ADDR(bar_addr, offset) (bar_addr + (offset))\n \n /* NPS packet registers */\n-#define NPS_PKT_IN_INSTR_CTLX(_i)\t(0x10060 + ((_i) * 0x40000))\n-#define NPS_PKT_IN_INSTR_BADDRX(_i)\t(0x10068 + ((_i) * 0x40000))\n-#define NPS_PKT_IN_INSTR_RSIZEX(_i)\t(0x10070 + ((_i) * 0x40000))\n-#define NPS_PKT_IN_DONE_CNTSX(_i)\t(0x10080 + ((_i) * 0x40000))\n-#define NPS_PKT_IN_INSTR_BAOFF_DBELLX(_i)\t(0x10078 + ((_i) * 0x40000))\n-#define NPS_PKT_IN_INT_LEVELSX(_i)\t\t(0x10088 + ((_i) * 0x40000))\n-#define NPS_PKT_SLC_CTLX(_i)\t\t(0x10000 + ((_i) * 0x40000))\n-#define NPS_PKT_SLC_CNTSX(_i)\t\t(0x10008 + ((_i) * 0x40000))\n-#define NPS_PKT_SLC_INT_LEVELSX(_i)\t(0x10010 + ((_i) * 0x40000))\n+#define NPS_PKT_IN_INSTR_CTLX(_i)\t(0x10060UL + ((_i) * 0x40000UL))\n+#define NPS_PKT_IN_INSTR_BADDRX(_i)\t(0x10068UL + ((_i) * 0x40000UL))\n+#define NPS_PKT_IN_INSTR_RSIZEX(_i)\t(0x10070UL + ((_i) * 0x40000UL))\n+#define NPS_PKT_IN_DONE_CNTSX(_i)\t(0x10080UL + ((_i) * 0x40000UL))\n+#define NPS_PKT_IN_INSTR_BAOFF_DBELLX(_i)\t(0x10078UL + ((_i) * 0x40000UL))\n+#define NPS_PKT_IN_INT_LEVELSX(_i)\t\t(0x10088UL + ((_i) * 0x40000UL))\n+#define NPS_PKT_SLC_CTLX(_i)\t\t(0x10000UL + ((_i) * 0x40000UL))\n+#define NPS_PKT_SLC_CNTSX(_i)\t\t(0x10008UL + ((_i) * 0x40000UL))\n+#define NPS_PKT_SLC_INT_LEVELSX(_i)\t(0x10010UL + ((_i) * 0x40000UL))\n \n /* AQM Virtual Function Registers */\n #define AQMQ_QSZX(_i)\t\t\t(0x20008 + ((_i)*0x40000))\ndiff --git a/drivers/crypto/nitrox/nitrox_sym.c b/drivers/crypto/nitrox/nitrox_sym.c\nindex 56410c44d..d1b32fec9 100644\n--- a/drivers/crypto/nitrox/nitrox_sym.c\n+++ b/drivers/crypto/nitrox/nitrox_sym.c\n@@ -683,7 +683,8 @@ nitrox_sym_pmd_create(struct nitrox_device *ndev)\n \tstruct rte_cryptodev *cdev;\n \n \trte_pci_device_name(&ndev->pdev->addr, name, sizeof(name));\n-\tsnprintf(name + strlen(name), RTE_CRYPTODEV_NAME_MAX_LEN, \"_n5sym\");\n+\tsnprintf(name + strlen(name), RTE_CRYPTODEV_NAME_MAX_LEN - strlen(name),\n+\t\t \"_n5sym\");\n \tndev->rte_sym_dev.driver = &nitrox_rte_sym_drv;\n \tndev->rte_sym_dev.numa_node = ndev->pdev->device.numa_node;\n \tndev->rte_sym_dev.devargs = NULL;\n", "prefixes": [] }