Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/6594/?format=api
{ "id": 6594, "url": "https://patches.dpdk.org/api/patches/6594/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1437757584-15502-12-git-send-email-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1437757584-15502-12-git-send-email-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/1437757584-15502-12-git-send-email-stephen@networkplumber.org", "date": "2015-07-24T17:06:24", "name": "[dpdk-dev,11/11] bond: remove useless cast", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "2ba4447ad6068261b00dba9a73481edc9da165a0", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1437757584-15502-12-git-send-email-stephen@networkplumber.org/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/6594/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/6594/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 495D3C4CA;\n\tFri, 24 Jul 2015 19:06:42 +0200 (CEST)", "from mail-pa0-f52.google.com (mail-pa0-f52.google.com\n\t[209.85.220.52]) by dpdk.org (Postfix) with ESMTP id EB5BEC4A8\n\tfor <dev@dpdk.org>; Fri, 24 Jul 2015 19:06:32 +0200 (CEST)", "by pachj5 with SMTP id hj5so17138939pac.3\n\tfor <dev@dpdk.org>; Fri, 24 Jul 2015 10:06:32 -0700 (PDT)", "from urahara.home.lan (static-50-53-82-155.bvtn.or.frontiernet.net.\n\t[50.53.82.155]) by smtp.gmail.com with ESMTPSA id\n\tra10sm15635403pab.19.2015.07.24.10.06.30\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tFri, 24 Jul 2015 10:06:30 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=MMmuWp2xHjxWcKTi0UEzS0jcX1Y6074zztWGJmJN3A4=;\n\tb=mZc2GVHk27HJ8E1YtFFjDFCXeJkncTEbXvx1/1escbFUS7VibRrXYwnMzuhVg1Vlvw\n\ttMJRPAIZzRz4jqQl9BQvI0+aR2tLgxqllLvWyAk64/M4YHvAyKqeNaHpA4mBabqAqlDe\n\tn3sHOPktOTwarczngi0FhatjaDGAzY4gYxo76a6j07WSQTawc1S7tlHBEHrDBRtzPDo2\n\t0qJ26tHjiPYMhfEcLjjy9BHhxL5TrNpyffa77zwEFYK+MWhy4lbH1iw1mzI7WdaAVh8e\n\tjoUxSR2ZSKS7oCGok32m08O8UdXmfO4DPUspxUOl8TSF4Nfa7AxkUIPcGB5vTLJRNUE0\n\tmQoA==", "X-Gm-Message-State": "ALoCoQlr3hv4ydG2/bLqAN7KJn+PbqWpBYxb6ZcubShQTefeUCo4fuKgj/c0QoQoqvJG5X4Cj7lv", "X-Received": "by 10.70.48.98 with SMTP id k2mr33591697pdn.69.1437757592386;\n\tFri, 24 Jul 2015 10:06:32 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Date": "Fri, 24 Jul 2015 10:06:24 -0700", "Message-Id": "<1437757584-15502-12-git-send-email-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.1.4", "In-Reply-To": "<1437757584-15502-1-git-send-email-stephen@networkplumber.org>", "References": "<1437757584-15502-1-git-send-email-stephen@networkplumber.org>", "Subject": "[dpdk-dev] [PATCH 11/11] bond: remove useless cast", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Found by coccinelle script.\ndrivers/net/bonding/rte_eth_bond_pmd.c:1587:34-54: WARNING: casting value returned by memory allocation function to (struct bond_rx_queue *) is useless.\ndrivers/net/bonding/rte_eth_bond_pmd.c:1611:35-55: WARNING: casting value returned by memory allocation function to (struct bond_tx_queue *) is useless.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/bonding/rte_eth_bond_pmd.c | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c\nindex 9cafe65..5e8c447 100644\n--- a/drivers/net/bonding/rte_eth_bond_pmd.c\n+++ b/drivers/net/bonding/rte_eth_bond_pmd.c\n@@ -1584,9 +1584,9 @@ bond_ethdev_rx_queue_setup(struct rte_eth_dev *dev, uint16_t rx_queue_id,\n \t\tuint16_t nb_rx_desc, unsigned int socket_id __rte_unused,\n \t\tconst struct rte_eth_rxconf *rx_conf, struct rte_mempool *mb_pool)\n {\n-\tstruct bond_rx_queue *bd_rx_q = (struct bond_rx_queue *)\n-\t\t\trte_zmalloc_socket(NULL, sizeof(struct bond_rx_queue),\n-\t\t\t\t\t0, dev->pci_dev->numa_node);\n+\tstruct bond_rx_queue *bd_rx_q\n+\t\t= rte_zmalloc_socket(NULL, sizeof(struct bond_rx_queue),\n+\t\t\t\t 0, dev->pci_dev->numa_node);\n \tif (bd_rx_q == NULL)\n \t\treturn -1;\n \n@@ -1608,9 +1608,9 @@ bond_ethdev_tx_queue_setup(struct rte_eth_dev *dev, uint16_t tx_queue_id,\n \t\tuint16_t nb_tx_desc, unsigned int socket_id __rte_unused,\n \t\tconst struct rte_eth_txconf *tx_conf)\n {\n-\tstruct bond_tx_queue *bd_tx_q = (struct bond_tx_queue *)\n-\t\t\trte_zmalloc_socket(NULL, sizeof(struct bond_tx_queue),\n-\t\t\t\t\t0, dev->pci_dev->numa_node);\n+\tstruct bond_tx_queue *bd_tx_q\n+\t\t= rte_zmalloc_socket(NULL, sizeof(struct bond_tx_queue),\n+\t\t\t\t 0, dev->pci_dev->numa_node);\n \n \tif (bd_tx_q == NULL)\n \t\treturn -1;\n", "prefixes": [ "dpdk-dev", "11/11" ] }