Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/65898/?format=api
{ "id": 65898, "url": "https://patches.dpdk.org/api/patches/65898/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200219101712.9525-1-taox.zhu@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200219101712.9525-1-taox.zhu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200219101712.9525-1-taox.zhu@intel.com", "date": "2020-02-19T10:17:12", "name": "net/ice: fix queue bind MSI-X interrupt error", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "753378352dc4473360870402eca69dce39ae5aad", "submitter": { "id": 1368, "url": "https://patches.dpdk.org/api/people/1368/?format=api", "name": "Zhu, TaoX", "email": "taox.zhu@intel.com" }, "delegate": { "id": 31221, "url": "https://patches.dpdk.org/api/users/31221/?format=api", "username": "yexl", "first_name": "xiaolong", "last_name": "ye", "email": "xiaolong.ye@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200219101712.9525-1-taox.zhu@intel.com/mbox/", "series": [ { "id": 8605, "url": "https://patches.dpdk.org/api/series/8605/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=8605", "date": "2020-02-19T10:17:12", "name": "net/ice: fix queue bind MSI-X interrupt error", "version": 1, "mbox": "https://patches.dpdk.org/series/8605/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/65898/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/65898/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A77A1A0555;\n\tWed, 19 Feb 2020 11:31:25 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6BC811B951;\n\tWed, 19 Feb 2020 11:31:24 +0100 (CET)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n by dpdk.org (Postfix) with ESMTP id 7CF54397D;\n Wed, 19 Feb 2020 11:31:22 +0100 (CET)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n 19 Feb 2020 02:31:21 -0800", "from unknown (HELO localhost.localdomain) ([10.239.250.16])\n by fmsmga001.fm.intel.com with ESMTP; 19 Feb 2020 02:31:19 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.70,459,1574150400\"; d=\"scan'208\";a=\"348915077\"", "From": "taox.zhu@intel.com", "To": "qiming.yang@intel.com,\n\twenzhuo.lu@intel.com", "Cc": "dev@dpdk.org, beilei.xing@intel.com, qi.z.zhang@intel.com,\n xiaolong.ye@intel.com, Zhu Tao <taox.zhu@intel.com>, stable@dpdk.org", "Date": "Wed, 19 Feb 2020 18:17:12 +0800", "Message-Id": "<20200219101712.9525-1-taox.zhu@intel.com>", "X-Mailer": "git-send-email 2.17.1", "Subject": "[dpdk-dev] [PATCH] net/ice: fix queue bind MSI-X interrupt error", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Zhu Tao <taox.zhu@intel.com>\n\nTo bind a queue to an MSI-X interrupt, need to set some register.\nThe register consists of many parts, each of which has several\nbits; therefore, the shift operator '<<' was used; so the operator\n'<' in the code should be '<<'.\n\nOld code adds 1 on even MSI-X interrupt vector index used by queue,\nresulting in interrupt mapping error.\n\nFixes: 65dfc889d8 (\"net/ice: support Rx queue interruption\")\nCc: stable@dpdk.org\n\nSigned-off-by: Zhu Tao <taox.zhu@intel.com>\n---\n drivers/net/ice/ice_ethdev.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c\nindex 8e9369e0a..85ef83e92 100644\n--- a/drivers/net/ice/ice_ethdev.c\n+++ b/drivers/net/ice/ice_ethdev.c\n@@ -2605,9 +2605,9 @@ __vsi_queues_bind_intr(struct ice_vsi *vsi, uint16_t msix_vect,\n \tfor (i = 0; i < nb_queue; i++) {\n \t\t/*do actual bind*/\n \t\tval = (msix_vect & QINT_RQCTL_MSIX_INDX_M) |\n-\t\t (0 < QINT_RQCTL_ITR_INDX_S) | QINT_RQCTL_CAUSE_ENA_M;\n+\t\t (0 << QINT_RQCTL_ITR_INDX_S) | QINT_RQCTL_CAUSE_ENA_M;\n \t\tval_tx = (msix_vect & QINT_TQCTL_MSIX_INDX_M) |\n-\t\t\t (0 < QINT_TQCTL_ITR_INDX_S) | QINT_TQCTL_CAUSE_ENA_M;\n+\t\t\t (0 << QINT_TQCTL_ITR_INDX_S) | QINT_TQCTL_CAUSE_ENA_M;\n \n \t\tPMD_DRV_LOG(INFO, \"queue %d is binding to vect %d\",\n \t\t\t base_queue + i, msix_vect);\n", "prefixes": [] }