Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/65827/?format=api
{ "id": 65827, "url": "https://patches.dpdk.org/api/patches/65827/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200217164345.6207-1-taox.zhu@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200217164345.6207-1-taox.zhu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200217164345.6207-1-taox.zhu@intel.com", "date": "2020-02-17T16:43:45", "name": "mempool/octeontx2: fix compile issue", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "65095b1719a50809d0ae2504d69776f5323653f2", "submitter": { "id": 1368, "url": "https://patches.dpdk.org/api/people/1368/?format=api", "name": "Zhu, TaoX", "email": "taox.zhu@intel.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200217164345.6207-1-taox.zhu@intel.com/mbox/", "series": [ { "id": 8555, "url": "https://patches.dpdk.org/api/series/8555/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=8555", "date": "2020-02-17T16:43:45", "name": "mempool/octeontx2: fix compile issue", "version": 1, "mbox": "https://patches.dpdk.org/series/8555/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/65827/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/65827/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2AA3EA0551;\n\tMon, 17 Feb 2020 09:09:02 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 54D1058C4;\n\tMon, 17 Feb 2020 09:09:01 +0100 (CET)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n by dpdk.org (Postfix) with ESMTP id B89402C4F\n for <dev@dpdk.org>; Mon, 17 Feb 2020 09:08:59 +0100 (CET)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n 17 Feb 2020 00:08:58 -0800", "from unknown (HELO localhost.localdomain) ([10.239.250.16])\n by fmsmga001.fm.intel.com with ESMTP; 17 Feb 2020 00:08:56 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.70,451,1574150400\"; d=\"scan'208\";a=\"348448345\"", "From": "taox.zhu@intel.com", "To": "jerinj@marvell.com,\n\tndabilpuram@marvell.com,\n\tvattunuru@marvell.com", "Cc": "dev@dpdk.org,\n\tTao Zhu <taox.zhu@intel.com>", "Date": "Mon, 17 Feb 2020 16:43:45 +0000", "Message-Id": "<20200217164345.6207-1-taox.zhu@intel.com>", "X-Mailer": "git-send-email 2.17.1", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] mempool/octeontx2: fix compile issue", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Tao Zhu <taox.zhu@intel.com>\n\nChange the definition of C99 style to C90 style.\ncompile log as below:\n\notx2_mempool_ops.c: In function ‘otx2_npa_populate’:\n/dpdk/drivers/mempool/octeontx2/otx2_mempool_ops.c:790:2: error: \\\n\t‘for’ loop initial declarations are only allowed in C99 mode\n for (int i = 0; i < OTX2_L1D_NB_SETS; i++)\n ^\n/dpdk/drivers/mempool/octeontx2/otx2_mempool_ops.c:790:2: \\\n\tnote: use option -std=c99 or -std=gnu99 to compile your code\n/dpdk/drivers/mempool/octeontx2/otx2_mempool_ops.c: At top level:\ncc1: error: unrecognized command line option \\\n\t\"-Wno-address-of-packed-member\" [-Werror]\ncc1: all warnings being treated as errors\nmake[6]: *** [otx2_mempool_ops.o] Error 1\nmake[5]: *** [octeontx2] Error 2\nmake[4]: *** [mempool] Error 2\n\nFixes: 9ed8e95c (\"mempool/octeontx2: optimize for L1D cache architecture\")\n\nSigned-off-by: Tao Zhu <taox.zhu@intel.com>\n---\n drivers/mempool/octeontx2/otx2_mempool_ops.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/mempool/octeontx2/otx2_mempool_ops.c b/drivers/mempool/octeontx2/otx2_mempool_ops.c\nindex 6b55447..ac2d618 100644\n--- a/drivers/mempool/octeontx2/otx2_mempool_ops.c\n+++ b/drivers/mempool/octeontx2/otx2_mempool_ops.c\n@@ -754,6 +754,7 @@\n \tsize_t total_elt_sz;\n \tuint8_t set;\n \tsize_t off;\n+\tint i;\n \n \tif (iova == RTE_BAD_IOVA)\n \t\treturn -EINVAL;\n@@ -787,7 +788,7 @@\n \totx2_npa_dbg(\"requested objects %\"PRIu64\", possible objects %\"PRIu64\"\",\n \t\t (uint64_t)max_objs, (uint64_t)(len / total_elt_sz));\n \totx2_npa_dbg(\"L1D set distribution :\");\n-\tfor (int i = 0; i < OTX2_L1D_NB_SETS; i++)\n+\tfor (i = 0; i < OTX2_L1D_NB_SETS; i++)\n \t\totx2_npa_dbg(\"set[%d] : objects : %\"PRIu64\"\", i,\n \t\t\t distribution[i]);\n \n", "prefixes": [] }