Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/65198/?format=api
{ "id": 65198, "url": "https://patches.dpdk.org/api/patches/65198/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200128072923.9912-10-somnath.kotur@broadcom.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200128072923.9912-10-somnath.kotur@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200128072923.9912-10-somnath.kotur@broadcom.com", "date": "2020-01-28T07:29:23", "name": "[9/9] net/bnxt: fix coverity warnings", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "e5e9d99e6b4bd45826e993e94528c13988748154", "submitter": { "id": 908, "url": "https://patches.dpdk.org/api/people/908/?format=api", "name": "Somnath Kotur", "email": "somnath.kotur@broadcom.com" }, "delegate": { "id": 1766, "url": "https://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200128072923.9912-10-somnath.kotur@broadcom.com/mbox/", "series": [ { "id": 8314, "url": "https://patches.dpdk.org/api/series/8314/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=8314", "date": "2020-01-28T07:29:14", "name": "bnxt patchset", "version": 2, "mbox": "https://patches.dpdk.org/series/8314/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/65198/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/65198/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C5071A04B3;\n\tTue, 28 Jan 2020 08:32:10 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B10AD1C132;\n\tTue, 28 Jan 2020 08:31:02 +0100 (CET)", "from relay.smtp.broadcom.com (unknown [192.19.211.62])\n by dpdk.org (Postfix) with ESMTP id E531F1C0C9\n for <dev@dpdk.org>; Tue, 28 Jan 2020 08:30:49 +0100 (CET)", "from dhcp-10-123-153-55.dhcp.broadcom.net\n (bgccx-dev-host-lnx35.bec.broadcom.net [10.123.153.55])\n by relay.smtp.broadcom.com (Postfix) with ESMTP id 8004729051C;\n Mon, 27 Jan 2020 23:30:49 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 relay.smtp.broadcom.com 8004729051C", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1580196649;\n bh=kS/vdRjL4cG+IU3TxCPvu4DWoG5dHp/by1GElb/YT6M=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=RDkQULhty3SX4faYEu0ocD9KYcOUCpov7dc5/ipZCqkxCrKr6YZGOpJqokp6mFZ9q\n ChGzr0qow08vk0GVOk2Oxf2pA5KutSL2io01ZQDIcuD/OC/yC7Gf0YqvNfXXyGEx/h\n Yi3vKtjquwlNaoXhHLuc9s0Z6voULd+MPIBDYcV0=", "From": "Somnath Kotur <somnath.kotur@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com", "Date": "Tue, 28 Jan 2020 12:59:23 +0530", "Message-Id": "<20200128072923.9912-10-somnath.kotur@broadcom.com>", "X-Mailer": "git-send-email 2.10.1.613.g2cc2e70", "In-Reply-To": "<20200128072923.9912-1-somnath.kotur@broadcom.com>", "References": "<20200128072923.9912-1-somnath.kotur@broadcom.com>", "Subject": "[dpdk-dev] [PATCH 9/9] net/bnxt: fix coverity warnings", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\n\nreturn value stored in \"ret\" but it has been overwritten before use.\n\nCID 353621: Code maintainability issues (UNUSED_VALUE)\nFixes: 57813868 (\"net/bnxt: fix VLAN strip\")\nFixes: df6cd7c1 (\"net/bnxt: handle reset notify async event from FW\")\n\nSigned-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\nReviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\nSigned-off-by: Somnath Kotur <somnath.kotur@broadcom.com>\n---\n drivers/net/bnxt/bnxt_ethdev.c | 18 +++++++++++++++---\n 1 file changed, 15 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex 72e5441..c1cb401 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -1956,9 +1956,15 @@ static int bnxt_free_one_vnic(struct bnxt *bp, uint16_t vnic_id)\n \tif (bp->eth_dev->data->dev_conf.rxmode.offloads &\n \t DEV_RX_OFFLOAD_VLAN_FILTER) {\n \t\trc = bnxt_add_vlan_filter(bp, 0);\n-\t\tbnxt_restore_vlan_filters(bp);\n+\t\tif (rc)\n+\t\t\treturn rc;\n+\t\trc = bnxt_restore_vlan_filters(bp);\n+\t\tif (rc)\n+\t\t\treturn rc;\n \t} else {\n \t\trc = bnxt_add_mac_filter(bp, vnic, NULL, 0, 0);\n+\t\tif (rc)\n+\t\t\treturn rc;\n \t}\n \n \trc = bnxt_hwrm_cfa_l2_set_rx_mask(bp, vnic, 0, NULL);\n@@ -3961,10 +3967,16 @@ static int bnxt_restore_filters(struct bnxt *bp)\n \tstruct rte_eth_dev *dev = bp->eth_dev;\n \tint ret = 0;\n \n-\tif (dev->data->all_multicast)\n+\tif (dev->data->all_multicast) {\n \t\tret = bnxt_allmulticast_enable_op(dev);\n-\tif (dev->data->promiscuous)\n+\t\tif (ret)\n+\t\t\treturn ret;\n+\t}\n+\tif (dev->data->promiscuous) {\n \t\tret = bnxt_promiscuous_enable_op(dev);\n+\t\tif (ret)\n+\t\t\treturn ret;\n+\t}\n \n \tret = bnxt_restore_mac_filters(bp);\n \tif (ret)\n", "prefixes": [ "9/9" ] }