Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/64275/?format=api
{ "id": 64275, "url": "https://patches.dpdk.org/api/patches/64275/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200107153946.6876-1-rory.sexton@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200107153946.6876-1-rory.sexton@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200107153946.6876-1-rory.sexton@intel.com", "date": "2020-01-07T15:39:45", "name": "[v3,1/2] ethdev: add L2TPv3 over IP header to flow API", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "d6f7e1d14647a4e21c6a0705cdc2a1950233e29e", "submitter": { "id": 619, "url": "https://patches.dpdk.org/api/people/619/?format=api", "name": "Sexton, Rory", "email": "rory.sexton@intel.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200107153946.6876-1-rory.sexton@intel.com/mbox/", "series": [ { "id": 8007, "url": "https://patches.dpdk.org/api/series/8007/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=8007", "date": "2020-01-07T15:39:45", "name": "[v3,1/2] ethdev: add L2TPv3 over IP header to flow API", "version": 3, "mbox": "https://patches.dpdk.org/series/8007/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/64275/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/64275/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 12BC5A04F3;\n\tTue, 7 Jan 2020 16:44:53 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 8B3AE1D9DA;\n\tTue, 7 Jan 2020 16:44:52 +0100 (CET)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n by dpdk.org (Postfix) with ESMTP id 3A08B1D9CA\n for <dev@dpdk.org>; Tue, 7 Jan 2020 16:44:51 +0100 (CET)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n 07 Jan 2020 07:44:50 -0800", "from silpixa00399483.ir.intel.com (HELO\n silpixa00399483.ger.corp.intel.com) ([10.237.223.172])\n by fmsmga008.fm.intel.com with ESMTP; 07 Jan 2020 07:44:48 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.69,406,1571727600\"; d=\"scan'208\";a=\"217779423\"", "From": "Rory Sexton <rory.sexton@intel.com>", "To": "dev@dpdk.org, qi.z.zhang@intel.com, beilei.xing@intel.com,\n adrien.mazarguil@6wind.com, orika@mellanox.com", "Cc": "Rory Sexton <rory.sexton@intel.com>,\n Dariusz Jagus <dariuszx.jagus@intel.com>", "Date": "Tue, 7 Jan 2020 15:39:45 +0000", "Message-Id": "<20200107153946.6876-1-rory.sexton@intel.com>", "X-Mailer": "git-send-email 2.17.1", "Subject": "[dpdk-dev] [PATCH v3 1/2] ethdev: add L2TPv3 over IP header to flow\n\tAPI", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch adds the new flow item RTE_FLOW_ITEM_TYPE_L2TPV3OIP to\nflow API to match a L2TPv3 over IP header. This patch supports only\nL2TPv3 over IP header format which is different to L2TPv2/L2TPv3\nover UDP. The difference in header formats between L2TPv3 over IP\nand L2TP over UDP require a separate implementation for each.\n\nSigned-off-by: Rory Sexton <rory.sexton@intel.com>\nSigned-off-by: Dariusz Jagus <dariuszx.jagus@intel.com>\n---\nv3 changes: adding testpmd docs updates\n---\n app/test-pmd/cmdline_flow.c | 33 +++++++++++++++++++++\n doc/guides/prog_guide/rte_flow.rst | 8 +++++\n doc/guides/testpmd_app_ug/testpmd_funcs.rst | 4 +++\n lib/librte_ethdev/rte_flow.c | 1 +\n lib/librte_ethdev/rte_flow.h | 29 +++++++++++++++++-\n 5 files changed, 74 insertions(+), 1 deletion(-)", "diff": "diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c\nindex 99dade7d8..72a792d93 100644\n--- a/app/test-pmd/cmdline_flow.c\n+++ b/app/test-pmd/cmdline_flow.c\n@@ -213,6 +213,8 @@ enum index {\n \tITEM_TAG,\n \tITEM_TAG_DATA,\n \tITEM_TAG_INDEX,\n+\tITEM_L2TPV3OIP,\n+\tITEM_L2TPV3OIP_SESSION_ID,\n \n \t/* Validate/create actions. */\n \tACTIONS,\n@@ -746,6 +748,7 @@ static const enum index next_item[] = {\n \tITEM_PPPOE_PROTO_ID,\n \tITEM_HIGIG2,\n \tITEM_TAG,\n+\tITEM_L2TPV3OIP,\n \tEND_SET,\n \tZERO,\n };\n@@ -1030,6 +1033,12 @@ static const enum index item_tag[] = {\n \tZERO,\n };\n \n+static const enum index item_l2tpv3oip[] = {\n+\tITEM_L2TPV3OIP_SESSION_ID,\n+\tITEM_NEXT,\n+\tZERO,\n+};\n+\n static const enum index next_action[] = {\n \tACTION_END,\n \tACTION_VOID,\n@@ -2593,6 +2602,22 @@ static const struct token token_list[] = {\n \t\t\t NEXT_ENTRY(ITEM_PARAM_IS)),\n \t\t.args = ARGS(ARGS_ENTRY(struct rte_flow_item_tag, index)),\n \t},\n+\t[ITEM_L2TPV3OIP] = {\n+\t\t.name = \"l2tpv3oip\",\n+\t\t.help = \"match L2TPv3 over IP header\",\n+\t\t.priv = PRIV_ITEM(L2TPV3OIP,\n+\t\t\t\t sizeof(struct rte_flow_item_l2tpv3oip)),\n+\t\t.next = NEXT(item_l2tpv3oip),\n+\t\t.call = parse_vc,\n+\t},\n+\t[ITEM_L2TPV3OIP_SESSION_ID] = {\n+\t\t.name = \"session_id\",\n+\t\t.help = \"session identifier\",\n+\t\t.next = NEXT(item_l2tpv3oip, NEXT_ENTRY(UNSIGNED), item_param),\n+\t\t.args = ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_l2tpv3oip,\n+\t\t\t\t\t session_id)),\n+\t},\n+\n \t/* Validate/create actions. */\n \t[ACTIONS] = {\n \t\t.name = \"actions\",\n@@ -6238,6 +6263,10 @@ flow_item_default_mask(const struct rte_flow_item *item)\n \t\tbreak;\n \tcase RTE_FLOW_ITEM_TYPE_PPPOE_PROTO_ID:\n \t\tmask = &rte_flow_item_pppoe_proto_id_mask;\n+\t\tbreak;\n+\tcase RTE_FLOW_ITEM_TYPE_L2TPV3OIP:\n+\t\tmask = &rte_flow_item_l2tpv3oip_mask;\n+\t\tbreak;\n \tdefault:\n \t\tbreak;\n \t}\n@@ -6327,6 +6356,10 @@ cmd_set_raw_parsed(const struct buffer *in)\n \t\tcase RTE_FLOW_ITEM_TYPE_GENEVE:\n \t\t\tsize = sizeof(struct rte_flow_item_geneve);\n \t\t\tbreak;\n+\t\tcase RTE_FLOW_ITEM_TYPE_L2TPV3OIP:\n+\t\t\tsize = sizeof(struct rte_flow_item_l2tpv3oip);\n+\t\t\tproto = 0x73;\n+\t\t\tbreak;\n \t\tdefault:\n \t\t\tprintf(\"Error - Not supported item\\n\");\n \t\t\t*total_size = 0;\ndiff --git a/doc/guides/prog_guide/rte_flow.rst b/doc/guides/prog_guide/rte_flow.rst\nindex a254c81ef..d4cef4621 100644\n--- a/doc/guides/prog_guide/rte_flow.rst\n+++ b/doc/guides/prog_guide/rte_flow.rst\n@@ -1336,6 +1336,14 @@ Broadcom switches.\n \n - Default ``mask`` matches classification and vlan.\n \n+Item: ``L2TPV3OIP``\n+^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n+\n+Matches a L2TPv3 over IP header.\n+\n+- ``session_id``: L2TPv3 over IP session identifier.\n+- Default ``mask`` matches session_id only.\n+\n \n Actions\n ~~~~~~~\ndiff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst\nindex 73ef0b41d..5e6935829 100644\n--- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst\n+++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst\n@@ -3954,6 +3954,10 @@ This section lists supported pattern items and their attributes, if any.\n \n - ``proto_id {unsigned}``: PPP protocol identifier.\n \n+- ``l2tpv3oip``: match L2TPv3 over IP header.\n+\n+ - ``session_id {unsigned}``: L2TPv3 over IP session identifier.\n+\n Actions list\n ^^^^^^^^^^^^\n \ndiff --git a/lib/librte_ethdev/rte_flow.c b/lib/librte_ethdev/rte_flow.c\nindex 87a3e8c4c..4d130be77 100644\n--- a/lib/librte_ethdev/rte_flow.c\n+++ b/lib/librte_ethdev/rte_flow.c\n@@ -93,6 +93,7 @@ static const struct rte_flow_desc_data rte_flow_desc_item[] = {\n \tMK_FLOW_ITEM(IGMP, sizeof(struct rte_flow_item_igmp)),\n \tMK_FLOW_ITEM(AH, sizeof(struct rte_flow_item_ah)),\n \tMK_FLOW_ITEM(HIGIG2, sizeof(struct rte_flow_item_higig2_hdr)),\n+\tMK_FLOW_ITEM(L2TPV3OIP, sizeof(struct rte_flow_item_l2tpv3oip)),\n };\n \n /** Generate flow_action[] entry. */\ndiff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h\nindex 452d359a1..8c7f6c12a 100644\n--- a/lib/librte_ethdev/rte_flow.h\n+++ b/lib/librte_ethdev/rte_flow.h\n@@ -502,7 +502,7 @@ enum rte_flow_item_type {\n \t */\n \tRTE_FLOW_ITEM_TYPE_HIGIG2,\n \n-\t/*\n+\t/**\n \t * [META]\n \t *\n \t * Matches a tag value.\n@@ -510,6 +510,16 @@ enum rte_flow_item_type {\n \t * See struct rte_flow_item_tag.\n \t */\n \tRTE_FLOW_ITEM_TYPE_TAG,\n+\n+\t/**\n+\t * Matches a L2TPv3 over IP header.\n+\t *\n+\t * Configure flow for L2TPv3 over IP packets.\n+\t *\n+\t * See struct rte_flow_item_l2tpv3oip.\n+\t */\n+\tRTE_FLOW_ITEM_TYPE_L2TPV3OIP,\n+\n };\n \n /**\n@@ -1373,6 +1383,23 @@ static const struct rte_flow_item_tag rte_flow_item_tag_mask = {\n };\n #endif\n \n+/**\n+ * RTE_FLOW_ITEM_TYPE_L2TPV3OIP.\n+ *\n+ * Matches a L2TPv3 over IP header.\n+ */\n+struct rte_flow_item_l2tpv3oip {\n+\trte_be32_t session_id; /**< Session ID. */\n+};\n+\n+/** Default mask for RTE_FLOW_ITEM_TYPE_L2TPV3OIP. */\n+#ifndef __cplusplus\n+static const struct rte_flow_item_l2tpv3oip rte_flow_item_l2tpv3oip_mask = {\n+\t.session_id = RTE_BE32(UINT32_MAX),\n+};\n+#endif\n+\n+\n /**\n * @warning\n * @b EXPERIMENTAL: this structure may change without prior notice\n", "prefixes": [ "v3", "1/2" ] }