Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/6401/?format=api
{ "id": 6401, "url": "https://patches.dpdk.org/api/patches/6401/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1436955120-5548-1-git-send-email-sergio.gonzalez.monroy@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1436955120-5548-1-git-send-email-sergio.gonzalez.monroy@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1436955120-5548-1-git-send-email-sergio.gonzalez.monroy@intel.com", "date": "2015-07-15T10:12:00", "name": "[dpdk-dev] eal: set hugepgae_sz to 4KB when using --no-huge", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "35ee79fd9615c2db2f2c6b1765c11a6b54c19f0a", "submitter": { "id": 73, "url": "https://patches.dpdk.org/api/people/73/?format=api", "name": "Sergio Gonzalez Monroy", "email": "sergio.gonzalez.monroy@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1436955120-5548-1-git-send-email-sergio.gonzalez.monroy@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/6401/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/6401/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 5917D5A8C;\n\tWed, 15 Jul 2015 12:12:05 +0200 (CEST)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby dpdk.org (Postfix) with ESMTP id 324BA5A7A\n\tfor <dev@dpdk.org>; Wed, 15 Jul 2015 12:12:03 +0200 (CEST)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga103.jf.intel.com with ESMTP; 15 Jul 2015 03:12:02 -0700", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby orsmga002.jf.intel.com with ESMTP; 15 Jul 2015 03:12:02 -0700", "from sivswdev02.ir.intel.com (sivswdev02.ir.intel.com\n\t[10.237.217.46])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tt6FAC06J025820; Wed, 15 Jul 2015 11:12:00 +0100", "from sivswdev02.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev02.ir.intel.com with ESMTP id t6FAC0Fu005589;\n\tWed, 15 Jul 2015 11:12:00 +0100", "(from smonroy@localhost)\n\tby sivswdev02.ir.intel.com with id t6FAC099005585;\n\tWed, 15 Jul 2015 11:12:00 +0100" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.15,479,1432623600\"; d=\"scan'208\";a=\"764829577\"", "From": "Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>", "To": "dev@dpdk.org", "Date": "Wed, 15 Jul 2015 11:12:00 +0100", "Message-Id": "<1436955120-5548-1-git-send-email-sergio.gonzalez.monroy@intel.com>", "X-Mailer": "git-send-email 1.8.5.4", "In-Reply-To": "<tencent_06BE1BD20BEC88F81E937905@qq.com>", "References": "<tencent_06BE1BD20BEC88F81E937905@qq.com>", "Subject": "[dpdk-dev] [PATCH] eal: set hugepgae_sz to 4KB when using --no-huge", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "After code rework from bellow commit, logic expects hugepage_sz field to\nalways be set (ie. not zero value).\nWhen using --no-huge, this field was left unset defaulting to zero.\n\nSet hugepage_sz to RTE_PGSIZE_4K when using --no-huge.\n\nFixes: b3dfffd962ecd (\"mem: allow multiple page sizes to be requested\")\n\nSigned-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>\n---\n lib/librte_eal/bsdapp/eal/eal_memory.c | 1 +\n lib/librte_eal/linuxapp/eal/eal_memory.c | 1 +\n 2 files changed, 2 insertions(+)", "diff": "diff --git a/lib/librte_eal/bsdapp/eal/eal_memory.c b/lib/librte_eal/bsdapp/eal/eal_memory.c\nindex 33ebd0f..a3242a5 100644\n--- a/lib/librte_eal/bsdapp/eal/eal_memory.c\n+++ b/lib/librte_eal/bsdapp/eal/eal_memory.c\n@@ -75,6 +75,7 @@ rte_eal_contigmem_init(void)\n \t\taddr = malloc(internal_config.memory);\n \t\tmcfg->memseg[0].phys_addr = (phys_addr_t)(uintptr_t)addr;\n \t\tmcfg->memseg[0].addr = addr;\n+\t\tmcfg->memseg[0].hugepage_sz = RTE_PGSIZE_4K;\n \t\tmcfg->memseg[0].len = internal_config.memory;\n \t\tmcfg->memseg[0].socket_id = 0;\n \t\treturn 0;\ndiff --git a/lib/librte_eal/linuxapp/eal/eal_memory.c b/lib/librte_eal/linuxapp/eal/eal_memory.c\nindex e501c49..4fd63bb 100644\n--- a/lib/librte_eal/linuxapp/eal/eal_memory.c\n+++ b/lib/librte_eal/linuxapp/eal/eal_memory.c\n@@ -1069,6 +1069,7 @@ rte_eal_hugepage_init(void)\n \t\t}\n \t\tmcfg->memseg[0].phys_addr = (phys_addr_t)(uintptr_t)addr;\n \t\tmcfg->memseg[0].addr = addr;\n+\t\tmcfg->memseg[0].hugepage_sz = RTE_PGSIZE_4K;\n \t\tmcfg->memseg[0].len = internal_config.memory;\n \t\tmcfg->memseg[0].socket_id = SOCKET_ID_ANY;\n \t\treturn 0;\n", "prefixes": [ "dpdk-dev" ] }