Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/64007/?format=api
{ "id": 64007, "url": "https://patches.dpdk.org/api/patches/64007/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20191219104434.32578-1-kkanas@marvell.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191219104434.32578-1-kkanas@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191219104434.32578-1-kkanas@marvell.com", "date": "2019-12-19T10:44:34", "name": "mempool/octeontx: fix error handling in initialization", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "21e4fea2d266d6f2abd6f77c328fd140899eb3f2", "submitter": { "id": 1302, "url": "https://patches.dpdk.org/api/people/1302/?format=api", "name": "Krzysztof Kanas", "email": "kkanas@marvell.com" }, "delegate": { "id": 310, "url": "https://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20191219104434.32578-1-kkanas@marvell.com/mbox/", "series": [ { "id": 7895, "url": "https://patches.dpdk.org/api/series/7895/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=7895", "date": "2019-12-19T10:44:34", "name": "mempool/octeontx: fix error handling in initialization", "version": 1, "mbox": "https://patches.dpdk.org/series/7895/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/64007/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/64007/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id EF36BA04F0;\n\tThu, 19 Dec 2019 11:44:41 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 175741BDFD;\n\tThu, 19 Dec 2019 11:44:41 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 82D261252\n for <dev@dpdk.org>; Thu, 19 Dec 2019 11:44:39 +0100 (CET)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id\n xBJAicPB018149 for <dev@dpdk.org>; Thu, 19 Dec 2019 02:44:38 -0800", "from sc-exch03.marvell.com ([199.233.58.183])\n by mx0a-0016f401.pphosted.com with ESMTP id 2wxneb2jyw-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Thu, 19 Dec 2019 02:44:38 -0800", "from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH03.marvell.com\n (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 19 Dec\n 2019 02:44:36 -0800", "from maili.marvell.com (10.93.176.43) by SC-EXCH03.marvell.com\n (10.93.176.83) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Thu, 19 Dec 2019 02:44:36 -0800", "from kk-box-0.marvell.com (unknown [10.95.130.75])\n by maili.marvell.com (Postfix) with ESMTP id 983363F7040;\n Thu, 19 Dec 2019 02:44:35 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : mime-version : content-transfer-encoding :\n content-type; s=pfpt0818; bh=7yM9EGzxMctb4V6Z3XGEdhGpNrDnP0Jm/bIGTQNbkuU=;\n b=yVjAQ0s8kypb4YcZ+5WdMtj80zIqJYmL4kdhz+/rKOAvtz/DMU7GIQ7HbJ3czzxxzsTs\n CRfwZWLjO4DDMg1HY0+hxWbPpXZuCTVw4Xeswruyrq+GU9cprDqxqLkQ/x7Y+6rRhf62\n nOBhwHRHoJbmGoS376dymssIQCHoPqrnsWgJwvnQocKjdj8cl8/lTqm5mR7Vc0g+EKJ+\n nLWHjHF4JvfvLg2U9q9uVW3Rg8MLbDq/ShM8abytwiafcE66w4aQ3P3Lc1hkXnjO7hTa\n EZAXqdxT9ZMrQ89rvR9aH3eiy+KFZB8XNwBh0JexbxUxZz6/eWfB8sxLbnFOG5vP38tk EA==", "From": "<kkanas@marvell.com>", "To": "<dev@dpdk.org>, Harman Kalra <hkalra@marvell.com>", "CC": "Krzysztof Kanas <kkanas@marvell.com>, <pbhagavatula@marvell.com>", "Date": "Thu, 19 Dec 2019 11:44:34 +0100", "Message-ID": "<20191219104434.32578-1-kkanas@marvell.com>", "X-Mailer": "git-send-email 2.21.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.95,18.0.572\n definitions=2019-12-19_01:2019-12-17,2019-12-19 signatures=0", "Subject": "[dpdk-dev] [PATCH] mempool/octeontx: fix error handling in\n\tinitialization", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Krzysztof Kanas <kkanas@marvell.com>\n\nWhen octeontx_get_fpavf fails fpa pointer is used to get\npool_stack_base, which is then freed.\n\nCoverity issue: 351263\n\nFixes: 9bc692f83baa (\"mempool/octeontx: add application domain validation\")\nCc: pbhagavatula@marvell.com\n\nSigned-off-by: Krzysztof Kanas <kkanas@marvell.com>\n---\n drivers/mempool/octeontx/octeontx_fpavf.c | 6 ++----\n 1 file changed, 2 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/mempool/octeontx/octeontx_fpavf.c b/drivers/mempool/octeontx/octeontx_fpavf.c\nindex c97267db3cc3..63f8fb3b500a 100644\n--- a/drivers/mempool/octeontx/octeontx_fpavf.c\n+++ b/drivers/mempool/octeontx/octeontx_fpavf.c\n@@ -305,10 +305,8 @@ octeontx_fpapf_pool_destroy(unsigned int gpool_index)\n \tint ret = -1;\n \n \tfpa = octeontx_get_fpavf(gpool_index);\n-\tif (fpa == NULL) {\n-\t\tret = -EINVAL;\n-\t\tgoto err;\n-\t}\n+\tif (fpa == NULL)\n+\t\treturn -EINVAL;\n \n \thdr.coproc = FPA_COPROC;\n \thdr.msg = FPA_CONFIGSET;\n", "prefixes": [] }