Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/640/?format=api
{ "id": 640, "url": "https://patches.dpdk.org/api/patches/640/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1411988346-20861-1-git-send-email-thomas.monjalon@6wind.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1411988346-20861-1-git-send-email-thomas.monjalon@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1411988346-20861-1-git-send-email-thomas.monjalon@6wind.com", "date": "2014-09-29T10:59:06", "name": "[dpdk-dev] pci: remove flag for multiple devices with single id", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "ce9f5f85ca7066ad043f01078686f0faa478dd7c", "submitter": { "id": 1, "url": "https://patches.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1411988346-20861-1-git-send-email-thomas.monjalon@6wind.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/640/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/640/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 594036A99;\n\tMon, 29 Sep 2014 12:52:53 +0200 (CEST)", "from mail-wg0-f41.google.com (mail-wg0-f41.google.com\n\t[74.125.82.41]) by dpdk.org (Postfix) with ESMTP id 9B9076A96\n\tfor <dev@dpdk.org>; Mon, 29 Sep 2014 12:52:49 +0200 (CEST)", "by mail-wg0-f41.google.com with SMTP id k14so13097851wgh.24\n\tfor <dev@dpdk.org>; Mon, 29 Sep 2014 03:59:25 -0700 (PDT)", "from localhost.localdomain (136-92-190-109.dsl.ovh.fr.\n\t[109.190.92.136]) by mx.google.com with ESMTPSA id\n\tt8sm11295362wib.8.2014.09.29.03.59.23 for <dev@dpdk.org>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tMon, 29 Sep 2014 03:59:24 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:subject:date:message-id;\n\tbh=0D0c1zab/n7KV8ZXqK4hapTSyy6OenVP11BA+BKRkmc=;\n\tb=mfCobPBRSMp7n8HNlxNfjNpz01zVPmola2ZPcPaSKPFyMoKX5lzgKfCR+k/MWlkCCE\n\tDtOjYJYmPBnIbh4Ki3TOoI+KefiUklebZJ0LuVxLCVDhJh0CLdaQE/czd84bJUCc3ZUd\n\tpuka1KMZGbsh73JeUHani+e2QZQpvVKVxffHqqT8SEvA6ZNEjmqX063u+wORqeVm0CdT\n\t6B9aiGIlgq3s9wEdc3S4nvxaGWxZp3m9lbI37cxz+bQ3S6Frhq5dDnqSGdLO/ulzXFeV\n\tpcfnNBt+rCpHjimJfkxLvITPp5vdElCn8vPgdh7vevIzqbPq1tT6+lsJZ1sjxdNkKPLq\n\t0Ojg==", "X-Gm-Message-State": "ALoCoQmSbxaZfLYQ2WvYdfrguDCfQ2WvL6LMpWgSxpD7Tewuup4SKnTbG8rMtaV+d2Em7AVHJ15N", "X-Received": "by 10.194.93.193 with SMTP id cw1mr35853351wjb.50.1411988365123; \n\tMon, 29 Sep 2014 03:59:25 -0700 (PDT)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "dev@dpdk.org", "Date": "Mon, 29 Sep 2014 12:59:06 +0200", "Message-Id": "<1411988346-20861-1-git-send-email-thomas.monjalon@6wind.com>", "X-Mailer": "git-send-email 2.0.4", "Subject": "[dpdk-dev] [PATCH] pci: remove flag for multiple devices with\n\tsingle id", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The flag RTE_PCI_DRV_MULTIPLE was used to register an eth_driver allowing\nmultiples devices with a single PCI id.\nIt is now possible to register a pci_driver and create ethdev objects\nusing rte_eth_dev_allocate().\n\nSuggested-by: David Marchand <david.marchand@6wind.com>\nSigned-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>\n---\n lib/librte_eal/common/eal_common_pci.c | 10 ----------\n lib/librte_eal/common/include/rte_pci.h | 4 ++--\n 2 files changed, 2 insertions(+), 12 deletions(-)", "diff": "diff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/common/eal_common_pci.c\nindex af809a8..f3c7f71 100644\n--- a/lib/librte_eal/common/eal_common_pci.c\n+++ b/lib/librte_eal/common/eal_common_pci.c\n@@ -103,10 +103,6 @@ static struct rte_devargs *pci_devargs_lookup(struct rte_pci_device *dev)\n * If vendor/device ID match, call the devinit() function of all\n * registered driver for the given device. Return -1 if initialization\n * failed, return 1 if no driver is found for this device.\n- * For drivers with the RTE_PCI_DRV_MULTIPLE flag enabled, register\n- * the same device multiple times until failure to do so.\n- * It is required for non-Intel NIC drivers provided by third-parties such\n- * as 6WIND.\n */\n static int\n pci_probe_all_drivers(struct rte_pci_device *dev)\n@@ -122,12 +118,6 @@ pci_probe_all_drivers(struct rte_pci_device *dev)\n \t\tif (rc > 0)\n \t\t\t/* positive value means driver not found */\n \t\t\tcontinue;\n-\t\t/* initialize subsequent driver instances for this device */\n-\t\tif ((dr->drv_flags & RTE_PCI_DRV_MULTIPLE) &&\n-\t\t\t(dev->devargs == NULL ||\n-\t\t\t\tdev->devargs->type != RTE_DEVTYPE_BLACKLISTED_PCI))\n-\t\t\twhile (rte_eal_pci_probe_one_driver(dr, dev) == 0)\n-\t\t\t\t;\n \t\treturn 0;\n \t}\n \treturn 1;\ndiff --git a/lib/librte_eal/common/include/rte_pci.h b/lib/librte_eal/common/include/rte_pci.h\nindex d6b1c1b..66ed793 100644\n--- a/lib/librte_eal/common/include/rte_pci.h\n+++ b/lib/librte_eal/common/include/rte_pci.h\n@@ -193,8 +193,8 @@ struct rte_pci_driver {\n \n /** Device needs PCI BAR mapping (done with either IGB_UIO or VFIO) */\n #define RTE_PCI_DRV_NEED_MAPPING 0x0001\n-/** Device driver must be registered several times until failure */\n-#define RTE_PCI_DRV_MULTIPLE 0x0002\n+/** Device driver must be registered several times until failure - deprecated */\n+#pragma GCC poison RTE_PCI_DRV_MULTIPLE\n /** Device needs to be unbound even if no module is provided */\n #define RTE_PCI_DRV_FORCE_UNBIND 0x0004\n /** Device driver supports link state interrupt */\n", "prefixes": [ "dpdk-dev" ] }