Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/63675/?format=api
{ "id": 63675, "url": "https://patches.dpdk.org/api/patches/63675/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20191209182314.4698-1-mmanning@vyatta.att-mail.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191209182314.4698-1-mmanning@vyatta.att-mail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191209182314.4698-1-mmanning@vyatta.att-mail.com", "date": "2019-12-09T18:23:14", "name": "net/mlx5: fix eagain on admin down", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": true, "hash": "8d9153ea12ead7ecb008e75a069818ecd0d4d009", "submitter": { "id": 1534, "url": "https://patches.dpdk.org/api/people/1534/?format=api", "name": "Mike Manning", "email": "mmanning@vyatta.att-mail.com" }, "delegate": { "id": 3268, "url": "https://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20191209182314.4698-1-mmanning@vyatta.att-mail.com/mbox/", "series": [ { "id": 7758, "url": "https://patches.dpdk.org/api/series/7758/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=7758", "date": "2019-12-09T18:23:14", "name": "net/mlx5: fix eagain on admin down", "version": 1, "mbox": "https://patches.dpdk.org/series/7758/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/63675/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/63675/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1B6C3A04F1;\n\tMon, 9 Dec 2019 19:23:43 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 291DE23D;\n\tMon, 9 Dec 2019 19:23:42 +0100 (CET)", "from mx0a-00191d01.pphosted.com (mx0b-00191d01.pphosted.com\n [67.231.157.136]) by dpdk.org (Postfix) with ESMTP id CB2861F5\n for <dev@dpdk.org>; Mon, 9 Dec 2019 19:23:40 +0100 (CET)", "from pps.filterd (m0049458.ppops.net [127.0.0.1])\n by m0049458.ppops.net-00191d01. (8.16.0.42/8.16.0.42) with SMTP id\n xB9IFRsu040826; Mon, 9 Dec 2019 13:23:39 -0500", "from alpi155.enaf.aldc.att.com (sbcsmtp7.sbc.com [144.160.229.24])\n by m0049458.ppops.net-00191d01. with ESMTP id 2wsa8sa6nr-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Mon, 09 Dec 2019 13:23:39 -0500", "from enaf.aldc.att.com (localhost [127.0.0.1])\n by alpi155.enaf.aldc.att.com (8.14.5/8.14.5) with ESMTP id xB9INcdN003146;\n Mon, 9 Dec 2019 13:23:38 -0500", "from zlp27128.vci.att.com (zlp27128.vci.att.com [135.66.87.50])\n by alpi155.enaf.aldc.att.com (8.14.5/8.14.5) with ESMTP id xB9INYU0003069\n (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);\n Mon, 9 Dec 2019 13:23:35 -0500", "from zlp27128.vci.att.com (zlp27128.vci.att.com [127.0.0.1])\n by zlp27128.vci.att.com (Service) with ESMTP id D9BC84039341;\n Mon, 9 Dec 2019 18:23:34 +0000 (GMT)", "from mlpi432.sfdc.sbc.com (unknown [144.151.223.11])\n by zlp27128.vci.att.com (Service) with ESMTP id C61954039340;\n Mon, 9 Dec 2019 18:23:34 +0000 (GMT)", "from sfdc.sbc.com (localhost [127.0.0.1])\n by mlpi432.sfdc.sbc.com (8.14.5/8.14.5) with ESMTP id xB9INXET013464;\n Mon, 9 Dec 2019 13:23:34 -0500", "from mail.eng.vyatta.net (mail.eng.vyatta.net [10.156.50.82])\n by mlpi432.sfdc.sbc.com (8.14.5/8.14.5) with ESMTP id xB9INRMY011632;\n Mon, 9 Dec 2019 13:23:28 -0500", "from MM-7520.vyatta.net (unknown [10.156.47.168])\n by mail.eng.vyatta.net (Postfix) with ESMTPA id AF3DB36008E;\n Mon, 9 Dec 2019 10:23:26 -0800 (PST)" ], "From": "Mike Manning <mmanning@vyatta.att-mail.com>", "To": "dev@dpdk.org", "Cc": "=?utf-8?q?N=C3=A9lio_Laranjeiro?= <nelio.laranjeiro@6wind.com>", "Date": "Mon, 9 Dec 2019 18:23:14 +0000", "Message-Id": "<20191209182314.4698-1-mmanning@vyatta.att-mail.com>", "X-Mailer": "git-send-email 2.11.0", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.95,18.0.572\n definitions=2019-12-09_04:2019-12-09,2019-12-09 signatures=0", "X-Proofpoint-Spam-Details": "rule=outbound_policy_notspam policy=outbound_policy\n score=0\n lowpriorityscore=0 phishscore=0 priorityscore=1501 mlxscore=0\n mlxlogscore=897 adultscore=0 spamscore=0 clxscore=1011 impostorscore=0\n malwarescore=0 suspectscore=1 bulkscore=0 classifier=spam adjust=0\n reason=mlx scancount=1 engine=8.12.0-1910280000\n definitions=main-1912090146", "Subject": "[dpdk-dev] [PATCH] net/mlx5: fix eagain on admin down", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The check in mlx5_link_update_unlocked_gs() returns -EAGAIN if link\nstatus does not correspond to link speed. If status is DOWN, the speed\nis expected to be ETH_SPEED_NUM_NONE (0). But as the link speed is -1\non admin down, modify the check to account for this.\n\nFixes: cfee94752b8f (\"net/mlx5: fix link status to use wait to complete\")\nCc: Nélio Laranjeiro <nelio.laranjeiro@6wind.com>\n\nSigned-off-by: Mike Manning <mmanning@vyatta.att-mail.com>\n---\n drivers/net/mlx5/mlx5_ethdev.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c\nindex d80ae458b..6ef2dfd74 100644\n--- a/drivers/net/mlx5/mlx5_ethdev.c\n+++ b/drivers/net/mlx5/mlx5_ethdev.c\n@@ -1031,8 +1031,8 @@ mlx5_link_update_unlocked_gs(struct rte_eth_dev *dev,\n \t\t\t\tETH_LINK_HALF_DUPLEX : ETH_LINK_FULL_DUPLEX);\n \tdev_link.link_autoneg = !(dev->data->dev_conf.link_speeds &\n \t\t\t\t ETH_LINK_SPEED_FIXED);\n-\tif (((dev_link.link_speed && !dev_link.link_status) ||\n-\t (!dev_link.link_speed && dev_link.link_status))) {\n+\tif ((((int)dev_link.link_speed > 0 && !dev_link.link_status) ||\n+\t ((int)dev_link.link_speed <= 0 && dev_link.link_status))) {\n \t\trte_errno = EAGAIN;\n \t\treturn -rte_errno;\n \t}\n", "prefixes": [] }