Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/63635/?format=api
{ "id": 63635, "url": "https://patches.dpdk.org/api/patches/63635/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1575806094-28391-11-git-send-email-anoobj@marvell.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1575806094-28391-11-git-send-email-anoobj@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1575806094-28391-11-git-send-email-anoobj@marvell.com", "date": "2019-12-08T11:54:49", "name": "[10/15] crypto/octeontx2: add lookup mem changes to hold sa indices", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "8d099b0d3e2d6c517c2e8e70b2b711c631160647", "submitter": { "id": 1205, "url": "https://patches.dpdk.org/api/people/1205/?format=api", "name": "Anoob Joseph", "email": "anoobj@marvell.com" }, "delegate": { "id": 6690, "url": "https://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1575806094-28391-11-git-send-email-anoobj@marvell.com/mbox/", "series": [ { "id": 7749, "url": "https://patches.dpdk.org/api/series/7749/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=7749", "date": "2019-12-08T11:54:39", "name": "add OCTEONTX2 inline IPsec support", "version": 1, "mbox": "https://patches.dpdk.org/series/7749/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/63635/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/63635/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7C4C2A04F1;\n\tSun, 8 Dec 2019 12:57:16 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9711C1BF6E;\n\tSun, 8 Dec 2019 12:56:37 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id F320C1BE82\n for <dev@dpdk.org>; Sun, 8 Dec 2019 12:56:35 +0100 (CET)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id\n xB8BrTmX008036; Sun, 8 Dec 2019 03:56:35 -0800", "from sc-exch02.marvell.com ([199.233.58.182])\n by mx0a-0016f401.pphosted.com with ESMTP id 2wrbawjj3w-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Sun, 08 Dec 2019 03:56:35 -0800", "from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH02.marvell.com\n (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Sun, 8 Dec\n 2019 03:56:33 -0800", "from maili.marvell.com (10.93.176.43) by SC-EXCH01.marvell.com\n (10.93.176.81) with Microsoft SMTP Server id 15.0.1367.3 via Frontend\n Transport; Sun, 8 Dec 2019 03:56:33 -0800", "from ajoseph83.caveonetworks.com.com (unknown [10.29.45.60])\n by maili.marvell.com (Postfix) with ESMTP id ED6B73F703F;\n Sun, 8 Dec 2019 03:56:28 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0818;\n bh=n48SzD5Eo/rrzOk0Uf9wGA/bfBj+vcHZ/DMLKfUVF0c=;\n b=EMhoXdg96kPV42ZqBdvYqmhEH8OhBG7kgLGAnRfFNi1/K9AzJFm/GthfTwq1g7uEyR0o\n QA/xZI25AjxumU4qGK4za48BfVF9RNNotG1XaJHi6PKdbLSiZYy8+eyua7age199AS11\n T02IlzI6agyYOTYf2WZnMQd6jOeFt3MedBVrSfHLe4WbPi6YUo1XUU4DA4LZvi35Id6Q\n e2oVvE//mKxsm2mR31l0JffatpI6Bj8+wfClmzQclF39ZF6G1PYEiV61HldKXnreMfco\n GyjrwuJKiOjNcP7Vk1J1PElZCR1W+cVaH8H16DITqdwBxgd8wQNedCoSsyi4WyEfOlij nA==", "From": "Anoob Joseph <anoobj@marvell.com>", "To": "Akhil Goyal <akhil.goyal@nxp.com>, Declan Doherty\n <declan.doherty@intel.com>, Thomas Monjalon <thomas@monjalon.net>", "CC": "Archana Muniganti <marchana@marvell.com>,\n Jerin Jacob <jerinj@marvell.com>,\n Narayana Prasad <pathreya@marvell.com>, Kiran Kumar K\n <kirankumark@marvell.com>, Nithin Dabilpuram <ndabilpuram@marvell.com>,\n \"Pavan Nikhilesh\" <pbhagavatula@marvell.com>, Ankur Dwivedi\n <adwivedi@marvell.com>, Anoob Joseph <anoobj@marvell.com>, Tejasree Kondoj\n <ktejasree@marvell.com>, Vamsi Attunuru <vattunuru@marvell.com>, Lukasz\n Bartosik <lbartosik@marvell.com>, <dev@dpdk.org>", "Date": "Sun, 8 Dec 2019 17:24:49 +0530", "Message-ID": "<1575806094-28391-11-git-send-email-anoobj@marvell.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1575806094-28391-1-git-send-email-anoobj@marvell.com>", "References": "<1575806094-28391-1-git-send-email-anoobj@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.95,18.0.572\n definitions=2019-12-08_03:2019-12-05,2019-12-08 signatures=0", "Subject": "[dpdk-dev] [PATCH 10/15] crypto/octeontx2: add lookup mem changes\n\tto hold sa indices", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Archana Muniganti <marchana@marvell.com>\n\nlookup_mem provides fast accessing of data path fields.\nStoring sa indices in lookup_mem which are required in\ninline rx data path.\n\nSigned-off-by: Ankur Dwivedi <adwivedi@marvell.com>\nSigned-off-by: Anoob Joseph <anoobj@marvell.com>\nSigned-off-by: Archana Muniganti <marchana@marvell.com>\nSigned-off-by: Tejasree Kondoj <ktejasree@marvell.com>\nSigned-off-by: Vamsi Attunuru <vattunuru@marvell.com>\n---\n drivers/common/octeontx2/otx2_common.h | 20 +++++++++++\n drivers/crypto/octeontx2/otx2_security.c | 59 +++++++++++++++++++++++++++++++-\n drivers/net/octeontx2/otx2_lookup.c | 9 +----\n drivers/net/octeontx2/otx2_rx.h | 10 ++----\n 4 files changed, 81 insertions(+), 17 deletions(-)", "diff": "diff --git a/drivers/common/octeontx2/otx2_common.h b/drivers/common/octeontx2/otx2_common.h\nindex 9705a8d..6456c4b 100644\n--- a/drivers/common/octeontx2/otx2_common.h\n+++ b/drivers/common/octeontx2/otx2_common.h\n@@ -170,4 +170,24 @@ extern int otx2_logtype_dpi;\n #include \"otx2_io_generic.h\"\n #endif\n \n+/* Fastpath lookup */\n+#define OTX2_NIX_FASTPATH_LOOKUP_MEM \"otx2_nix_fastpath_lookup_mem\"\n+#define PTYPE_NON_TUNNEL_WIDTH\t\t16\n+#define PTYPE_TUNNEL_WIDTH\t\t12\n+#define PTYPE_NON_TUNNEL_ARRAY_SZ\tBIT(PTYPE_NON_TUNNEL_WIDTH)\n+#define PTYPE_TUNNEL_ARRAY_SZ\t\tBIT(PTYPE_TUNNEL_WIDTH)\n+#define PTYPE_ARRAY_SZ\t\t\t((PTYPE_NON_TUNNEL_ARRAY_SZ +\\\n+\t\t\t\t\t PTYPE_TUNNEL_ARRAY_SZ) *\\\n+\t\t\t\t\t sizeof(uint16_t))\n+\n+/* NIX_RX_PARSE_S's ERRCODE + ERRLEV (12 bits) */\n+#define ERRCODE_ERRLEN_WIDTH\t\t12\n+#define ERR_ARRAY_SZ\t\t\t((BIT(ERRCODE_ERRLEN_WIDTH)) *\\\n+\t\t\t\t\tsizeof(uint32_t))\n+\n+#define PORT_ARRAY_SZ\t\t\t(RTE_MAX_ETHPORTS * sizeof(uint64_t))\n+\n+#define LOOKUP_ARRAY_SZ\t\t\t(PTYPE_ARRAY_SZ + ERR_ARRAY_SZ +\\\n+\t\t\t\t\tPORT_ARRAY_SZ)\n+\n #endif /* _OTX2_COMMON_H_ */\ndiff --git a/drivers/crypto/octeontx2/otx2_security.c b/drivers/crypto/octeontx2/otx2_security.c\nindex 545c806..4d762d9 100644\n--- a/drivers/crypto/octeontx2/otx2_security.c\n+++ b/drivers/crypto/octeontx2/otx2_security.c\n@@ -136,6 +136,59 @@ static const struct rte_security_capability otx2_sec_eth_capabilities[] = {\n \t}\n };\n \n+static void\n+lookup_mem_sa_tbl_clear(struct rte_eth_dev *eth_dev)\n+{\n+\tstatic const char name[] = OTX2_NIX_FASTPATH_LOOKUP_MEM;\n+\tuint16_t port = eth_dev->data->port_id;\n+\tconst struct rte_memzone *mz;\n+\tuint64_t **sa_tbl;\n+\tuint8_t *mem;\n+\n+\tmz = rte_memzone_lookup(name);\n+\tif (mz == NULL)\n+\t\treturn;\n+\n+\tmem = mz->addr;\n+\n+\tsa_tbl = (uint64_t **)(mem + PTYPE_ARRAY_SZ + ERR_ARRAY_SZ);\n+\tif (sa_tbl[port] == NULL)\n+\t\treturn;\n+\n+\trte_free(sa_tbl[port]);\n+\tsa_tbl[port] = NULL;\n+}\n+\n+static int\n+lookup_mem_sa_index_update(struct rte_eth_dev *eth_dev, int spi, void *sa)\n+{\n+\tstatic const char name[] = OTX2_NIX_FASTPATH_LOOKUP_MEM;\n+\tstruct otx2_eth_dev *dev = otx2_eth_pmd_priv(eth_dev);\n+\tuint16_t port = eth_dev->data->port_id;\n+\tconst struct rte_memzone *mz;\n+\tuint64_t **sa_tbl;\n+\tuint8_t *mem;\n+\n+\tmz = rte_memzone_lookup(name);\n+\tif (mz == NULL) {\n+\t\totx2_err(\"Could not find fastpath lookup table\");\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tmem = mz->addr;\n+\n+\tsa_tbl = (uint64_t **)(mem + PTYPE_ARRAY_SZ + ERR_ARRAY_SZ);\n+\n+\tif (sa_tbl[port] == NULL) {\n+\t\tsa_tbl[port] = rte_malloc(NULL, dev->ipsec_in_max_spi *\n+\t\t\t\t\t sizeof(uint64_t), 0);\n+\t}\n+\n+\tsa_tbl[port][spi] = (uint64_t)sa;\n+\n+\treturn 0;\n+}\n+\n static int\n otx2_sec_eth_tx_cpt_qp_get(uint16_t port_id, struct otx2_cpt_qp **qp)\n {\n@@ -383,8 +436,10 @@ sec_eth_ipsec_in_sess_create(struct rte_eth_dev *eth_dev,\n \n \tsa->userdata = priv->userdata;\n \n-\treturn ipsec_fp_sa_ctl_set(ipsec, crypto_xform, ctl);\n+\tif (lookup_mem_sa_index_update(eth_dev, ipsec->spi, sa))\n+\t\treturn -EINVAL;\n \n+\treturn ipsec_fp_sa_ctl_set(ipsec, crypto_xform, ctl);\n }\n \n static int\n@@ -667,6 +722,8 @@ otx2_sec_eth_fini(struct rte_eth_dev *eth_dev)\n \t !(dev->rx_offloads & DEV_RX_OFFLOAD_SECURITY))\n \t\treturn;\n \n+\tlookup_mem_sa_tbl_clear(eth_dev);\n+\n \tin_sa_mz_name_get(name, RTE_MEMZONE_NAMESIZE, port);\n \trte_memzone_free(rte_memzone_lookup(name));\n }\ndiff --git a/drivers/net/octeontx2/otx2_lookup.c b/drivers/net/octeontx2/otx2_lookup.c\nindex bcf2ff4..46fdbc8 100644\n--- a/drivers/net/octeontx2/otx2_lookup.c\n+++ b/drivers/net/octeontx2/otx2_lookup.c\n@@ -7,13 +7,6 @@\n \n #include \"otx2_ethdev.h\"\n \n-/* NIX_RX_PARSE_S's ERRCODE + ERRLEV (12 bits) */\n-#define ERRCODE_ERRLEN_WIDTH\t\t12\n-#define ERR_ARRAY_SZ\t\t\t((BIT(ERRCODE_ERRLEN_WIDTH)) *\\\n-\t\t\t\t\tsizeof(uint32_t))\n-\n-#define LOOKUP_ARRAY_SZ\t\t\t(PTYPE_ARRAY_SZ + ERR_ARRAY_SZ)\n-\n const uint32_t *\n otx2_nix_supported_ptypes_get(struct rte_eth_dev *eth_dev)\n {\n@@ -314,7 +307,7 @@ nix_create_rx_ol_flags_array(void *mem)\n void *\n otx2_nix_fastpath_lookup_mem_get(void)\n {\n-\tconst char name[] = \"otx2_nix_fastpath_lookup_mem\";\n+\tconst char name[] = OTX2_NIX_FASTPATH_LOOKUP_MEM;\n \tconst struct rte_memzone *mz;\n \tvoid *mem;\n \ndiff --git a/drivers/net/octeontx2/otx2_rx.h b/drivers/net/octeontx2/otx2_rx.h\nindex 351ad0f..5e1d5a2 100644\n--- a/drivers/net/octeontx2/otx2_rx.h\n+++ b/drivers/net/octeontx2/otx2_rx.h\n@@ -5,17 +5,11 @@\n #ifndef __OTX2_RX_H__\n #define __OTX2_RX_H__\n \n+#include \"otx2_common.h\"\n+\n /* Default mark value used when none is provided. */\n #define OTX2_FLOW_ACTION_FLAG_DEFAULT\t0xffff\n \n-#define PTYPE_NON_TUNNEL_WIDTH\t\t16\n-#define PTYPE_TUNNEL_WIDTH\t\t12\n-#define PTYPE_NON_TUNNEL_ARRAY_SZ\tBIT(PTYPE_NON_TUNNEL_WIDTH)\n-#define PTYPE_TUNNEL_ARRAY_SZ\t\tBIT(PTYPE_TUNNEL_WIDTH)\n-#define PTYPE_ARRAY_SZ\t\t\t((PTYPE_NON_TUNNEL_ARRAY_SZ +\\\n-\t\t\t\t\t PTYPE_TUNNEL_ARRAY_SZ) *\\\n-\t\t\t\t\t sizeof(uint16_t))\n-\n #define NIX_RX_OFFLOAD_NONE (0)\n #define NIX_RX_OFFLOAD_RSS_F BIT(0)\n #define NIX_RX_OFFLOAD_PTYPE_F BIT(1)\n", "prefixes": [ "10/15" ] }