Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/63479/?format=api
{ "id": 63479, "url": "https://patches.dpdk.org/api/patches/63479/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20191202074935.97629-55-xiaolong.ye@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191202074935.97629-55-xiaolong.ye@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191202074935.97629-55-xiaolong.ye@intel.com", "date": "2019-12-02T07:49:20", "name": "[54/69] net/i40e/base: change for reading lpi statistics", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "dcaa8035deeb50b27fc2d9e9b64fc2e4c1bd009c", "submitter": { "id": 1120, "url": "https://patches.dpdk.org/api/people/1120/?format=api", "name": "Xiaolong Ye", "email": "xiaolong.ye@intel.com" }, "delegate": { "id": 31221, "url": "https://patches.dpdk.org/api/users/31221/?format=api", "username": "yexl", "first_name": "xiaolong", "last_name": "ye", "email": "xiaolong.ye@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20191202074935.97629-55-xiaolong.ye@intel.com/mbox/", "series": [ { "id": 7701, "url": "https://patches.dpdk.org/api/series/7701/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=7701", "date": "2019-12-02T07:48:26", "name": "update for i40e base code", "version": 1, "mbox": "https://patches.dpdk.org/series/7701/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/63479/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/63479/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 82B93A04B5;\n\tMon, 2 Dec 2019 09:06:10 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id F18EE1C10B;\n\tMon, 2 Dec 2019 08:59:14 +0100 (CET)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n by dpdk.org (Postfix) with ESMTP id 97B001C0BC\n for <dev@dpdk.org>; Mon, 2 Dec 2019 08:59:05 +0100 (CET)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n 01 Dec 2019 23:59:05 -0800", "from dpdk_yexl_af_xdp.sh.intel.com ([10.67.119.186])\n by fmsmga008.fm.intel.com with ESMTP; 01 Dec 2019 23:59:04 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.69,268,1571727600\"; d=\"scan'208\";a=\"207993677\"", "From": "Xiaolong Ye <xiaolong.ye@intel.com>", "To": "Beilei Xing <beilei.xing@intel.com>,\n\tQi Zhang <qi.z.zhang@intel.com>", "Cc": "dev@dpdk.org, Xiaolong Ye <xiaolong.ye@intel.com>,\n Jaroslaw Gawin <jaroslawx.gawin@intel.com>", "Date": "Mon, 2 Dec 2019 15:49:20 +0800", "Message-Id": "<20191202074935.97629-55-xiaolong.ye@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20191202074935.97629-1-xiaolong.ye@intel.com>", "References": "<20191202074935.97629-1-xiaolong.ye@intel.com>", "Subject": "[dpdk-dev] [PATCH 54/69] net/i40e/base: change for reading lpi\n\tstatistics", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "There was no values for time duration statistics for LPI in EEE.\nTwo byte mask has been added to filter the flags because F/W\nreturns the status only in two lower bytes.\n\nSigned-off-by: Jaroslaw Gawin <jaroslawx.gawin@intel.com>\nReviewed-by: Grzegorz Szczurek <grzegorzx.szczurek@intel.com>\nReviewed-by: Galazka Krzysztof <krzysztof.galazka@intel.com>\nReviewed-by: Slawomir Laba <slawomirx.laba@intel.com>\nReviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\nReviewed-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>\nReviewed-by: Michael Alice <alice.michael@intel.com>\nSigned-off-by: Xiaolong Ye <xiaolong.ye@intel.com>\n---\n drivers/net/i40e/base/i40e_adminq_cmd.h | 1 +\n drivers/net/i40e/base/i40e_common.c | 6 ++++--\n 2 files changed, 5 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/i40e/base/i40e_adminq_cmd.h b/drivers/net/i40e/base/i40e_adminq_cmd.h\nindex 5879f32ff..bc4aefba6 100644\n--- a/drivers/net/i40e/base/i40e_adminq_cmd.h\n+++ b/drivers/net/i40e/base/i40e_adminq_cmd.h\n@@ -2301,6 +2301,7 @@ struct i40e_aqc_run_phy_activity {\n \t\tstruct {\n \t\t\t__le32\tcmd_status;\n #define I40E_AQ_RUN_PHY_ACT_CMD_STAT_SUCC\t\t0x4\n+#define I40E_AQ_RUN_PHY_ACT_CMD_STAT_MASK\t\t0xFFFF\n \t\t\t__le32\tdata0;\n \t\t\t__le32\tdata1;\n \t\t} resp;\ndiff --git a/drivers/net/i40e/base/i40e_common.c b/drivers/net/i40e/base/i40e_common.c\nindex aebbd6004..1766214b9 100644\n--- a/drivers/net/i40e/base/i40e_common.c\n+++ b/drivers/net/i40e/base/i40e_common.c\n@@ -7248,7 +7248,8 @@ enum i40e_status_code i40e_get_lpi_duration(struct i40e_hw *hw,\n \n \tif (retval)\n \t\treturn retval;\n-\tif (cmd_status != I40E_AQ_RUN_PHY_ACT_CMD_STAT_SUCC)\n+\tif ((cmd_status & I40E_AQ_RUN_PHY_ACT_CMD_STAT_MASK) !=\n+\t I40E_AQ_RUN_PHY_ACT_CMD_STAT_SUCC)\n \t\treturn I40E_ERR_ADMIN_QUEUE_ERROR;\n \n \tif (hw->phy.link_info.link_speed == I40E_LINK_SPEED_1GB &&\n@@ -7262,7 +7263,8 @@ enum i40e_status_code i40e_get_lpi_duration(struct i40e_hw *hw,\n \n \t\tif (retval)\n \t\t\treturn retval;\n-\t\tif (cmd_status != I40E_AQ_RUN_PHY_ACT_CMD_STAT_SUCC)\n+\t\tif ((cmd_status & I40E_AQ_RUN_PHY_ACT_CMD_STAT_MASK) !=\n+\t\t I40E_AQ_RUN_PHY_ACT_CMD_STAT_SUCC)\n \t\t\treturn I40E_ERR_ADMIN_QUEUE_ERROR;\n \t\ttx_time_dur = 0;\n \t\trx_time_dur = 0;\n", "prefixes": [ "54/69" ] }