Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 63287,
    "url": "https://patches.dpdk.org/api/patches/63287/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20191125152303.68461-1-bruce.richardson@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20191125152303.68461-1-bruce.richardson@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20191125152303.68461-1-bruce.richardson@intel.com",
    "date": "2019-11-25T15:23:03",
    "name": "examples/ioat: handle failure case for ioat dequeue",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "09e234337937c85c59b69d56a2492229d8469b6f",
    "submitter": {
        "id": 20,
        "url": "https://patches.dpdk.org/api/people/20/?format=api",
        "name": "Bruce Richardson",
        "email": "bruce.richardson@intel.com"
    },
    "delegate": {
        "id": 24651,
        "url": "https://patches.dpdk.org/api/users/24651/?format=api",
        "username": "dmarchand",
        "first_name": "David",
        "last_name": "Marchand",
        "email": "david.marchand@redhat.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20191125152303.68461-1-bruce.richardson@intel.com/mbox/",
    "series": [
        {
            "id": 7610,
            "url": "https://patches.dpdk.org/api/series/7610/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=7610",
            "date": "2019-11-25T15:23:03",
            "name": "examples/ioat: handle failure case for ioat dequeue",
            "version": 1,
            "mbox": "https://patches.dpdk.org/series/7610/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/63287/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/63287/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B94A7A04C2;\n\tMon, 25 Nov 2019 16:23:12 +0100 (CET)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6A84328EE;\n\tMon, 25 Nov 2019 16:23:11 +0100 (CET)",
            "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n by dpdk.org (Postfix) with ESMTP id B9C80A3\n for <dev@dpdk.org>; Mon, 25 Nov 2019 16:23:09 +0100 (CET)",
            "from fmsmga008.fm.intel.com ([10.253.24.58])\n by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n 25 Nov 2019 07:23:08 -0800",
            "from silpixa00399126.ir.intel.com (HELO\n silpixa00399126.ger.corp.intel.com) ([10.237.223.2])\n by fmsmga008.fm.intel.com with ESMTP; 25 Nov 2019 07:23:07 -0800"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.69,241,1571727600\"; d=\"scan'208\";a=\"206168153\"",
        "From": "Bruce Richardson <bruce.richardson@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "Bruce Richardson <bruce.richardson@intel.com>",
        "Date": "Mon, 25 Nov 2019 15:23:03 +0000",
        "Message-Id": "<20191125152303.68461-1-bruce.richardson@intel.com>",
        "X-Mailer": "git-send-email 2.21.0",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH] examples/ioat: handle failure case for ioat\n\tdequeue",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "On a failure with the ioat dequeue, -1 is returned, which was not properly\nhandled. This could lead to out-of-bounds reads on a later loop which\nassumed a positive return value. Fix this by treating an error as though a\ndequeue of 0 had been encountered.\n\nCoverity issue: 350342\nFixes: 2328542ed84e (\"examples/ioat: add rawdev copy mode\")\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n examples/ioat/ioatfwd.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)",
    "diff": "diff --git a/examples/ioat/ioatfwd.c b/examples/ioat/ioatfwd.c\nindex 5e623a4d5..9fc033bc3 100644\n--- a/examples/ioat/ioatfwd.c\n+++ b/examples/ioat/ioatfwd.c\n@@ -457,7 +457,7 @@ ioat_tx_port(struct rxtx_port_config *tx_config)\n \t\t\t\tMAX_PKT_BURST, NULL);\n \t\t}\n \n-\t\tif (nb_dq == 0)\n+\t\tif (nb_dq <= 0)\n \t\t\treturn;\n \n \t\tif (copy_mode == COPY_MODE_IOAT_NUM)\n",
    "prefixes": []
}