Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 63180,
    "url": "https://patches.dpdk.org/api/patches/63180/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20191120232628.29737-1-stephen@networkplumber.org/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20191120232628.29737-1-stephen@networkplumber.org>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20191120232628.29737-1-stephen@networkplumber.org",
    "date": "2019-11-20T23:26:28",
    "name": "testpmd: fix memory leak in iterator",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "f74b03cc5c63eaf6244d9dc97b64c5e6ae956199",
    "submitter": {
        "id": 27,
        "url": "https://patches.dpdk.org/api/people/27/?format=api",
        "name": "Stephen Hemminger",
        "email": "stephen@networkplumber.org"
    },
    "delegate": {
        "id": 319,
        "url": "https://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20191120232628.29737-1-stephen@networkplumber.org/mbox/",
    "series": [
        {
            "id": 7552,
            "url": "https://patches.dpdk.org/api/series/7552/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=7552",
            "date": "2019-11-20T23:26:28",
            "name": "testpmd: fix memory leak in iterator",
            "version": 1,
            "mbox": "https://patches.dpdk.org/series/7552/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/63180/comments/",
    "check": "fail",
    "checks": "https://patches.dpdk.org/api/patches/63180/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4B5DBA04C7;\n\tThu, 21 Nov 2019 00:26:41 +0100 (CET)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E8A0BB62;\n\tThu, 21 Nov 2019 00:26:39 +0100 (CET)",
            "from mail-pg1-f195.google.com (mail-pg1-f195.google.com\n [209.85.215.195]) by dpdk.org (Postfix) with ESMTP id 32249235\n for <dev@dpdk.org>; Thu, 21 Nov 2019 00:26:38 +0100 (CET)",
            "by mail-pg1-f195.google.com with SMTP id h27so548920pgn.0\n for <dev@dpdk.org>; Wed, 20 Nov 2019 15:26:38 -0800 (PST)",
            "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n by smtp.gmail.com with ESMTPSA id w10sm305557pgi.47.2019.11.20.15.26.35\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 20 Nov 2019 15:26:35 -0800 (PST)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:mime-version\n :content-transfer-encoding;\n bh=rwiKK2O456RLbNZ0EuCVo9bMXUgcnSomxhvCaW/Riug=;\n b=0KpNUxCDri4o26Up/UwUxNo+aQqxceCvoPRCAg0tj9YY09hr4zAcZWr3kouHOO9ydy\n nQHx3B/Uz+p5DDiitq4v7nQVp0y6HHoYyWgXAc/qY5W6tqQW5vSXu6OmkHJlyx4EP28K\n T37VwwOBZBVVgtwqxfY4XDlYKb2Y0JRQK3Vm4zv3kC1dQXxrL0/Buvo65xE5WxHucY9H\n vPW5dUvFK2VceUfUHUURvGXwFrs43zDJvtOf/NOm6eeKAYHw8nqJId/I+d5iOCDbO0nb\n 6/bDX6JKUuI13VLrDa711ZrwOoW7FIOs0tN0UVOBbzZT5g5mv1Aqzc7MXyqCTwehPIyY\n cmQg==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n :content-transfer-encoding;\n bh=rwiKK2O456RLbNZ0EuCVo9bMXUgcnSomxhvCaW/Riug=;\n b=q5PzTAx15i5RnVRmVcxO66ukHy7Qxj6vLtJe9v7IZx76K9jQiwLaRxjWzMWwt5rig0\n DhtMs1G0SX6b3dHJ9v6mKq/3eFb4Jj00H9kniCjWBm4kAbGcD7cOLRwuSQSSkcOcJj2I\n CAH15XY4oUTS2TzaLnlPUvV1ilVIOPMJ3LyXIZLDUteo0Dvh/BuQ5OCCe2LD4LRTVfSR\n A+QHFhTW7n3zOxuyMmpeu3Yy8w9HZgBB3T8srXEo7HEXyLalv36BUu9D3VzJ2M7ZUDYw\n FZ5CxJXTZcekHvGXpu/46acloO4s7oqFqzA76pvqdJaJSWTUqlQ4CwFvdYc7jFFMeBek\n CejQ==",
        "X-Gm-Message-State": "APjAAAU+l2EraEK/l8oCp1Q6TOwX3BkUqbbs4dVMt2cH/Dn8DLJDVKjB\n O18+PGWjWcbAFPhGdLbBlcZgVppEV5WORA==",
        "X-Google-Smtp-Source": "\n APXvYqyQnRrpjm2Ce2taCN2OZh7aBgrI7FK11cb3jVz6YcNoiJfCdIjllxZCkJqnRB1SjJlHuxCa1A==",
        "X-Received": "by 2002:a63:68c3:: with SMTP id\n d186mr5453706pgc.301.1574292396714;\n Wed, 20 Nov 2019 15:26:36 -0800 (PST)",
        "From": "Stephen Hemminger <stephen@networkplumber.org>",
        "To": "dev@dpdk.org",
        "Cc": "Stephen Hemminger <stephen@networkplumber.org>, ndabilpuram@marvell.com,\n stable@dpdk.org",
        "Date": "Wed, 20 Nov 2019 15:26:28 -0800",
        "Message-Id": "<20191120232628.29737-1-stephen@networkplumber.org>",
        "X-Mailer": "git-send-email 2.20.1",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH] testpmd: fix memory leak in iterator",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "The RTE_FOREACH_MATCHING_DEV iterator requires that\nif a break is done before the end of the loop,\nthe function rte_eth_iterator_cleanup() must be called.\n\nFixes: 55e51c962432 (\"app/testpmd: add device related commands\")\nCc: ndabilpuram@marvell.com\nCc: stable@dpdk.org\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n app/test-pmd/testpmd.c | 1 +\n 1 file changed, 1 insertion(+)",
    "diff": "diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c\nindex 446da3623442..cf59c378229f 100644\n--- a/app/test-pmd/testpmd.c\n+++ b/app/test-pmd/testpmd.c\n@@ -2616,6 +2616,7 @@ detach_device(char *identifier)\n \t\tif (ports[port_id].port_status != RTE_PORT_CLOSED) {\n \t\t\tif (ports[port_id].port_status != RTE_PORT_STOPPED) {\n \t\t\t\tprintf(\"Port %u not stopped\\n\", port_id);\n+\t\t\t\trte_eth_iterator_cleanup(&iterator);\n \t\t\t\treturn;\n \t\t\t}\n \n",
    "prefixes": []
}