Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/62946/?format=api
{ "id": 62946, "url": "https://patches.dpdk.org/api/patches/62946/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20191113163441.90162-1-lunyuanx.cui@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191113163441.90162-1-lunyuanx.cui@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191113163441.90162-1-lunyuanx.cui@intel.com", "date": "2019-11-13T16:34:41", "name": "[v2] net/ixgbe: fix link status", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "ebb5f1a840e985e37909ec4eee4e745d2298a403", "submitter": { "id": 1420, "url": "https://patches.dpdk.org/api/people/1420/?format=api", "name": "Cui, LunyuanX", "email": "lunyuanx.cui@intel.com" }, "delegate": { "id": 31221, "url": "https://patches.dpdk.org/api/users/31221/?format=api", "username": "yexl", "first_name": "xiaolong", "last_name": "ye", "email": "xiaolong.ye@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20191113163441.90162-1-lunyuanx.cui@intel.com/mbox/", "series": [ { "id": 7438, "url": "https://patches.dpdk.org/api/series/7438/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=7438", "date": "2019-11-13T16:34:41", "name": "[v2] net/ixgbe: fix link status", "version": 2, "mbox": "https://patches.dpdk.org/series/7438/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/62946/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/62946/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8ADC8A0353;\n\tWed, 13 Nov 2019 09:34:31 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 04AD81BEF6;\n\tWed, 13 Nov 2019 09:34:31 +0100 (CET)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n by dpdk.org (Postfix) with ESMTP id 699F41BEF0;\n Wed, 13 Nov 2019 09:34:29 +0100 (CET)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n 13 Nov 2019 00:34:27 -0800", "from intel.sh.intel.com ([10.239.255.129])\n by fmsmga002.fm.intel.com with ESMTP; 13 Nov 2019 00:34:26 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.68,299,1569308400\"; d=\"scan'208\";a=\"235193485\"", "From": "Cui LunyuanX <lunyuanx.cui@intel.com>", "To": "dev@dpdk.org", "Cc": "Wenzhuo Lu <wenzhuo.lu@intel.com>, Yang Qiming <qiming.yang@intel.com>,\n Cui LunyuanX <lunyuanx.cui@intel.com>, stable@dpdk.org", "Date": "Wed, 13 Nov 2019 16:34:41 +0000", "Message-Id": "<20191113163441.90162-1-lunyuanx.cui@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20191113125555.88840-1-lunyuanx.cui@intel.com>", "References": "<20191113125555.88840-1-lunyuanx.cui@intel.com>", "Subject": "[dpdk-dev] [PATCH v2] net/ixgbe: fix link status", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "After ports reset, tx laser register will be reset. The link\nstatus for 82599eb got from link status register was not correct.\nSet tx laser disabled after ports reset.\n\nixgbe_dev_setup_link_alarm_handler() will set tx laser enabled\nwhen show port information. The purpose of the function has already\nimplemented in ixgbe_dev_start(). There is no need to reuse it\nin ixgbe_dev_link_update_share().\n\nFixes: 0408f47ba4d6 (\"net/ixgbe: fix busy polling while fiber link update\")\nCc: stable@dpdk.org\n\nSigned-off-by: Cui LunyuanX <lunyuanx.cui@intel.com>\n---\n drivers/net/ixgbe/ixgbe_ethdev.c | 7 ++-----\n 1 file changed, 2 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c\nindex 8c1caac18..5e516599c 100644\n--- a/drivers/net/ixgbe/ixgbe_ethdev.c\n+++ b/drivers/net/ixgbe/ixgbe_ethdev.c\n@@ -1298,6 +1298,8 @@ eth_ixgbe_dev_init(struct rte_eth_dev *eth_dev, void *init_params __rte_unused)\n \t/* enable support intr */\n \tixgbe_enable_intr(eth_dev);\n \n+\tixgbe_dev_set_link_down(eth_dev);\n+\n \t/* initialize filter info */\n \tmemset(filter_info, 0,\n \t sizeof(struct ixgbe_filter_info));\n@@ -4154,11 +4156,6 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev,\n \t\tlink_up = 0;\n \n \tif (link_up == 0) {\n-\t\tif (ixgbe_get_media_type(hw) == ixgbe_media_type_fiber) {\n-\t\t\tintr->flags |= IXGBE_FLAG_NEED_LINK_CONFIG;\n-\t\t\trte_eal_alarm_set(10,\n-\t\t\t\tixgbe_dev_setup_link_alarm_handler, dev);\n-\t\t}\n \t\treturn rte_eth_linkstatus_set(dev, &link);\n \t}\n \n", "prefixes": [ "v2" ] }