Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/6288/?format=api
https://patches.dpdk.org/api/patches/6288/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1436484387-29273-3-git-send-email-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1436484387-29273-3-git-send-email-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/1436484387-29273-3-git-send-email-stephen@networkplumber.org", "date": "2015-07-09T23:26:27", "name": "[dpdk-dev,v2,2/2] vfio: don't build unnecessary files", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": true, "hash": "01ca7a898bf93eb140e805c0db05ed4ef4181105", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1436484387-29273-3-git-send-email-stephen@networkplumber.org/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/6288/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/6288/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 81D4068A5;\n\tFri, 10 Jul 2015 01:26:22 +0200 (CEST)", "from mail-pa0-f41.google.com (mail-pa0-f41.google.com\n\t[209.85.220.41]) by dpdk.org (Postfix) with ESMTP id A23045A6D\n\tfor <dev@dpdk.org>; Fri, 10 Jul 2015 01:26:20 +0200 (CEST)", "by pabvl15 with SMTP id vl15so157614685pab.1\n\tfor <dev@dpdk.org>; Thu, 09 Jul 2015 16:26:20 -0700 (PDT)", "from urahara.home.lan (static-50-53-82-155.bvtn.or.frontiernet.net.\n\t[50.53.82.155]) by smtp.gmail.com with ESMTPSA id\n\tky17sm583659pab.31.2015.07.09.16.26.19\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tThu, 09 Jul 2015 16:26:19 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=0RCSR0bnYzIt4TE7BEhOHwijcbajPOmw9JVjAnnA/cc=;\n\tb=PeBVM152AiaB9/hL8qZCb+mCgUlaVCDPQLf5/ca4I8nKQ+zBy32TMguN/isGCC2GpQ\n\t2wT9Q1xsJ4XBsbKGy3R7TRRm+TKiivr9kuoznUmMowhzizaFIbH66/RhiuMZ8ewzV9Ye\n\tz+54hSOmnnINQzcCIrNHPFRDQUFDn3LT+hMGwGYYMixtllQsziOHfDSMKq47XSPoM1tb\n\tAXaosx6gJA4oAHJEmXTClX6uSjkAyq4JicXy0ktFG6lYbRo5sbYMOWfoRS7pvULhx7QO\n\t8m1oscU5XMvFVkg9D/hHX8BzbbqhFlTfeTgJ6klfXXcqd98YQtrznv04NYf9cdD5l6fG\n\txP2g==", "X-Gm-Message-State": "ALoCoQmmcK3FwVtj0NOwn3fkH1F/qzb5j/6FOC5bbkHjEAxhKwXNGdG8PTIZkwyrvYxiSZNR5h9k", "X-Received": "by 10.66.145.33 with SMTP id sr1mr35397177pab.41.1436484380013; \n\tThu, 09 Jul 2015 16:26:20 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Date": "Thu, 9 Jul 2015 16:26:27 -0700", "Message-Id": "<1436484387-29273-3-git-send-email-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.1.4", "In-Reply-To": "<1436484387-29273-1-git-send-email-stephen@networkplumber.org>", "References": "<1436484387-29273-1-git-send-email-stephen@networkplumber.org>", "Cc": "Stephen Hemminger <shemming@brocade.com>", "Subject": "[dpdk-dev] [PATCH v2 2/2] vfio: don't build unnecessary files", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Stephen Hemminger <shemming@brocade.com>\n\nIf VFIO is configured, it is better to just not build the source\nfiles (rather than generating empty object files).\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/librte_eal/linuxapp/eal/Makefile | 4 ++--\n lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 3 ---\n lib/librte_eal/linuxapp/eal/eal_pci_vfio_mp_sync.c | 3 ---\n 3 files changed, 2 insertions(+), 8 deletions(-)", "diff": "diff --git a/lib/librte_eal/linuxapp/eal/Makefile b/lib/librte_eal/linuxapp/eal/Makefile\nindex 42a16fe..bc513c0 100644\n--- a/lib/librte_eal/linuxapp/eal/Makefile\n+++ b/lib/librte_eal/linuxapp/eal/Makefile\n@@ -64,8 +64,8 @@ SRCS-$(CONFIG_RTE_LIBRTE_EAL_LINUXAPP) += eal_thread.c\n SRCS-$(CONFIG_RTE_LIBRTE_EAL_LINUXAPP) += eal_log.c\n SRCS-$(CONFIG_RTE_LIBRTE_EAL_LINUXAPP) += eal_pci.c\n SRCS-$(CONFIG_RTE_LIBRTE_EAL_LINUXAPP) += eal_pci_uio.c\n-SRCS-$(CONFIG_RTE_LIBRTE_EAL_LINUXAPP) += eal_pci_vfio.c\n-SRCS-$(CONFIG_RTE_LIBRTE_EAL_LINUXAPP) += eal_pci_vfio_mp_sync.c\n+SRCS-$(CONFIG_RTE_EAL_VFIO) += eal_pci_vfio.c\n+SRCS-$(CONFIG_RTE_EAL_VFIO) += eal_pci_vfio_mp_sync.c\n SRCS-$(CONFIG_RTE_LIBRTE_EAL_LINUXAPP) += eal_debug.c\n SRCS-$(CONFIG_RTE_LIBRTE_EAL_LINUXAPP) += eal_lcore.c\n SRCS-$(CONFIG_RTE_LIBRTE_EAL_LINUXAPP) += eal_timer.c\ndiff --git a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c\nindex 426953a..9ba4b10 100644\n--- a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c\n+++ b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c\n@@ -59,8 +59,6 @@\n * This file is only compiled if CONFIG_RTE_EAL_VFIO is set to \"y\".\n */\n \n-#ifdef VFIO_PRESENT\n-\n #define PAGE_SIZE (sysconf(_SC_PAGESIZE))\n #define PAGE_MASK (~(PAGE_SIZE - 1))\n \n@@ -909,4 +907,3 @@ pci_vfio_is_enabled(void)\n {\n \treturn vfio_cfg.vfio_enabled;\n }\n-#endif\ndiff --git a/lib/librte_eal/linuxapp/eal/eal_pci_vfio_mp_sync.c b/lib/librte_eal/linuxapp/eal/eal_pci_vfio_mp_sync.c\nindex fec7080..657fc2c 100644\n--- a/lib/librte_eal/linuxapp/eal/eal_pci_vfio_mp_sync.c\n+++ b/lib/librte_eal/linuxapp/eal/eal_pci_vfio_mp_sync.c\n@@ -62,8 +62,6 @@\n * This file is only compiled if CONFIG_RTE_EAL_VFIO is set to \"y\".\n */\n \n-#ifdef VFIO_PRESENT\n-\n #define SOCKET_PATH_FMT \"%s/.%s_mp_socket\"\n #define CMSGLEN (CMSG_LEN(sizeof(int)))\n #define FD_TO_CMSGHDR(fd, chdr) \\\n@@ -391,4 +389,3 @@ pci_vfio_mp_sync_setup(void)\n \treturn 0;\n }\n \n-#endif\n", "prefixes": [ "dpdk-dev", "v2", "2/2" ] }{ "id": 6288, "url": "