Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 6265,
    "url": "https://patches.dpdk.org/api/patches/6265/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1436459501-14173-20-git-send-email-helin.zhang@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1436459501-14173-20-git-send-email-helin.zhang@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1436459501-14173-20-git-send-email-helin.zhang@intel.com",
    "date": "2015-07-09T16:31:41",
    "name": "[dpdk-dev,v10,19/19] mbuf: remove old packet type bit masks",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "f043b2216ecc5976d4b8f47c51d5f388eed0510d",
    "submitter": {
        "id": 14,
        "url": "https://patches.dpdk.org/api/people/14/?format=api",
        "name": "Zhang, Helin",
        "email": "helin.zhang@intel.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1436459501-14173-20-git-send-email-helin.zhang@intel.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/6265/comments/",
    "check": "pending",
    "checks": "https://patches.dpdk.org/api/patches/6265/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 61FF2C3EA;\n\tThu,  9 Jul 2015 18:33:08 +0200 (CEST)",
            "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id 52587C320\n\tfor <dev@dpdk.org>; Thu,  9 Jul 2015 18:33:03 +0200 (CEST)",
            "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby orsmga101.jf.intel.com with ESMTP; 09 Jul 2015 09:32:37 -0700",
            "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby orsmga003.jf.intel.com with ESMTP; 09 Jul 2015 09:32:36 -0700",
            "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id t69GWXxE006258;\n\tFri, 10 Jul 2015 00:32:33 +0800",
            "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid t69GWUmM014344; Fri, 10 Jul 2015 00:32:32 +0800",
            "(from hzhan75@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id t69GWT3h014340; \n\tFri, 10 Jul 2015 00:32:29 +0800"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.15,441,1432623600\"; d=\"scan'208\";a=\"603113929\"",
        "From": "Helin Zhang <helin.zhang@intel.com>",
        "To": "dev@dpdk.org",
        "Date": "Fri, 10 Jul 2015 00:31:41 +0800",
        "Message-Id": "<1436459501-14173-20-git-send-email-helin.zhang@intel.com>",
        "X-Mailer": "git-send-email 1.7.4.1",
        "In-Reply-To": "<1436459501-14173-1-git-send-email-helin.zhang@intel.com>",
        "References": "<1435912347-19499-1-git-send-email-helin.zhang@intel.com>\n\t<1436459501-14173-1-git-send-email-helin.zhang@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v10 19/19] mbuf: remove old packet type bit masks",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "As unified packet types are used instead, those old bit masks and\nthe relevant macros for packet type indication need to be removed.\nTo avoid breaking ABI compatibility, all the changes would be\nenabled by RTE_NEXT_ABI, which is disabled by default.\n\nSigned-off-by: Helin Zhang <helin.zhang@intel.com>\n---\n lib/librte_mbuf/rte_mbuf.c | 4 ++++\n lib/librte_mbuf/rte_mbuf.h | 4 ++++\n 2 files changed, 8 insertions(+)\n\nv2 changes:\n* Used redefined packet types and enlarged packet_type field in mbuf.\n* Redefined the bit masks for packet RX offload flags.\n\nv5 changes:\n* Rolled back the bit masks of RX flags, for ABI compatibility.\n\nv6 changes:\n* Disabled the code changes for unified packet type by default, to\n  avoid breaking ABI compatibility.\n\nv7 changes:\n* Renamed RTE_UNIFIED_PKT_TYPE to RTE_NEXT_ABI.",
    "diff": "diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf/rte_mbuf.c\nindex f506517..4320dd4 100644\n--- a/lib/librte_mbuf/rte_mbuf.c\n+++ b/lib/librte_mbuf/rte_mbuf.c\n@@ -251,14 +251,18 @@ const char *rte_get_rx_ol_flag_name(uint64_t mask)\n \t/* case PKT_RX_HBUF_OVERFLOW: return \"PKT_RX_HBUF_OVERFLOW\"; */\n \t/* case PKT_RX_RECIP_ERR: return \"PKT_RX_RECIP_ERR\"; */\n \t/* case PKT_RX_MAC_ERR: return \"PKT_RX_MAC_ERR\"; */\n+#ifndef RTE_NEXT_ABI\n \tcase PKT_RX_IPV4_HDR: return \"PKT_RX_IPV4_HDR\";\n \tcase PKT_RX_IPV4_HDR_EXT: return \"PKT_RX_IPV4_HDR_EXT\";\n \tcase PKT_RX_IPV6_HDR: return \"PKT_RX_IPV6_HDR\";\n \tcase PKT_RX_IPV6_HDR_EXT: return \"PKT_RX_IPV6_HDR_EXT\";\n+#endif /* RTE_NEXT_ABI */\n \tcase PKT_RX_IEEE1588_PTP: return \"PKT_RX_IEEE1588_PTP\";\n \tcase PKT_RX_IEEE1588_TMST: return \"PKT_RX_IEEE1588_TMST\";\n+#ifndef RTE_NEXT_ABI\n \tcase PKT_RX_TUNNEL_IPV4_HDR: return \"PKT_RX_TUNNEL_IPV4_HDR\";\n \tcase PKT_RX_TUNNEL_IPV6_HDR: return \"PKT_RX_TUNNEL_IPV6_HDR\";\n+#endif /* RTE_NEXT_ABI */\n \tdefault: return NULL;\n \t}\n }\ndiff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h\nindex 3a17d95..b90c73f 100644\n--- a/lib/librte_mbuf/rte_mbuf.h\n+++ b/lib/librte_mbuf/rte_mbuf.h\n@@ -92,14 +92,18 @@ extern \"C\" {\n #define PKT_RX_HBUF_OVERFLOW (0ULL << 0)  /**< Header buffer overflow. */\n #define PKT_RX_RECIP_ERR     (0ULL << 0)  /**< Hardware processing error. */\n #define PKT_RX_MAC_ERR       (0ULL << 0)  /**< MAC error. */\n+#ifndef RTE_NEXT_ABI\n #define PKT_RX_IPV4_HDR      (1ULL << 5)  /**< RX packet with IPv4 header. */\n #define PKT_RX_IPV4_HDR_EXT  (1ULL << 6)  /**< RX packet with extended IPv4 header. */\n #define PKT_RX_IPV6_HDR      (1ULL << 7)  /**< RX packet with IPv6 header. */\n #define PKT_RX_IPV6_HDR_EXT  (1ULL << 8)  /**< RX packet with extended IPv6 header. */\n+#endif /* RTE_NEXT_ABI */\n #define PKT_RX_IEEE1588_PTP  (1ULL << 9)  /**< RX IEEE1588 L2 Ethernet PT Packet. */\n #define PKT_RX_IEEE1588_TMST (1ULL << 10) /**< RX IEEE1588 L2/L4 timestamped packet.*/\n+#ifndef RTE_NEXT_ABI\n #define PKT_RX_TUNNEL_IPV4_HDR (1ULL << 11) /**< RX tunnel packet with IPv4 header.*/\n #define PKT_RX_TUNNEL_IPV6_HDR (1ULL << 12) /**< RX tunnel packet with IPv6 header. */\n+#endif /* RTE_NEXT_ABI */\n #define PKT_RX_FDIR_ID       (1ULL << 13) /**< FD id reported if FDIR match. */\n #define PKT_RX_FDIR_FLX      (1ULL << 14) /**< Flexible bytes reported if FDIR match. */\n #define PKT_RX_QINQ_PKT      (1ULL << 15)  /**< RX packet with double VLAN stripped. */\n",
    "prefixes": [
        "dpdk-dev",
        "v10",
        "19/19"
    ]
}