Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/6263/?format=api
{ "id": 6263, "url": "https://patches.dpdk.org/api/patches/6263/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1436459501-14173-17-git-send-email-helin.zhang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1436459501-14173-17-git-send-email-helin.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1436459501-14173-17-git-send-email-helin.zhang@intel.com", "date": "2015-07-09T16:31:38", "name": "[dpdk-dev,v10,16/19] examples/l3fwd-power: replace bit mask based packet type with unified packet type", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "0725ba254a52dfe7c51852855975a453d9d250fe", "submitter": { "id": 14, "url": "https://patches.dpdk.org/api/people/14/?format=api", "name": "Zhang, Helin", "email": "helin.zhang@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1436459501-14173-17-git-send-email-helin.zhang@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/6263/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/6263/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 03A46C35E;\n\tThu, 9 Jul 2015 18:33:04 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id B73ABC320\n\tfor <dev@dpdk.org>; Thu, 9 Jul 2015 18:33:01 +0200 (CEST)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby orsmga101.jf.intel.com with ESMTP; 09 Jul 2015 09:32:32 -0700", "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby orsmga003.jf.intel.com with ESMTP; 09 Jul 2015 09:32:28 -0700", "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id t69GWQZp005481;\n\tFri, 10 Jul 2015 00:32:26 +0800", "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid t69GWMfF014323; Fri, 10 Jul 2015 00:32:24 +0800", "(from hzhan75@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id t69GWMZm014319; \n\tFri, 10 Jul 2015 00:32:22 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.15,441,1432623600\"; d=\"scan'208\";a=\"603113844\"", "From": "Helin Zhang <helin.zhang@intel.com>", "To": "dev@dpdk.org", "Date": "Fri, 10 Jul 2015 00:31:38 +0800", "Message-Id": "<1436459501-14173-17-git-send-email-helin.zhang@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "In-Reply-To": "<1436459501-14173-1-git-send-email-helin.zhang@intel.com>", "References": "<1435912347-19499-1-git-send-email-helin.zhang@intel.com>\n\t<1436459501-14173-1-git-send-email-helin.zhang@intel.com>", "Subject": "[dpdk-dev] [PATCH v10 16/19] examples/l3fwd-power: replace bit mask\n\tbased packet type with unified packet type", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "To unify packet types among all PMDs, bit masks of packet type for\n'ol_flags' are replaced by unified packet type.\nTo avoid breaking ABI compatibility, all the changes would be\nenabled by RTE_NEXT_ABI, which is disabled by default.\n\nSigned-off-by: Helin Zhang <helin.zhang@intel.com>\n---\n examples/l3fwd-power/main.c | 8 ++++++++\n 1 file changed, 8 insertions(+)\n\nv2 changes:\n* Used redefined packet types and enlarged packet_type field in mbuf.\n\nv5 changes:\n* Re-worded the commit logs.\n\nv6 changes:\n* Disabled the code changes for unified packet type by default, to\n avoid breaking ABI compatibility.\n\nv7 changes:\n* Renamed RTE_UNIFIED_PKT_TYPE to RTE_NEXT_ABI.", "diff": "diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c\nindex d4eba1a..dbbebdd 100644\n--- a/examples/l3fwd-power/main.c\n+++ b/examples/l3fwd-power/main.c\n@@ -635,7 +635,11 @@ l3fwd_simple_forward(struct rte_mbuf *m, uint8_t portid,\n \n \teth_hdr = rte_pktmbuf_mtod(m, struct ether_hdr *);\n \n+#ifdef RTE_NEXT_ABI\n+\tif (RTE_ETH_IS_IPV4_HDR(m->packet_type)) {\n+#else\n \tif (m->ol_flags & PKT_RX_IPV4_HDR) {\n+#endif\n \t\t/* Handle IPv4 headers.*/\n \t\tipv4_hdr =\n \t\t\trte_pktmbuf_mtod_offset(m, struct ipv4_hdr *,\n@@ -670,8 +674,12 @@ l3fwd_simple_forward(struct rte_mbuf *m, uint8_t portid,\n \t\tether_addr_copy(&ports_eth_addr[dst_port], ð_hdr->s_addr);\n \n \t\tsend_single_packet(m, dst_port);\n+#ifdef RTE_NEXT_ABI\n+\t} else if (RTE_ETH_IS_IPV6_HDR(m->packet_type)) {\n+#else\n \t}\n \telse {\n+#endif\n \t\t/* Handle IPv6 headers.*/\n #if (APP_LOOKUP_METHOD == APP_LOOKUP_EXACT_MATCH)\n \t\tstruct ipv6_hdr *ipv6_hdr;\n", "prefixes": [ "dpdk-dev", "v10", "16/19" ] }