Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/62487/?format=api
{ "id": 62487, "url": "https://patches.dpdk.org/api/patches/62487/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20191105181640.3714-1-Devyn.Johnson@BanduraCyber.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191105181640.3714-1-Devyn.Johnson@BanduraCyber.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191105181640.3714-1-Devyn.Johnson@BanduraCyber.com", "date": "2019-11-05T18:16:40", "name": "Working Towards Making DPDK Compile with Additional Warning Flags", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": true, "hash": "4ffe440111dd45f768e78ce1c6f454174c12b20f", "submitter": { "id": 1487, "url": "https://patches.dpdk.org/api/people/1487/?format=api", "name": "Devyn Johnson", "email": "devyn.johnson@banduracyber.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20191105181640.3714-1-Devyn.Johnson@BanduraCyber.com/mbox/", "series": [ { "id": 7262, "url": "https://patches.dpdk.org/api/series/7262/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=7262", "date": "2019-11-05T18:16:40", "name": "Working Towards Making DPDK Compile with Additional Warning Flags", "version": 1, "mbox": "https://patches.dpdk.org/series/7262/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/62487/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/62487/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 100D1A04A2;\n\tTue, 5 Nov 2019 19:16:52 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 795AF1BED5;\n\tTue, 5 Nov 2019 19:16:51 +0100 (CET)", "from mail-io1-f68.google.com (mail-io1-f68.google.com\n [209.85.166.68]) by dpdk.org (Postfix) with ESMTP id CA37F1BED4\n for <dev@dpdk.org>; Tue, 5 Nov 2019 19:16:49 +0100 (CET)", "by mail-io1-f68.google.com with SMTP id g15so2292501iob.9\n for <dev@dpdk.org>; Tue, 05 Nov 2019 10:16:49 -0800 (PST)", "from BAN-0119.bandura.local\n (71-86-11-242.static.stls.mo.charter.com. [71.86.11.242])\n by smtp.googlemail.com with ESMTPSA id y12sm458949iop.20.2019.11.05.10.16.47\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 05 Nov 2019 10:16:47 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=banduracyber-com.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id;\n bh=ziGjK2/TSrhLQ9Fene8o4RiHIbvkWpKANSY+HzktCjo=;\n b=1odzvvUqU/Bz31QQMn/XjrDRt7va4+Fx1dDO7N2V496FL4xk01aFMKMg5fFEZjIp9u\n KxmjPrRWnWhMmMEMbsziWGmqoK+5rbhZZAnt5ucfejDdxPu4P8yR96SZFxt90zWkatJh\n u1mjQ0/QGNs2mJ3IP1Ae/Q8EMLN1VUdrSTCAOtXIp10kQLKdWxnbx95uhSttcWG8J5Ll\n hKzEBjcR5ZxVMYiPZ63a0JVzKi+KmMOerMhFf6Y4E0cWxiIscfeLofF1yp1LGimgeudS\n CEkTmOGP3sqnmCNWcsg04JuY9EwOV8E6TcySQAUteQQQeAUwY65qDVknOjyc8qKlDViY\n ideg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id;\n bh=ziGjK2/TSrhLQ9Fene8o4RiHIbvkWpKANSY+HzktCjo=;\n b=hBIocx6R0oRYQEiS2eHjwSEhKHyjPTycZAWD9UJ0DCEtPQK7y9H8GZghhG9cFI6Gd9\n 5iYWBfvzrC+dCULwO4edR4Ksxc5Wj5eN/WetK6Y/xua2P0cgPlr54kX95EPmgNBdnItd\n zcSlPzcpByUxpf+pvxQFFVjX/wxj6OhbikwAAOMnoPt105+ETqcft5MLOBREf2klI67A\n 5EK6RWMaTdKbNEMJ4mAj1nPbRaeML+LhKP0sFod+lN6wAkviMFaLxNPxrbaG0zsomapx\n GnY75VxUUoQlRG53+r8gFhK9QICCDsnCYZ3E8kV+CjtPQDj/2QdhqYcAD6dP5/EYe3vy\n Bjkw==", "X-Gm-Message-State": "APjAAAXwHiy4ETJb9fiOVZgmcabxKltyCTyliaEJ7T3cfu3+6Fax49ni\n UEeJYw3yckKG4S1FXR8wWsmIjXXSQp8ubQ==", "X-Google-Smtp-Source": "\n APXvYqy5/LgsLuMtexleSITQ3sPdKnnRccLG+/e9tbtolfcz1AIm7PFl+d/0LERoN53uDDSWhGcb8w==", "X-Received": "by 2002:a5d:8b10:: with SMTP id k16mr29442350ion.69.1572977808305;\n Tue, 05 Nov 2019 10:16:48 -0800 (PST)", "From": "devyn.johnson@banduracyber.com", "X-Google-Original-From": "Devyn.Johnson@BanduraCyber.com", "To": "dev@dpdk.org", "Cc": "Devyn Collier Johnson <Devyn.Johnson@BanduraCyber.com>", "Date": "Tue, 5 Nov 2019 12:16:40 -0600", "Message-Id": "<20191105181640.3714-1-Devyn.Johnson@BanduraCyber.com>", "Subject": "[dpdk-dev] [PATCH] Working Towards Making DPDK Compile with\n\tAdditional Warning Flags", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Devyn Collier Johnson <Devyn.Johnson@BanduraCyber.com>\n\nSigned-off-by: Devyn Collier Johnson <Devyn.Johnson@BanduraCyber.com>\n---\n lib/librte_cryptodev/rte_cryptodev.c | 4 ++--\n lib/librte_eal/common/eal_common_cpuflags.c | 4 ++--\n lib/librte_eal/common/eal_common_errno.c | 2 +-\n lib/librte_eal/common/eal_common_hexdump.c | 4 ++--\n lib/librte_eal/common/eal_common_lcore.c | 10 +++++-----\n lib/librte_eal/common/eal_common_log.c | 10 +++++-----\n lib/librte_eal/common/eal_common_memalloc.c | 8 ++++----\n lib/librte_eal/common/eal_common_memory.c | 2 +-\n lib/librte_eal/common/eal_common_proc.c | 2 +-\n lib/librte_eal/common/eal_common_tailqs.c | 2 +-\n lib/librte_eal/common/eal_memalloc.h | 8 ++++----\n lib/librte_eal/common/eal_private.h | 2 +-\n lib/librte_eal/common/include/rte_bitmap.h | 20 ++++++++++----------\n lib/librte_eal/common/include/rte_common.h | 2 +-\n lib/librte_eal/common/include/rte_errno.h | 2 +-\n lib/librte_eal/common/include/rte_hexdump.h | 2 +-\n lib/librte_eal/common/include/rte_lcore.h | 10 +++++-----\n lib/librte_eal/common/include/rte_log.h | 8 ++++----\n lib/librte_eal/common/malloc_elem.c | 4 ++--\n lib/librte_eal/linux/eal/eal.c | 2 +-\n lib/librte_ethdev/rte_class_eth.c | 2 +-\n lib/librte_ethdev/rte_mtr.c | 2 +-\n lib/librte_ethdev/rte_tm.c | 2 +-\n lib/librte_mbuf/rte_mbuf.c | 4 ++--\n lib/librte_mbuf/rte_mbuf_dyn.c | 4 ++--\n lib/librte_mempool/rte_mempool.c | 2 +-\n lib/librte_ring/rte_ring.c | 2 +-\n lib/librte_timer/rte_timer.c | 20 ++++++++++----------\n 28 files changed, 73 insertions(+), 73 deletions(-)", "diff": "diff --git a/lib/librte_cryptodev/rte_cryptodev.c b/lib/librte_cryptodev/rte_cryptodev.c\nindex 89aa2ed3e..0f72d5892 100644\n--- a/lib/librte_cryptodev/rte_cryptodev.c\n+++ b/lib/librte_cryptodev/rte_cryptodev.c\n@@ -357,7 +357,7 @@ rte_cryptodev_asym_capability_get(uint8_t dev_id,\n \t\t\treturn &capability->asym.xform_capa;\n \t}\n \treturn NULL;\n-};\n+}\n\n int\n rte_cryptodev_sym_capability_check_cipher(\n@@ -803,7 +803,7 @@ rte_cryptodev_queue_pairs_config(struct rte_cryptodev *dev, uint16_t nb_qpairs,\n\n \tif ((dev == NULL) || (nb_qpairs < 1)) {\n \t\tCDEV_LOG_ERR(\"invalid param: dev %p, nb_queues %u\",\n-\t\t\t\t\t\t\tdev, nb_qpairs);\n+\t\t\t\t\t\t\t(void*)dev, nb_qpairs);\n \t\treturn -EINVAL;\n \t}\n\ndiff --git a/lib/librte_eal/common/eal_common_cpuflags.c b/lib/librte_eal/common/eal_common_cpuflags.c\nindex dc5f75d05..4365b5697 100644\n--- a/lib/librte_eal/common/eal_common_cpuflags.c\n+++ b/lib/librte_eal/common/eal_common_cpuflags.c\n@@ -14,10 +14,10 @@ rte_cpu_is_supported(void)\n \tstatic const enum rte_cpu_flag_t compile_time_flags[] = {\n \t\t\tRTE_COMPILE_TIME_CPUFLAGS\n \t};\n-\tunsigned count = RTE_DIM(compile_time_flags), i;\n+\tconst unsigned int count = RTE_DIM(compile_time_flags);\n \tint ret;\n\n-\tfor (i = 0; i < count; i++) {\n+\tfor (unsigned int i = 0; i < count; i++) {\n \t\tret = rte_cpu_get_flag_enabled(compile_time_flags[i]);\n\n \t\tif (ret < 0) {\ndiff --git a/lib/librte_eal/common/eal_common_errno.c b/lib/librte_eal/common/eal_common_errno.c\nindex 2a10fb823..481232b0a 100644\n--- a/lib/librte_eal/common/eal_common_errno.c\n+++ b/lib/librte_eal/common/eal_common_errno.c\n@@ -18,7 +18,7 @@\n RTE_DEFINE_PER_LCORE(int, _rte_errno);\n\n const char *\n-rte_strerror(int errnum)\n+rte_strerror(const int errnum)\n {\n \t/* BSD puts a colon in the \"unknown error\" messages, Linux doesn't */\n #ifdef RTE_EXEC_ENV_FREEBSD\ndiff --git a/lib/librte_eal/common/eal_common_hexdump.c b/lib/librte_eal/common/eal_common_hexdump.c\nindex 2d2179d41..e3d82fc09 100644\n--- a/lib/librte_eal/common/eal_common_hexdump.c\n+++ b/lib/librte_eal/common/eal_common_hexdump.c\n@@ -18,7 +18,7 @@ rte_hexdump(FILE *f, const char *title, const void *buf, unsigned int len)\n \tchar line[LINE_LEN];\t/* space needed 8+16*3+3+16 == 75 */\n\n \tfprintf(f, \"%s at [%p], len=%u\\n\",\n-\t\ttitle ? : \" Dump data\", data, len);\n+\t\ttitle ? title : \" Dump data\", data, len);\n \tofs = 0;\n \twhile (ofs < len) {\n \t\t/* format the line in the buffer */\n@@ -49,7 +49,7 @@ rte_hexdump(FILE *f, const char *title, const void *buf, unsigned int len)\n }\n\n void\n-rte_memdump(FILE *f, const char *title, const void *buf, unsigned int len)\n+rte_memdump(FILE *f, const char *title, const void *buf, const unsigned int len)\n {\n \tunsigned int i, out;\n \tconst unsigned char *data = buf;\ndiff --git a/lib/librte_eal/common/eal_common_lcore.c b/lib/librte_eal/common/eal_common_lcore.c\nindex 39efadef1..4812ca212 100644\n--- a/lib/librte_eal/common/eal_common_lcore.c\n+++ b/lib/librte_eal/common/eal_common_lcore.c\n@@ -48,13 +48,13 @@ int rte_lcore_to_cpu_id(int lcore_id)\n \treturn lcore_config[lcore_id].core_id;\n }\n\n-rte_cpuset_t rte_lcore_cpuset(unsigned int lcore_id)\n+rte_cpuset_t rte_lcore_cpuset(const unsigned int lcore_id)\n {\n \treturn lcore_config[lcore_id].cpuset;\n }\n\n enum rte_lcore_role_t\n-rte_eal_lcore_role(unsigned int lcore_id)\n+rte_eal_lcore_role(const unsigned int lcore_id)\n {\n \tstruct rte_config *cfg = rte_eal_get_configuration();\n\n@@ -63,7 +63,7 @@ rte_eal_lcore_role(unsigned int lcore_id)\n \treturn cfg->lcore_role[lcore_id];\n }\n\n-int rte_lcore_is_enabled(unsigned int lcore_id)\n+int rte_lcore_is_enabled(const unsigned int lcore_id)\n {\n \tstruct rte_config *cfg = rte_eal_get_configuration();\n\n@@ -92,7 +92,7 @@ unsigned int rte_get_next_lcore(unsigned int i, int skip_master, int wrap)\n }\n\n unsigned int\n-rte_lcore_to_socket_id(unsigned int lcore_id)\n+rte_lcore_to_socket_id(const unsigned int lcore_id)\n {\n \treturn lcore_config[lcore_id].socket_id;\n }\n@@ -194,7 +194,7 @@ rte_socket_count(void)\n }\n\n int\n-rte_socket_id_by_idx(unsigned int idx)\n+rte_socket_id_by_idx(const unsigned int idx)\n {\n \tconst struct rte_config *config = rte_eal_get_configuration();\n \tif (idx >= config->numa_node_count) {\ndiff --git a/lib/librte_eal/common/eal_common_log.c b/lib/librte_eal/common/eal_common_log.c\nindex e0a7bef03..21b93072b 100644\n--- a/lib/librte_eal/common/eal_common_log.c\n+++ b/lib/librte_eal/common/eal_common_log.c\n@@ -84,14 +84,14 @@ rte_log_get_stream(void)\n \t\t * of stderr, even if the application closes and\n \t\t * reopens it.\n \t\t */\n-\t\treturn default_log_stream ? : stderr;\n+\t\treturn default_log_stream ? default_log_stream : stderr;\n \t}\n \treturn f;\n }\n\n /* Set global log level */\n void\n-rte_log_set_global_level(uint32_t level)\n+rte_log_set_global_level(const uint32_t level)\n {\n \trte_logs.level = (uint32_t)level;\n }\n@@ -104,7 +104,7 @@ rte_log_get_global_level(void)\n }\n\n int\n-rte_log_get_level(uint32_t type)\n+rte_log_get_level(const uint32_t type)\n {\n \tif (type >= rte_logs.dynamic_types_len)\n \t\treturn -1;\n@@ -113,7 +113,7 @@ rte_log_get_level(uint32_t type)\n }\n\n int\n-rte_log_set_level(uint32_t type, uint32_t level)\n+rte_log_set_level(const uint32_t type, const uint32_t level)\n {\n \tif (type >= rte_logs.dynamic_types_len)\n \t\treturn -1;\n@@ -127,7 +127,7 @@ rte_log_set_level(uint32_t type, uint32_t level)\n\n /* set log level by regular expression */\n int\n-rte_log_set_level_regexp(const char *regex, uint32_t level)\n+rte_log_set_level_regexp(const char *regex, const uint32_t level)\n {\n \tregex_t r;\n \tsize_t i;\ndiff --git a/lib/librte_eal/common/eal_common_memalloc.c b/lib/librte_eal/common/eal_common_memalloc.c\nindex 55189d072..864e4fc71 100644\n--- a/lib/librte_eal/common/eal_common_memalloc.c\n+++ b/lib/librte_eal/common/eal_common_memalloc.c\n@@ -69,7 +69,7 @@ find_mem_alloc_validator(const char *name, int socket_id)\n\n bool\n eal_memalloc_is_contig(const struct rte_memseg_list *msl, void *start,\n-\t\tsize_t len)\n+\t\tconst size_t len)\n {\n \tvoid *end, *aligned_start, *aligned_end;\n \tsize_t pgsz = (size_t)msl->page_sz;\n@@ -252,7 +252,7 @@ eal_memalloc_mem_event_notify(enum rte_mem_event event, const void *start,\n\n int\n eal_memalloc_mem_alloc_validator_register(const char *name,\n-\t\trte_mem_alloc_validator_t clb, int socket_id, size_t limit)\n+\t\trte_mem_alloc_validator_t clb, const int socket_id, const size_t limit)\n {\n \tstruct mem_alloc_validator_entry *entry;\n \tint ret, len;\n@@ -302,7 +302,7 @@ eal_memalloc_mem_alloc_validator_register(const char *name,\n }\n\n int\n-eal_memalloc_mem_alloc_validator_unregister(const char *name, int socket_id)\n+eal_memalloc_mem_alloc_validator_unregister(const char *name, const int socket_id)\n {\n \tstruct mem_alloc_validator_entry *entry;\n \tint ret, len;\n@@ -341,7 +341,7 @@ eal_memalloc_mem_alloc_validator_unregister(const char *name, int socket_id)\n }\n\n int\n-eal_memalloc_mem_alloc_validate(int socket_id, size_t new_len)\n+eal_memalloc_mem_alloc_validate(const int socket_id, const size_t new_len)\n {\n \tstruct mem_alloc_validator_entry *entry;\n \tint ret = 0;\ndiff --git a/lib/librte_eal/common/eal_common_memory.c b/lib/librte_eal/common/eal_common_memory.c\nindex 4a9cc1f19..89d41ac4a 100644\n--- a/lib/librte_eal/common/eal_common_memory.c\n+++ b/lib/librte_eal/common/eal_common_memory.c\n@@ -43,7 +43,7 @@ static uint64_t system_page_sz;\n #define MAX_MMAP_WITH_DEFINED_ADDR_TRIES 5\n void *\n eal_get_virtual_area(void *requested_addr, size_t *size,\n-\t\tsize_t page_sz, int flags, int mmap_flags)\n+\t\tconst size_t page_sz, const int flags, int mmap_flags)\n {\n \tbool addr_is_hint, allow_shrink, unmap, no_align;\n \tuint64_t map_sz;\ndiff --git a/lib/librte_eal/common/eal_common_proc.c b/lib/librte_eal/common/eal_common_proc.c\nindex cbe8d10fc..587832982 100644\n--- a/lib/librte_eal/common/eal_common_proc.c\n+++ b/lib/librte_eal/common/eal_common_proc.c\n@@ -707,7 +707,7 @@ send_msg(const char *dst_path, struct rte_mp_msg *msg, int type)\n }\n\n static int\n-mp_send(struct rte_mp_msg *msg, const char *peer, int type)\n+mp_send(struct rte_mp_msg *msg, const char *peer, const int type)\n {\n \tint dir_fd, ret = 0;\n \tDIR *mp_dir;\ndiff --git a/lib/librte_eal/common/eal_common_tailqs.c b/lib/librte_eal/common/eal_common_tailqs.c\nindex ead06897b..7d7faf316 100644\n--- a/lib/librte_eal/common/eal_common_tailqs.c\n+++ b/lib/librte_eal/common/eal_common_tailqs.c\n@@ -65,7 +65,7 @@ rte_dump_tailq(FILE *f)\n \t\tconst struct rte_tailq_entry_head *head = &tailq->tailq_head;\n\n \t\tfprintf(f, \"Tailq %u: qname:<%s>, tqh_first:%p, tqh_last:%p\\n\",\n-\t\t\ti, tailq->name, head->tqh_first, head->tqh_last);\n+\t\t\ti, tailq->name, (void*)head->tqh_first, (void*)head->tqh_last);\n \t}\n \trte_mcfg_tailq_read_unlock();\n }\ndiff --git a/lib/librte_eal/common/eal_memalloc.h b/lib/librte_eal/common/eal_memalloc.h\nindex e953cd84e..35dee1b21 100644\n--- a/lib/librte_eal/common/eal_memalloc.h\n+++ b/lib/librte_eal/common/eal_memalloc.h\n@@ -48,7 +48,7 @@ eal_memalloc_free_seg_bulk(struct rte_memseg **ms, int n_segs);\n */\n bool\n eal_memalloc_is_contig(const struct rte_memseg_list *msl, void *start,\n-\t\tsize_t len);\n+\t\tconst size_t len);\n\n /* synchronize local memory map to primary process */\n int\n@@ -67,13 +67,13 @@ eal_memalloc_mem_event_notify(enum rte_mem_event event, const void *start,\n\n int\n eal_memalloc_mem_alloc_validator_register(const char *name,\n-\t\trte_mem_alloc_validator_t clb, int socket_id, size_t limit);\n+\t\trte_mem_alloc_validator_t clb, const int socket_id, const size_t limit);\n\n int\n-eal_memalloc_mem_alloc_validator_unregister(const char *name, int socket_id);\n+eal_memalloc_mem_alloc_validator_unregister(const char *name, const int socket_id);\n\n int\n-eal_memalloc_mem_alloc_validate(int socket_id, size_t new_len);\n+eal_memalloc_mem_alloc_validate(const int socket_id, const size_t new_len);\n\n /* returns fd or -errno */\n int\ndiff --git a/lib/librte_eal/common/eal_private.h b/lib/librte_eal/common/eal_private.h\nindex 8a9d493f0..6e4f87578 100644\n--- a/lib/librte_eal/common/eal_private.h\n+++ b/lib/librte_eal/common/eal_private.h\n@@ -234,7 +234,7 @@ int rte_eal_check_module(const char *module_name);\n /**< immediately unmap reserved virtual area. */\n void *\n eal_get_virtual_area(void *requested_addr, size_t *size,\n-\t\tsize_t page_sz, int flags, int mmap_flags);\n+\t\tconst size_t page_sz, const int flags, int mmap_flags);\n\n /**\n * Get cpu core_id.\ndiff --git a/lib/librte_eal/common/include/rte_bitmap.h b/lib/librte_eal/common/include/rte_bitmap.h\nindex 6b846f251..2c7f74538 100644\n--- a/lib/librte_eal/common/include/rte_bitmap.h\n+++ b/lib/librte_eal/common/include/rte_bitmap.h\n@@ -94,9 +94,9 @@ __rte_bitmap_index2_set(struct rte_bitmap *bmp)\n }\n\n static inline uint32_t\n-__rte_bitmap_get_memory_footprint(uint32_t n_bits,\n-\tuint32_t *array1_byte_offset, uint32_t *array1_slabs,\n-\tuint32_t *array2_byte_offset, uint32_t *array2_slabs)\n+__rte_bitmap_get_memory_footprint(const uint32_t n_bits,\n+\tuint32_t * __restrict array1_byte_offset, uint32_t * __restrict array1_slabs,\n+\tuint32_t * __restrict array2_byte_offset, uint32_t * __restrict array2_slabs)\n {\n \tuint32_t n_slabs_context, n_slabs_array1, n_cache_lines_context_and_array1;\n \tuint32_t n_cache_lines_array2;\n@@ -145,7 +145,7 @@ __rte_bitmap_scan_init(struct rte_bitmap *bmp)\n * Bitmap memory footprint measured in bytes on success, 0 on error\n */\n static inline uint32_t\n-rte_bitmap_get_memory_footprint(uint32_t n_bits) {\n+rte_bitmap_get_memory_footprint(const uint32_t n_bits) {\n \t/* Check input arguments */\n \tif (n_bits == 0) {\n \t\treturn 0;\n@@ -167,7 +167,7 @@ rte_bitmap_get_memory_footprint(uint32_t n_bits) {\n * Handle to bitmap instance.\n */\n static inline struct rte_bitmap *\n-rte_bitmap_init(uint32_t n_bits, uint8_t *mem, uint32_t mem_size)\n+rte_bitmap_init(const uint32_t n_bits, uint8_t *mem, const uint32_t mem_size)\n {\n \tstruct rte_bitmap *bmp;\n \tuint32_t array1_byte_offset, array1_slabs, array2_byte_offset, array2_slabs;\n@@ -247,7 +247,7 @@ rte_bitmap_reset(struct rte_bitmap *bmp)\n * 0 upon success, error code otherwise\n */\n static inline void\n-rte_bitmap_prefetch0(struct rte_bitmap *bmp, uint32_t pos)\n+rte_bitmap_prefetch0(struct rte_bitmap *bmp, const uint32_t pos)\n {\n \tuint64_t *slab2;\n \tuint32_t index2;\n@@ -268,7 +268,7 @@ rte_bitmap_prefetch0(struct rte_bitmap *bmp, uint32_t pos)\n * 0 when bit is cleared, non-zero when bit is set\n */\n static inline uint64_t\n-rte_bitmap_get(struct rte_bitmap *bmp, uint32_t pos)\n+rte_bitmap_get(struct rte_bitmap *bmp, const uint32_t pos)\n {\n \tuint64_t *slab2;\n \tuint32_t index2, offset2;\n@@ -288,7 +288,7 @@ rte_bitmap_get(struct rte_bitmap *bmp, uint32_t pos)\n * Bit position\n */\n static inline void\n-rte_bitmap_set(struct rte_bitmap *bmp, uint32_t pos)\n+rte_bitmap_set(struct rte_bitmap *bmp, const uint32_t pos)\n {\n \tuint64_t *slab1, *slab2;\n \tuint32_t index1, index2, offset1, offset2;\n@@ -316,7 +316,7 @@ rte_bitmap_set(struct rte_bitmap *bmp, uint32_t pos)\n * Value to be assigned to the 64-bit slab in array2\n */\n static inline void\n-rte_bitmap_set_slab(struct rte_bitmap *bmp, uint32_t pos, uint64_t slab)\n+rte_bitmap_set_slab(struct rte_bitmap *bmp, const uint32_t pos, const uint64_t slab)\n {\n \tuint64_t *slab1, *slab2;\n \tuint32_t index1, index2, offset1;\n@@ -356,7 +356,7 @@ __rte_bitmap_line_not_empty(uint64_t *slab2)\n * Bit position\n */\n static inline void\n-rte_bitmap_clear(struct rte_bitmap *bmp, uint32_t pos)\n+rte_bitmap_clear(struct rte_bitmap *bmp, const uint32_t pos)\n {\n \tuint64_t *slab1, *slab2;\n \tuint32_t index1, index2, offset1, offset2;\ndiff --git a/lib/librte_eal/common/include/rte_common.h b/lib/librte_eal/common/include/rte_common.h\nindex 459d082d1..2a73c3a88 100644\n--- a/lib/librte_eal/common/include/rte_common.h\n+++ b/lib/librte_eal/common/include/rte_common.h\n@@ -261,7 +261,7 @@ static void __attribute__((destructor(RTE_PRIO(prio)), used)) func(void)\n * whichever difference is the lowest.\n */\n #define RTE_ALIGN_MUL_NEAR(v, mul)\t\t\t\t\\\n-\t({\t\t\t\t\t\t\t\\\n+\t__extension__ ({\t\t\t\t\t\t\t\\\n \t\ttypeof(v) ceil = RTE_ALIGN_MUL_CEIL(v, mul);\t\\\n \t\ttypeof(v) floor = RTE_ALIGN_MUL_FLOOR(v, mul);\t\\\n \t\t(ceil - v) > (v - floor) ? floor : ceil;\t\\\ndiff --git a/lib/librte_eal/common/include/rte_errno.h b/lib/librte_eal/common/include/rte_errno.h\nindex ba45591d2..7d7eeba8d 100644\n--- a/lib/librte_eal/common/include/rte_errno.h\n+++ b/lib/librte_eal/common/include/rte_errno.h\n@@ -39,7 +39,7 @@ RTE_DECLARE_PER_LCORE(int, _rte_errno); /**< Per core error number. */\n * A pointer to a thread-local string containing the text describing\n * the error.\n */\n-const char *rte_strerror(int errnum);\n+const char *rte_strerror(const int errnum);\n\n #ifndef __ELASTERROR\n /**\ndiff --git a/lib/librte_eal/common/include/rte_hexdump.h b/lib/librte_eal/common/include/rte_hexdump.h\nindex 2d03c089c..d85b33ae2 100644\n--- a/lib/librte_eal/common/include/rte_hexdump.h\n+++ b/lib/librte_eal/common/include/rte_hexdump.h\n@@ -50,7 +50,7 @@ rte_hexdump(FILE *f, const char * title, const void * buf, unsigned int len);\n */\n\n void\n-rte_memdump(FILE *f, const char * title, const void * buf, unsigned int len);\n+rte_memdump(FILE *f, const char * title, const void * buf, const unsigned int len);\n\n\n #ifdef __cplusplus\ndiff --git a/lib/librte_eal/common/include/rte_lcore.h b/lib/librte_eal/common/include/rte_lcore.h\nindex 476b8ef3a..09695bc14 100644\n--- a/lib/librte_eal/common/include/rte_lcore.h\n+++ b/lib/librte_eal/common/include/rte_lcore.h\n@@ -33,7 +33,7 @@ RTE_DECLARE_PER_LCORE(rte_cpuset_t, _cpuset); /**< Per thread \"cpuset\". */\n * @return\n * The role of the lcore.\n */\n-enum rte_lcore_role_t rte_eal_lcore_role(unsigned int lcore_id);\n+enum rte_lcore_role_t rte_eal_lcore_role(const unsigned int lcore_id);\n\n /**\n * Return the Application thread ID of the execution unit.\n@@ -121,7 +121,7 @@ rte_socket_count(void);\n * - -1 on error, with errno set to EINVAL\n */\n int\n-rte_socket_id_by_idx(unsigned int idx);\n+rte_socket_id_by_idx(const unsigned int idx);\n\n /**\n * Get the ID of the physical socket of the specified lcore\n@@ -132,7 +132,7 @@ rte_socket_id_by_idx(unsigned int idx);\n * the ID of lcoreid's physical socket\n */\n unsigned int\n-rte_lcore_to_socket_id(unsigned int lcore_id);\n+rte_lcore_to_socket_id(const unsigned int lcore_id);\n\n /**\n * @warning\n@@ -161,7 +161,7 @@ rte_lcore_to_cpu_id(int lcore_id);\n */\n __rte_experimental\n rte_cpuset_t\n-rte_lcore_cpuset(unsigned int lcore_id);\n+rte_lcore_cpuset(const unsigned int lcore_id);\n\n /**\n * Test if an lcore is enabled.\n@@ -172,7 +172,7 @@ rte_lcore_cpuset(unsigned int lcore_id);\n * @return\n * True if the given lcore is enabled; false otherwise.\n */\n-int rte_lcore_is_enabled(unsigned int lcore_id);\n+int rte_lcore_is_enabled(const unsigned int lcore_id);\n\n /**\n * Get the next enabled lcore ID.\ndiff --git a/lib/librte_eal/common/include/rte_log.h b/lib/librte_eal/common/include/rte_log.h\nindex 1bb0e6694..b0ed94b55 100644\n--- a/lib/librte_eal/common/include/rte_log.h\n+++ b/lib/librte_eal/common/include/rte_log.h\n@@ -123,7 +123,7 @@ FILE *rte_log_get_stream(void);\n * @param level\n * Log level. A value between RTE_LOG_EMERG (1) and RTE_LOG_DEBUG (8).\n */\n-void rte_log_set_global_level(uint32_t level);\n+void rte_log_set_global_level(const uint32_t level);\n\n /**\n * Get the global log level.\n@@ -141,7 +141,7 @@ uint32_t rte_log_get_global_level(void);\n * @return\n * 0 on success, a negative value if logtype is invalid.\n */\n-int rte_log_get_level(uint32_t logtype);\n+int rte_log_get_level(const uint32_t logtype);\n\n /**\n * Set the log level for a given type based on shell pattern.\n@@ -165,7 +165,7 @@ int rte_log_set_level_pattern(const char *pattern, uint32_t level);\n * @return\n * 0 on success, a negative value if level is invalid.\n */\n-int rte_log_set_level_regexp(const char *regex, uint32_t level);\n+int rte_log_set_level_regexp(const char *regex, const uint32_t level);\n\n /**\n * Set the log level for a given type.\n@@ -177,7 +177,7 @@ int rte_log_set_level_regexp(const char *regex, uint32_t level);\n * @return\n * 0 on success, a negative value if logtype or level is invalid.\n */\n-int rte_log_set_level(uint32_t logtype, uint32_t level);\n+int rte_log_set_level(uint32_t logtype, const uint32_t level);\n\n /**\n * Get the current loglevel for the message being processed.\ndiff --git a/lib/librte_eal/common/malloc_elem.c b/lib/librte_eal/common/malloc_elem.c\nindex 658c9b5b7..193d7526b 100644\n--- a/lib/librte_eal/common/malloc_elem.c\n+++ b/lib/librte_eal/common/malloc_elem.c\n@@ -666,8 +666,8 @@ elem_state_to_str(enum elem_state state)\n void\n malloc_elem_dump(const struct malloc_elem *elem, FILE *f)\n {\n-\tfprintf(f, \"Malloc element at %p (%s)\\n\", elem,\n+\tfprintf(f, \"Malloc element at %p (%s)\\n\", (const void*)elem,\n \t\t\telem_state_to_str(elem->state));\n \tfprintf(f, \" len: 0x%zx pad: 0x%\" PRIx32 \"\\n\", elem->size, elem->pad);\n-\tfprintf(f, \" prev: %p next: %p\\n\", elem->prev, elem->next);\n+\tfprintf(f, \" prev: %p next: %p\\n\", (void*)elem->prev, (void*)elem->next);\n }\ndiff --git a/lib/librte_eal/linux/eal/eal.c b/lib/librte_eal/linux/eal/eal.c\nindex 9e2d50cfb..620470126 100644\n--- a/lib/librte_eal/linux/eal/eal.c\n+++ b/lib/librte_eal/linux/eal/eal.c\n@@ -451,7 +451,7 @@ rte_eal_config_reattach(void)\n \t\t\t/* errno is stale, don't use */\n \t\t\tRTE_LOG(ERR, EAL, \"Cannot mmap memory for rte_config at [%p], got [%p]\"\n \t\t\t\t\" - please use '--\" OPT_BASE_VIRTADDR\n-\t\t\t\t\"' option\\n\", rte_mem_cfg_addr, mem_config);\n+\t\t\t\t\"' option\\n\", rte_mem_cfg_addr, (void*)mem_config);\n \t\t\tmunmap(mem_config, sizeof(struct rte_mem_config));\n \t\t\treturn -1;\n \t\t}\ndiff --git a/lib/librte_ethdev/rte_class_eth.c b/lib/librte_ethdev/rte_class_eth.c\nindex 6338355e2..76959e71a 100644\n--- a/lib/librte_ethdev/rte_class_eth.c\n+++ b/lib/librte_ethdev/rte_class_eth.c\n@@ -163,4 +163,4 @@ static struct rte_class rte_class_eth = {\n \t.dev_iterate = eth_dev_iterate,\n };\n\n-RTE_REGISTER_CLASS(eth, rte_class_eth);\n+RTE_REGISTER_CLASS(eth, rte_class_eth)\ndiff --git a/lib/librte_ethdev/rte_mtr.c b/lib/librte_ethdev/rte_mtr.c\nindex 3073ac03f..ab2b3372c 100644\n--- a/lib/librte_ethdev/rte_mtr.c\n+++ b/lib/librte_ethdev/rte_mtr.c\n@@ -41,7 +41,7 @@ rte_mtr_ops_get(uint16_t port_id, struct rte_mtr_error *error)\n }\n\n #define RTE_MTR_FUNC(port_id, func)\t\t\t\\\n-({\t\t\t\t\t\t\t\\\n+__extension__ ({\t\t\t\t\t\t\t\\\n \tconst struct rte_mtr_ops *ops =\t\t\t\\\n \t\trte_mtr_ops_get(port_id, error);\t\t\\\n \tif (ops == NULL)\t\t\t\t\t\\\ndiff --git a/lib/librte_ethdev/rte_tm.c b/lib/librte_ethdev/rte_tm.c\nindex 9709454f3..18f5d04cf 100644\n--- a/lib/librte_ethdev/rte_tm.c\n+++ b/lib/librte_ethdev/rte_tm.c\n@@ -40,7 +40,7 @@ rte_tm_ops_get(uint16_t port_id, struct rte_tm_error *error)\n }\n\n #define RTE_TM_FUNC(port_id, func)\t\t\t\t\\\n-({\t\t\t\t\t\t\t\\\n+__extension__ ({\t\t\t\t\t\t\t\\\n \tconst struct rte_tm_ops *ops =\t\t\t\\\n \t\trte_tm_ops_get(port_id, error);\t\t\\\n \tif (ops == NULL)\t\t\t\t\t\\\ndiff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf/rte_mbuf.c\nindex 8c51dc1a0..de46fa7a2 100644\n--- a/lib/librte_mbuf/rte_mbuf.c\n+++ b/lib/librte_mbuf/rte_mbuf.c\n@@ -474,7 +474,7 @@ rte_pktmbuf_dump(FILE *f, const struct rte_mbuf *m, unsigned dump_len)\n \t__rte_mbuf_sanity_check(m, 1);\n\n \tfprintf(f, \"dump mbuf at %p, iova=%\"PRIx64\", buf_len=%u\\n\",\n-\t m, (uint64_t)m->buf_iova, (unsigned)m->buf_len);\n+\t (const void*)m, (uint64_t)m->buf_iova, (unsigned)m->buf_len);\n \tfprintf(f, \" pkt_len=%\"PRIu32\", ol_flags=%\"PRIx64\", nb_segs=%u, \"\n \t \"in_port=%u\\n\", m->pkt_len, m->ol_flags,\n \t (unsigned)m->nb_segs, (unsigned)m->port);\n@@ -484,7 +484,7 @@ rte_pktmbuf_dump(FILE *f, const struct rte_mbuf *m, unsigned dump_len)\n \t\t__rte_mbuf_sanity_check(m, 0);\n\n \t\tfprintf(f, \" segment at %p, data=%p, data_len=%u\\n\",\n-\t\t\tm, rte_pktmbuf_mtod(m, void *), (unsigned)m->data_len);\n+\t\t\t(const void*)m, (void*)rte_pktmbuf_mtod(m, void *), (unsigned)m->data_len);\n \t\tlen = dump_len;\n \t\tif (len > m->data_len)\n \t\t\tlen = m->data_len;\ndiff --git a/lib/librte_mbuf/rte_mbuf_dyn.c b/lib/librte_mbuf/rte_mbuf_dyn.c\nindex d6931f847..daea77fe2 100644\n--- a/lib/librte_mbuf/rte_mbuf_dyn.c\n+++ b/lib/librte_mbuf/rte_mbuf_dyn.c\n@@ -28,7 +28,7 @@ TAILQ_HEAD(mbuf_dynfield_list, rte_tailq_entry);\n static struct rte_tailq_elem mbuf_dynfield_tailq = {\n \t.name = \"RTE_MBUF_DYNFIELD\",\n };\n-EAL_REGISTER_TAILQ(mbuf_dynfield_tailq);\n+EAL_REGISTER_TAILQ(mbuf_dynfield_tailq)\n\n struct mbuf_dynflag_elt {\n \tTAILQ_ENTRY(mbuf_dynflag_elt) next;\n@@ -40,7 +40,7 @@ TAILQ_HEAD(mbuf_dynflag_list, rte_tailq_entry);\n static struct rte_tailq_elem mbuf_dynflag_tailq = {\n \t.name = \"RTE_MBUF_DYNFLAG\",\n };\n-EAL_REGISTER_TAILQ(mbuf_dynflag_tailq);\n+EAL_REGISTER_TAILQ(mbuf_dynflag_tailq)\n\n struct mbuf_dyn_shm {\n \t/**\ndiff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_mempool.c\nindex 0f29e8712..b172a058e 100644\n--- a/lib/librte_mempool/rte_mempool.c\n+++ b/lib/librte_mempool/rte_mempool.c\n@@ -1200,7 +1200,7 @@ rte_mempool_dump(FILE *f, struct rte_mempool *mp)\n \tRTE_ASSERT(f != NULL);\n \tRTE_ASSERT(mp != NULL);\n\n-\tfprintf(f, \"mempool <%s>@%p\\n\", mp->name, mp);\n+\tfprintf(f, \"mempool <%s>@%p\\n\", mp->name, (void*)mp);\n \tfprintf(f, \" flags=%x\\n\", mp->flags);\n \tfprintf(f, \" pool=%p\\n\", mp->pool_data);\n \tfprintf(f, \" iova=0x%\" PRIx64 \"\\n\", mp->mz->iova);\ndiff --git a/lib/librte_ring/rte_ring.c b/lib/librte_ring/rte_ring.c\nindex d9b308036..86d0c8232 100644\n--- a/lib/librte_ring/rte_ring.c\n+++ b/lib/librte_ring/rte_ring.c\n@@ -232,7 +232,7 @@ rte_ring_free(struct rte_ring *r)\n void\n rte_ring_dump(FILE *f, const struct rte_ring *r)\n {\n-\tfprintf(f, \"ring <%s>@%p\\n\", r->name, r);\n+\tfprintf(f, \"ring <%s>@%p\\n\", r->name, (const void*)r);\n \tfprintf(f, \" flags=%x\\n\", r->flags);\n \tfprintf(f, \" size=%\"PRIu32\"\\n\", r->size);\n \tfprintf(f, \" capacity=%\"PRIu32\"\\n\", r->capacity);\ndiff --git a/lib/librte_timer/rte_timer.c b/lib/librte_timer/rte_timer.c\nindex 3834c9473..254276c3d 100644\n--- a/lib/librte_timer/rte_timer.c\n+++ b/lib/librte_timer/rte_timer.c\n@@ -145,7 +145,7 @@ rte_timer_subsystem_init_v20(void)\n \t\tpriv_timer[lcore_id].prev_lcore = lcore_id;\n \t}\n }\n-VERSION_SYMBOL(rte_timer_subsystem_init, _v20, 2.0);\n+VERSION_SYMBOL(rte_timer_subsystem_init, _v20, 2.0)\n\n /* Init the timer library. Allocate an array of timer data structs in shared\n * memory, and allocate the zeroth entry for use with original timer\n@@ -211,7 +211,7 @@ rte_timer_subsystem_init_v1905(void)\n }\n MAP_STATIC_SYMBOL(int rte_timer_subsystem_init(void),\n \t\t rte_timer_subsystem_init_v1905);\n-BIND_DEFAULT_SYMBOL(rte_timer_subsystem_init, _v1905, 19.05);\n+BIND_DEFAULT_SYMBOL(rte_timer_subsystem_init, _v1905, 19.05)\n\n void\n rte_timer_subsystem_finalize(void)\n@@ -572,7 +572,7 @@ rte_timer_reset_v20(struct rte_timer *tim, uint64_t ticks,\n \treturn __rte_timer_reset(tim, cur_time + ticks, period, tim_lcore,\n \t\t\t fct, arg, 0, &default_timer_data);\n }\n-VERSION_SYMBOL(rte_timer_reset, _v20, 2.0);\n+VERSION_SYMBOL(rte_timer_reset, _v20, 2.0)\n\n int\n rte_timer_reset_v1905(struct rte_timer *tim, uint64_t ticks,\n@@ -587,7 +587,7 @@ MAP_STATIC_SYMBOL(int rte_timer_reset(struct rte_timer *tim, uint64_t ticks,\n \t\t\t\t unsigned int tim_lcore,\n \t\t\t\t rte_timer_cb_t fct, void *arg),\n \t\t rte_timer_reset_v1905);\n-BIND_DEFAULT_SYMBOL(rte_timer_reset, _v1905, 19.05);\n+BIND_DEFAULT_SYMBOL(rte_timer_reset, _v1905, 19.05)\n\n int\n rte_timer_alt_reset(uint32_t timer_data_id, struct rte_timer *tim,\n@@ -662,7 +662,7 @@ rte_timer_stop_v20(struct rte_timer *tim)\n {\n \treturn __rte_timer_stop(tim, 0, &default_timer_data);\n }\n-VERSION_SYMBOL(rte_timer_stop, _v20, 2.0);\n+VERSION_SYMBOL(rte_timer_stop, _v20, 2.0)\n\n int\n rte_timer_stop_v1905(struct rte_timer *tim)\n@@ -671,7 +671,7 @@ rte_timer_stop_v1905(struct rte_timer *tim)\n }\n MAP_STATIC_SYMBOL(int rte_timer_stop(struct rte_timer *tim),\n \t\t rte_timer_stop_v1905);\n-BIND_DEFAULT_SYMBOL(rte_timer_stop, _v1905, 19.05);\n+BIND_DEFAULT_SYMBOL(rte_timer_stop, _v1905, 19.05)\n\n int\n rte_timer_alt_stop(uint32_t timer_data_id, struct rte_timer *tim)\n@@ -822,7 +822,7 @@ rte_timer_manage_v20(void)\n {\n \t__rte_timer_manage(&default_timer_data);\n }\n-VERSION_SYMBOL(rte_timer_manage, _v20, 2.0);\n+VERSION_SYMBOL(rte_timer_manage, _v20, 2.0)\n\n int\n rte_timer_manage_v1905(void)\n@@ -836,7 +836,7 @@ rte_timer_manage_v1905(void)\n \treturn 0;\n }\n MAP_STATIC_SYMBOL(int rte_timer_manage(void), rte_timer_manage_v1905);\n-BIND_DEFAULT_SYMBOL(rte_timer_manage, _v1905, 19.05);\n+BIND_DEFAULT_SYMBOL(rte_timer_manage, _v1905, 19.05)\n\n int\n rte_timer_alt_manage(uint32_t timer_data_id,\n@@ -1079,7 +1079,7 @@ rte_timer_dump_stats_v20(FILE *f)\n {\n \t__rte_timer_dump_stats(&default_timer_data, f);\n }\n-VERSION_SYMBOL(rte_timer_dump_stats, _v20, 2.0);\n+VERSION_SYMBOL(rte_timer_dump_stats, _v20, 2.0)\n\n int\n rte_timer_dump_stats_v1905(FILE *f)\n@@ -1088,7 +1088,7 @@ rte_timer_dump_stats_v1905(FILE *f)\n }\n MAP_STATIC_SYMBOL(int rte_timer_dump_stats(FILE *f),\n \t\t rte_timer_dump_stats_v1905);\n-BIND_DEFAULT_SYMBOL(rte_timer_dump_stats, _v1905, 19.05);\n+BIND_DEFAULT_SYMBOL(rte_timer_dump_stats, _v1905, 19.05)\n\n int\n rte_timer_alt_dump_stats(uint32_t timer_data_id __rte_unused, FILE *f)\n", "prefixes": [] }