Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/62409/?format=api
https://patches.dpdk.org/api/patches/62409/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20191105015642.17385-1-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191105015642.17385-1-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20191105015642.17385-1-stephen@networkplumber.org", "date": "2019-11-05T01:56:42", "name": "mk: add EXTRA_CFLAGS to link step for shared library", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": true, "hash": "a4baabc08d787ee2f0586753d6ced5f9ea8bd35b", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20191105015642.17385-1-stephen@networkplumber.org/mbox/", "series": [ { "id": 7232, "url": "https://patches.dpdk.org/api/series/7232/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=7232", "date": "2019-11-05T01:56:42", "name": "mk: add EXTRA_CFLAGS to link step for shared library", "version": 1, "mbox": "https://patches.dpdk.org/series/7232/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/62409/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/62409/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8A72CA0352;\n\tTue, 5 Nov 2019 02:56:54 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 2740C2C23;\n\tTue, 5 Nov 2019 02:56:54 +0100 (CET)", "from mail-pg1-f176.google.com (mail-pg1-f176.google.com\n [209.85.215.176]) by dpdk.org (Postfix) with ESMTP id C54D52BE9\n for <dev@dpdk.org>; Tue, 5 Nov 2019 02:56:52 +0100 (CET)", "by mail-pg1-f176.google.com with SMTP id j30so9375388pgn.5\n for <dev@dpdk.org>; Mon, 04 Nov 2019 17:56:52 -0800 (PST)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n by smtp.gmail.com with ESMTPSA id x10sm15036653pgl.53.2019.11.04.17.56.49\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 04 Nov 2019 17:56:50 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:mime-version\n :content-transfer-encoding;\n bh=MxpsR8NssAX9UcgonB/YE2uVMlEIN4UfEVX6frMYE3Q=;\n b=Isg980YbgAMztV4sCXA84QlhUWvAgWUNYJCIetvg5Yf8wfy9IqncrP10+LnAGCN5J8\n dFDLdbo0zS2uviPQwJ1BFtNaFElJZgJrnlq85QuZFcADkXcMGRZMRULLr35PtxXxGqA9\n E0Px7yx3GxNdTk4mrR4GxO0MVij/b64kBo+V/+DGQQTyMwffiyS5LHlmvR/FIz45uslQ\n e2EyiZUeoQHT+KbDltr6iA3kZn5AQh8wOKtRtPVcuDa0U21Dc008j3Qh5TasdYgmc/0M\n evB3mjnDEz90bzW4ieU8lA8wqPDuHOYbE9tf90fROJEXQMNqyHJBmkPMaDvlUZC8c3i9\n gWaw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n :content-transfer-encoding;\n bh=MxpsR8NssAX9UcgonB/YE2uVMlEIN4UfEVX6frMYE3Q=;\n b=HmZAdxGWsGi3+bG5jqS+y8tbCbx2rDT2ztatt1fQwK9CpIiv3lPgZpkJqDfl7QeVfP\n XMw8dE2NLGFR+H5zf8fcdPLsY5xD+9o9M00iCmrKincAvIAasqrocW956l7RHrkfD648\n +VG9RcTy8e6ZQSbwSH8riPQK9IqFsB7Svgf4Bh8BNlqD5LLfN06deAbwgvsj9EveNDzQ\n kef0txMQE/AmjSFmNMX7TqwCZ81+aG4RAh3TyyugCDGVrYyLf/l+kxqX2OQXLlJGMSe0\n snByyuLCIkmrfNlpvP2eCC5EG6G5OmAmOk+QGYEC1B8bR/NnTD7G2NFB15D6UyxXZ9o4\n FpAg==", "X-Gm-Message-State": "APjAAAUqcdBnALTT/J7qh/z+ePnD7BOGAycFcWtEQLJMeeoJKaw9BsR+\n m+qeKiuElXYzNMCGEIs5q1Dln6KZ/SRBHA==", "X-Google-Smtp-Source": "\n APXvYqwwO89gw1/pb/ZOYppWeRkAda0C2LUIhS3rk4VERA/++1aGNfch4FpHkGdgclolW28Z/YgKpQ==", "X-Received": "by 2002:a63:4104:: with SMTP id o4mr32926651pga.169.1572919011154;\n Mon, 04 Nov 2019 17:56:51 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Date": "Mon, 4 Nov 2019 17:56:42 -0800", "Message-Id": "<20191105015642.17385-1-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] mk: add EXTRA_CFLAGS to link step for shared\n\tlibrary", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When doing a cross compiling it is common to use EXTRA_CFLAGS with\n--sysroot option to point to alternate root filesystem. This already\nworks as expected for objects and executables, it just doesn't work\ncorrectly for shared libraries.\n\nWhen a shared library is linked using CC this flag needs to\nbe passed in order for libraries to be found.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n mk/rte.shared.mk | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/mk/rte.shared.mk b/mk/rte.shared.mk\nindex 2b501ddb8480..a0620a3eb233 100644\n--- a/mk/rte.shared.mk\n+++ b/mk/rte.shared.mk\n@@ -31,7 +31,7 @@ exe2cmd = $(strip $(call dotfile,$(patsubst %,%.cmd,$(1))))\n \n ifeq ($(LINK_USING_CC),1)\n override EXTRA_LDFLAGS := $(call linkerprefix,$(EXTRA_LDFLAGS))\n-O_TO_SO = $(CC) $(call linkerprefix,$(LDFLAGS)) $(LDFLAGS_$(@)) $(EXTRA_LDFLAGS) \\\n+O_TO_SO = $(CC) $(EXTRA_CFLAGS) $(call linkerprefix,$(LDFLAGS)) $(LDFLAGS_$(@)) $(EXTRA_LDFLAGS) \\\n \t-shared -o $@ $(OBJS-y) $(call linkerprefix,$(LDLIBS))\n else\n O_TO_SO = $(LD) $(LDFLAGS) $(LDFLAGS_$(@)) $(EXTRA_LDFLAGS) \\\n", "prefixes": [] }{ "id": 62409, "url": "